Commit Graph

747 Commits

Author SHA1 Message Date
Fabian Maurer 823c4b14b4 comdlg32: Use proper size for combobox controls.
Signed-off-by: Fabian Maurer <dark.shadow4@web.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-31 18:55:25 +02:00
Nikolay Sivov 1c1db33aba comdlg32: Improve tracing messages.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-31 10:53:58 +02:00
Nikolay Sivov c4b133e231 comdlg32: Simplify notification helper.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-31 10:53:56 +02:00
Nikolay Sivov 3c33ebd662 comdlg32: Use existing symbol for Help button id.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-11 10:17:50 -05:00
Huw Davies 5d9ab56d9e comdlg32: Select the correct font before querying the extents.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-05 14:12:18 +02:00
Huw Davies e77771c0bf comdlg32: Set the radiobuttons' font if they're part of a visual group.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-05 14:12:18 +02:00
Huw Davies 00994524f5 comdlg32: Use pixel sizes throughout.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-05 14:12:18 +02:00
Huw Davies 6df0198a2b comdlg32: Scale the control size limits with dpi.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-05 00:19:54 +02:00
Huw Davies 6891b5a044 comdlg32: Don't ask for icon information since it's unused.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-25 11:47:19 +02:00
Nikolay Sivov a44a608378 comdlg32: Take nMaxFile into account when converting A->W.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-13 19:28:11 +01:00
Nikolay Sivov b47de18ce1 comdlg32: Use GetPropW() to get to file dialog data.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-21 13:57:36 +01:00
Nikolay Sivov c23a91cb63 comdlg32: Consolidate file dialog initialization to avoid duplication.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-21 13:57:36 +01:00
Nikolay Sivov aef84332a2 comdlg32: Expand initial directory path for file open dialog.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-21 13:57:36 +01:00
Alex Henrie e07d20f3f3 comdlg32: Don't crash if an IShellFolder could not be created.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-14 22:46:58 +01:00
Alex Henrie bd1b3c104e comdlg32: Use localized "Path does not exist" string.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-14 22:46:57 +01:00
Józef Kucia 1707df3da2 comdlg32: Delay OleInitialize() until after file dialog window is created.
This fixes a problem exposed by commit
f65e04770d.

Signed-off-by: Józef Kucia <jkucia@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-02 20:40:13 +01:00
Józef Kucia 5dda6495eb comdlg32/tests: Add test for OLE initialization in file dialogs.
Signed-off-by: Józef Kucia <jkucia@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-02 20:40:13 +01:00
Nikolay Sivov 6c4aaf776f comdlg32: Always use original Open File dialog template.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-26 10:37:08 +01:00
Michael Stefaniuc eff2ecc39a comdlg32: Avoid some superfluous pointer casts.
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-12-08 13:56:02 +01:00
Alistair Leslie-Hughes 3126d9ca4c comdlg32/tests: Test when a directory is passed to OpenFileName Dialog.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-10-27 18:06:29 +02:00
Bruno Jesus 5809118892 comdlg32: Avoid crash when a path is passed into Open File Dialog.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-10-27 18:06:23 +02:00
Carlo Bramini a1b0d92587 comdlg32: Uses SetDlgItemInt() to simplify the code.
Signed-off-by: Carlo Bramini <carlo_bramini@users.sourceforge.net>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-10-17 16:48:47 -07:00
Alistair Leslie-Hughes 326a9ea137 comdlg: Select all text when enter is pressed.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-09-09 20:20:53 +09:00
Alistair Leslie-Hughes b11d7f7482 comdlg32: Clear the filename text on OPEN_BROWSE.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-09-09 20:20:53 +09:00
Nikolay Sivov 384ece4d7e comdlg32/itemdlg: Fix setting NULL file name (Coverity).
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-28 21:38:13 +09:00
Lauri Kenttä c851ecca2b comdlg32: Avoid repeated GlobalLock etc in filedlg.
Signed-off-by: Lauri Kenttä <lauri.kentta@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-08 12:11:16 +09:00
Lauri Kenttä f99da3f3a1 comdlg32: Avoid generating filenames twice in filedlg.
Signed-off-by: Lauri Kenttä <lauri.kentta@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-08 12:11:02 +09:00
Lauri Kenttä 86a993ea3c comdlg32: Init clipboard format only once in filedlg.
Signed-off-by: Lauri Kenttä <lauri.kentta@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-08 12:10:20 +09:00
Michael Stefaniuc 3ad882ff24 comdlg32: Use InflateRect() instead of open coding it.
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-04 17:29:35 +09:00
Michael Stefaniuc 4e7272f087 comdlg32: Avoid using CopyRect().
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-06-22 22:16:35 +09:00
Michael Stefaniuc db134bbd5a comdlg32/tests: Use wine_dbgstr_rect() to print RECTs.
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-06-10 20:34:03 +09:00
Pierre Schweitzer d288d8d333 comdlg32: Check for overflow before dereferencing.
Signed-off-by: Pierre Schweitzer <pierre@reactos.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-02 18:30:45 +09:00
Michael Stefaniuc 69f6493a8c comdlg32: Use wine_dbgstr_rect() to trace a RECT.
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-21 18:42:25 +09:00
Nikolay Sivov be27c23df9 comdlg32/tests: Simplify a test using todo_wine_if().
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-12 12:17:47 +09:00
Nikolay Sivov 2f6393bfa0 comdlg32: Don't use BOOL constants for regular integer type.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-11 19:54:15 +09:00
Nikolay Sivov c8e407da3b comdlg32: Explicitly compare to HRESULT values.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-03 20:04:32 +01:00
Nikolay Sivov 1a7121b327 comdlg32/fontdlg: Remove dead assignment (Coverity).
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-12-22 10:46:40 +01:00
Nikolay Sivov 9f5260300d comdlg32/fontdlg: Fix string format for sizes added to listbox.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-12-22 10:46:39 +01:00
Nikolay Sivov daaa083404 comdlg32/fontdlg: Allow font sizes outside of defaults set.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-12-22 10:46:39 +01:00
Nikolay Sivov a48d96843c comdlg32/fontdlg: Limit text length user can type in as font point size.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-12-22 10:46:38 +01:00
Alexandre Julliard 5095ee32af user32: Fix WS_EX_DLGMODALFRAME handling in AdjustWindowRect and add more tests.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-12-07 22:30:56 +09:00
Vincent Povirk d0fac61c6d comdlg32: Initially focus filename text box.
Signed-off-by: Vincent Povirk <vincent@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-06 14:44:53 +09:00
Vincent Povirk 30ac0f5a66 comdlg32: Add ES_AUTOHSCROLL style to filename text box.
Signed-off-by: Vincent Povirk <vincent@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-04 14:41:40 +09:00
André Hentschel 03bf3cac66 comdlg32/tests: Disable test which crashes on Win10.
Signed-off-by: André Hentschel <nerv@dawncrow.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-16 21:06:20 +09:00
Vincent Povirk 34d57e3621 comdlg32: Implement radio button lists in item dialog. 2015-09-14 16:47:51 +09:00
Vincent Povirk 9068f2d10c comdlg32: Return success from IFileDialogCustomize::MakeProminent. 2015-09-14 16:21:26 +09:00
Vincent Povirk 4270a8a4dc comdlg32: Return success from IFileDialog2::AddPlace. 2015-09-14 16:21:23 +09:00
Vincent Povirk 3fc57e7b49 comdlg32: Remove fixme from EnableOpenDropDown. 2015-09-14 16:21:21 +09:00
Vincent Povirk bbe009778e comdlg32: Fix ignored out parameter. 2015-09-14 16:21:18 +09:00
Vincent Povirk 6056a3f163 comdlg32: Show open dropdown menu on button press. 2015-08-28 21:24:37 +09:00
Vincent Povirk bc0abc2369 comdlg32: Show and hide the open dropdown menu dynamically. 2015-08-28 21:24:15 +09:00
Vincent Povirk c5c5163e61 comdlg32: Implement open dropdown menu. 2015-08-28 21:23:26 +09:00
Vincent Povirk 836f06f6f9 comdlg32: Add WS_CLIPSIBLINGS to controls in the item dialog. 2015-08-27 21:43:46 +09:00
Vincent Povirk d3163241af comdlg32: Partially implement IFileDialogCustomize::EnableOpenDropDown.
This builds a menu but cannot display it yet.
2015-08-19 20:19:56 +09:00
Vincent Povirk 8d8e75849f comdlg32: Implement SetControlItemState for combo boxes. 2015-08-19 20:19:56 +09:00
Vincent Povirk 068a6c7a5f comdlg32: Implement SetControlItemState for menu controls.
This required some rethinking because menus and combo boxes don't
provide a way to "hide" items, just remove them, and native always
shows items in the order they were added even when hidden and shown.
2015-08-19 20:19:56 +09:00
Vincent Povirk b206287c91 comdlg32: Implement overwrite check in item dialog. 2015-08-17 14:47:05 +09:00
Vincent Povirk 3ec84397c9 comdlg32: Add test for IFileDialogEvents::OnOverwrite. 2015-08-17 14:47:01 +09:00
Nikolay Sivov 9da369b455 comdlg32: Remove some casts. 2015-08-03 10:57:55 +02:00
Nikolay Sivov ae2794eac9 comdlg32: Remove browser border for common item dialog. 2015-08-03 10:57:50 +02:00
Nikolay Sivov da8fd05251 comdlg32/tests: Test that different IFileDialogCustomize IIDs return same pointer. 2015-08-03 10:57:30 +02:00
Joachim Priesner c5ad37baf0 comdlg32: File dialog: Append multi-part extensions like .abc.def. 2015-06-05 14:32:47 +09:00
Alex Henrie e4e78b0a83 comdlg32: Remove unused string resource "Borders". 2015-04-29 15:46:13 +09:00
David Hedberg 2afbf9dbbc comdlg32: Only attempt to update the layout if the dialog window exists. 2015-04-01 22:34:20 +09:00
Francois Gouget 99f0f3a7e1 comdlg32: Remove unneeded NONAMELESSSTRUCT directives. 2015-03-09 22:06:24 +09:00
Michael Stefaniuc 74007d4405 comdlg32: Remove unused variable assigments (PVS-Studio). 2015-01-13 19:54:02 +01:00
Michael Stefaniuc 51d0345ebd comdlg32: RT_DIALOG is already an INTRESOURCE (PVS-Studio). 2014-11-27 11:43:28 +01:00
Michael Stefaniuc 0867e7fe78 comdlg32: Remove an always true if check (PVS-Studio). 2014-11-26 17:26:51 +01:00
Ralf Habacker 2b9d337f6d comdlg32: Update dmFormName when changing paper size in print UI. 2014-11-20 23:40:39 +09:00
Qian Hong 0380ee031c comdlg32/tests: Fixed memory leak (Valgrind). 2014-11-20 22:33:45 +09:00
Michael Stefaniuc b4b58a82e3 comdlg32: Simplify check for an empty string (PVS-Studio). 2014-11-18 22:11:14 +09:00
Michael Stefaniuc 50a877d69f comdlg32: Use the proper macro to create an int atom (PVS-Studio). 2014-10-31 10:49:29 +09:00
Alexandre Julliard 2b40148e1e comdlg32: Use PathAddBackslash to avoid a compiler warning. 2014-10-28 14:33:17 +09:00
André Hentschel c4747f46cf comdlg32: Remove duplicate code (PVS-Studio). 2014-10-28 14:06:02 +09:00
Francois Gouget 0dd5cb1cef Assorted spelling fixes. 2014-09-29 10:36:36 +02:00
David Hedberg d495cc37a6 comdlg32: Expand the filetype combobox dropdown to fit the contents. 2014-09-04 13:45:05 +02:00
David Hedberg dc7f17ee14 comdlg32: Set BS_MULTILINE also for check buttons. 2014-09-04 13:45:05 +02:00
David Hedberg 7b7f4c613f comdlg32: ::SetFileTypeIndex and ::GetFileTypeIndex uses a one-based index. 2014-09-04 13:44:51 +02:00
Francois Gouget e9e76d823f comdlg32/tests: Add a trailing '\n' to an ok() call. 2014-09-04 13:37:21 +02:00
David Hedberg befe0f7b69 comdlg32: Implement calling IFileDialogEvents::OnTypeChange(). 2014-09-03 21:21:58 +02:00
David Hedberg 5f50864811 comdlg32/tests: Add some IFileDialogEvents tests. 2014-09-03 21:21:57 +02:00
David Hedberg aac6255d46 comdlg32: Implement IFileDialogCustomize::StartVisualGroup() and ::EndVisualGroup(). 2014-08-25 15:55:29 +02:00
David Hedberg 3cf2fb3a9c comdlg32: Support browsing for folders. 2014-08-04 14:32:59 +02:00
David Hedberg 7311a9fc6e comdlg32: Populate psia_results before making any callbacks. 2014-07-22 14:28:21 +02:00
Frédéric Delanoy 2e5cb7aac8 Assorted spelling/grammar fixes. 2014-04-30 18:34:20 +02:00
Stefan Leichter 73a2408f27 comdlg32: Update version resource to values reported from XP. 2014-03-04 11:49:50 +01:00
Frédéric Delanoy ce1175149b comdlg32/tests: Use BOOL type where appropriate. 2014-02-25 14:21:50 -06:00
Frédéric Delanoy a5f20b3173 comdlg32/tests: Use common wine_dbgstr_guid implementation from test.h. 2014-01-28 11:44:24 +01:00
Andrey Gusev be367393c9 Assorted typos fixes. 2014-01-13 17:37:42 +01:00
Alexandre Julliard 99ef0d6ff0 makefiles: Get rid of the MAKE_TEST_RULES variable. 2014-01-02 12:13:16 +01:00
Alexandre Julliard 5e7416e5c8 makefiles: Get rid of the MAKE_DLL_RULES variable. 2014-01-02 12:08:18 +01:00
Alexandre Julliard d08ff3ff19 makefiles: Use a single variable for all types of idl files. 2013-12-31 18:15:17 +01:00
Alexandre Julliard 4f3d71cef3 makefiles: Get rid of the no longer used PO_SRCS variables. 2013-12-15 10:23:04 +01:00
Alexandre Julliard 5756ee09f3 makefiles: Add makedep pragmas for rc files that contain translations. 2013-11-05 20:38:19 +01:00
Alexandre Julliard c7803b885b makefiles: Add makedep pragmas for registration idl files. 2013-11-05 20:38:18 +01:00
Frédéric Delanoy e5d954096b comdlg32/tests: Use BOOL type where appropriate. 2013-10-23 11:22:25 +02:00
Frédéric Delanoy 3e3efd1e1b comdlg32: Use BOOL type where appropriate. 2013-10-23 11:21:15 +02:00
Nikolay Sivov e011d0e3c7 comdlg32/tests: Compile with -D__WINESRC__. 2013-10-15 17:43:41 +02:00
Frédéric Delanoy 8e7abd00a8 comdlg32: Use BOOL type where appropriate. 2013-10-11 11:05:04 +02:00
Frédéric Delanoy 2bbe7a330c comdlg32/tests: Use BOOL type where appropriate. 2013-10-07 13:32:06 +02:00