Commit Graph

1397 Commits

Author SHA1 Message Date
Mike McCormack 0a44661d6f Switch IShellLink to use shlwapi.SHCreateStreamOnFileW. 2005-06-16 09:46:05 +00:00
Michael Jung e5ef9dd8dc Test GetAttributesOf on the MyComputer shellfolder. 2005-06-16 09:44:50 +00:00
Michael Jung e2dbc8044a Added tests for SHGetPathFromIDList. 2005-06-15 18:07:55 +00:00
Huw Davies 47db6bc567 Unquote the icon file path if it's quoted. 2005-06-15 18:07:43 +00:00
Mike McCormack c62940a1ac Remove some uses of wine/unicode.h functions. 2005-06-15 10:21:46 +00:00
Michael Jung ebb1aaee86 Implement SHGetPathFromIDList based on GetDisplayNameOf. 2005-06-15 10:20:00 +00:00
Michael Jung 8b4b4b3af2 Replace magic error constant. 2005-06-14 19:18:26 +00:00
Michael Jung 81b7509f3b Use SHGetPathFromIDList instead of SHELL32_GetPathFromIDList. 2005-06-14 19:17:41 +00:00
Michael Jung bb19a58a93 Return the correct attributes for the desktop folder.
Corresponding tests.
2005-06-14 18:10:24 +00:00
Michael Jung 5664a68033 Added tests to compare SHGetPathFromIDList and GetDisplayNameOf. 2005-06-14 17:21:25 +00:00
Mike McCormack 215bd9a70b Add the IContextMenu interface to the ShellLink object. 2005-06-14 11:38:55 +00:00
Mike McCormack 0569609e3d Implement ShellLink's IShellExtInit::Initialize() method. 2005-06-13 19:04:17 +00:00
Mike McCormack d4eb4f54ed - add the IShellExtInit interface to the ShellLink object
- use inline functions rather than macros to resolve the
  implementation pointer from an interface pointer
2005-06-13 11:50:09 +00:00
Michael Jung 71404a7372 Set the FILESYSANCESTOR and FILESYSTEM flags correctly in
GetAttributesOf.
2005-06-10 19:31:59 +00:00
Saulius Krasuckas 83ac47e53c Get current directory during tests on win9x too. 2005-06-09 12:05:50 +00:00
Mike McCormack fa1b7822a5 Add the IShellLinkDataList interface to the ShellLink object. 2005-06-09 12:05:38 +00:00
Mike McCormack 8e2cb0835c Add a cast to get rid of a warning. 2005-06-09 09:46:23 +00:00
Michael Jung d1f59dba67 Use shell icon cache instead of an own IExtractIcon implementation. 2005-06-09 09:43:18 +00:00
Mike McCormack b64186ad22 Warning fixes for -Wmissing-declarations and -Wwrite-strings. 2005-06-07 20:30:30 +00:00
Juan Lang ab88fd34dc Const-ify a mask. 2005-06-07 20:03:39 +00:00
Dmitry Timoshkov eba47f1dfe Make remaining OLE interface vtables const. 2005-06-06 19:50:35 +00:00
Michael Jung d20fde8a80 Allow for unixfs folders to be rooted at desktop level.
Moved dos->unix path conversion into canonicalize_path.
Fail in BindToObject, if called with empty pidl.
2005-06-06 19:37:47 +00:00
Michael Jung 38f2ee9d04 Let BindToObject fail, if called with empty relative pidl.
Tests to show that it should do so.
Fix SHBrowseForFolder to not pass an empty pidl to BindToObject.
2005-06-06 10:04:15 +00:00
Juan Lang 4571d0187f Set default for "My Documents" to $HOME, and "Desktop" to ~/Desktop. 2005-06-02 19:39:24 +00:00
Mike McCormack 4c6149ee0c Eliminate some -Wwrite-strings warnings. 2005-06-01 11:04:26 +00:00
Stefan Dösinger ea18de5f58 *Handle cidl==0 in shfldr_desktop, shfldr_fs and shfldr_mycomp.
*Remove the dwAttributes member from the IGenericSFImpl class, it's
not needed and can't be initialised in Initialize and InitializeEx.
2005-05-26 16:09:12 +00:00
Michael Jung 3c3495ea51 Add a new CLSID for UnixDosFolder, which is identical to UnixFolder,
but does unix <-> dos path conversion for GetDisplayNameOf and
ParseDisplayName.
2005-05-24 11:45:47 +00:00
Michael Jung 8016f6cc62 More robustly query the SHGDN_FORPARSING flag in the shell32's folders
GetDisplayNameOf methods.
2005-05-23 16:31:42 +00:00
Alexandre Julliard aebb745488 Comment out stub WEP entry points so that we can call WEP for builtin
dlls too.
2005-05-23 10:12:26 +00:00
Alexandre Julliard 0ddd30b0b6 Removed unnecessary code in the 16-bit DllEntryPoint function of some
dlls, and also fixed its ordinal in a few places.
2005-05-23 10:00:26 +00:00
Michael Jung 82ed0ce999 Consider only the GIL_FORSHORTCUT flag in SIC_CompareEntries. 2005-05-20 18:58:35 +00:00
Kouji Sasaki c1f2824429 Added the processing for determination of SFGAO_HASSUBFOLDER flag in
SHELL32_GetItemAttribute function.
2005-05-18 09:43:39 +00:00
Juan Lang f12eadf7bf - only log unsupported flags in ShellExecute
- environment variables are expanded, so SEE_MASK_DOENVSUBST is
  supported
2005-05-14 11:06:54 +00:00
Ge van Geldorp 40cb98269b Overlay icons for .lnk files with a small arrow in the lower left
corner.
2005-05-13 17:48:33 +00:00
Mike McCormack 3e2cb75349 Remove some unused include files. 2005-05-13 13:59:15 +00:00
Michael Jung a858a5a76c Replace '\\' by '/' in strings passed to ParseDisplayName to be able
to handle DOS-style relative paths.
2005-05-13 13:55:03 +00:00
Mike McCormack 1ae212a105 Split SHGetFileInfoW into two functions. 2005-05-12 09:56:48 +00:00
Michael Lin 9bd101d012 - Implement IPersistFolder2.
- Retrieve the correct attributes in ParseDisplayName().
2005-05-12 09:56:04 +00:00
Juan Lang 2439b5fdda Fixes to IShellFolder::GetAttributesOf implementations, spotted by
silverblade_:
- a count of zero is allowed to GetAttributesOf if apidl is NULL
- SFGAO_VALIDATE must be cleared upon return
2005-05-10 08:28:11 +00:00
Mike Hearn 25abe7c537 Fix SHELL_GetPathFromIDList[AW] to return the desktop path given an
empty PIDL.
2005-05-10 08:27:23 +00:00
Michael Jung ea3793b79d Support folder relative paths in UnixFolders' ParseDisplayName
method.
2005-05-09 19:33:01 +00:00
Alexandre Julliard 34fa35dc99 Added rules for building import libraries in the individual dll
makefiles, and added support for building a .def.a static import
library too.
2005-05-09 14:42:30 +00:00
Michael Jung 3a117bccd8 Always pass fully qualified paths to stat system call. 2005-05-09 09:26:02 +00:00
Huw Davies da13552c55 It makes no sense to have a left pointing arrow as the desktop icon.
Replace it with something more appropiate.
2005-05-09 09:25:28 +00:00
Robert Lunnon f4949b8d80 Make references to NAME_MAX refer to PATH_MAX instead. 2005-05-07 14:50:00 +00:00
Alexandre Julliard d62356aa1e Added rules to build import libraries in the individual dll makefiles.
Generate import libraries with the right name right away instead of
using an intermediate .spec.def file.
2005-05-07 12:39:52 +00:00
Michael Jung fc40dcf985 Make the root of the shell extension map to the root of the unix
filesystem.
2005-05-07 12:17:02 +00:00
Michael Jung 15934680f7 Return a cloned PIDL by SHBrowseForFolder to avoid heap corruption. 2005-05-06 19:33:06 +00:00
Michael Jung 94e5f01275 Display a drive icon for the unix root directory. 2005-05-06 19:32:54 +00:00
Francois Gouget 821d4c4645 Fix nativeapi.pm so it knows about AC_HEADER_STAT().
Make the error message about unexpected '#ifdef HAVE_XXX' clearer.
Protect sys/stat.h #includes with the corresponding '#ifdef HAVE_XXX'
check.
2005-05-06 16:22:54 +00:00
Francois Gouget f5c9da6860 Assorted spelling fixes. 2005-05-06 15:44:31 +00:00
Michael Jung 45bcdd2be1 Fixed GetDisplayNameOf method to not depend on incorrect behaviour
regarding the SHGDN_INFOLDER flag.
2005-05-05 10:30:51 +00:00
Michael Jung ddc26aa94e Fixed MyComputer's GetDisplayNameOf method. 2005-05-05 10:30:39 +00:00
Mike McCormack 2b2c6f2fba Remove static variables in SHBrowseForFolder implementation. 2005-05-04 09:48:15 +00:00
Mike McCormack 95a58eba7d Split up the window procedure. 2005-04-28 18:26:58 +00:00
Gerald Pfeifer 039869eed1 Include <limits.h> to get a definition of NAME_MAX. 2005-04-27 08:12:08 +00:00
Michael Jung 3abb5bd6bb Support for regular files (as opposed to directories). 2005-04-25 10:56:29 +00:00
Michael Jung 025bc2d8a2 Use the shell32 typical binary format for ITEMIDLISTs. 2005-04-22 21:29:17 +00:00
Michael Jung 2a788026a3 Fixed incorrect IShellFolder::EnumOjects API usage. 2005-04-22 19:07:00 +00:00
Mike McCormack 5960e7c93c MSI advertised shortcuts don't require a product ID. 2005-04-22 19:06:12 +00:00
Peter Berg Larsen 56c34e1b2c Rewritten DoEnvironmentSubst16. 2005-04-21 17:14:39 +00:00
Francois Gouget 4527aae24f Assorted spelling fixes. 2005-04-19 09:49:38 +00:00
Troy Rollo 98d336c363 Fix SEGV for non-fully-qualified destination paths.
Don't fail ShFileOperationW if FOF_ALLOWUNDO is passed.
2005-04-19 09:49:05 +00:00
Francois Gouget 3b36eee083 Add trailing '\n's to ok() calls. 2005-04-19 09:48:44 +00:00
Peter Berg Larsen 6e3bcb5a54 Replace strncpy with memcpy or lstrcpyn. 2005-04-18 10:30:55 +00:00
Huw Davies 7ac969d560 When we're hiding file extensions then SetNameOf should append the
original extension if SHGDN_FORPARSING isn't set.
The flags passed to SetNameOf refer to the dst string not the src
pidl.
2005-04-15 16:11:45 +00:00
Martin Fuchs d3b5018275 Correct comments of some export ordinals. 2005-04-13 15:17:16 +00:00
Huw Davies 0e5b772cdc Add a unicode pidl type.
Improve support for PT_YAGUID.
Improve IShellLink debugging.
2005-04-13 14:39:27 +00:00
Steven Edwards ad7f4daf35 Register Shell Drag and Drop Helper. 2005-04-13 11:07:49 +00:00
Michael Jung 9a4f552f2f Implemented the UnixFolder's IShellFolder2::CompareIDs method. 2005-04-13 11:01:10 +00:00
Huw Davies be428abd3e Better icon handling for some special folders.
Identify and add defines for a bunch of shell icons.
2005-04-12 12:00:40 +00:00
Michael Jung d1f1d34c2b Implemented enough of IShellFolder2 to make UnixFolder work within the
open/save-dialogs.
2005-04-12 11:58:05 +00:00
Huw Davies 52cf1992ea If ICommDlgBrowser_OnDefaultCommand returns anything other than S_OK
then we should call the default handler.
2005-04-12 10:16:35 +00:00
Juan Lang 7376f57c30 Use Unicode string result from GetDisplayNameOf if it isn't
representable using ANSI.
2005-04-12 10:15:29 +00:00
Huw Davies 8dabf51d39 Directory items should have the SFGOA_FILESYSANCESTOR attribute.
Add a test for this and cleanup the shlfolder test a bit.
2005-04-11 18:50:01 +00:00
Huw Davies 861282bf28 Fix the icon resource ids (most were off by one).
Fix IExtractIcon_{GetIconLocation,Extract} to use -ve icon resource
ids and fix bugs relating to confusion between resource ids and the
system imagelist indicies.
Extend the system imagelist initialization hack to load both +ve and
-ve resource ids.
Add a printer icon (that'll be used by an upcoming printer folder
patch).
2005-04-11 13:04:41 +00:00
Mike McCormack 7340a357ba Fix up PIDL dumping code. 2005-03-31 10:05:59 +00:00
Francois Gouget 6b10c324c5 Assorted spelling fixes. 2005-03-30 17:08:31 +00:00
Mike McCormack a5cb5a2ab3 Use api definitions, remove duplicate code. 2005-03-27 17:54:48 +00:00
Paul Vriens 0b3b35116a Print retval in decimal to avoid confusion.
NT4 fails with ERROR_INVALID_TARGET_HANDLE instead of
ERROR_REDIR_PAUSED.
Use some correct messages on error.
Extra tracing.
2005-03-25 20:47:50 +00:00
Jakob Eriksson 9ed61de9a2 Get rid of HeapAlloc casts. 2005-03-24 21:01:35 +00:00
Francois Gouget 93416cdaf7 Assorted spelling fixes. 2005-03-23 13:15:18 +00:00
Jakob Eriksson 4fead33f30 If the device gets interrupted, we just give up. 2005-03-22 21:16:24 +00:00
Jakob Eriksson b718b0b019 StrRetToStrNAW returns ok on NT4, though it should return FALSE. 2005-03-22 18:19:13 +00:00
Mike McCormack 17c3106896 Eliminate casts of the return value of HeapAlloc. 2005-03-21 11:25:13 +00:00
Mike McCormack fd40ace3d3 Fix usage of STGM_ enumerations, remove forward declaration. 2005-03-19 17:09:14 +00:00
Mike McCormack 2597b1beca Remove forward declarations of interface methods. 2005-03-19 17:09:03 +00:00
Mike McCormack b7cc006c33 Remove an unused function. 2005-03-19 17:08:52 +00:00
Jon Griffiths dbf222f3aa Use LMEM_ flags for LocalAlloc(), not GMEM_ (GlobalAlloc). 2005-03-17 20:53:37 +00:00
Aric Stewart 984931bd09 For ShellExecuteExA we need to copy out the hProcess value from the W
structure.
2005-03-17 20:50:53 +00:00
Mike McCormack 4098dc64ca Remove some dead code and some ifdefs. 2005-03-17 18:55:49 +00:00
Mike McCormack c9bd224f0f Fix a regression in the file open dialog. 2005-03-17 18:55:16 +00:00
Mike McCormack b12ce9b446 Convert path to unicode, rearrange to remove forward declaration. 2005-03-17 13:57:38 +00:00
Filip Navara 9f2bbd6566 _dbg_ILGetNext returns NULL if pidl->mkid.cb is zero, fix the loops
accordingly.
2005-03-16 19:51:13 +00:00
Juan Lang 2786964da2 Correct registering shell folders (values in Shell Folders key weren't
getting written).
2005-03-16 11:37:46 +00:00
Martin Fuchs 824353d01b - switch to correct shell desktop context menu
- launch desk.cpl when activating the desktop context menu entry
  "properties"
- don't send WM_COMMAND if we didn't get a shell view window
2005-03-14 10:49:03 +00:00
Michael Jung 015d2a4dbe Beginning of a shell namespace extension to browse the unix
filesystem.
2005-03-09 16:41:17 +00:00
Dimitrie O. Paun c02dd0a902 Add support for .exe's with exported functions. 2005-03-08 16:55:26 +00:00
Mike McCormack 2c8367a3de Use lstrcmpiA in preference to strcasecmp. 2005-03-07 11:05:03 +00:00
Huw Davies 5be005b0d5 Don't prepend '\\' to the subkey name. 2005-03-03 13:52:06 +00:00
Francois Gouget fbb3343547 Assorted spelling fixes. 2005-03-02 13:53:50 +00:00
Juan Lang 316df99bf9 Convert more API calls to Unicode. 2005-03-02 10:16:41 +00:00
Michael Jung 6bc9999e08 Fixed parsing of ITEMIDLIST in InitializeTreeView.
Added some documentation.
Fixed a crash occuring when the user double-clicks a leaf item.
2005-03-01 11:45:32 +00:00
Juan Lang 88cf8ce5ac Convert tabs to space, wrap long lines, make indenting consistent. 2005-03-01 10:41:14 +00:00
Juan Lang b7dac96974 Convert a few calls to Unicode. 2005-02-26 17:41:26 +00:00
Mike McCormack 64c3208e10 - implement loading and saving of MSI advertised shortcut info
- make more test cases pass
- read and write the location block
- improve the binary compatibility of lnk files
2005-02-25 16:19:57 +00:00
Jon Griffiths eb5bf7dd38 Documentation spelling fixes. 2005-02-25 14:07:56 +00:00
Mike McCormack d68294f06f Remove tabs and reformat. 2005-02-23 15:41:39 +00:00
Francois Gouget d95630ebf3 Add the -noname flag to match the Platform SDK. 2005-02-23 15:41:14 +00:00
Mike McCormack f8a4f6b59b - handle IFileSystemBindData in ISF_Desktop_fnParseDisplayName
- more Unicode conversion
2005-02-23 12:45:12 +00:00
Francois Gouget 14de57089e Don't hardcode ordinals if which are not hardcoded on Windows. 2005-02-23 12:44:43 +00:00
Mike McCormack 3b2019badb Make lstr* functions inline inside Wine. 2005-02-22 15:50:13 +00:00
Mike McCormack 0d735ac9be - handle IFileSystemBindData in IShellFolder::ParseDisplayName
- convert IShellFolder::ParseDisplayName to use Unicode
2005-02-22 15:47:21 +00:00
Mike McCormack 3d9ba61478 Cleanup, create unicode versions of _ILCreateFromPath,
_ILCreateGuidFromStr, and _ILCreateFromFindData.
2005-02-22 14:50:35 +00:00
Hans Leidekker 2294e30dd4 - Revert wrong -noname markup for Drag*, DoEnvironmentSubst and
SHGetNewLinkInfo{A,W}.
- Also mark stub exports -noname when they are exported by ordinal
  only on win98/2k.
- Implementation level stubs for SheChangeDirA, SheGetDirA,
  SHHelpShortcuts_RunDLL{A,W}.
- New spec file stubs for Control_RunDLLAsUserW,
  FixupOptionalComponents, OCInstall, SHChangeNotifySuspendResume,
  SHCreateProcessAsUserW, SHExtractIconsW,
  SHInvokePrinterCommand{A,W}, SHIsFileAvailableOffline,
  SHLoadNonloadedIconOverlayIdentifiers, SHPathPrepareForWrite{A,W},
  ShellExec_RunDLL{,A,W}, SHGetIconOverlayIndex{A,W}.
2005-02-21 18:37:33 +00:00
Mike McCormack 59ce35aba8 Remove tabs and make formatting consistent. 2005-02-21 18:36:47 +00:00
Hans Leidekker c6806cd204 Mark exports -noname when they are exported by ordinal only on
win98/2k.
2005-02-18 20:13:01 +00:00
Dmitry Timoshkov 9074f257e0 Convert winemenubuilder to unicode. 2005-02-17 11:51:44 +00:00
Joris Huizer e889f71269 - renamed file_operation_delete and to shfileops_delete
- renamed file_operation_checkFlags to shfileops_check_flags
- added helper function shfileops_do_operation()
- added helper function shfileops_get_parent_attr()
- added helper function shfileops_get_parent_attr2()
- various cleanups in SHFileOperationW using these functions
2005-02-17 11:50:25 +00:00
Alex Villacís Lasso 18bfe6a095 Change SUBLANG_DEFAULT to SUBLANG_NEUTRAL for LANG_SPANISH in all
resources, so that Spanish locales other than Spain also use Spanish
resources.
2005-02-16 21:10:59 +00:00
Huw Davies 084e596a95 SetPath("") should return S_OK.
SetPath("nonexistent_path") should return S_FALSE.
2005-02-16 16:27:42 +00:00
Dmitry Timoshkov 39f960bdfa - Fix prototypes of GetClassLongA/W, GetClassLongPtrA/W and
SetClassLongA/W according to SDK definitions.
- Add prototypes for SetClassLongPtrA/W, protect some GWL_ and GCL_
  constants from using in Wine or in _WIN64 mode.
- Fix all places in Wine affected by the above changes.
2005-02-15 21:51:06 +00:00
Mike McCormack af882e0e41 Reindent some code to improve readability. 2005-02-15 20:45:53 +00:00
Mike McCormack a830bf55ca Define some extra SHFGI values. 2005-02-15 15:43:54 +00:00
Francois Gouget 208df0eb52 Test the interaction between IShellLink::SetIDList() and
IShellLink::SetPath().
Check what default values one gets on a fresh IShellLink object.
Add some more tests verifying nothing is lost in an IShellLink
save/load cycle. Merged the empty shelllink test with these.
2005-02-14 11:52:29 +00:00
Marcelo Duarte 574c0edabb Update the resources for Portuguese. 2005-02-14 11:12:30 +00:00
Marcus Meissner 30ed10004b Output some more informations.
Mark one global variable static.
2005-02-14 11:07:55 +00:00
Filip Navara 4d20d165ff Don't crash if ShellFolder doesn't implement the IID_ISFHelper
interface.
2005-02-14 11:06:48 +00:00
Ge van Geldorp a912c2a885 Error numbers >= 32 are to be expected. 2005-02-14 11:03:21 +00:00
Francois Gouget 4d801b66e6 Assorted spelling fixes. 2005-02-10 19:19:35 +00:00
Ge van Geldorp 9cc5e6cd03 - Fix quoting of .cpl filename.
- Use "cplopen" verb to execute .cpl files.
2005-02-09 13:25:13 +00:00
Francois Gouget da8b3dd7f2 Assorted spelling fixes. 2005-01-26 21:09:04 +00:00
Mike McCormack 18fb9ace14 Implement GetAdvise and SetAdvise. 2005-01-21 10:16:11 +00:00
Henning Gerhardt e34aac5038 A small spelling fix and a small update (thank to Andreas Mohr). 2005-01-17 19:32:58 +00:00
Henning Gerhardt 038c5cbcbf Update German resources. 2005-01-17 13:43:16 +00:00
Joris Huizer 2d58a624dd - add file_operation_delete
- add file_operation_checkFlags
- use these in SHFileOperationW replacing inline code
2005-01-14 16:51:14 +00:00
James Hawkins ba92d2924a - Use Interlocked* instead of ++/-- in AddRef/Release.
- Use only stored result of Interlocked* in AddRef/Release.
- Expand TRACEs to display the ref count.
2005-01-14 16:02:20 +00:00
Klemens Friedl a4d4652dd1 Update German language file. 2005-01-14 15:13:56 +00:00
Robert Shearman 3dad1f9043 Don't sort the children of My Computer in shell browse for folder
dialog.
2005-01-11 10:40:14 +00:00
Eric Pouech cf1d00bb08 Removed excessive statement (break after return or goto, not useful
break, not needed vars...)
2005-01-09 16:42:53 +00:00
Hans Leidekker c1236fd120 Stub implementations for SHUpdateImageA, SHHandleUpdateImage,
SHObjectProperties, SHGetNewLinkInfo{A,W}, SHStartNetConnectionDialog,
SHEmptyRecycleBin{A,W}, SHFormatDrive, SHQueryRecycleBin{A,W}.
'HeapAlloc can fail' fix for ExtractIconExA.
Implement ExtractAssociatedIconA -> W.
Correct prototype for SHObjectProperties.
Forward SHGetNewLinkInfo to SHGetNewLinkInfoA.
2005-01-03 20:26:06 +00:00
Jacek Caban 76d4edf1f0 Get rid of W->A call. 2005-01-03 14:39:08 +00:00
Rein Klazes 3714a39867 Correct cases where arguments of ok() calls depend on the order in
which they are evaluated.
2004-12-27 17:26:37 +00:00
Michael Stefaniuc 5ad7d858e0 Do not check for non NULL pointer before HeapFree'ing it. It's
redundant.
2004-12-23 17:06:43 +00:00
Alexandre Julliard 758b2887e9 Remove some no longer needed AW functions. 2004-12-17 19:20:07 +00:00
Rein Klazes 71e322b29f ShellExecuteEx, ExtractIconEx, SHFileOperation, SHGetFileInfo,
SHGetPathFromIDList spec entries always refer to the Ansi
version. Problem found by Paul Vriens.
2004-12-17 19:05:46 +00:00
Jon Griffiths f82272c92f Remove unneeded headers to reduce unneeded rebuilds. 2004-12-16 14:35:55 +00:00
Eric Pouech 4056d7ef8c Fixed some errors in function prototypes. 2004-12-13 21:19:01 +00:00
Alexandre Julliard ebe3c529b1 Janitorial: C booleans must not be compared against TRUE. 2004-12-09 14:07:59 +00:00
José Manuel Ferrer Ortiz 7a03fd6763 Added some Spanish translations. 2004-12-09 13:44:20 +00:00
Klemens Friedl 586930973d More Windows-like About dialog. 2004-12-09 11:39:31 +00:00
Robert Shearman cba8763c33 Remove unnecessary WNDPROC casts. 2004-12-06 11:51:29 +00:00
Stefan Leichter 9cc5c15795 Fix missing imports of the test program on NT4. 2004-12-06 11:45:13 +00:00
Juan Lang d179f8be8c Revert shell32 version to Win2K SP4 level. 2004-12-06 11:34:07 +00:00
Eric Pouech 0a258964c2 Const correctness fixes. 2004-11-30 21:38:57 +00:00
Tom Wickline 5c38e1b561 Version resources cleanup. 2004-11-23 13:59:34 +00:00
Alexandre Julliard 405568801e Removed a couple of no longer needed entries. 2004-11-19 18:28:05 +00:00
Robert Shearman 18988663c2 - Use more specific error codes than E_FAIL, where possible.
- Move vtable to end, give it the const modifier, and remove unneeded
  function declarations.
2004-11-19 18:14:47 +00:00
Aric Stewart 990ea44e98 Implementation of PathCleanupSpec. 2004-11-04 04:54:08 +00:00
Fabrice Ménard 7ce764669e Check the type of error returned by SHCreateDirectoryExW. 2004-11-02 05:22:39 +00:00
Rolf Kalbermatter e50a27de04 Use SHCreateDirectoryEx function instead of doing explicit recursive
directory creation.
2004-10-28 20:58:51 +00:00
Rolf Kalbermatter a2ebf8b356 Add test for SHCreateDirectoryEx function.
Fixed some typos.
2004-10-28 20:58:38 +00:00
Fabrice Ménard 8818ded2dc Some French translations added. 2004-10-27 21:36:17 +00:00
Rolf Kalbermatter 87fb440e71 Fix bad memory allocation for unicode buffer. 2004-10-27 21:18:35 +00:00
Juan Lang c639af64be _SHExpandEnvironmentStrings should return input string if no % found
to expand, and should call ExpandEnvironmentStringsW if it doesn't
handle an environment variable directly.  Based on a patch from Dan
Kegel.
2004-10-27 21:17:30 +00:00
Ge van Geldorp b3f2c53155 Use only one .res file. 2004-10-27 00:47:53 +00:00
Juan Lang 217bd082c6 Update shell32's version to WinXP level. 2004-10-26 21:17:50 +00:00
Juan Lang 535679aec7 Fix CSIDL_CONTROLS and CSIDL_PRINTERS PIDL types, and update tests now
that they pass.
2004-10-26 00:17:31 +00:00
Juan Lang 4a6a898e2d Avoid copying invalid data on error. 2004-10-25 21:53:18 +00:00
Sami Aario c2dcecc362 Check the return value of the SHGetDesktopFolder call. 2004-10-25 21:45:36 +00:00
Francois Gouget 3bb5b093e8 Assorted spelling fixes. 2004-10-22 22:27:51 +00:00
Alexandre Julliard 2d2e2e1e55 Avoid copying invalid data on error. 2004-10-22 20:26:23 +00:00
Francois Gouget a1779c1e33 Fix the function pointer declarations so MSVC likes them.
CSIDL_PROFILES is not defined in the Windows SDK.
snprintf and strcasecmp don't exist on Windows. Replace them with
wnsprintfA and lstrcmpiA respectively.
2004-10-22 20:25:46 +00:00
Mike McCormack 43149f490c Add a test for creating empty shelllink files. 2004-10-22 19:52:33 +00:00
Rolf Kalbermatter eb883577e4 - SHCreateDirectory should create intermediate directories if
necessary.
- Remove extra boolean parameter in SHNotifyMoveFile as it is not
  used.
- Use in SHFileOperation the function SHNotifyCreateDirectory instead
  of SHCreateDirectoryEx as it does not anymore what is needed here.
- Fix several unsigned/signed mismatch warnings.
2004-10-21 22:29:42 +00:00
Ge van Geldorp 9b399da426 - Don't double-quote an already double-quoted argument.
- Properly increment the fmt pointer.
2004-10-21 20:59:25 +00:00
Juan Lang 9cbc42bbae - the correct registry location to override is User Shell Folders, not
Shell Folders
- if User Shell Folders doesn't exist in HKCU, HKLM should be tried
- SHGetSpecialFolderPath should call SHGetFolderPath, not vice-versa
- the default values should be localizable
- some of the parameter checking and returned LPITEMIDLISTs were a bit
  off
2004-10-21 19:59:46 +00:00
Vincent Béron 6c644d68cf Fix various function prototypes. 2004-10-19 23:55:15 +00:00
Mike McCormack d5b0e0f01e Convert the shellmenu code to use unicode. 2004-10-19 03:56:40 +00:00
Vincent Béron 4eeae1adb3 Fix some types problems. 2004-10-18 22:39:21 +00:00
Rolf Kalbermatter 20952a5d23 Modify ANSI functions to allocate intermediate Unicode strings on the
heap instead of stack.
2004-10-18 21:45:16 +00:00
Rolf Kalbermatter 29d4ec4f85 Added SHFreeNameMappings implementation. 2004-10-18 19:33:45 +00:00
Vitaliy Margolen 64c63dd4b8 Sort files/folders before testing. 2004-10-11 19:52:23 +00:00
Francois Gouget 486d020c1b Don't define COBJMACROS in objbase.h.
Update the Wine sources accordingly.
2004-10-07 03:06:48 +00:00
Francois Gouget 75be67c6c0 Conformance tests must not include wine/debug.h. 2004-10-07 02:59:11 +00:00
Rolf Kalbermatter 18514ca547 Fix bug found by Piotr Caban, where our function tried to delete a
directory eventhough the user canceled the operation.
2004-10-06 00:04:39 +00:00
Francois Gouget 67aa858a31 Assorted spelling fixes. 2004-10-05 18:15:29 +00:00
Alexandre Julliard 739e5b06da Avoid depending on the non-standard IUnknown_METHODS macro in Wine
internal headers.
2004-10-05 04:16:21 +00:00
Alexandre Julliard ed19983d65 Fixed typo in ProgramsW.
Changed the case of windows and system directories to match the
directories we create by default.
2004-10-04 20:49:51 +00:00
Piotr Caban 304e0796cd Added Polish translation. 2004-10-04 19:31:50 +00:00
Ge van Geldorp 3db9386195 Can't pass NULL as default value to GetPrivateProfileString. 2004-10-04 19:05:02 +00:00
Alexandre Julliard 72c9008e73 Authors: Klemens Friedl <frik85@hotmail.com>, Martin Fuchs <martin-fuchs@gmx.net>
- drive icon artwork
- display different drive icons depending on the drive type
2004-09-29 21:13:58 +00:00
Robert Shearman 8e80468170 Simplify getting custom icons for a folder by utilising the new
SHELL32_GetCustomFolderAttribute function.
2004-09-28 19:33:57 +00:00
Robert Shearman 5ad2d3517f - Add support for custom shell folders, such as the History folder.
- Always try to initialize folder using IPersistFolder3 interface and
  then fall back on IPersistFolder if not supported.
2004-09-28 19:33:44 +00:00
Ge van Geldorp 535387aeb1 Call GetProcessHeap() instead of passing its address. 2004-09-27 20:34:49 +00:00
Martin Fuchs 7ccc2d25a2 - Use system metrics to determine icon sizes.
- Move invalid index from 1 to 0.
2004-09-24 01:10:31 +00:00
Martin Fuchs 09878e1c6a At least print message if we're not returning requested data. 2004-09-23 22:52:03 +00:00
Ge van Geldorp e63e3781c6 Some windres versions don't like POPUP"", change to POPUP "". 2004-09-23 04:28:04 +00:00
Steven Edwards e85b67bd9e Remove some unneeded include statements. 2004-09-23 04:27:24 +00:00
Robert Shearman bbdac5e475 GetWindowLong -> GetWindowLongPtr. 2004-09-22 19:14:08 +00:00
Martin Fuchs 1c8d9b66c3 Store absolute path in .lnk file. 2004-09-22 19:11:27 +00:00
Martin Fuchs fa417e2869 Implement IShellLinkA::Resolve and IShellLinkW::Resolve. 2004-09-22 04:00:56 +00:00
Robert Shearman c6516740af Share version information between DllGetVersion and resource file. 2004-09-22 04:00:43 +00:00
Francois Gouget bc371a83ec Fix CSIDL_COMMON_{STARTMENU,PROGRAMS,DESKTOPDIRECTORY} so they all use
paths in 'All Users' like CSIDL_COMMON_STARTUP.
The CSIDL_COMMON_PROGRAMS fix solves many menu creation problems.
2004-09-21 20:05:54 +00:00
Martin Fuchs a6f9e517fe Match class name used by Windows. 2004-09-21 20:04:59 +00:00
Martin Fuchs 06f6cc9d20 Correct setting of default menu item in shell context menus. 2004-09-20 21:46:11 +00:00
Martin Fuchs bfb0653147 Make drive letters in PIDLs always uppercase to enable PIDL
comparison.
2004-09-20 19:12:17 +00:00
Jens Collin 9e679d3675 Added lookup of environment vars in SHELL_ArgifyW. 2004-09-14 20:14:09 +00:00
Juan Lang a78b4981ca Added support for DLLVERSIONINFO2 in DllGetVersion. 2004-09-14 17:44:40 +00:00
Vitaliy Margolen f609b68ea5 IShellFolder::CompareIDs - return only -1/0/1 in lower 16 bit. 2004-09-13 23:25:09 +00:00
Alexandre Julliard 314b99c48f Removed some more uses of the non-standard ICOM_THIS macro. 2004-09-09 20:17:07 +00:00
Francois Gouget c13638ee85 Fix c_parser.pm so it handles 'const' preceeding a '*'.
Add missing #pragma pack directives for the new shlobj.h types.
Fix some field names in CSFV and QCMINFO.
Update the generated tests to also check shtypes.h and test some more
types.
2004-09-07 22:46:26 +00:00
Alexandre Julliard 39a696a166 Removed some uses of the non-standard ICOM_THIS macro. 2004-09-06 20:34:29 +00:00
Francois Gouget 5512ae2685 Disable MSVC warning 4116 to avoid the 'unnamed type definition in
parentheses' warning caused by TYPE_ALIGNMENT().
2004-09-06 20:29:53 +00:00
Robert Shearman 4188874ad5 - Add exports for missing ordinals 191-194.
- Stub for SHUpdateImageW.
2004-09-06 20:24:10 +00:00
Alexandre Julliard b0394dea42 Get rid of the WINE_UNUSED macro. 2004-09-01 17:36:04 +00:00
Francois Gouget 3e2868b457 Don't export the shell32 SHAllocShared functions by name.
Implement them by calling out their shlwapi equivalent (which had a
much more complete implementation anyway).
Fix the prototype of shlwapi's SHAllocShared().
Don't crash if lpvData is NULL in SHAllocShared().
Add a conformance test to shlwapi.
2004-08-31 17:38:59 +00:00
Francois Gouget 20b8b56d5f Enable the disabled tests in tests.data or add a comment describing
why the type cannot be tested.
Update the generated files, they compile and run successfully both on
Windows (with the Windows headers) and in Wine.
2004-08-25 00:42:50 +00:00
Huw Davies 174e6a5d28 Change dialogs to use MS Shell Dlg rather than Helv or MS Sans Serif. 2004-08-24 18:33:01 +00:00
Alexandre Julliard f714b39762 Get rid of the no longer used ICOM_MSVTABLE_COMPAT_DummyRTTIVALUE
macro.
2004-08-23 19:39:48 +00:00
Aric Stewart 383de6efbc Make sure exePath contains the path since it is used later in the
function as well.
2004-08-23 17:55:29 +00:00
Francois Gouget 310f093ac5 Moved declarations from undocshell.h to shlobj.h to match the latest
platform SDK.
2004-08-22 22:27:31 +00:00
Alexandre Julliard 25e2a320a7 Don't define BEGIN_INTERFACE in unknwn.h. 2004-08-22 21:38:46 +00:00
Huw Davies 0af47c8080 Unicodify a load of strings. 2004-08-20 19:57:50 +00:00
Francois Gouget 09747e50e7 Fix packing bug in shlobj.h.
Fix the declaration of bitfields so their layout matches what MSVC
generates.
Modify winapi_test to compute the bitfields size/alignment like MSVC
does.
Update the impacted generated.c files.
2004-08-20 19:33:17 +00:00
Aric Stewart 4133ed17d9 In IPersistFile_Save if the exe file is not found, trust the path we
are given and allow creation of the link.
2004-08-20 19:28:33 +00:00
Francois Gouget 68232c6c2f Remove types that don't exist from tests.dat.
Don't test types that have a platform dependent layout.
Don't test Wine-only types.
Helps get the generated tests compiling on Windows.
2004-08-19 20:34:42 +00:00
Francois Gouget 466f5e79a8 Add new fields to the NOTIFYICONDATA structure so it matches the
latest platform SDK.
Update shell32/tests/generated.c. It now works when compiled with the
Windows headers.
2004-08-19 19:16:31 +00:00
Vincent Béron 6fae1ce6fd Don't hardcode c:\windows paths in msi.dll. 2004-08-18 23:41:10 +00:00
Ge van Geldorp 225c8e6c57 Handle shell link files contained in double quotes. 2004-08-16 23:18:36 +00:00
Mike McCormack 22442cd880 Clean up messy comment in SHFileOperation.
Reduce the number of goto labels in SHFileOperation by one.
2004-08-16 19:57:05 +00:00
Francois Gouget e69f38551e Add the CCHILDREN_TITLEBAR+1 and NUM_POINTS macros.
Add a couple base types that winapi_test does not know how to parse.
Fix a bug so that 'signed' and 'unsigned' are recognised as valid
types.
2004-08-16 19:46:09 +00:00
Alexandre Julliard 48c4bb3c31 Get rid of the non-standard ICOM_VTABLE macro. 2004-08-12 23:00:51 +00:00
Alexandre Julliard 0467ce9fd7 Get rid of the non-standard ICOM_VFIELD macro. 2004-08-12 19:52:49 +00:00
Alexandre Julliard 616940eb9a Get rid of the non-standard ICOM_DEFINE macro. 2004-08-12 03:33:30 +00:00
Alexandre Julliard b459952144 Avoid some non-portable makefile constructs, and get rid of the
ALTNAMES variable.
2004-08-11 23:59:06 +00:00
Francois Gouget 522217c0e2 Remove LPFILESYSTEMBINDDATA as it's not defined in the standard
Windows headers.
2004-08-11 20:52:37 +00:00
Francois Gouget bf72af30d0 Modify widl to put the C COM macros inside an #ifdef COBJMACROS block
as is done in the Windows headers.
Add #define COBJMACROS where needed in Wine.
Fixes the compilation of the oleaut32/tests/olefont.c and
urlmon/tests/url.c conformance tests with the Windows headers.
2004-08-11 19:43:45 +00:00
Jon Griffiths 5f2e8b7f46 Delete the about dialog font when the dialog is closed. 2004-08-09 22:56:58 +00:00
Mike McCormack 9cd9cfd2ed Use Heap function in preference to malloc/free. 2004-08-09 19:46:47 +00:00
Marcus Meissner 2e6e18bfbb Marked some functions in debughlp as static.
Do not use REFIID as return, but IID*.
2004-08-09 18:49:42 +00:00
Jon Griffiths 42c8b413da Don't leak cache imagelists on exit. 2004-08-06 18:58:18 +00:00
Filip Navara 3a6c9dc907 Destroy associated listview when IShellView is destroyed. 2004-08-04 18:16:27 +00:00
Jens Collin ff3d644072 Use ShellExecute instead of CreateProcess in run dialog. 2004-08-02 18:48:21 +00:00
Filip Navara 06e9945f70 Add REST_NONLEGACYSHELLMODE policy. 2004-07-29 23:58:31 +00:00
Francois Gouget f8e01efb3d Assorted spelling fixes. 2004-07-23 23:02:09 +00:00
Marcelo Duarte 62d4adfffe French translation and other adjustments. 2004-07-23 22:59:49 +00:00
Henning Gerhardt 68ade3b7ac Minor fixes and updates to the German resource files. 2004-07-22 20:35:07 +00:00
Ivan Leo Puoti 0eb21bb4dd Added Italian resources. 2004-07-22 19:45:00 +00:00
Marcelo Duarte 95f067d3cd Update localization for Portuguese language. 2004-07-19 20:09:00 +00:00
Martin Fuchs f045c9df81 Distinguish between Open and Explore commands.
Execute items by default.
2004-07-16 19:13:21 +00:00
José Manuel Ferrer Ortiz e3cea2785b Updated the Spanish shell32 translation and made some corrections to
other language files.
2004-07-12 20:44:33 +00:00
Marcus Meissner ab7af13705 Fixed double applet = applet = assignment.
Removed sic_hdpa only used in 1 C file as static var.
Make VT_Shell_IMalloc32 and related variables static.
2004-07-12 19:50:56 +00:00
Alexandre Julliard b74089091b Authors: Martin Fuchs <martin-fuchs@gmx.net>, Ge van Geldorp <gvg@reactos.com>
Implement MessageBox-based RestartDialog() and RestartDialogEx(), use
string resources for ExitWindowsDialog() to allow
internationalization.
2004-07-09 22:51:19 +00:00
Mike McCormack 75d8be030a Fix a buffer overrun in autocomplete. 2004-07-04 00:11:07 +00:00
Ge van Geldorp 1b2a819075 Fix IFileSystemBindData method order. 2004-06-30 18:13:09 +00:00
Ge van Geldorp c390bb2aea Match prototypes to Platform SDK. 2004-06-28 20:32:53 +00:00
Royce Mitchell III 0d592611bd Shell32 run dialog combobox should also have WS_TABSTOP style. 2004-06-21 23:54:19 +00:00
Robert Shearman 77b7f95716 Make ole32 a delay-load import of shell32. 2004-06-18 00:23:38 +00:00
Francois Gouget 1117e69c14 SHELL_ExecuteW() passes a Unicode environment to CreateProcessW() so
it must specify the CREATE_UNICODE_ENVIRONMENT flag. Also the
SHELL_ExecuteW32() functions will always be called with a Unicode
environment so adjust their prototype accordingly.
2004-06-15 18:27:50 +00:00
Dmitry Timoshkov a98f0dffa6 Fix warnings introduced by my last patch. 2004-06-15 17:02:46 +00:00
Dmitry Timoshkov d321561ba4 Restore default "open" functionality of ShellExecute. 2004-06-15 00:44:14 +00:00
Dmitry Timoshkov 7c1ae16431 Ignore DdeClientTransaction error in ShellExecute. 2004-06-14 19:32:32 +00:00
Dmitry Timoshkov 5567887fd3 Add support for quoting "file://%1" like format strings. 2004-06-14 17:54:24 +00:00
Ulrich Czekalla d886064101 Implemented RealDriveType. 2004-06-14 16:56:39 +00:00
Ulrich Czekalla ed3d86f9be When we send out a notification to a registered window with
SHCNRF_NewDelivery, we should send a LPNOTIFICATIONLIST and the
process id of the caller.
2004-06-02 21:33:47 +00:00
Aric Stewart 3d9fb73909 Make sure that the size of the buffer passed to RegSetValueExW is in
bytes not WCHARs.
2004-05-28 19:28:41 +00:00
Uwe Bonnes 63a4b203d7 Assume MAX_PATH length for pszDisplayName. 2004-05-27 20:01:56 +00:00
Ivan Leo Puoti 3e42f6953e Changed my name, so update copyright info. 2004-05-27 02:25:13 +00:00
Stefan Leichter c51c46bada Moved stub of Control_FillCache_RunDLL from ascii to unicode. 2004-05-27 01:54:30 +00:00
Eric Pouech df93f2eeee GetModuleFileName[AW] doesn't terminate the string if the buffer is
too small.
2004-05-19 03:22:55 +00:00
Patrik Stridvall 070db4e5de Fixed some issues found by winapi_check. 2004-05-17 21:08:31 +00:00
Ilya Korniyko 4943881d28 Encoding fixes in Ukrainian translation. 2004-05-10 19:54:10 +00:00
Alexandre Julliard a11b2bbafb Updated the auto-generated tests. 2004-05-04 00:41:11 +00:00
Maxime Bellengé 54d7cb60e1 Fix a string allocation. 2004-05-02 04:20:23 +00:00
Maxime Bellengé 77c7c61edd - Fix the return key handling and clean up the code.
- Add support for quickComplete with Ctrl+Return.
2004-04-30 04:14:33 +00:00
Mike McCormack 0f6af2cee0 Stub implementation for SHFindFiles. 2004-04-29 20:01:38 +00:00
Ilya Korniyko 1c279bfd89 Added Ukrainian translations. 2004-04-26 23:35:17 +00:00
Dmitry Timoshkov 85ef456512 Fix the DDE PFNCALLBACK prototype. 2004-04-26 23:29:44 +00:00
Maxime Bellengé e2a90d9d52 Implemented the ACO_AUTOSUGGEST, ACO_AUTOAPPEND, ACO_UPDOWNKEYDROPSLIST
styles.
2004-04-26 20:06:24 +00:00
Dmitry Timoshkov 61daaf8bd3 Fix a bug in ShellExecute which called DdeCreateStringHandleW with a
wrong parameter. Revert previous erroneous fix.
2004-04-23 21:32:17 +00:00
Huw Davies 180045676b DdeClientTransaction returns zero on error. 2004-04-22 23:46:35 +00:00
Francois Gouget 8fc374d8b4 Make Unicode strings 'static const'. 2004-04-20 02:14:00 +00:00
Francois Gouget 52c0832161 Make Unicode strings static const. 2004-04-20 01:12:17 +00:00
Francois Gouget 6a6c85c6d8 Make Unicode const strings static so they are not copied to the stack
each time we enter the function.
2004-04-19 20:12:14 +00:00
Maxime Bellengé b7852de12f Add the IAutoComplete and IAutoComplete2 implementation (but methods
stubbed for now).
2004-04-19 19:26:57 +00:00
Wolfgang Schwotzer 0471483851 SHBrowseForFolder: support lpBrowseInfo->pszDisplayName being NULL. 2004-04-19 19:25:56 +00:00
Juan Lang 6d169747d6 Correct return value in a couple of error cases. 2004-04-15 05:04:10 +00:00
Martin Fuchs a9a04e8d4f - make drive letters in PIDLs always uppercase to enable PIDL
comparison
- Unicodify _ILCreateDrive()
2004-04-15 04:57:46 +00:00
Martin Fuchs 849337b9b6 Correct error handling in SHELL32_ParseNextElement(). 2004-04-15 04:55:54 +00:00
Martin Fuchs 618cf6fc0f Return "file not found" error values instead of E_INVALIDARG if
_ILCreateFromPathA() failed to find files.
2004-04-14 23:57:46 +00:00
Juan Lang bbdd20d536 Correct some PIDL types and eliminate some magic numbers in PIDL
allocation; correct a copy-pasto from a previous patch.
2004-04-14 19:33:07 +00:00
Juan Lang 77beaca78f If a folder contains a desktop.ini, check it for the icon location
before using the default folder icon.
2004-04-14 19:32:34 +00:00
Juan Lang 38deeb4fd2 Add stub for ShellDDEInit to let Windows explorer.exe get past the
beginning.
2004-04-13 21:15:33 +00:00
Juan Lang ae78d17f9d IShellView seems reasonably complete, change a FIXME to a TRACE to
speed up open/save dialogs.
2004-04-13 21:15:01 +00:00
Martin Fuchs b8dc8abbc0 Correct IShellFolder::GetAttributesOf() for the case *rgfInOut=0. 2004-04-13 00:19:11 +00:00
Martin Fuchs c01e515815 Check for folders in ShellExecute(). 2004-04-13 00:18:45 +00:00
Martin Fuchs 6223fdc9f2 - rename 'wszCommandline' to 'wszParameters'
- separate out command line arguments from executable file name
2004-04-12 23:12:51 +00:00
Martin Fuchs 1ab301d7be - eliminate MSVC type conversion warning
- IShellLink::GetIconLocation(): get icons for shell links if not
  already set
2004-04-12 23:12:39 +00:00
Francois Gouget 0217bfdfed Assorted spelling fixes. 2004-04-12 22:08:23 +00:00