fe7e786ace
advapi32: Add exception handling around all service RPC calls.
2008-04-11 12:14:24 +02:00
9dc979604c
advapi32: Fix a few tests that fail in win2k.
2008-04-11 11:16:14 +02:00
5c8473ba78
advapi32: Array parameters are passed to function as pointers so lose size information.
2008-04-09 11:43:41 +02:00
2ae8e87616
advapi32: Do not call MIDL_user_free() with pointer to stack memory.
2008-04-07 13:39:32 +02:00
9bc84d81df
wineboot: Start services.exe on startup instead of on demand in the advapi32 services code.
2008-04-02 11:55:24 +02:00
9d834fc180
advapi32: Remove some unused services functions.
2008-04-01 19:11:09 +02:00
9bb129d17b
advapi32: Silence the pipe read error in the normal case.
2008-03-31 17:26:07 +02:00
b8348b95a6
services: Remove dependency on service name being determined correctly in order for the two ends on the control pipe to meet up.
...
Instead use the mechanism used by native which uses
\\.\pipe\net\NtControlPipeN.
Also remove the service startup event set by StartServiceCtrlDispatcher
as we wait for the service status to change instead.
2008-03-29 11:51:39 +01:00
9a6fc01d84
services: Move ControlService and StartServiceW from advapi32.dll to services.exe.
...
This also changes the architecture such that services.exe is the server
end of the control pipe and the service is the client end.
2008-03-29 11:51:34 +01:00
7afd9a977a
services: Move LockServiceDatabase and UnlockServiceDatabase from advapi32.dll to services.exe.
2008-03-29 11:51:01 +01:00
b48714b148
services: Move SetServiceStatus and QueryServiceStatusEx to services.exe.
2008-03-29 11:50:57 +01:00
010dcb168b
services: Move GetServiceDisplayName to services.exe and implement GetServiceKeyName.
2008-03-29 11:17:33 +01:00
76d4eeebff
services: Move ChangeServiceConfigW implementation from advapi32.dll to services.exe.
2008-03-29 11:17:07 +01:00
a363b9a066
services: Move QueryServiceConfigW from advapi32.dll to services.exe.
2008-03-29 11:16:43 +01:00
a2156fc348
services: Move CreateService, OpenService and DeleteService implementations from advapi32.dll to services.exe.
2008-03-29 11:15:59 +01:00
4275fbf603
services: Start a local RPC server.
2008-03-29 11:15:05 +01:00
06d429d6b6
Spelling fixes.
2008-03-27 20:48:19 +01:00
6cb602c6db
advapi32: Partly implemented QueryServiceConfig2A/W.
2008-03-26 14:13:07 +01:00
9ea9eaaa81
advapi32: Create MachineGuid value if it doesn't exist.
2008-03-25 19:58:43 +01:00
4c984e089a
advapi32: Test the MachineGuid value.
2008-03-25 19:58:37 +01:00
2904f543f4
advapi32: Add a stub for CreateRestrictedToken.
2008-03-22 11:14:13 +01:00
304b415284
Assorted spelling fixes.
2008-03-19 11:21:27 +01:00
e92121d41e
advapi/service: Give service its own debug channel.
2008-03-14 11:21:53 +01:00
df0f42fe78
advapi32: Implemented RegOverridePredefKey.
2008-03-11 19:48:57 +01:00
81e0ef44e9
advapi32/tests: Fix a few typos.
2008-03-07 10:52:20 +01:00
48000893f9
makefiles: Simplify the use of the IMPORTLIB variable in the DLL makefiles.
...
Only specify the root to keep platform-specifics out of the individual
DLL makefiles.
2008-03-04 20:55:01 +01:00
bfc290f6d0
advapi32/tests: Skip not available functions.
2008-03-03 15:38:57 +01:00
0c7ab1bd30
advapi32/tests: Don't crash on NT4, W2K and XP-SP1.
2008-02-25 19:50:12 +01:00
284f86183c
advapi: Check if service really exists before bombing out in CreateService.
2008-02-22 11:55:12 +01:00
7a585f3c37
advapi32/tests: Check whether RegGetValue() '\0'-terminates the buffer when retrieving a zero-byte string value.
2008-02-19 13:39:24 +01:00
6843da68e7
advapi32/tests: Remove an obsolete comment: Wine's on-disk registry format now supports string values with no trailing '\0'.
2008-02-19 13:39:24 +01:00
608ac1e828
advapi32: Fix the AccessCheck tests so that the ACCESS_SYSTEM_SECURITY test now runs (when the user has the Security privilege).
...
Duplicate the token at SecurityImpersonation impersonation level instead
of SecurityIdentification, otherwise the call to RtlAdjustPrivilege
fails on Windows.
2008-02-19 13:39:24 +01:00
ba4669860e
advapi32/tests: Skip tests when our language isn't LANG_ENGLISH.
2008-02-18 14:13:18 +01:00
cca635b472
advapi32: Add tests for the off-by-one fixing behaviour of RegSetValueExA and RegSetValueExW.
2008-02-18 13:30:01 +01:00
628183c2f9
advapi32: Document that the cbData parameter of RegSetValueA/W is ignored.
2008-02-18 13:29:56 +01:00
121be51f1d
advapi32: Add tests for RegSetValueA/W.
...
Fix RegSetValueA/W to return ERROR_INVALID_PARAMETER if NULL data is
passed in.
2008-02-18 13:29:51 +01:00
3138f87e73
advapi32: Fix CryptVerifySignatureW test failures on Win98SE and NT4.
2008-02-16 13:51:37 +01:00
79333bd1c0
advapi32/tests: Check that a credential type is supported before testing it. Test CRED_TYPE_DOMAIN_VISIBLE_PASSWORD credentials. Factorize the CredentialBlob checks.
2008-02-15 12:05:39 +01:00
6552f86ff9
advapi32/tests: Factorize the password constants.
2008-02-15 12:05:30 +01:00
ddab29b7d1
advapi32: Add a rudimentary implementation of CredGetSessionTypes().
2008-02-15 12:05:20 +01:00
7579145ae1
advapi32: The lpcbSecurityDescriptor parameter to RegGetKeySecurity isn't optional, so don't complicate the code by treating as though it is.
2008-02-15 11:03:31 +01:00
e2de4b18e5
advapi32/tests: CryptVerifySignatureW is not implemented on win98.
2008-02-15 09:54:23 +01:00
56d085ccec
advapi32/tests: Only use functions if they are implemented.
2008-02-12 22:40:15 +01:00
05c7174909
tests: Add a helper routine to wait for a child process and propagate its result correctly.
2008-02-07 12:56:00 +01:00
f3f64c7939
advapi32: Fix the failing QueryServiceConfig2 test on platforms win2k3 and vista.
2008-02-05 12:19:36 +01:00
b2f4c7737b
advapi32: Fix the size calculation in StartServiceW.
...
Calculating an open-ended structure using sizeof doesn't yield an
accurate size because of alignment.
2008-02-04 13:03:16 +01:00
d4c48db4b0
advapi32: Fix some cred test failures on Vista and prevent it crashing.
2008-01-25 12:30:32 +01:00
e84daed485
Avoid sizeof in traces.
2008-01-24 14:03:10 +01:00
269cb45f25
advapi32/tests: Add the trailing '\n' to an ok() call.
2008-01-23 20:39:27 +01:00
44273b00ed
advapi32/tests: Make tests run on win9x/NT4 again.
2008-01-23 12:05:37 +01:00
b503bcf6e6
advapi32: Implement LookupAccountNameW for well-known groups.
2008-01-23 11:31:42 +01:00
28cabdfe9f
advapi32: Add a test for LookupAccountNameA on a well-known group.
2008-01-23 11:31:42 +01:00
6efa903cf0
advapi32: Implement SetEntriesInAclW.
2008-01-23 11:31:42 +01:00
261bf8dad5
advapi32: Add more tests for SetEntriesInAcl.
2008-01-23 11:31:42 +01:00
d6748c9db7
advapi32: Added some tests for QueryServiceConfig2A/W.
2008-01-22 11:18:48 +01:00
f6caf1be81
Misc spelling fixes.
2008-01-18 12:51:08 +01:00
520054f60c
advapi32/tests: Actually test strings that expand to something bigger than their original size.
2008-01-18 11:53:02 +01:00
d9a06b236a
advapi32: RegGetValueW() must return the required buffer size in bytes, not WCHARs.
2008-01-11 12:25:21 +01:00
c47c6483aa
advapi32: RegGetValue() should not return an error when expanding a string and given a NULL buffer and a zero size.
...
Adjust the tests to cover this case for REG_EXPAND_SZ registry
values. Improve the documentation a bit.
2008-01-11 12:25:14 +01:00
038c3a264b
advapi32: Accept a NULL lpServiceStatus in ControlService.
2008-01-10 12:07:22 +01:00
d2e0786eb2
advapi32/tests: Don't crash on win98.
2008-01-08 12:54:58 +01:00
ef15bbf1cb
advapi32/tests: Print the correct size in an error message.
2008-01-07 17:18:07 +01:00
781c3b9c6a
advapi32: Fix the length written to the pipe for the start message.
2008-01-07 12:18:11 +01:00
3133280d08
advapi32: Don't wait for 20 seconds if a service fails to start.
2008-01-04 12:50:11 +01:00
05f38321c4
advapi32: Remove unneeded casts.
2007-12-31 17:39:39 +01:00
7593fac632
advapi32: Start non-interactive services in a separate window station.
2007-12-20 16:44:36 +01:00
eb2d8458a3
advapi32: Move the EnumDependentServicesA/W stubs in service.c where they belong.
...
Make the stubs return success.
2007-12-20 15:00:42 +01:00
c673b2284d
advapi32: Return from StartServiceCtrlDispatcher when all services are stopped.
2007-12-19 18:28:20 +01:00
a12b9c52da
advapi32: Replace the list of services with an array.
2007-12-19 17:02:12 +01:00
1f11ad8288
advapi32: Use exponential backoff when waiting for a service to start.
2007-12-19 15:07:20 +01:00
4889a0edf7
advapi32: Fix RegisterServiceCtrlHandler spec entry.
2007-12-19 15:06:19 +01:00
865bb0a67a
advapi32: Reimplement RegisterServiceCtrlHandler on top of RegisterServiceCtrlHandlerEx.
2007-12-19 15:05:04 +01:00
1590b1f731
advapi32: Fix undocumented behaviour in ReqQueryValueEx when 'count' and 'type' point to the same address.
2007-12-14 14:06:45 +01:00
c0b12351e0
Avoid size_t types in traces.
2007-12-07 18:49:18 +01:00
65d2f8a68d
advapi32: service_control_dispatcher(): Fixed invalid pipe test to display GetLastError() before it gets overwritten.
2007-12-05 13:47:00 +01:00
263cb72e13
advapi32: Remove unneeded casts.
2007-12-03 13:10:21 +01:00
defbdf76e5
advapi32: Add stub for CreateProcessWithLogonW.
2007-11-29 15:46:50 +01:00
fd03f4ae86
advapi32: Fix a typo.
2007-11-29 13:39:16 +01:00
f96ff7d46e
advapi32: Make the credential registry key stay around if a persist value longer than session is specified.
2007-11-28 11:23:56 +01:00
c251100685
advapi32: Use the open_for_write parameter to open_cred_mgr_key and fix get_cred_mgr_encryption_key to not need KEY_WRITE access to the key passed in.
2007-11-28 11:23:54 +01:00
312a1db3ec
advapi32: Add support for using the Mac Keychain services as a backend for the credential functions instead of the registry.
2007-11-27 12:29:34 +01:00
50532d8b4d
advapi32: Fix a typo in CredEnumerateW.
2007-11-27 11:38:28 +01:00
ca83f61d2e
advapi32: Move credential registry reading code to separate functions.
2007-11-27 11:38:22 +01:00
f874126bec
advapi32: Remove untriggerable check.
2007-11-19 13:51:45 +01:00
89b9af7714
advapi32: Fix buffer overrun in tests/registry.c:wine_debugstr_wn().
2007-11-12 12:55:42 +01:00
81a5701ca9
Assorted spelling fixes.
2007-11-09 13:07:12 +01:00
0590fe2ecf
Make some variables static.
2007-11-06 14:38:54 +01:00
cac17c455d
advapi32/tests: Make tests run on win98 again.
2007-11-02 12:38:36 +01:00
e8d7af2d43
advapi32: Implement filter matching for CredEnumerate.
2007-10-31 12:39:54 +01:00
e6f28ebb1a
advapi32: Add tests for credential management functions.
2007-10-31 12:39:54 +01:00
e3fae172f1
advapi32: Implement ANSI credential management functions.
2007-10-31 12:39:54 +01:00
61e836b947
advapi32: Implement CredEnumerateW.
2007-10-31 12:39:53 +01:00
72bd876599
advapi32: Implement CredDeleteW.
2007-10-31 12:39:53 +01:00
7689fad310
advapi32: Implement CredReadW and CredFree.
2007-10-31 12:39:53 +01:00
7583130908
advapi32: Implement CredWriteW.
2007-10-31 12:39:53 +01:00
dc072e209d
advapi32/tests: Fix undefined memory references in registry.c.
2007-10-30 12:46:38 +01:00
27e8b829a4
advapi32: Export RegOverridePredefKey.
2007-10-26 15:16:38 +02:00
a1e0f773e0
advapi32: Add a well known sid.
2007-10-26 14:03:46 +02:00
e7d423ce48
advapi32: Fix CreateWellKnownSid test on Windows XP.
2007-10-26 14:03:46 +02:00
e51f8490f2
server: Ignore ACEs with the INHERIT_ONLY_ACE flag set during access checks.
2007-10-26 12:46:30 +02:00
340122abb7
advapi32: Fix the ACCESS_SYSTEM_SECURITY test by impersonating the token during the call to RtlAdjustPrivileges.
2007-10-26 12:46:30 +02:00
efed229a08
advapi32: Add a test for access checks with the INHERIT_ONLY_ACE flag.
2007-10-26 12:46:30 +02:00
1fd2bc5215
advapi32: Add stubs for CredEnumerateA/W.
2007-10-25 12:53:22 +02:00
87b15db617
advapi32: Print out the unknown value for sid use in the LookupAccountName test, instead of the known value.
2007-10-25 12:14:34 +02:00
6b081232b9
ntdll: Add a stub for RtlSetControlSecurityDescriptor.
...
Implement SetSecurityDescriptorControl on top of RtlSetControlSecurityDescriptor.
2007-10-23 18:20:45 +02:00
b1335db353
Better match the PSDK types and update win32.api to fix the winapi_check warnings.
2007-10-23 18:19:42 +02:00
06b2da9560
ntdll: Fix RtlValidAcl to accept newer ACL revisions.
2007-10-23 18:18:29 +02:00
866ec27044
advapi32: Add some tests for ACL functions.
2007-10-23 18:18:29 +02:00
8bfb77b958
advapi32: Runtime link to CreateWellKnownSid in the tests for the function, since it isn't available on all platforms.
2007-10-23 18:18:29 +02:00
35c0511d2b
advapi32: Remove tests for the sha context structure.
2007-10-23 12:22:52 +02:00
5c1334e775
advapi32/tests: Fix memory leak (found by Smatch).
2007-10-22 15:58:22 +02:00
cf509c29f1
advapi32: Make CreateWellKnownSid create domain sids (with test).
2007-10-22 14:54:39 +02:00
b06379b2b3
advapi32: Add a test for CreateWellKnownSid and implement two more SIDs.
2007-10-22 14:54:39 +02:00
8bc12f3f41
advapi32/tests: Define OBJECT_BASIC_INFORMATION in source file as it is not defined in Windows SDK winternl.h.
2007-10-22 14:54:39 +02:00
05cb54fcc8
advapi32/tests: Make the SDDL test pass under Vista.
2007-10-22 14:54:39 +02:00
27213de046
advapi32: Fix AdjustTokenPrivileges() to match the PSDK.
2007-10-17 13:44:01 +02:00
2cecc630b6
advapi32: Don't link to CreateWellKnownSid at compile time in the security tests.
...
It isn't available on some Windows platforms.
2007-10-16 13:17:29 +02:00
12e44bf299
server: Fix token_access_check to allow full access to security descriptors with present but NULL DACLs.
2007-10-16 13:17:22 +02:00
a006b06080
ntdll: Fix the return code from RtlSetDaclSecurityDescriptor when daclpresent is FALSE.
2007-10-16 13:17:14 +02:00
d1a3e2ede5
advapi32: Add tests for AccessCheck with NULL DACLs and blank DACLs.
2007-10-16 13:17:09 +02:00
22e9da0dd7
advapi32: Improve stub for EnumServicesStatusExA a bit.
2007-10-15 16:56:11 +02:00
d16a634c38
Better match the PSDK types and update win32.api to fix the winapi_check warnings.
2007-10-15 14:06:48 +02:00
fda899a778
Assorted spelling fixes.
2007-10-11 19:52:49 +02:00
719da96a3e
advapi32: security: Remove unneeded FIXME.
2007-10-04 11:41:06 +02:00
57a67ebcce
advapi32/tests: Fix a typo.
2007-10-03 12:02:48 +02:00
40c66b8977
advapi32/tests: Fix memory leaks (found by Smatch).
2007-10-03 12:02:38 +02:00
00bc3d9e48
advapi32: Allow GetFileSecurityA/W to work on files that have been opened already with restricted sharing flags.
...
Only use the minimum required access rights for the information being retrieved.
2007-10-03 11:17:04 +02:00
1262d7dbef
advapi32: Implement SetFileSecurityW on top of NtSetSecurityObject.
2007-10-03 11:16:59 +02:00
a8b8ddd865
advapi32: Fix GetServiceDisplayNameA for cchBuffer == 0.
2007-09-28 11:30:00 +02:00
8fd1cf0f56
advapi32: Implement GetPrivateObjectSecurity (with test).
2007-09-28 11:26:45 +02:00
0590dc9b5c
advapi32: In ConvertStringSecurityDescriptorToSecurityDescriptor "AU" should be checked before "A" (with testcase).
2007-09-28 11:26:25 +02:00
8188ce6fb1
advapi32: Make ConvertStringSecurityDescriptorToSecurityDescriptor write the ACL.
2007-09-28 11:26:18 +02:00
611f57bc20
advapi32/ntdll: GetSecurityDescriptorOwner/Group should fill isDefaulted also for NULL sids.
2007-09-28 11:26:10 +02:00
3c51b2c645
advapi32/ntdll: MakeRelativeSD should preserve NULL pointers (with testcase).
2007-09-28 11:26:00 +02:00
2ba324738d
advapi32: The lpServiceStartName should default to LocalSystem for Win32 services.
2007-09-27 12:49:35 +02:00
790424f0ad
advapi32: Move the storage specifier to the beginning of the declaration.
2007-09-27 11:08:21 +02:00
6d5d0eaafa
advapi32: Make ConvertSidToStringSid use helper functions of ConvertSecurityDescriptorToStringSecurityDescriptor.
2007-09-26 12:15:14 +02:00
3198809fd5
advapi32: Implement ConvertSecurityDescriptorToStringSecurityDescriptor[AW].
2007-09-26 12:15:14 +02:00
bb3a968d30
advapi32: fix some compiler warnings when using -Wsign-compare.
2007-09-25 14:12:46 +02:00
ff3ab48081
advapi32: Make ConvertStringSidToSid not to ignore the first subauthority.
2007-09-25 11:18:53 +02:00
57ca9ae92d
advapi32: Add AddAuditAccessAceEx.
2007-09-25 11:18:45 +02:00
1122dc130a
advapi32: Fix a test.
2007-09-25 11:18:30 +02:00
5b4aa62fd2
advapi32: Add some more rights constants for ConvertStringSecurityDescriptorToSecurityDescriptor.
2007-09-24 13:31:30 +02:00
af183df608
advapi32: Add and use LSTATUS.
2007-09-18 11:20:53 +02:00
c5c0a26f60
advapi32: QueryObjectSecurity should return a self-relative security descriptor and not overflow the buffer.
2007-09-18 10:47:50 +02:00
bcfe954451
advapi32: Fix ImpersonateNamedPipeClient to pass in a pointer to an IO_STATUS_BLOCK to NtFsControl.
...
Otherwise, NtFsControl file won't do anything except return STATUS_INVALID_PARAMETER.
2007-09-14 14:23:35 +02:00
82ef8d7239
advapi32: Replace SERV_free by HeapFree.
2007-09-12 14:09:17 +02:00
c213c2c2ab
advapi32/tests: Don't use locale dependent string for testing.
2007-08-27 11:57:57 +02:00
ec58b4485a
advapi32: Obtain the process id locally.
2007-08-23 13:35:41 +02:00
346fbb32e1
advapi32: Return an error if we try to start an already running service.
2007-08-23 13:35:34 +02:00
a5bbed2b95
advapi32: Add more tests for CryptVerifySignatureW, and correct its parameter checking.
2007-08-23 12:37:55 +02:00
95af1823ca
advapi32/tests: Skip a test when not properly logged in on win9x.
2007-08-17 11:47:51 +02:00
fc436b92e5
advapi32/tests: Use GetModuleHandleA and skip.
2007-08-14 20:29:21 +02:00
4e8b83dcde
advapi32/tests: Make tests run again on win95.
2007-08-14 12:45:49 +02:00
a5aab7fae6
advapi32/tests: Fix typo.
2007-08-08 15:32:04 +02:00
0900c72bef
advapi32/service: Cater better for domain in test.
2007-07-31 22:35:36 +02:00
a0dd646eef
advapi32/tests: Don't test the contents of an uninitialized buffer.
2007-07-31 22:35:30 +02:00
5266e57975
Assorted spelling fixes.
2007-07-31 21:37:50 +02:00
a33993bcbd
crypt32: Fix the CryptReleaseContext() prototype.
2007-07-31 21:37:09 +02:00
def4466fd1
advapi32/service: Cater for domain in the test.
2007-07-30 23:37:58 +02:00
02e160179f
advapi32/tests: Use skip when we don't have enough rights.
2007-07-30 23:37:58 +02:00
9b8e9516ab
advapi32/service: Be a bit more consistent.
2007-07-30 14:59:20 +02:00
9c2d8c73aa
advapi32/service: Fix GetServiceDisplayNameA for service with no displayname.
2007-07-30 14:59:13 +02:00
641e645276
advapi32/service: Test for too small buffer.
2007-07-30 14:46:20 +02:00
07af2fe2b5
advapi32/service: Set correct error when the service doesn't exist.
2007-07-30 14:46:14 +02:00
dc6653887c
advapi32/service: Fix buffersize calculations for GetServiceDisplayNameW.
2007-07-27 12:50:31 +02:00
95d2f04611
advapi32/service: Forward GetServiceDisplayNameA to GetServiceDisplayNameW.
2007-07-27 12:50:19 +02:00
23d61ac866
advapi32/service: Test GetServiceDisplayNameA for service with no displayname.
2007-07-27 12:48:20 +02:00
adb3bbf274
advapi32/service: More tests for GetServiceDisplayName.
2007-07-27 12:48:00 +02:00
f0e07382cd
advapi32/service: Add tests for GetServiceKeyName.
2007-07-25 13:01:52 +02:00
7625c3bf37
advapi32/service: Close a handle on failure.
2007-07-25 13:01:43 +02:00
05e1539b2b
advapi32/service: Add another test for GetServiceDisplayName.
2007-07-25 13:00:46 +02:00
83d8cbcc48
advapi32/service: Handle is checked before servicename.
2007-07-24 11:26:00 +02:00
b5a61cb492
advapi32/service: Add tests for GetDisplayName.
2007-07-23 11:48:26 +02:00
12dbeef655
advapi32/tests: Run on NT4 again.
2007-07-23 11:48:19 +02:00
433393fd51
advapi32: Rename the test to better represent the tested functionality.
2007-07-20 12:25:50 +02:00
e50edb61f0
advapi32/service: Some 'refcount' tests.
2007-07-20 11:45:53 +02:00
4c24492d31
advapi32/service: lpBinaryPathName is mandatory.
2007-07-20 11:45:09 +02:00
af27e2159f
advapi32/service: Some tests for DeleteService.
2007-07-19 11:57:01 +02:00
f8f6340a69
advapi32/service: Check for duplicate displayname.
2007-07-19 11:56:39 +02:00
a80e952ac0
advapi32/service: Cleanup (long lines and a typo).
2007-07-19 11:56:30 +02:00
4fdf90d406
advapi32: Add tests for ConvertStringSecurityDescriptorToSecurityDescriptor.
2007-07-19 11:55:47 +02:00
ccfa9ad8df
advapi32: Set the right pointer so that StringAcl is updated correct in ParseAceStringRights.
...
The number of allowed hex digits should be 8, not 6.
2007-07-19 11:55:37 +02:00
6c24386e03
advapi32: Don't crash in ConvertStringSecurityDescriptorToSecurityDescriptorW if LocalAlloc fails.
2007-07-19 11:55:13 +02:00
4d5ce383f5
advapi32: Add the size of the security descriptor structure to the size of memory required in ParseStringSecurityDescriptorToSecurityDescriptor.
2007-07-19 11:55:06 +02:00
60d847b074
advapi32: Fix a typo in ParseStringAclToAcl which caused the ACE to be written inside of the ACL memory.
2007-07-19 11:54:59 +02:00
f56fe2c1bc
advapi32: Fix ComputeStringSidSize to work with SIDs with one sub authority.
...
Use GetSidLengthRequired instead of computing the length in a way that
won't always be correct.
2007-07-19 11:54:40 +02:00
f8ea5a73ce
advapi32/service: Test for duplicate displayname.
2007-07-18 13:38:16 +02:00
6c63fa627e
advapi32/service: Check combination of service-type and start-type.
2007-07-16 22:47:09 +02:00
cf111099fc
advapi32/tests: Use skip instead of trace.
2007-07-13 14:43:29 +02:00
f09359cda4
advapi/service: Check servicetype and starttype.
2007-07-13 12:28:25 +02:00
d470e688c4
advapi/service: Create specific access rights for service handles.
2007-07-13 12:27:40 +02:00
137eb037b9
advapi/service: Check for empty servicename and binaryname.
2007-07-12 12:58:29 +02:00
c011369aab
advapi/service: Check if we have enough access rights to create a service.
2007-07-12 12:58:16 +02:00
5dab8935b9
advapi/service: First tests (and fixes) for CreateService.
2007-07-12 12:58:08 +02:00
13b3b724c6
advapi/service: Fix possible handle leak.
2007-07-12 12:57:47 +02:00
05fec6c871
advapi/service: Simplify DeleteService by using RegDeleteTree.
2007-07-12 12:57:41 +02:00
14ab7d766f
advapi32: Create specific access rights for service control manager handles.
2007-07-11 11:59:39 +02:00
06d6a03d45
advapi32: Handle to Service Control Manager is checked first.
2007-07-09 12:16:52 +02:00
db892decda
advapi32/tests: Add tests for CloseServiceHandle.
2007-07-06 18:11:36 +02:00
71982a4257
advapi32/tests: Add tests for OpenServiceA.
2007-07-06 18:11:26 +02:00
a3317a5c01
Assorted spelling fixes.
2007-07-05 19:56:34 +02:00
21492e4904
advapi32/tests: Use skip for not implemented function.
2007-07-05 19:54:31 +02:00
8fae363595
advapi32/tests: Use skip when we don't have enough rights.
2007-07-03 20:39:32 +02:00
6dde764898
advapi32/tests: Add tests for OpenSCManagerA.
2007-07-02 13:37:34 +02:00
ff62d6cf42
advapi32/service: Don't rely blindly on type.
2007-06-28 11:00:35 +02:00
9c6a5dfa85
advapi32/service: Make sure we fill all struct members.
2007-06-28 11:00:23 +02:00
dcef0bbf71
advapi32/service: Return (more) correct needed buffersize.
2007-06-27 14:32:28 +02:00
169af787d2
advapi32/service: Fix wrong key.
2007-06-27 14:32:28 +02:00
160b55cb2a
advapi32/service: Use the correct registry key for the service account.
2007-06-27 14:32:27 +02:00
3418ed23e1
advapi32/tests: Add some service related tests.
2007-06-27 14:32:27 +02:00
d521a2c6d3
advapi32: Always set the requested fields of the security descriptor according to the info flags in GetNamedSecurityInfoW.
...
Also, set the control flags so that other security descriptor
functions can retrieve the info from it.
2007-06-25 23:21:50 +02:00
1da7a32b11
advapi32: Add more RegGetValue() conformance tests, and fix Wine accordingly.
2007-06-21 13:11:09 +02:00
9aa4235117
advapi32: Mark service processes as system processes, and exit when all user processes are done.
2007-06-06 20:33:30 +02:00
84918394d2
advapi32: Convert the service list to a standard list.
2007-06-05 13:47:35 +02:00
88b6bc4f7c
advapi32: Added implementation of RegDeleteTreeA/W.
2007-05-30 15:55:05 +02:00
2e67fa32b1
advapi32: Return error on NULL service name to GetServiceDisplayNameA/W.
2007-05-21 19:11:08 +02:00
ac5dca86ff
advapi32: Fix return value to indicate error when NULL string is passed in.
2007-05-21 12:30:44 +02:00
020bd631ed
advapi32: Launch winedevice.exe when asked to start a kernel driver service.
2007-05-17 16:52:18 +02:00
fef82e74b6
advapi32: Add access flags to service handle data.
2007-05-16 14:27:46 +02:00
eb48a47260
advapi32: Fix a typo.
2007-05-14 14:25:16 +02:00
0a5e707a39
advapi32: Fix set process request, a pipe instance can only handle one request.
2007-05-08 21:35:34 +02:00
d0790f1bfe
advapi32: Implement GetServiceDisplayNameW.
2007-05-08 13:46:31 +02:00
7af5a9d87f
advapi32: Implement GetServiceDisplayNameA.
2007-05-08 13:46:26 +02:00
4b7c5097c3
advapi32: Store process ID into status structure on startup.
2007-05-08 13:45:56 +02:00
e79a94d45b
advapi32: Add FILE_FLAG_BACKUP_SEMANTICS to the flags passed to CreateFileW to be able to get security information for directories as well as for files.
2007-05-04 13:42:55 +02:00
5bb4ed2d66
advapi32: Check for error in CryptEnumProviderTypesA and CryptEnumProvidersA.
2007-05-03 14:36:43 +02:00
ff19b2f25a
advapi32: Exclude unused headers.
2007-04-30 12:25:54 +02:00
67e2c97a88
advapi: Improve SetEntriesInAclA stub.
2007-04-30 12:20:14 +02:00
552c225949
advapi32: Fix initial cleanup of the registry keys used for testing.
2007-04-30 12:19:56 +02:00
a60f60ac43
advapi32: Make service_start_process return the pid to the caller.
2007-04-24 11:53:32 +02:00
e782b836be
advapi32: Make struct service_data_t have the new SERVICE_STATUS_PROCESS struct.
2007-04-24 11:53:24 +02:00
2c99d4b2a7
advapi32: More tests for RegDeleteTreeA.
2007-04-23 17:26:34 +02:00
25142a27d0
advapi32: Fix one byte array overflow during DES unhash.
2007-04-23 14:41:56 +02:00
c5339be92b
advapi32: Add EnumServicesStatusExA/W stub implementation.
2007-04-23 14:38:38 +02:00
a2fbbd9209
advapi32: Make SERVICE_STATUS_PROCESS match the declaration in MSDN and PSDK.
2007-04-23 14:37:29 +02:00
481de9d82d
advapi32: Thunk GetFileSecurityW to NtQuerySecurityObject.
2007-04-23 13:56:32 +02:00
6c33eb4410
advapi32: Make QueryServiceStatus use QueryServiceStatusEx.
2007-04-20 13:20:15 +02:00
af5f6325e5
advapi32: Implement QueryServiceStatusEx.
...
Based on a patch by Anastasius Focht.
2007-04-20 13:18:59 +02:00
042a78dd05
advapi32/tests: Use memcmp() instead of strcmp() so that we can check 'intrazeroed' strings.
2007-04-18 13:13:09 +02:00
b934fc90eb
advapi32: Fix and extend the RegQueryValueEx() tests.
...
- Added tests for empty and zero-byte strings. Wine passes these tests, sort of.
- Check that the returned string is correct.
- All known Windows versions implement RegQueryValueExA(), so complain if it is not implemented.
- Only allow the Win9x quirks for the Ansi version.
- Query the name2A/W value for the string2A/W tests!
- The test_hkey_main_Value_A/W() functions were doing a sizeof() on the string parameter to compute the string's full size!
- We must reset GLE before each test, otherwise Win9x skips all but the first test.
2007-04-16 12:08:25 +02:00
402f4e9c74
advapi32/tests: Fix RegQueryValueExA test for win9x and ME.
2007-04-12 16:16:44 +02:00
7dd647b633
advapi32/tests: Use skip when OpenSCManagerA is not implemented.
2007-04-11 11:20:47 +02:00
1e3b6afa57
advapi32/tests: Make sure NT4 and W2K tests don't fail.
2007-04-10 14:23:14 +02:00
d347ebe196
advapi32: Spelling fixes.
2007-04-07 11:01:17 +02:00
0dcf196001
advapi32: Add some tests for RegDeleteTreeA.
2007-04-05 10:53:59 +02:00
3c75d9380a
advapi32: Constify some variables.
2007-04-03 11:22:20 +02:00
ddaacfbe2c
advapi32/tests: Some cleanup.
2007-04-02 11:29:14 +02:00
11f6e89f87
advapi32/tests: Reopen the main handle if needed.
2007-04-02 11:29:04 +02:00
81a95ff6ee
advapi32/tests: Add check to see if SetEntriesInAclW is implemented.
2007-03-30 10:09:15 +02:00
33b8ec1cb5
advapi32/tests: Add check to see if ImpersonateSelf is implemented.
2007-03-30 10:09:10 +02:00
bb00c95c45
advapi32/tests: Add check to see if LookupAccountNameA is implemented.
2007-03-29 21:13:54 +02:00
e54247b10c
advapi32/tests: Move check for ERROR_CALL_NOT_IMPLEMENTED to the first call.
2007-03-29 21:13:38 +02:00
640cb29bb7
advapi32/tests: Use skip.
2007-03-29 21:13:32 +02:00
d9e8a0f63e
Remove unneeded checks on the GetModuleHandle() return value for cases where we are linked with the dll.
2007-03-28 12:36:13 +02:00
2cd033eee1
advapi: Improve SetEntriesInAclW stub.
2007-03-20 12:39:41 +01:00
112257e59d
advapi: Constify argument of StartServiceCtrlDispatcher[AW] functions.
2007-03-20 12:39:36 +01:00
a2e7c325f9
advapi32: Replace inline static with static inline.
2007-03-17 20:03:29 +01:00
fc45352781
advapi32/tests: DuplicateTokenEx is not present on all platforms.
2007-03-17 19:52:01 +01:00
81e7d69dfd
advapi32: Implement RegGetKeySecurity with NtQuerySecurityObject.
2007-03-17 19:51:47 +01:00
6598aa5028
advapi32/tests: RegQueryValueW is not always implemented.
2007-03-16 11:21:12 +01:00
c2b05d32f0
advapi32: Fix a failing test on Windows caused by the existence of one SID that always has no associated account.
2007-03-16 11:21:02 +01:00
b4c33d5f99
advapi32/tests: No need to check return value of GetModuleHandle.
2007-03-14 22:44:07 +01:00
33e310f63d
advapi32/tests: Use GetModuleHandle and skip.
2007-03-13 21:08:13 +01:00
f41ebce136
advapi32/tests: Use GetModuleHandle and skip.
2007-03-13 21:08:07 +01:00
60cb73b573
advapi32: RegGetKeySecurity needs to pass length of struct to caller.
2007-03-13 11:52:47 +01:00
dea58c017d
advapi32: Explicitly initialize nested array element.
2007-03-13 11:52:22 +01:00
6544831184
advapi32/tests: Prepare for more tests and use skip.
2007-03-12 12:23:51 +01:00
39fb7839a7
advapi32: Constify some variables.
2007-03-12 12:01:24 +01:00
3b695ae33a
advapi32: Constify some variables.
2007-03-12 12:01:17 +01:00
1a71294ad3
advapi32: Constify some variables.
2007-03-12 12:01:10 +01:00
7e2228f15a
advapi32: Fixed registry test that failed because of a buffer overflow.
2007-03-08 21:06:31 +01:00
9dd1f1e341
Added version information for a number of dlls.
2007-03-07 21:25:16 +01:00
69299c7738
advapi32/tests: Move skip to a more appropriate place.
2007-03-05 16:43:27 +01:00
71697ec116
advapi32/tests: Don't use FreeLibrary with GetModuleHandle.
2007-03-05 16:43:27 +01:00
a170f762c0
advapi32: Replace const pointer parameters with correct pointers to const.
2007-03-05 12:09:03 +01:00
201317ed5e
advapi32: Constify a variable.
2007-03-05 12:08:58 +01:00
d478f5dadd
advapi32/tests: Make use of skip.
2007-03-05 12:05:47 +01:00
6bf1a6c5d2
advapi32/tests: Make use of skip.
2007-03-02 11:52:33 +01:00
53d838a1bf
advapi32: Create the service manager registry key if needed.
2007-02-28 20:51:25 +01:00
ee1706035a
advapi32: Reimplement QueryServiceConfigA on top of QueryServiceConfigW.
2007-02-28 20:47:51 +01:00
ec636f151b
advapi32: Avoid slashes and backslashes in user names.
2007-02-28 14:51:04 +01:00
c0a5671d9c
ntdll: More error checking. Properly handle NULL ACLs.
2007-02-28 13:28:33 +01:00
d342d1413c
server: Add get_token_impersonation_level server call for retrieving the impersonation level from a token.
...
Add tests for GetTokenInformation(TokenImpersonationLevel).
2007-02-21 19:49:37 +01:00
6a76a0ac7a
server: Check object's security when creating handles.
...
Don't check object's security when duplicating a handle of the same or
lower access rights. Based on a patch by Vitaliy Margolen.
2007-02-21 19:49:02 +01:00
c9b9847dce
server: Track the impersonation level of tokens.
2007-02-16 13:09:55 +01:00
795b40187e
advapi32: Add tests for token impersonation levels and what operations are allowed at each level.
2007-02-15 19:16:52 +01:00
4ea7535497
advapi32: Add some more tests for AccessCheck that determine what
...
token impersonation levels it accepts and to show that it doesn't
accept primary tokens.
2007-02-15 19:15:42 +01:00
78a28e6043
advapi32: Add more tests for DuplicateHandle security.
2007-02-15 14:19:29 +01:00
fdff5c3a3a
ntdll: Fix NtUnloadKey to match the DDK.
2007-02-05 12:26:01 +01:00
671b023de8
advapi32: Fix prototypes to match the PSDK.
2007-02-05 12:25:48 +01:00
c04e7e7878
advapi32: Add more tests for granted access mask. Fix test on Wine.
2007-01-25 12:52:27 +01:00
2cf11ef771
advapi32: Add few more tests for token access check and fix it on Wine.
2007-01-25 12:42:32 +01:00
793b12cdad
advapi32: Do not include unnecessary headers.
2007-01-22 13:29:00 +01:00
6cc4510b71
advapi32: Add tests for RegQueryValue.
2007-01-16 16:54:17 +01:00
f46cfe601c
advapi32: Remove a useless macro.
2007-01-05 20:27:13 +01:00
214eb389c9
advapi32: Change the test for the type parameter of RegQueryValueExA to only run on Win9x, since the value is set to a random value on NT.
2006-12-28 12:17:04 +01:00
cbec9337e6
advapi32/tests: Replace an '#if 0' with an 'if (0)'.
2006-12-14 20:24:41 +01:00
3d3529d605
advapi32/tests: Free memory after use.
2006-12-06 11:26:48 +01:00
d05fabb660
advapi32: Eliminate wild pointers.
2006-12-05 11:37:57 +01:00
19a49eb51a
advapi32: Add tests for LookupAccountName.
2006-12-01 13:12:04 +01:00
024237efaa
advapi32: Remove redundant NULL checks before CRYPT_Free.
2006-11-30 12:27:03 +01:00
e5b4b47c16
advapi32: Make some data const.
2006-11-29 12:44:43 +01:00
b2656633a6
Add some documentation headers to make winapi_check happy.
2006-11-13 13:01:15 +01:00
ac28398d12
advapi32: Constify a parameter.
2006-11-13 12:47:10 +01:00
3d73173fe1
advapi32: Fixed last error check in RegSaveKey.
2006-11-10 12:22:44 +01:00
5cff5038a9
Fix ntsecapi.h so it does not depend on winternl.h.
2006-11-08 12:53:19 +01:00
30e44c85c8
Assorted spelling fixes.
2006-11-07 15:25:24 +01:00
f15af94db8
advapi32: Test for OpenProcessToken with MAXIMUM_ALLOWED access.
2006-11-06 13:48:06 +01:00
5425cb35ed
advapi32: Fixed a couple items from previous patch (spotted by G Pfeifer).
2006-10-23 12:27:12 +02:00
4dfd319dbf
advapi32: Plug a couple of memory leaks.
2006-10-20 13:49:50 +02:00
e852f195a0
advapi32: Cast-qual warning fix.
2006-10-18 14:08:13 +02:00
ef998ea6cb
Assorted spelling fixes.
2006-10-16 11:33:38 +02:00
6a9222fc39
Fixed some printf warnings caused by using sizeof.
2006-10-12 14:58:25 +02:00
2730fe6d1c
advapi32: Make internal functions static.
2006-10-12 11:34:41 +02:00
ca118989f4
advapi32: Remove redundant NULL check before SERV_free (found by Smatch).
2006-10-06 15:20:31 +02:00
53535d6e13
advapi32/tests: Win64 printf format warning fixes.
2006-10-04 20:56:14 +02:00
4301816d47
advapi32: Win64 printf format warning fixes.
2006-10-03 16:21:58 +02:00
1a2aa7ca3d
advapi32: Make sure it's a real cleanup.
2006-10-02 21:38:04 +02:00
85ce5117c5
Add a WINE_NO_LONG_INT define to many makefiles to ease the transition of DWORD/LONG/ULONG from long to int.
2006-09-29 16:08:30 +02:00
38d33e33ae
advapi32: Fix ADVAPI_GetComputerSid to work correctly if a sid doesn't exist in the registry.
...
This makes the tests run correctly on first invocation.
2006-09-25 17:55:40 +02:00
32ab895e46
makefiles: Generate the dependencies line to avoid some code duplication.
2006-09-14 09:38:16 +02:00
06f9532dda
Assorted spelling fixes.
2006-09-08 11:04:53 +02:00
c339d8e272
advapi32: Fix lsa tests on windows98.
2006-09-07 10:21:57 +02:00
5cf75e615a
makefiles: Only run test and documentation targets in directories that need them.
2006-08-28 13:37:44 +02:00
0eebab8652
advapi32/tests: Cast-qual warnings fix.
2006-08-28 11:36:58 +02:00
d46c9e2ec2
advapi32: Fix security tests to not crash on windows.
2006-08-28 11:36:02 +02:00
9959d7e37f
advapi32: Cast-qual warnings fix.
2006-08-26 19:16:19 +02:00
f0085e6376
advapi32: Fix LookupAccountSid and tests to pass on windows and wine.
2006-08-26 18:55:12 +02:00
ee32bd99dd
advapi32: Fix lsa tests.
2006-08-26 18:55:04 +02:00
58ce495599
advapi32: Output information on failed LsaQueryInformationPolicy tests.
2006-08-24 14:09:14 +02:00
ca80c55ae8
advapi32: LookupAccountSid buffer size query tests.
2006-08-21 12:07:54 +02:00
39b77ec560
advapi32: LookupAccountSid buffer size query fixes.
2006-08-21 12:07:50 +02:00
e8e501f44b
advapi32: Fix test_LookupAccountSid to work on win9x.
2006-08-18 11:35:22 +02:00
bc590e87a6
advapi32: Add tests for RegQueryValueEx to show that it sets the data
...
size to 0 when a buffer isn't present and that it sets the type to
REG_NONE on Win9x.
2006-08-16 17:02:04 +02:00
6abfc027d5
advapi32: Fix LsaQueryInformationPolicy test to pass on NT4.
2006-08-16 12:41:17 +02:00
b0498a76e0
advapi32: Move duplicated code into function.
2006-08-14 20:17:09 +02:00
70071af6ad
advapi32: Try again with different access mask if LsaOpenPolicy fails with STATUS_ACCESS_DENIED.
2006-08-14 20:17:09 +02:00
aea864ce61
advapi32: Add more LookupAccountSid tests.
2006-08-14 11:46:13 +02:00
0f3cd3f224
advapi32: Add more SIDs to AccountLookupSid.
2006-08-14 11:45:53 +02:00
b843ce55c7
advapi32/tests: Write-strings warnings fix.
2006-08-14 11:44:52 +02:00
da44bfc02d
advapi32: Add some more well known SIDs.
2006-08-12 11:40:21 +02:00
08484ba498
advapi32: Add more SID tests.
2006-08-04 20:44:52 +02:00
1b8cfc5151
advapi32: Add a computer SID to the registry.
2006-08-04 12:04:06 +02:00
dabf5e88bf
advapi32: Check returned data from LsaQueryInformationPolicy.
2006-08-02 22:05:03 +02:00
0424424e34
advapi32: LsaQueryInformationPolicy: do the right thing for both domains and accounts.
2006-08-02 11:42:10 +02:00
c6e513dc72
advapi32: More LsaQueryInformationPolicy tests.
2006-08-01 18:34:35 +02:00
3879fef21d
advapi32: LsaQueryInformationPolicy update.
...
Update LsaQueryInformationPolicy to use correct computer name and SID.
Add support for PolicyDnsDomainInformation.
2006-08-01 11:01:04 +02:00
6d4fb08ece
advapi32: Add computer sid support to LookupAccountSidW.
2006-07-31 15:04:00 +02:00
9d43504655
advapi32: Add more helper functions.
...
Add ADVAPI_GetComputerSid.
2006-07-31 14:49:31 +02:00
Rob Shearman