b48436c5de
Skip unprocessed key events in the style manager
...
Originally committed to SVN as r6414.
2012-02-01 00:48:33 +00:00
3be4693480
Uncrustify AssStyleStorage a bit
...
Originally committed to SVN as r6413.
2012-02-01 00:48:24 +00:00
ac5af24014
Remove pointless #ifdef __APPLE__ around CmdDown()
...
The entire point of CmdDown is that it calls ControlDown on non-OS X, so
the ifdefs are completely pointless.
Originally committed to SVN as r6412.
2012-02-01 00:48:16 +00:00
7bd0691bd7
In PersistLocation get the new location of the dialog directly from the dialog rather than from the event as the data in the event is wrong
...
Originally committed to SVN as r6411.
2012-02-01 00:48:07 +00:00
04cc422391
Close the spell checker after all lines have been checked rather than only once there are no errors remaining. Closes #1442 .
...
Originally committed to SVN as r6410.
2012-02-01 00:47:57 +00:00
3af57cdbcd
Copy the source line's group in AssDialogue's copy constructor as copying wxStrings is far faster than constructing new ones
...
Originally committed to SVN as r6409.
2012-02-01 00:47:49 +00:00
a7d54f3d69
Make AssEntry::group const as it really should never change
...
Originally committed to SVN as r6408.
2012-02-01 00:47:38 +00:00
8bef1eb874
Destruct AssFiles on a background thread as it's rather slow with large files
...
Originally committed to SVN as r6407.
2012-02-01 00:47:28 +00:00
64553dd633
Handle commands which change types at runtime. Closes #1413 .
...
Originally committed to SVN as r6406.
2012-01-31 04:04:02 +00:00
983ffc1e83
Add some dumb heuristics to detect binary files in the charset detector to avoid taking forever feeding hundreds of MB through it. Closes #1438 .
...
Originally committed to SVN as r6405.
2012-01-31 04:03:55 +00:00
d68a395499
Open files in binary mode for charset detection
...
Originally committed to SVN as r6404.
2012-01-31 04:03:50 +00:00
fc96f1bd28
Swallow cancel exceptions thrown from opening audio from the script so that unrelated things aren't canceled
...
Originally committed to SVN as r6403.
2012-01-31 04:03:44 +00:00
f774f21903
Explicitly do nothing when an empty container is passed to delete_clear as it's oddly slow otherwise
...
Originally committed to SVN as r6402.
2012-01-31 00:44:55 +00:00
c2d3c910c7
Replace some uses of "" with wxString()
...
Despite special-casing zero-length input, wxString("") takes over four
times as long as wxString() - and on a 10k line script, this change cuts
AssFile's copy constructor's runtime in half.
Originally committed to SVN as r6401.
2012-01-31 00:44:43 +00:00
3b0d2ae8e6
Add effect and actor to the things that lines can be sorted by
...
Originally committed to SVN as r6400.
2012-01-31 00:44:34 +00:00
a114238396
Use AssTime::GetASSFormated for the video position display
...
Originally committed to SVN as r6399.
2012-01-31 00:44:26 +00:00
725820efc0
Add support for setting the active line from automation macros
...
The macro processing function can now return a second value, which is
the index of the line to make active, which must be one of the lines in
the selection. If it is not, or if the value is not present, then the
active line is left unchanged if it is in the new selection, or set to
the first line of the new selection if it is not.
Closes #1435 .
Originally committed to SVN as r6398.
2012-01-31 00:44:16 +00:00
dad803e956
Set the start and end times of syllables relative to the line's start time rather than time 0 to match 2.1.x's behavior. Closes #1440 .
...
Originally committed to SVN as r6397.
2012-01-31 00:44:07 +00:00
4c4ea92d0f
Update all spellcheckers after adding a word
...
Previously adding a word to the dictionary via the spell checker dialog
would not update the dictionary used by the subs edit box and
vice-versa.
Originally committed to SVN as r6396.
2012-01-31 00:43:59 +00:00
57fc4145d9
Always use the same language for all spellchecker instances as having different languages in different places is weird
...
Originally committed to SVN as r6395.
2012-01-31 00:43:49 +00:00
e205f9d51b
Make the 'Add to dictionary' button in the spellchecker dialog actually do something. Closes #1441 .
...
Originally committed to SVN as r6394.
2012-01-31 00:43:40 +00:00
aa49a4eb0f
Factor out the options lookups from BaseGrid::GetRowStrings so that they aren't pointlessly checked every row
...
Originally committed to SVN as r6393.
2012-01-31 00:43:32 +00:00
1af19fb42e
Make AssTime::GetASSFormated roughly an order of magnitude faster
...
Originally committed to SVN as r6392.
2012-01-31 00:43:23 +00:00
0c972886fb
Cache most of the brushes used in grid painting
...
Originally committed to SVN as r6391.
2012-01-31 00:43:15 +00:00
cf1425f9d1
Don't get the strings for hidden columns when painting the grid. Speeds up grid painting by up to 25%.
...
Originally committed to SVN as r6390.
2012-01-31 00:43:06 +00:00
b34d2c547f
Use wxAutoBufferedPaintDC rather than manual double-buffering in BaseGrid, as it's simpler and slightly faster
...
Originally committed to SVN as r6389.
2012-01-31 00:42:58 +00:00
e5f1719d8f
Use DC clipping in AudioRenderer rather than wxMemoryDC + Blit
...
In addition to being far simpler, this is marginally faster as
wxMemoryDC has a decent amount of overhead.
Originally committed to SVN as r6388.
2012-01-31 00:42:47 +00:00
0bff490b7e
Enable/disable the OK button in the TPP dialog when styles are (un)checked
...
Originally committed to SVN as r6387.
2012-01-27 23:35:31 +00:00
049c730813
Fix handling of autosave and autobackup paths that don't end in a slash
...
Originally committed to SVN as r6386.
2012-01-27 21:32:48 +00:00
e258e8c25f
Fix crash on empty lines in karaoke mode
...
Originally committed to SVN as r6385.
2012-01-27 20:04:31 +00:00
9e3f280cda
Fix bug where opening audio with audio already open would resize the audio display
...
Originally committed to SVN as r6384.
2012-01-27 20:04:22 +00:00
ef4c1b369d
Adjust the label for the history box in the shift times dialog to suggest that old shifts can now be loaded
...
Originally committed to SVN as r6383.
2012-01-27 20:04:14 +00:00
642a9df2bf
Correct the tooltip for 'Shift to Current Frame'
...
Originally committed to SVN as r6382.
2012-01-27 20:04:05 +00:00
78f1198426
Fix error when adding a word to the dictionary when the user dictionary file doesn't already exist
...
Originally committed to SVN as r6381.
2012-01-27 20:03:55 +00:00
bc9c521cfd
Apply the 'Subs Edit Box' hotkey handling to all of the text boxes in the subs edit area rather than just the main text edit. Closes #1431 .
...
Originally committed to SVN as r6380.
2012-01-27 19:23:35 +00:00
0dc0135f9a
Select the appropriate entry in the zoom dropdown when the zoom is changed externally so that keyboard navigation works. Updates #1433 .
...
Originally committed to SVN as r6379.
2012-01-27 19:23:26 +00:00
2d5df24fd6
Update the zoom on Enter in the zoom box. Updates #1433 .
...
Originally committed to SVN as r6378.
2012-01-27 19:23:16 +00:00
772c8dee3b
Fix accelerator conflict between Redo and Find and Replace
...
Originally committed to SVN as r6377.
2012-01-27 19:23:07 +00:00
16db1eb4dd
Add more menu accelerators and fix a conflict between View and Video. Patch by catntabile. Closes #1434 .
...
Originally committed to SVN as r6376.
2012-01-27 19:22:57 +00:00
d01c0cf501
Fix crash when drawing a vector clip that does not start with a move. Closes #1430 .
...
Originally committed to SVN as r6375.
2012-01-27 19:22:46 +00:00
4746ae8a1d
Really unhardcode the Paste Over dialog's height rather than just the width
...
Originally committed to SVN as r6374.
2012-01-26 23:23:41 +00:00
a54983a9bc
Fix a few minor issues with the Paste Over dialog
...
Remove the pointlessly hardcoded height of the checklist.
Set the parent correctly.
Set the initial focus to the OK button.
Originally committed to SVN as r6373.
2012-01-26 23:21:19 +00:00
8c246e1cb8
Make shift-scrollwheel scroll the grid a page at a time. Closes #1407 .
...
Originally committed to SVN as r6372.
2012-01-26 22:46:09 +00:00
6d550b4a5d
Repaint the entire grid on timing changes
...
Timing changes can potentially make all of the columns need to be
repainted (due to the collision line color), and the grid currently
isn't smart enough to know when this is actually the case, so just
always repaint the entire thing.
Originally committed to SVN as r6371.
2012-01-26 22:27:57 +00:00
a1ad0fa585
Use Scintilla's logic for deciding when to coalesce edit box changes
...
Scintilla's modification notifications don't expose enough information
to do a very good job of deciding when to group changes with previous
ones, but it does expose when Scintilla thinks undo groups should end,
so just use that.
This should significantly improve the behavior of undo when editing
lines in the edit box.
Originally committed to SVN as r6370.
2012-01-26 22:13:39 +00:00
d55f1622f1
Fix backwards-compatibilty break in the lua karaoke parser
...
Insert an empty syllable at the beginning of the karaoke syllable table
to better mimick 2.1.x's behavior.
Originally committed to SVN as r6369.
2012-01-26 21:19:25 +00:00
0aec0a9d59
Add an option to skip over commented lines in the spell checker. Closes #1428 .
...
Originally committed to SVN as r6368.
2012-01-26 20:51:08 +00:00
92ae4a616e
Fix truncation of all float fields in styles
...
Originally committed to SVN as r6367.
2012-01-26 20:17:31 +00:00
99a7eece9c
Significantly speed up duplicating multiple lines
...
SubtitlesGrid::DuplicateLines iterated over the entire file multiple
times for each line duplicated, making duplicating large numbers of
lines extremely slow.
Originally committed to SVN as r6366.
2012-01-26 20:08:54 +00:00
15a4eca7ce
Fix crash on (auto)save when using CSRI and video is open
...
Calling AssFile::Save/Load from multiple threads (even on different
objects) was not safe due to that is uses SubtitleFormat internally,
which was inheriently thread-unsafe. To fix this, change
SubtitleFormat's interface to support immutable implementations, and
make all of the current implementations immutable.
This isn't a perfect solution - making a subtitle format implemented in
lua immutable would be rather difficult - so at some point in the future
SubtitleFormat should probably be changed to a factory which returns new
objects from GetReader/GetWriter.
Originally committed to SVN as r6365.
2012-01-26 20:08:38 +00:00
Thomas Goyne