dfc3de131c
Make ngIRCd compile and run on NeXTSTEP 3.3 and OPENSTEP 4.2
...
by Steven D. Blackford <kb7sqi@aol.com>:
"I wanted to let you know that I've done a quick port of ngircd-0.12.0 for
NEXTSTEP3.3/OPENSTEP4.2. There wasn't a lot of changes required to get it
to compile clean, but I did make the necessary changes so that I didn't
have to use -posix flag. The NeXT has a pretty buggy POSIX implementation
so I always try to work around it. :-)
Anway, here's the changes required to get it to compile."
2008-08-01 16:21:16 +02:00
ccbbd7d1a5
GIT: added src/testsuite/message-test to ignore list.
2008-07-27 20:51:37 +02:00
e5cf73b9ee
Fix Validate_Args(): unused parameter "Idx" and "Req"
...
This patch fixes the following error message of GCC (tested with version
4.3.0) when not compiling ngIRCd in "strict RFC" mode:
parse.c: In function "Validate_Args":
parse.c:341: error: unused parameter "Idx"
parse.c:341: error: unused parameter "Req"
2008-07-27 20:35:01 +02:00
5df56111c4
message-test: Disable two tests using "localhost" as host name
...
Some operating systems, for example OpenBSD and OpenSolaris, use
"localhost.<domain>" instead of just "localhost" for 127.0.0.1, so
the "message-test" using "localhost" failed on such systems.
Don't have an idee how to make this work on all platforms ... :-/
So I simply disabled the two affected tests to make the testsuite
run on OpenBSD and OpenSolaris again.
2008-07-27 18:03:13 +02:00
e5174c629c
Fix Send_Message(): "lastCurrentTarget" may be used uninitialized
...
This patch fixes the following warning of GCC 4.3.1:
irc.c: In function "Send_Message":
irc.c:315: error: "lastCurrentTarget" may be used uninitialized in
this function
2008-07-27 17:16:41 +02:00
3358ad07d7
Fix t_diff(): declaration of 'div' shadows a global declaration
...
This patch fixes the following GCC warning message:
irc-info.c:422: warning: declaration of 'div' shadows a global declaration
2008-07-27 15:58:06 +02:00
318c8b238b
Cosmetic whitespace and line length fixes, mostly in Send_Message().
2008-07-27 15:50:51 +02:00
f8381aafb4
Added "message-test" to Makefile, so it is distrubuted and run.
2008-07-27 14:45:04 +02:00
d4eb55c79f
Cleaned up PRIVMSG and NOTICE patches.
2008-07-27 01:23:20 +02:00
2546a13ad2
Cumulative Message Patch
2008-07-27 01:23:04 +02:00
b92a7627f3
Don't allow empty channel names ("#") in strict RFC mode.
...
This closes Bug #88 .
Patch proposed by Eric <egrunow@ucsd.edu>, but with wrong length
comparision: please note that Channel_IsValidName() checks the name
INCLUDING the prefix, so the test must be length<=1!
2008-07-22 13:24:14 +02:00
258143897c
Return 461 (syntax error) on "JOIN :" and "PART :"
...
Up to this patch ngIRCd did not return any result (GIT master) or a badly
formated 403 (":irc.server 403 test :No such channel" [note the two
spaces!], branch-0-12-x) on the above commands, this patch changes the
behaviour to reflect ircd 2.11 which returns 461 in both cases.
2008-07-22 13:18:19 +02:00
477f2fd9e7
Channel_Join(): Code cleanup.
2008-07-22 13:07:57 +02:00
3f01324160
Fixes to misc-test: accept "localhost.<domain>" as well as "localhost"
...
Some operating systems, for example OpenBSD, use "localhost.<domain>"
instead of "localhost", so the "who-test" expecting "localhost" failed
on such systems.
(Please see 149859c5fecc..., which fixes this for the who-test already)
2008-07-21 13:40:22 +02:00
71562ebe57
Translated comments from German to English
2008-06-16 13:58:56 +02:00
258e39e89f
Fix GCC warnings for possibly uninitialized variables in IRC_JOIN
...
This patch fixes the following two warnings of GCC 4.2.4:
irc-channel.c: In function "IRC_JOIN":
irc-channel.c:185:
warning: "lastkey" may be used uninitialized in this function
irc-channel.c:185:
warning: "lastchan" may be used uninitialized in this function
2008-06-16 13:18:03 +02:00
e142c50ae6
GIT: added src/src/config.h.in~ to ignore list.
2008-06-11 16:02:06 +02:00
a84f7dcee5
Allow mixed line terminations (CR+LF/CR/LF) in non-RFC-compliant mode
...
Up to now ngIRCd accepted CR+LF as well as a single CR or LF in "non RFC
compliant" mode (the default). But ngIRCd became confused when it received
data containing mixed line endings (e. g. "111\r222\n333\r\n").
This patch enables ngIRCd (in "non RFC compliant" mode) to detect CR+LF,
CR, and LF as equally good line termination sequences and to always end the
command after the first one detected.
Some clients (for exmaple Trilian) are that ... broken to send such mixed
line terminations ...
First patch proposed by Scott Perry <scperry@ucsd.edu>,
Thanks to Ali Shemiran <ashemira@ucsd.edu> for testing!
2008-06-11 16:00:38 +02:00
8644cbf197
Don't allow stray \r or \n in command parameters
...
If ngircd receives an input line like "COMMAND arg\nIRRELEVANT\r\n",
"arg\nIRRELEVANT" is passed as an argument to COMMAND. This can lead
to output like:
:ngircd.test.server 322 nick #chan 1 :
topicwithprecedingnewline
:ngircd.test.server 322 nick #nxtchan 1 :
[..]
Worse, this allows clients to piggyback irc commands, e.g.
"TOPIC #a :test\n:fake!~a@nonexistant JOIN :#a\r\n", which
causes the client to receive a JOIN command during /LIST output.
Bug reported by Scott Perry, first patch by Florian Westphal.
2008-05-30 14:58:25 +02:00
6f7b669bec
--configtest: return non-zero exit code if there are errors
2008-05-28 00:31:20 +02:00
951314cb79
Handle_Buffer(): code cleanup.
...
Both callers ignore the return code of this function, so get rid of it,
but make sure that the client is disconnected on errors.
2008-05-26 23:38:32 +02:00
d360871394
Conn_Handler(): cleanup code, add/translate comments.
...
In addition, the "timeout" variable has been removed because it is
unnecessary today: Handle_Buffer() handles all the data it can handle,
and io_dispatch() returns immediately when new data is available. So
we don't have to double-check but better sleep. Pointed out by Florian.
2008-05-26 21:38:27 +02:00
b90f71ca2a
Use strtok_r instead of strchr in IRC_JOIN.
...
This patch does significant cleanup on the join code by using strtok_r
instead of mangling strchr to parse channel names and keys in parallel when
a JOIN command contains a list of channels and keys.
Also adds an strtok_r implementation to libportab.
2008-05-26 21:20:03 +02:00
956bbe2c28
Reset client idle time on NICK, JOIN, and PART
2008-05-24 21:50:54 +02:00
e19f7a8c19
Remove ListenIPv4/ListenIPv6 options.
...
Use "Listen = list,of,addresses" instead.
2008-05-19 14:34:48 +02:00
4ed2cb1a02
make Listen parameter a comma-seperated list of addresses.
...
this also obsoletes ListenIPv4 and ListenIPv6 options.
If Listen is unset, it is treated as Listen="::,0.0.0.0".
Note: ListenIPv4 and ListenIPv6 options are still recognized,
but ngircd will print a warning if they are used in the config file.
Also, some plattforms require that ai_socktype
is set in the getaddrinfo() hints structure.
2008-05-19 14:27:35 +02:00
818a206a42
Add option aliases -V (for --version) and -h (for --help).
...
This patch adds -h and -V short options (to complement the usage).
It is based on a patch attached to Debian bug #466063 , see
<http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=466063 >.
Idea by Jari Aalto <jari.aalto@cante.net>,
patch adapted by Alexander Barton <alex@barton.de>.
2008-05-18 16:19:41 +02:00
5d87f6ba80
Add tests for MOTD, VERSION, TIME, USERHOST
...
The misc-test.e file is also somewhat reorganized and commented here.
Patch from Brandon Beresini, Bryan Caldwell and Dana Dahlstrom.
2008-05-15 11:13:45 +02:00
d02b083543
Merge commit 'aad49bd260494878aed6795c7a897ad1d28c3082'
2008-05-13 12:14:14 +02:00
70254a5553
This patch implements a (maybe) compliant WHOWAS command.
...
It is hard to test this in the test suite because we 1) shouldn't rely on
previous tests populating WHOWAS and 2) don't connect a user for more than 30
seconds.
Also makes WHOWAS return ERR_NONICKNAMEGIVEN_MSG as implied by RFC.
2008-05-12 18:56:31 +02:00
b1d38de4d2
If bind() fails, also print ip address and not just the port number.
2008-05-12 18:46:55 +02:00
d90cc7add0
GIT: ignore symbolic links to tests in testsuite directory
...
Added symbolic links to new tests (invite-test, join-test, and kick-test)
to .gitignore file.
2008-05-11 15:20:46 +02:00
149859c5fe
Fixes to who-test: accept "localhost.<domain>" as well as "localhost"
...
Some operating systems, for example OpenBSD, use "localhost.<domain>"
instead of "localhost", so the "who-test" expecting "localhost" failed
on such systems.
2008-05-11 15:17:22 +02:00
d9c26f3aeb
ng_ipaddr.h must include netinet/in.h.
...
compile on FreeBSD 5.4 failed with:
./../ipaddr/ng_ipaddr.h:34: error: field `sin4' has incomplete type
Reported and tested by Jefferson S Almeida.
2008-05-10 21:49:51 +02:00
0510bbe958
Removed space after # so that Cygwin's version of expect recognizes comments.
2008-05-09 21:54:47 +02:00
12cd554af1
Fix secret channel information leak
...
/who on a secret channel that the user is not a member of
now returns proper RPL_ENDOFWHO_MSG instead of nothing.
2008-05-09 21:47:31 +02:00
5cf5ba31eb
Added Cygwin uid kludge. (verified working)
2008-05-08 13:04:25 +02:00
75b719a0c8
Anglified and improved comments in channel.c and channel.h
...
[Dana Dahlstrom: repair tab/space conversion in patch]
2008-05-08 03:15:04 +02:00
4e56e5341f
Implement IRC commands SERVICE, SERVLIST, and SQUERY as dummy functions
...
SERVICE, SERVLIST, and SQUERY are required by RFC 2812 (it states in
section 3 that "all commands described in this section MUST be implemented
by any server for this protocol." -- So we implement them without (much)
actual functionality ...
2008-05-05 18:06:43 +02:00
3895b42d1b
Add invite-test.e to test suite.
2008-05-05 16:12:41 +02:00
6c81ffaece
Tests for the INVITE command.
2008-05-05 16:12:41 +02:00
97cc58fb13
Invite: prefix last argument with colon when necessary.
2008-05-05 16:12:41 +02:00
c63d8fd051
tests for JOIN and various replies
...
Brandon Beresini sent me a patch yesterday adding tests for JOIN under
various circumstances, which I believe he worked on with Bryan Caldwell
and Ali Shemiran. I made a few modifications; the result is below.
2008-05-05 16:12:41 +02:00
3d8eda9c86
Allow KICK to handle comma-delimited lists (of channels, nicks).
...
includes test cases.
[fw@strlen.de:
- move code around to avoid duplication
- use const where possible
- integrate test case]
2008-05-05 16:12:41 +02:00
3283d275ba
Invite: Send RPL_AWAY to client sending the invite if target is away.
2008-05-05 15:52:41 +02:00
faf9b6ea16
Fixes to who-test: accept any ident, escape some '*' flags.
...
This prevents who-test.e from failing when ngircd
is performing ident lookups and an ident server is running.
2008-05-05 15:40:00 +02:00
452fb28394
IRC_INVITE: coding style cleanup.
2008-05-05 15:39:54 +02:00
0428a1c4ea
Constify some of Channel_Kick()s arguments.
2008-05-05 15:38:47 +02:00
98a8ea105c
constify Client_Search() argument.
2008-05-05 15:38:43 +02:00
83bfdddf99
Allow IRC ops to ignore channel limits when joining
...
Allow IRC ops to ignore any channel limit (bans, invite only etc.) when they
want to join a channel.
2008-05-05 14:45:28 +02:00
2a790861a1
Handle 1-character messages terminated with CR or LF correctly
...
Code cleanup and fix for Bug #83 , "ngIRCd chokes on 1-character messages" in
function Handle_Buffer(): the buffer is now correctly cleared when ngIRCd
receives 1-character messages terminated with either CR or LF (in violation
to RFC 2812, section 2.3 "Messages", 5th paragraph).
2008-05-02 02:14:15 +02:00
4e507881f3
On AIX (for example) socklen_t is defined in sys/socket.h
...
On AIX and probably other systems socklen_t is defined in sys/socket.h,
so we have to include it here explicitly (tested by Florian).
2008-05-01 20:25:39 +02:00
f7c2e8223f
Always enable modeless channels.
...
Modeless channels (+channels) are described in RFC 2811;
so my modifications to
530112b114
2008-05-01 18:08:07 +02:00
60acc62af7
Prevent GIT to complain about opless-channel-test link
2008-05-01 16:31:13 +02:00
530112b114
Add support for modeless channels
...
Add support for modeless channels (+channels).
[fw@strlen.de:
- integrate test cases
- don't support +channels when compiled with --strict-rfc
- do not set +o mode for channel creator
- force +nt mode when channel is created ]
2008-05-01 15:55:12 +02:00
4a81367dac
--configtest: fix missing whitespace at "ConnectIPv4" option.
2008-04-29 15:27:44 +02:00
bb6ee46892
Merge branch 'master' of git://git.breakpoint.cc/fw/ngircd-fw
2008-04-29 15:15:28 +02:00
9194319399
Testsuite: remove erroneous ConfUID setting in config file.
...
The config file for ngircds test suite contained obsolete
ConfUID/ConfGID settings, causing ngircd to needlesly complain when
started as non-root (which is hopefully the _normal_ case...)
2008-04-29 13:32:29 +02:00
33b1204349
Get rid of cvs-version.* and CVSDATE definition.
...
(cherry picked from commit b187fac244f4e14705f882ba7c43eef0238e2830)
2008-04-25 00:14:11 +02:00
523a6fad09
Report ERR_NOTONCHANNEL when trying to part a channel one is not member of.
...
When trying to part a channel ("PART #channel") the client is not member of
the daemon now correctly reports the numeric ERR_NOTONCHANNEL (442) insted
of ERR_NOSUCHCHANNEL (403).
2008-04-24 23:52:54 +02:00
54b17fc201
Channel_Part(): Code and comment cleanup.
2008-04-24 23:47:33 +02:00
25f48a2a34
IRC_PART(): code and comment cleanup.
2008-04-24 23:46:59 +02:00
22fa782be7
IPv6: Add config options to disabe ipv4/ipv6 support.
...
This also enables ipv6-only setups.
2008-04-21 00:45:19 +02:00
a0efcdccfa
Updated copyright notice to read "2001-2008".
2008-04-20 15:48:22 +02:00
8df445316a
Channel_Mode: Remove duplicate code.
...
Incidentially, this doesn't even change the
generated code...
2008-04-19 16:58:00 +02:00
11af32466f
Channel_Mode: change order of if (set) and if (client) check.
2008-04-19 16:51:42 +02:00
5538115537
Channel_Mode: Re-indent switch.
...
No functional changes were made.
2008-04-19 16:45:31 +02:00
b8643477ba
Channel_Mode: check return type of Invite/Ban Add/Del function
2008-04-19 16:17:11 +02:00
796dcf6a62
Channel_Mode: unify 'b' and 'I' switch/case handling.
2008-04-19 14:16:17 +02:00
6b0c094809
Channel_Mode: Unify Del_Invite and Del_Ban handler
2008-04-19 14:12:06 +02:00
b36fc3b095
Constify Lists_MakeMask argument and return type.
2008-04-19 14:11:25 +02:00
2dd51a98e4
Channel_Mode: Unify Add_Invite and Add_Ban handler
2008-04-19 14:02:54 +02:00
7b33424c13
Added "portabtest" binary to .gitignore file in src/portabtest/.
2008-04-09 19:46:26 +02:00
bc63064d5c
Moved .cvsignore files to .gitignore
...
Since we are using GIT starting from now, I converted all the
.cvsignore files to .gitignore files.
2008-04-09 18:54:52 +02:00
be844d74d3
Fix client.c sparse warnings.
...
client.c:72:6: warning: symbol 'Max_Users' was not declared. Should it be static?
client.c:72:21: warning: symbol 'My_Max_Users' was not declared. Should it be static?
2008-04-04 23:22:06 +02:00
637d739285
io.c: kill select FD_SETSIZE sanity check in io_library_init.
...
We already have way too many.
2008-04-03 23:20:26 +02:00
66e68de16a
io.c: fix select FD_SETSIZE check when using epoll as io backend
2008-04-03 23:20:22 +02:00
7f44a2ad1c
io.c: try to cut down the number of ifdefs.
...
consolidate backend-specific helpers and
add empty statinc inle stubs in the ifndef case
to let the compiler remove the functions at compile time.
2008-03-27 16:53:39 +01:00
abb1abeb77
Do not exit unconditionally if config file cannot be opened
...
ngircd will exit if the config file cannot be opened. While
thats okay if ngircd starts up for the first time, it isn't
when we are re-reading the config file after a /REHASH or SIGHUP.
2008-03-26 21:31:13 +01:00
ab1f48a346
Fix #include's: search log.h locally, include string.h. The latter is required because we include conn.h, which includes resolve.h, which includes ng_ipaddr.h, which contains a macro using strlcpy() ...
2008-03-11 15:42:58 +01:00
feb31e4200
IPv6 support.
...
all references to struct sockaddr/in_addr have been
removed from src/ngircd.
libngipaddr (in src/ipaddr/) hides all the gory details.
See src/ipaddr/ng_ipaddr.h for API description.
2008-02-26 23:50:35 +01:00
44cdf1b1ca
Fix sending of JOINs between servers.
...
This does hit only operators that join a channel with at least 2 servers active in the net
the server the oper connects to sends "channel^Go" to the other servers
the other server first searches for the channel and then strips the modes from the channel name
he has to do the other way round: first strip and then check the channel name.
2008-02-26 23:49:33 +01:00
e710e8ae37
Channel_Mode cleanups
...
- better indentation
- move answering request into seperate function.
2008-02-26 23:49:33 +01:00
5147b675cb
Removed the SQUIT test for now, actually we don't support it yet.
2008-02-26 23:49:33 +01:00
ddecfcd831
Implemented IRC commands INFO, USERS (dummy), and SUMMON (dummy).
2008-02-26 23:49:33 +01:00
2f71fbb2a1
Include flags in RPL_WHOREPLY messages.
...
RPL_WHOREPLY messages generated by IRC_WHO don't include flags (*,@,+)
that should appear according to this description:
http://www.mishscript.de/reference/rawhelp3.htm#raw352
Other IRC servers do include the flags.
Modify who-test.e to expose missing flags,
modify ngircd-test.conf to accommodate who-test.e, and fix
irc-info.c to correct these problems.
2008-02-26 23:49:33 +01:00
1784180bf3
Don't send trailing space in MODE messages
...
Under some circumstances ngIRCd currently issues a channel MODE message
with a trailing space after the last parameter, which isn't permitted by
the grammar in RFC 2812 section 2.3.1:
http://tools.ietf.org/html/rfc2812#section-2.3.1
The following patch modifies mode-test.e to expose this, and modifies
irc-mode.c to correct it.
2008-02-26 23:49:33 +01:00
634ef8c131
IRC_JOIN cleanups.
...
- put sending of mode and forwarding of JOIN to other clients
into seperate function.
- put sending of topic/channel names into seperate function.
- put access check into seperate function.
- translate/remove remaining german comments.
- stop if JOIN to a channel in a list (JOIN #a,#,b,#c...) fails
(This doesn't change the behaviour: skip-to-next-channel-on-error
did never work as intended)
2008-02-26 23:49:33 +01:00
4d152b771e
Make IRC_WHO also search username/servername/hostname.
...
Dana Dahlstrom reported that IRC_WHO did not follow
RFC 2812, Section 3.6.1. Specifically:
- IRC_WHO did not send "G" flag instead if "H" if client was away
- did not search username/servername/hostname etc. if argument
was not a channel.
Fix all of the above and tidy things up a bit.
Also add IRC_WHO test script contributed by Dana.
2008-02-26 23:49:33 +01:00
c634303765
Remove duplicate Channel_FirstChannelOf().
...
noticed there's a way to make the loop
slightly more elegant.
[fw@strlen.de: Extra () to silence gcc.]
2008-02-26 23:49:33 +01:00
cb0d594e61
Make Channel_Part name and reason parameters 'const'.
2008-02-26 23:49:33 +01:00
6bd35bf090
Implement RFC 2812 handling of "0" argument to JOIN
...
The students in my software-engineering class are writing IRC clients in
Java, and I'm running ngIRCd as a sandbox for them to play in. We
noticed ngIRCd doesn't obey the "JOIN 0" command specified in RFC 2812:
JOIN 0 ; Leave all currently joined
channels.
http://tools.ietf.org/html/rfc2812#section-3.2.1
I believe the following patch addresses this. Cheers!
[fw@strlen.de: put it into a seperate function]
2008-02-26 23:49:33 +01:00
3022d7cff3
Don't use Client_Type after command has been processed.
...
This caused a read from already free'd memory, if the processed
command (IRC_QUIT) calls Client_Destroy.
2008-02-26 23:49:33 +01:00
42db159d26
Fix wrong strncpy usage if CVSDATE defined
...
Hello_User() used strncpy with overlapping src/dest.
Use memmove instead.
2008-02-26 23:49:33 +01:00
59b19ea6a3
This adds support for sending NOTICEs to a channel.
...
[also see Bug #70 in ngircd bugzilla].
Based on a patch by Fabian Schlager <fabian.schlager@gmail.com>.
2008-02-26 23:49:33 +01:00
4add9c29ed
[Parser]: Fix minor sparse warnings
...
parse.c:56:9: warning: symbol 'My_Commands' was not declared. Should it be static?
parse.c:107:9: warning: symbol 'My_Numerics' was not declared. Should it be static?
Also move handling of numerics into a seperate helper function.
2008-01-13 16:12:49 +00:00
463c5cb7c5
IRC_PART could reference invalid memory.
2008-01-07 11:42:00 +00:00
61e6b5c0aa
[Resolver]: Use dotted-decimal IP address if hostname is >= 64
2008-01-02 11:03:29 +00:00
91a6fffaa0
io_event_disable: return if event-to-disable is already off
2008-01-02 10:29:51 +00:00
2ce5b734bd
kqueue: check for EV_ERROR in .flags
...
if kevent() returns events, check for EV_ERROR in event flags, too.
2007-12-27 18:25:26 +00:00
f99f9a8f02
Fix format arg: ListenAddress was printed instead of Bind address.
2007-12-13 01:30:16 +00:00
4715ccf9ca
Fix format string in error path: didn't print strerror(errno)
2007-12-13 01:05:01 +00:00
8974e90552
implement '/STAT u' (uptime)
2007-12-11 11:29:43 +00:00
2fe13f0a45
Fix fmt string: int, not long
2007-12-07 21:19:01 +00:00
20ce56cc5b
include <arpa/inet.h> inside tool.h
...
In file included from hash.c:24:
../tool/tool.h:27: warning: `struct in_addr' declared inside parameter list
2007-11-25 18:42:37 +00:00
47a0379e2b
remove ip-string from Conf_Server struct
...
struct Conf_Server stored the ip address to connect to
in dotted-decimal notation; but we only need this for connect()
so long-time storage isn't necessary.
2007-11-23 16:28:37 +00:00
82d32ffb28
bind ListenAddress for outgoing connections
...
ngircd would always use INADDR_ANY for outgoing connections;
which might not be desirable. Added new [Server] option
"Bind" to set source ip.
2007-11-23 16:26:03 +00:00
024588dbe7
Funktions to handle numerics sent to the server.
2007-11-21 12:20:32 +00:00
47ca178a21
Introduce option to configure the maximum nick name lenth in ngircd.conf
...
- New configuration option "MaxNickLength" to specify the allowed maximum
length of user nick names. Note: must be unique in an IRC network!
- Enhanced the IRC+ protocol to support an enhanced "server handshake" and
enable server to recognice numeric 005 (ISUPPORT) and 376 (ENDOFMOTD).
See doc/Protocol.txt for details.
2007-11-21 12:16:33 +00:00
53b98fd7e9
Fixes the wrong logging output when nested servers are introduced
...
to the network as well as the wrong output of the LINKS command.
2007-11-20 20:02:40 +00:00
68f896eee0
Adjust test suite to be usable on HP/UX 11.11 :-)
2007-11-18 15:07:16 +00:00
06bfb3adfb
Fix code to compile using K&R C compiler and ansi2kr again.
2007-11-18 15:05:35 +00:00
ad7361dfe0
if ngircd doesn't run chrooted, it tries to chdir
...
to the users working directory (as returned by getpwuid()).
Failing to chdir to that directory isn't an error; so
log with LOG_INFO and prefix the message with "Notice".
2007-11-15 01:03:01 +00:00
001c00b273
New config option NoDNS: disables all DNS queries.
2007-10-25 11:01:19 +00:00
b861f536b2
configtest would still print "-1" for MaxConnections, MaxConnectionsIP and MaxJoins
...
if any of those values was set to 0.
2007-10-24 00:48:41 +00:00
8f162f4e17
Fixed propagation of channel mode 'P' on server links.
2007-10-14 12:08:57 +00:00
d223b587e4
accoring to comments in the code, MaxConnections, MaxConnectionsIP and MaxJoins
...
options allow setting values < 0 -- this isn't the case. Comments adjusted.
2007-10-13 19:11:06 +00:00
d4ed056147
Numeric 317: implemented "signon time" (displayed in WHOIS result).
2007-10-04 15:03:55 +00:00
4b9e52eb4d
implement /WALLOPS as described in RFC 2812, section 4.7.
2007-08-02 10:14:26 +00:00
69081851ac
SECURITY: Fixed a severe bug in handling JOIN commands, which could
...
cause the server to crash. Thanks to Sebastian Vesper, <net@veoson.net>.
2007-07-31 18:56:13 +00:00
efcca62a35
last fix accidentially broke reconnect timer.
2007-07-21 18:46:28 +00:00
cd65e0a56e
Don't connect to a server if a connection to another server within the same group
...
is in progress.
2007-06-28 15:13:38 +00:00
2275add327
Add new server config option to disable automatic connect. (Tassilo Schweyer)
2007-06-28 05:15:12 +00:00
5675be4cd9
fix compile /w gcc 2.95 (reported by Tassilo Schweyer)
2007-06-11 20:06:46 +00:00
255edf7eab
Reworked read and write buffer handling, introduced WRITEBUFFER_SLINK_LEN.
2007-05-17 23:34:24 +00:00
5930a29197
Zip_Flush(): close the connection in all error cases.
2007-05-17 15:16:47 +00:00
07d8da60de
array_start() cannot legally return NULL if array_length() > 0 --> use assert().
2007-05-17 14:46:14 +00:00
44afe042d1
Make Zip_Flush() more graceful.
2007-05-17 13:49:49 +00:00
a073bc89c4
there is no need to treat servers differently than clients on the read side.
2007-05-17 12:39:25 +00:00
63e89ceb21
make needlesly global function Conn_Write static.
2007-05-09 13:21:11 +00:00
09416f36bf
remove ZBUFFER constants and increase max buffer size of server links
2007-05-09 08:55:14 +00:00
508b55126f
fix compressed server links
2007-05-02 12:34:30 +00:00
9f65979979
2007 :-)
2007-04-09 01:24:05 +00:00
09deb857ce
- change return type of Conn_InitListeners to unsigned
...
- remove minor whitespace damage
2007-04-04 21:52:12 +00:00
8c14d397ba
put parentheses around argument
2007-04-03 22:08:10 +00:00
99eab1e216
if we can't bind a socket we now Log the port number, too.
2007-02-21 11:06:06 +00:00
c93d089736
return false instead of NULL in error path
2007-01-29 21:13:26 +00:00
429f85b77a
Remove Client_DestroyNow() to keep semantik "every CONNECTON has a CLIENT".
2007-01-23 16:07:19 +00:00
ea2a4b3370
fix broken IO_DEBUG build
2007-01-19 13:52:54 +00:00
f9b9850662
io_event_add: return if eventtype is already registered.
2007-01-18 00:25:26 +00:00
1b852fce72
add support for predefined-channel configuration of k and l modes
2006-12-29 14:09:48 +00:00
43f8d149bb
added "portabtest" binary to list of files to ignore.
2006-12-28 13:34:43 +00:00
949a4ef793
Added .cvsignore files to hide generated files from CVS.
2006-12-28 13:20:07 +00:00
f74781647a
array_free(): enable debug code only when DEBUG_ARRAY is #define'd.
2006-12-28 12:53:41 +00:00
5c78230283
New configure option "--without-select"; when usin epoll() IO API include
...
support for select() as well by default and fall back on runtime when needed.
2006-12-26 16:00:45 +00:00
262d945284
Fixed typo in #ifdef which tests if this header is already included or not.
2006-12-25 22:53:52 +00:00
4243cae985
register io handler before creating new local client structure
2006-12-25 01:11:12 +00:00
40226d26b2
revert to last good revision again 8-/
2006-12-17 23:04:45 +00:00
d2f7d3087d
do not call Conn_Close when io_event_create fails
2006-12-17 22:55:07 +00:00
3f1e03edd9
fix possibe buffer-off-by one
2006-12-17 22:52:43 +00:00
23e7f7f0dd
don't call Resolve_Shutdown() when io_event_create fails
2006-12-17 22:50:51 +00:00
8cb0e3af68
removed errouneous FD_SETSIZE limit when not using select()
2006-12-16 22:48:34 +00:00
5040d56489
minor cleanup
2006-12-07 22:24:14 +00:00
fb0fbe908d
remove unused function Channel_PCount
2006-12-07 22:23:39 +00:00
fa7bb2790a
moved invite/ban lists to channel structure
2006-12-07 17:57:20 +00:00
5877bca4bc
fix RPL_LOCALUSERS_MSG (%ld -> %lu)
2006-12-02 14:24:36 +00:00
37602d1523
Log(LOG_DEBUG, .. -> LogDebug()
2006-12-02 14:10:48 +00:00
a09034563a
predefined channels MUST start with '#', but this is not very intuitive,
...
since # is also used as a comment character in ngircd.conf. Thus
we prefix the name with '#' if it is missing.
2006-11-20 19:32:07 +00:00
5b35b101f2
Fixed validation of server names containing digits.
2006-11-10 10:05:00 +00:00
058d3085a9
New configuration option "PredefChannelsOnly": if set, make
...
all JOINs to-non existants channel return ERR_BANNEDFROMCHAN_MSG,
restricting users to those channels defined in the config file.
2006-11-05 13:03:46 +00:00
018e351630
-Whitespace Damage; Client_OperCount(), Client_UnknownCount(), Client_MyServerCount() return unsigned long
2006-10-07 10:40:52 +00:00
6e105bf87e
channel maxusers now unsigned long
2006-10-06 21:32:58 +00:00
61966a6088
add const qualifier to Hash() and Matche() Arguments
2006-10-06 21:23:47 +00:00
27c96632f1
Client_IsValidNick: no need to strcpy.
2006-10-06 19:57:56 +00:00
4108e16be6
Channel_Join was severely broken.
2006-10-05 18:26:54 +00:00
4e02bdc322
Update info text of local server after re-reading configuration.
2006-10-03 10:59:40 +00:00
ca5e09865e
Removed an unused variable -- but where did it come from!? Strange ...
2006-10-03 10:28:38 +00:00
d8950c5dd0
cleaned up Channel_IsValidName (now uses strcspn())
2006-10-02 21:55:49 +00:00
257312b102
Changed Numerics 265 and 266 to follow ircd 2.11.x "standards".
2006-10-01 19:13:32 +00:00
27d947fb7d
Allow PASS syntax defined in RFC 1459 for server links, too.
...
Removed client status CLIENT_GOTPASSSERVER.
2006-10-01 19:05:00 +00:00
bed98979dc
Enhanced ISUPPORT message (numeric 005).
2006-10-01 19:03:05 +00:00
4c6c6ecf0e
array_get: no need to multiply again. remove unneeded checks. remove array_free_wipe().
2006-09-30 21:49:46 +00:00
a2f5a05ff8
io_close_poll()s closing brace mysteriously disappeared... fixed.
2006-09-19 18:21:30 +00:00
639eb40035
Added support for the /dev/poll i/o interface.
2006-09-17 10:41:06 +00:00
0d6f9d4e3e
simplify io_library_init*
2006-09-16 16:47:27 +00:00
147de9dfa9
add support for the poll() interface
2006-09-16 15:00:09 +00:00
f6e729443e
cleanup
2006-09-16 14:49:26 +00:00
e426c131c7
fix embarassing fileptr leak
2006-09-16 12:22:09 +00:00
e2aacff7d4
s/Log(LOG_DEBUG/LogDebug(/ , translated comments, etc.
2006-08-12 11:58:21 +00:00
0eccdbc137
-whitespace damage
2006-08-12 11:56:24 +00:00
939ee6a39b
simplify Resolve_Read().
2006-08-12 11:54:23 +00:00
83caef4598
if compiling without -DDEBUG, make LogDebug 'static inline' so gcc optimizes it away.
2006-08-05 09:16:21 +00:00
6eb3f3055d
Added support for Solaris 11.
2006-08-05 00:15:28 +00:00
47026e14ce
Don't assert() when a pre-defined channel has no topic.
2006-07-24 22:54:09 +00:00
63626449f8
Flag the format parameter of LogDebug() as "unused" when not compiling with
...
debug code to avoid gcc warnings. Added some documentation comments.
2006-07-23 23:23:45 +00:00
184eb1c54b
Removed unused variable "ret" when using the select() API.
2006-07-23 23:11:44 +00:00
5ce6bf28d1
Removed (theoretically) division by zero; reformated some code.
2006-07-23 23:05:20 +00:00
f1f94f07e1
Validate "ServerName" variable.
2006-07-23 16:42:45 +00:00
3e8978d836
Allow DIE to send a message to all locally connected clients. Closes bug #48 .
2006-07-23 15:43:18 +00:00
9a2d4eef44
"Enhanced" debug message for Handle_Write(), only print when data in buffer.
2006-07-23 15:22:56 +00:00
0d5fc770d3
Output some debug messages only if DEBUG_ZIP is #define'd.
2006-07-23 15:19:20 +00:00
5590f8624b
Don't include conn.h, conn-func.h is enough.
2006-07-23 14:55:40 +00:00
47e581e453
Updated copyright notice ;-)
2006-07-23 12:07:33 +00:00
3833f8aae3
remove fd from io_event structure
2006-07-12 19:27:12 +00:00
161340d486
ALIGN_XXX( v ) macros now leave v alone if it was already aligned.
2006-07-01 22:11:48 +00:00
e9e1fa459b
Sorted channel modes alphabetically.
2006-06-15 20:28:15 +00:00
00ab67dcdb
The third parameter of bind() is of type "socklen_t", not "int".
2006-05-12 11:53:04 +00:00
dd3a3bc603
Use some more specific data types (e. g. pid_t vs. int), make "SPLint" happy :-)
2006-05-10 21:24:01 +00:00
0a3f562f36
make splint complain less...
2006-05-10 17:33:36 +00:00
9dfd42a7e6
disabled most (rather annoying) debug messages using DEBUG_ARRAY / DEBUG_IO defines
2006-05-09 17:02:40 +00:00
2af87e9152
Handle time shifts backwards gracefully.
2006-05-09 14:49:08 +00:00
185004cb30
kqueue support was completely broken; seemed to work on FreeBSD just because of sheer luck.
2006-05-07 10:54:42 +00:00
4a2eea2939
minor cleanup, removed unneeded check in safemult_sizet
2006-05-07 10:52:47 +00:00
6d3686e73d
Send invite and ban lists only once and not repeatedly for every channel.
2006-04-30 21:31:43 +00:00
5d0ba011c7
Fix Connection Pool resizing.
2006-04-29 16:19:46 +00:00
87f4b1c6f6
Client_GetFromConn() removed and replaced with new function Conn_GetClient()
2006-04-23 10:37:27 +00:00
8067bab106
changes some comments, minor cleanup
2006-04-23 10:33:37 +00:00
097c7bd741
Fix up ngt_TrimStr() once more ... :-/
2006-04-09 12:53:07 +00:00
bebfbedf3f
fix ngt_TrimStr(), fix format string
2006-03-24 23:25:38 +00:00
cba9270845
ngt_TrimStr(): code cleanup.
2006-03-22 08:05:10 +00:00
2a9ffe7037
use strlcat return value; don't call time() repeatedly.
2006-03-18 22:27:09 +00:00
4000e01b28
corrected return value
2006-03-16 20:14:16 +00:00
68d3d36dd6
removed silly if (foo) { if (foo){ }} statement
2006-03-16 19:56:34 +00:00
eedfc35bbc
s/gehoert//
2006-03-11 10:43:49 +00:00
d39d3ec4b9
Client_RegisterWhowas(): call time() only once
2006-03-11 10:33:30 +00:00
79dfd60a0c
Don't use "awk" directly, instead use $(AWK) variable.
2006-03-11 01:48:50 +00:00
29ad5e0d94
Moved now local prototype of Client_New() to C file, renamed it to
...
Init_New_Client() and cleaned up some code and comments.
2006-03-11 01:37:31 +00:00
7e8ac0afcf
Client_New() not used outside client.c -> static
2006-03-10 20:25:29 +00:00
93df629b69
changed connection structure to array-api
2006-02-16 19:21:57 +00:00
66060dbce9
new Function: LogDebug()
2006-02-08 17:33:28 +00:00
0701afedee
removed Resolve_SUCCESS() Macro and Res_Stat->sucess boolean (no longer used/needed)
2006-02-08 15:24:10 +00:00
a17745d6d7
Make connid same as connection fd.
2006-02-08 15:20:21 +00:00
1249acfdba
removed obsolete "int Conn_MaxFD"
2006-02-02 21:00:21 +00:00
c8fb6a2258
simplify IRC_Show_MOTD()
2006-01-27 17:19:58 +00:00
fb9707de98
Added test if the stress-test expect script itself completes without errors.
2005-12-30 22:13:21 +00:00
db9afbbf0e
Modified expect script to work with servers having IDENT support.
2005-12-30 22:12:28 +00:00
4b2f966b7e
Fix Bugzilla #64 -- ngicrd did not reconnect to other servers after failed forward dns lookup.
2005-12-09 09:26:55 +00:00
0570e13cac
Minor whitespace fixes.
2005-11-21 16:31:30 +00:00
6b21249151
Remove direct call of Conf_UnsetServer(): it's already indirectly called
...
by Conn_Close() a few lines above.
2005-11-21 15:06:37 +00:00
bc09a3e487
Changed Handle_Write() to not close sockets itself but to call Conn_Close.
2005-10-11 19:29:23 +00:00
ff218617db
gcc 4: "warning: declaration of 'dup' shadows a global declaration".
2005-09-24 17:06:54 +00:00
b65358b17c
avoid 2nd time() call in Check_Servers(), improve comments
2005-09-24 02:48:46 +00:00
e9f3e69f36
use io_close instead of plain close in Conn_ExitListeners()
2005-09-24 02:20:00 +00:00
5b2364b236
merge new resolver code
2005-09-12 19:10:20 +00:00
4db29b0076
Minimal changes (needed for merging resolver changes)
2005-09-11 11:42:48 +00:00
0aae3ec5d7
Mostly formatting; changes needed for SSL merge
2005-09-10 23:42:12 +00:00
468a1c7767
Handle_Write(): Report write attempts on closed sockets when in debug mode.
2005-09-05 09:10:08 +00:00
ab3ac4e466
Removed obsolete debug message.
2005-09-05 08:11:11 +00:00
4d18ac83a2
Set one second penalty on unknown commands.
2005-09-04 23:42:24 +00:00
660b529c10
Add debug code to Conn_SetPenalty().
2005-09-04 23:38:32 +00:00
565129f992
io_close(): explicitly remove fd from epoll set
2005-09-04 13:38:59 +00:00
fc4cd39202
Wait for DNS reverse lookup (and ident request) before writing results to pipe.
2005-09-03 11:17:16 +00:00
6444442931
fix fd leak (happens on failure of fork() ).
2005-09-02 21:47:30 +00:00
e899c75d7e
Updated copyright notice.
2005-09-02 17:12:58 +00:00
cae9a3aee5
small formatting change
2005-09-02 17:01:23 +00:00
e708790566
JOIN now supports more than one channel key at a time.
2005-09-02 15:46:49 +00:00
dd3d2e2c39
Complain if MyPassword starts with ':'. (Reported by Ben Korvemaker)
2005-09-02 13:58:52 +00:00
9275dc4dc4
reformatted Handle_SERVER()
2005-09-02 13:50:52 +00:00
af9123fd82
Cleaned up some code, comments and log/debug messages.
2005-09-02 13:28:30 +00:00
ca32c1b311
Implementec numeric "333": Time and user name who set a channel topic.
2005-09-02 12:50:25 +00:00
a5b5a6a99a
Make PONG handler compatible with ngIRCd <= 0.9 ("make it more relaxed").
2005-09-01 10:51:24 +00:00
c65343e719
reformatted a few lines.
2005-08-30 22:08:00 +00:00
30c11b2313
use size_t for array length variables
2005-08-30 13:38:16 +00:00
b7033e1478
use size_t instead of unsigned int.
2005-08-30 13:36:32 +00:00
db992975eb
last cleanup accidentally broke kqueue backend.
2005-08-29 13:58:54 +00:00
c12dc45f17
Added prefix to connection statistic NOTICE.
2005-08-29 11:11:15 +00:00
a2e4eb5aaf
Fixed server NOTICEs to users with "s" mode ("server messages").
2005-08-29 10:58:00 +00:00
58b8fb5d12
remove unneeded variable "bool action"
2005-08-28 16:51:20 +00:00
8efeae1714
fix embarassing cut&paste error
2005-08-28 12:18:50 +00:00
21ad5dcfff
array_cat0_temporary(): removed confusing DEBUG messages
2005-08-28 11:47:02 +00:00
4074fd9149
Enhanced the handler for PING and PONG commands: fix forwarding and enable
...
back-passing of a client supplied additional argument of PING.
2005-08-28 11:40:13 +00:00
2f105b1c0a
if the request is empty, remove \r\n (or single \n or \r) from receive buffer.
2005-08-28 00:19:29 +00:00
a2cdc08c39
fix handling of empty requests
2005-08-27 23:42:23 +00:00
e728bd2e1a
Changed handling of timeouts for unregistered connections: don't reset
...
the counter if data is received and disconnect clients earlier.
2005-08-27 23:33:10 +00:00
12e288c062
removed misleading const qualifier
2005-08-27 23:23:54 +00:00
f36337fab3
fix kevent() warning on powerpc-apple-darwin8-gcc-4.0.0
2005-08-27 20:27:07 +00:00
1a46b37bd5
remove unneeded call io_event_kqueue_commit_cache()
2005-08-27 20:25:54 +00:00
6434d0b23e
return PING argument in PONG reply if STRICT_RFC is not defined.
2005-08-27 18:39:56 +00:00
ac96fe5877
Changed log level of "Initialization failed" message from ERR to ALERT.
2005-08-25 08:48:43 +00:00
a6d1d26a43
Fixed line lengths ...
2005-08-25 08:40:15 +00:00
c2f5399b51
Fixed format string bug in "connection statistics" message; code cleanups.
2005-08-15 23:02:40 +00:00
ae6e6616a6
Made test script run a longer time.
2005-08-12 21:38:52 +00:00
a5915f75c9
Set timeout.
2005-08-12 21:35:12 +00:00
f2ba8abec5
Detect source directory correctly.
2005-08-12 21:34:19 +00:00
b15d906dff
The KILL command killed much more than desired (including server links!)
...
when the target user is connected to a remote server. [from 0.9.x]
2005-08-02 23:19:21 +00:00
1c14e2e0a2
Removed some line feeds in debug statements.
2005-08-02 22:48:57 +00:00
77f54693ef
Removed unnecessary #define of "LOCAL", now use plain C "static" instead.
2005-07-31 20:13:07 +00:00
b61407713d
Removed "U" unsignet suffix: caused problems with older compilers and is
...
not necessary for this constants.
2005-07-30 22:53:16 +00:00
51ccb5928a
internal changes needed for future ssl support
2005-07-29 09:29:47 +00:00
84706af7fe
topic no longer limited to 127 chars (now only limited by protocol)
2005-07-28 16:23:55 +00:00
46a191caf6
changed RES_STAT buffer to array
2005-07-28 16:13:09 +00:00
20ff63a8a1
add array_cat0_temporary() and array_init()
2005-07-28 16:12:50 +00:00
2e794a6943
Reverse lookup now checks result by additional forward lookup
2005-07-25 09:20:10 +00:00
6ecccd2644
add reverse lookup check
2005-07-24 21:42:00 +00:00
74cb2e2768
Eliminate some compiler warnings ("unused parameter").
2005-07-22 21:31:05 +00:00
68dc35b548
Removed "srcdoc" target for src/ tree (now in doc/ subdirectory).
2005-07-22 21:01:03 +00:00
987559e46d
change Handle_OPERATOR() formatting
2005-07-17 18:58:04 +00:00
fca29bfa23
prevent io_masterfd leak when library_init() is called twice
2005-07-14 14:35:38 +00:00
63db3daafe
Cleaned up some log messages.
2005-07-14 09:20:39 +00:00
2e858755c5
Brought some debug log messages "in line".
2005-07-14 09:14:12 +00:00
b682a5e485
Reformatted some comments.
2005-07-14 09:11:38 +00:00
efbfe4ae83
removed unneeded variable "bsize"
2005-07-13 16:06:55 +00:00
c92e57fec3
add better error checks for io_ routines
2005-07-12 20:44:46 +00:00
ca130e6db6
removed unneeded return statement
2005-07-12 20:44:13 +00:00
248d75e566
fix embarassing buffer-off-by one
2005-07-11 20:58:05 +00:00
4715b17106
make Conn_NewListener local to conn.c
2005-07-11 14:56:38 +00:00
70facb7f6e
made a few config options unsigned.
2005-07-11 14:11:35 +00:00
76604f847a
change assertions to stop splint from complaining
2005-07-11 14:10:53 +00:00
c7693f625e
s/strcpy/strlcpy/
2005-07-10 21:07:22 +00:00
e50d049074
minor cosmetic changes
2005-07-09 21:35:20 +00:00
Alexander Barton