Dan Kegel
0161606b53
advapi32: Don't test buffer length if buffer is null.
2008-05-27 20:39:38 +02:00
Francois Gouget
705de5d391
advapi32/tests: Remove a stray reference to CryptReleaseContext(). This gets the test to run again on Win95.
2008-05-22 11:43:09 +02:00
Andrew Talbot
cca1854e96
advapi32: Remove unused file-static variables.
2008-05-20 15:43:54 +02:00
Alexandre Julliard
33914a1bf4
services: Send the service name in the control requests.
...
Only start a single dispatcher thread for all services.
2008-05-08 18:08:41 +02:00
Paul Vriens
deee97d9ea
advapi32/tests: Add another test.
2008-05-07 12:06:47 +02:00
Andrew Talbot
092a2b3efa
advapi32: Avoid giving variables same name as library functions.
2008-05-05 19:46:15 +02:00
Rob Shearman
d245e7978d
advapi32: Make sure not to return a credential with a NULL UserName field when a Mac Keychain doesn't have an account name attribute.
2008-05-01 11:13:27 +02:00
Alexandre Julliard
dad21bbcbf
makefiles: List the static libraries as normal imports instead of extra libs.
2008-04-30 14:23:55 +02:00
Andrew Talbot
06f05a9a5c
advapi32: Use correct function pointer cast.
2008-04-30 10:25:52 +02:00
Alexandre Julliard
ef07d83405
Include wine/port.h everywhere we use exceptions.
2008-04-29 20:18:49 +02:00
Lei Zhang
9fca0f27d0
advapi32: Replace UuidToStringW call with a sprintfW.
2008-04-29 12:34:29 +02:00
James Hawkins
76dfff11a3
advapi32: Fix a test that fails in win2k3 SP2.
2008-04-25 11:33:43 +02:00
James Hawkins
d3bbc0231a
advapi32: Fix a test that fails in win2k3.
2008-04-21 13:20:12 +02:00
James Hawkins
9f859b4519
advapi32: Remove a test that fails on some systems.
2008-04-21 12:12:13 +02:00
James Hawkins
3a4f271a6b
advapi32: Fix a test that fails on some versions of win2k.
2008-04-21 12:12:06 +02:00
Marcus Meissner
fbc236107d
advapi32: Initialize hLock.
2008-04-18 13:57:15 +02:00
Rob Shearman
fe7e786ace
advapi32: Add exception handling around all service RPC calls.
2008-04-11 12:14:24 +02:00
James Hawkins
9dc979604c
advapi32: Fix a few tests that fail in win2k.
2008-04-11 11:16:14 +02:00
Andrew Talbot
5c8473ba78
advapi32: Array parameters are passed to function as pointers so lose size information.
2008-04-09 11:43:41 +02:00
Andrew Talbot
2ae8e87616
advapi32: Do not call MIDL_user_free() with pointer to stack memory.
2008-04-07 13:39:32 +02:00
Rob Shearman
9bc84d81df
wineboot: Start services.exe on startup instead of on demand in the advapi32 services code.
2008-04-02 11:55:24 +02:00
Rob Shearman
9d834fc180
advapi32: Remove some unused services functions.
2008-04-01 19:11:09 +02:00
Alexandre Julliard
9bb129d17b
advapi32: Silence the pipe read error in the normal case.
2008-03-31 17:26:07 +02:00
Rob Shearman
b8348b95a6
services: Remove dependency on service name being determined correctly in order for the two ends on the control pipe to meet up.
...
Instead use the mechanism used by native which uses
\\.\pipe\net\NtControlPipeN.
Also remove the service startup event set by StartServiceCtrlDispatcher
as we wait for the service status to change instead.
2008-03-29 11:51:39 +01:00
Rob Shearman
9a6fc01d84
services: Move ControlService and StartServiceW from advapi32.dll to services.exe.
...
This also changes the architecture such that services.exe is the server
end of the control pipe and the service is the client end.
2008-03-29 11:51:34 +01:00
Rob Shearman
7afd9a977a
services: Move LockServiceDatabase and UnlockServiceDatabase from advapi32.dll to services.exe.
2008-03-29 11:51:01 +01:00
Rob Shearman
b48714b148
services: Move SetServiceStatus and QueryServiceStatusEx to services.exe.
2008-03-29 11:50:57 +01:00
Mikołaj Zalewski
010dcb168b
services: Move GetServiceDisplayName to services.exe and implement GetServiceKeyName.
2008-03-29 11:17:33 +01:00
Mikołaj Zalewski
76d4eeebff
services: Move ChangeServiceConfigW implementation from advapi32.dll to services.exe.
2008-03-29 11:17:07 +01:00
Mikołaj Zalewski
a363b9a066
services: Move QueryServiceConfigW from advapi32.dll to services.exe.
2008-03-29 11:16:43 +01:00
Mikołaj Zalewski
a2156fc348
services: Move CreateService, OpenService and DeleteService implementations from advapi32.dll to services.exe.
2008-03-29 11:15:59 +01:00
Mikołaj Zalewski
4275fbf603
services: Start a local RPC server.
2008-03-29 11:15:05 +01:00
Austin English
06d429d6b6
Spelling fixes.
2008-03-27 20:48:19 +01:00
Stefan Leichter
6cb602c6db
advapi32: Partly implemented QueryServiceConfig2A/W.
2008-03-26 14:13:07 +01:00
Juan Lang
9ea9eaaa81
advapi32: Create MachineGuid value if it doesn't exist.
2008-03-25 19:58:43 +01:00
Juan Lang
4c984e089a
advapi32: Test the MachineGuid value.
2008-03-25 19:58:37 +01:00
Dan Hipschman
2904f543f4
advapi32: Add a stub for CreateRestrictedToken.
2008-03-22 11:14:13 +01:00
Francois Gouget
304b415284
Assorted spelling fixes.
2008-03-19 11:21:27 +01:00
Paul Vriens
e92121d41e
advapi/service: Give service its own debug channel.
2008-03-14 11:21:53 +01:00
Alexandre Julliard
df0f42fe78
advapi32: Implemented RegOverridePredefKey.
2008-03-11 19:48:57 +01:00
Paul Vriens
81e0ef44e9
advapi32/tests: Fix a few typos.
2008-03-07 10:52:20 +01:00
Rob Shearman
48000893f9
makefiles: Simplify the use of the IMPORTLIB variable in the DLL makefiles.
...
Only specify the root to keep platform-specifics out of the individual
DLL makefiles.
2008-03-04 20:55:01 +01:00
Paul Vriens
bfc290f6d0
advapi32/tests: Skip not available functions.
2008-03-03 15:38:57 +01:00
Paul Vriens
0c7ab1bd30
advapi32/tests: Don't crash on NT4, W2K and XP-SP1.
2008-02-25 19:50:12 +01:00
Maarten Lankhorst
284f86183c
advapi: Check if service really exists before bombing out in CreateService.
2008-02-22 11:55:12 +01:00
Francois Gouget
7a585f3c37
advapi32/tests: Check whether RegGetValue() '\0'-terminates the buffer when retrieving a zero-byte string value.
2008-02-19 13:39:24 +01:00
Francois Gouget
6843da68e7
advapi32/tests: Remove an obsolete comment: Wine's on-disk registry format now supports string values with no trailing '\0'.
2008-02-19 13:39:24 +01:00
Rob Shearman
608ac1e828
advapi32: Fix the AccessCheck tests so that the ACCESS_SYSTEM_SECURITY test now runs (when the user has the Security privilege).
...
Duplicate the token at SecurityImpersonation impersonation level instead
of SecurityIdentification, otherwise the call to RtlAdjustPrivilege
fails on Windows.
2008-02-19 13:39:24 +01:00
Paul Vriens
ba4669860e
advapi32/tests: Skip tests when our language isn't LANG_ENGLISH.
2008-02-18 14:13:18 +01:00
Rob Shearman
cca635b472
advapi32: Add tests for the off-by-one fixing behaviour of RegSetValueExA and RegSetValueExW.
2008-02-18 13:30:01 +01:00
Rob Shearman
628183c2f9
advapi32: Document that the cbData parameter of RegSetValueA/W is ignored.
2008-02-18 13:29:56 +01:00
Rob Shearman
121be51f1d
advapi32: Add tests for RegSetValueA/W.
...
Fix RegSetValueA/W to return ERROR_INVALID_PARAMETER if NULL data is
passed in.
2008-02-18 13:29:51 +01:00
Juan Lang
3138f87e73
advapi32: Fix CryptVerifySignatureW test failures on Win98SE and NT4.
2008-02-16 13:51:37 +01:00
Francois Gouget
79333bd1c0
advapi32/tests: Check that a credential type is supported before testing it. Test CRED_TYPE_DOMAIN_VISIBLE_PASSWORD credentials. Factorize the CredentialBlob checks.
2008-02-15 12:05:39 +01:00
Francois Gouget
6552f86ff9
advapi32/tests: Factorize the password constants.
2008-02-15 12:05:30 +01:00
Francois Gouget
ddab29b7d1
advapi32: Add a rudimentary implementation of CredGetSessionTypes().
2008-02-15 12:05:20 +01:00
Rob Shearman
7579145ae1
advapi32: The lpcbSecurityDescriptor parameter to RegGetKeySecurity isn't optional, so don't complicate the code by treating as though it is.
2008-02-15 11:03:31 +01:00
Paul Vriens
e2de4b18e5
advapi32/tests: CryptVerifySignatureW is not implemented on win98.
2008-02-15 09:54:23 +01:00
Paul Vriens
56d085ccec
advapi32/tests: Only use functions if they are implemented.
2008-02-12 22:40:15 +01:00
Alexandre Julliard
05c7174909
tests: Add a helper routine to wait for a child process and propagate its result correctly.
2008-02-07 12:56:00 +01:00
Stefan Leichter
f3f64c7939
advapi32: Fix the failing QueryServiceConfig2 test on platforms win2k3 and vista.
2008-02-05 12:19:36 +01:00
Rob Shearman
b2f4c7737b
advapi32: Fix the size calculation in StartServiceW.
...
Calculating an open-ended structure using sizeof doesn't yield an
accurate size because of alignment.
2008-02-04 13:03:16 +01:00
Reece H. Dunn
d4c48db4b0
advapi32: Fix some cred test failures on Vista and prevent it crashing.
2008-01-25 12:30:32 +01:00
Alexandre Julliard
e84daed485
Avoid sizeof in traces.
2008-01-24 14:03:10 +01:00
Francois Gouget
269cb45f25
advapi32/tests: Add the trailing '\n' to an ok() call.
2008-01-23 20:39:27 +01:00
Paul Vriens
44273b00ed
advapi32/tests: Make tests run on win9x/NT4 again.
2008-01-23 12:05:37 +01:00
Rob Shearman
b503bcf6e6
advapi32: Implement LookupAccountNameW for well-known groups.
2008-01-23 11:31:42 +01:00
Rob Shearman
28cabdfe9f
advapi32: Add a test for LookupAccountNameA on a well-known group.
2008-01-23 11:31:42 +01:00
Rob Shearman
6efa903cf0
advapi32: Implement SetEntriesInAclW.
2008-01-23 11:31:42 +01:00
Rob Shearman
261bf8dad5
advapi32: Add more tests for SetEntriesInAcl.
2008-01-23 11:31:42 +01:00
Stefan Leichter
d6748c9db7
advapi32: Added some tests for QueryServiceConfig2A/W.
2008-01-22 11:18:48 +01:00
Austin English
f6caf1be81
Misc spelling fixes.
2008-01-18 12:51:08 +01:00
Francois Gouget
520054f60c
advapi32/tests: Actually test strings that expand to something bigger than their original size.
2008-01-18 11:53:02 +01:00
Francois Gouget
d9a06b236a
advapi32: RegGetValueW() must return the required buffer size in bytes, not WCHARs.
2008-01-11 12:25:21 +01:00
Francois Gouget
c47c6483aa
advapi32: RegGetValue() should not return an error when expanding a string and given a NULL buffer and a zero size.
...
Adjust the tests to cover this case for REG_EXPAND_SZ registry
values. Improve the documentation a bit.
2008-01-11 12:25:14 +01:00
Paul Chitescu
038c3a264b
advapi32: Accept a NULL lpServiceStatus in ControlService.
2008-01-10 12:07:22 +01:00
Paul Vriens
d2e0786eb2
advapi32/tests: Don't crash on win98.
2008-01-08 12:54:58 +01:00
Alexandre Julliard
ef15bbf1cb
advapi32/tests: Print the correct size in an error message.
2008-01-07 17:18:07 +01:00
Alexandre Julliard
781c3b9c6a
advapi32: Fix the length written to the pipe for the start message.
2008-01-07 12:18:11 +01:00
Alexandre Julliard
3133280d08
advapi32: Don't wait for 20 seconds if a service fails to start.
2008-01-04 12:50:11 +01:00
Andrew Talbot
05f38321c4
advapi32: Remove unneeded casts.
2007-12-31 17:39:39 +01:00
Alexandre Julliard
7593fac632
advapi32: Start non-interactive services in a separate window station.
2007-12-20 16:44:36 +01:00
Alexandre Julliard
eb2d8458a3
advapi32: Move the EnumDependentServicesA/W stubs in service.c where they belong.
...
Make the stubs return success.
2007-12-20 15:00:42 +01:00
Alexandre Julliard
c673b2284d
advapi32: Return from StartServiceCtrlDispatcher when all services are stopped.
2007-12-19 18:28:20 +01:00
Alexandre Julliard
a12b9c52da
advapi32: Replace the list of services with an array.
2007-12-19 17:02:12 +01:00
Alexandre Julliard
1f11ad8288
advapi32: Use exponential backoff when waiting for a service to start.
2007-12-19 15:07:20 +01:00
Alexandre Julliard
4889a0edf7
advapi32: Fix RegisterServiceCtrlHandler spec entry.
2007-12-19 15:06:19 +01:00
Alexandre Julliard
865bb0a67a
advapi32: Reimplement RegisterServiceCtrlHandler on top of RegisterServiceCtrlHandlerEx.
2007-12-19 15:05:04 +01:00
Sam Dennis
1590b1f731
advapi32: Fix undocumented behaviour in ReqQueryValueEx when 'count' and 'type' point to the same address.
2007-12-14 14:06:45 +01:00
Alexandre Julliard
c0b12351e0
Avoid size_t types in traces.
2007-12-07 18:49:18 +01:00
Tim Schwartz
65d2f8a68d
advapi32: service_control_dispatcher(): Fixed invalid pipe test to display GetLastError() before it gets overwritten.
2007-12-05 13:47:00 +01:00
Andrew Talbot
263cb72e13
advapi32: Remove unneeded casts.
2007-12-03 13:10:21 +01:00
Louis Lenders
defbdf76e5
advapi32: Add stub for CreateProcessWithLogonW.
2007-11-29 15:46:50 +01:00
Andrew Talbot
fd03f4ae86
advapi32: Fix a typo.
2007-11-29 13:39:16 +01:00
Rob Shearman
f96ff7d46e
advapi32: Make the credential registry key stay around if a persist value longer than session is specified.
2007-11-28 11:23:56 +01:00
Rob Shearman
c251100685
advapi32: Use the open_for_write parameter to open_cred_mgr_key and fix get_cred_mgr_encryption_key to not need KEY_WRITE access to the key passed in.
2007-11-28 11:23:54 +01:00
Rob Shearman
312a1db3ec
advapi32: Add support for using the Mac Keychain services as a backend for the credential functions instead of the registry.
2007-11-27 12:29:34 +01:00
Rob Shearman
50532d8b4d
advapi32: Fix a typo in CredEnumerateW.
2007-11-27 11:38:28 +01:00
Rob Shearman
ca83f61d2e
advapi32: Move credential registry reading code to separate functions.
2007-11-27 11:38:22 +01:00
Gerald Pfeifer
f874126bec
advapi32: Remove untriggerable check.
2007-11-19 13:51:45 +01:00
Dan Kegel
89b9af7714
advapi32: Fix buffer overrun in tests/registry.c:wine_debugstr_wn().
2007-11-12 12:55:42 +01:00
Francois Gouget
81a5701ca9
Assorted spelling fixes.
2007-11-09 13:07:12 +01:00
Alexandre Julliard
0590fe2ecf
Make some variables static.
2007-11-06 14:38:54 +01:00
Paul Vriens
cac17c455d
advapi32/tests: Make tests run on win98 again.
2007-11-02 12:38:36 +01:00
Rob Shearman
e8d7af2d43
advapi32: Implement filter matching for CredEnumerate.
2007-10-31 12:39:54 +01:00
Rob Shearman
e6f28ebb1a
advapi32: Add tests for credential management functions.
2007-10-31 12:39:54 +01:00
Rob Shearman
e3fae172f1
advapi32: Implement ANSI credential management functions.
2007-10-31 12:39:54 +01:00
Rob Shearman
61e836b947
advapi32: Implement CredEnumerateW.
2007-10-31 12:39:53 +01:00
Rob Shearman
72bd876599
advapi32: Implement CredDeleteW.
2007-10-31 12:39:53 +01:00
Rob Shearman
7689fad310
advapi32: Implement CredReadW and CredFree.
2007-10-31 12:39:53 +01:00
Rob Shearman
7583130908
advapi32: Implement CredWriteW.
2007-10-31 12:39:53 +01:00
Dan Kegel
dc072e209d
advapi32/tests: Fix undefined memory references in registry.c.
2007-10-30 12:46:38 +01:00
Louis Lenders
27e8b829a4
advapi32: Export RegOverridePredefKey.
2007-10-26 15:16:38 +02:00
Mikolaj Zalewski
a1e0f773e0
advapi32: Add a well known sid.
2007-10-26 14:03:46 +02:00
Mikolaj Zalewski
e7d423ce48
advapi32: Fix CreateWellKnownSid test on Windows XP.
2007-10-26 14:03:46 +02:00
Rob Shearman
e51f8490f2
server: Ignore ACEs with the INHERIT_ONLY_ACE flag set during access checks.
2007-10-26 12:46:30 +02:00
Rob Shearman
340122abb7
advapi32: Fix the ACCESS_SYSTEM_SECURITY test by impersonating the token during the call to RtlAdjustPrivileges.
2007-10-26 12:46:30 +02:00
Rob Shearman
efed229a08
advapi32: Add a test for access checks with the INHERIT_ONLY_ACE flag.
2007-10-26 12:46:30 +02:00
Juan Lang
1fd2bc5215
advapi32: Add stubs for CredEnumerateA/W.
2007-10-25 12:53:22 +02:00
Rob Shearman
87b15db617
advapi32: Print out the unknown value for sid use in the LookupAccountName test, instead of the known value.
2007-10-25 12:14:34 +02:00
Rob Shearman
6b081232b9
ntdll: Add a stub for RtlSetControlSecurityDescriptor.
...
Implement SetSecurityDescriptorControl on top of RtlSetControlSecurityDescriptor.
2007-10-23 18:20:45 +02:00
Francois Gouget
b1335db353
Better match the PSDK types and update win32.api to fix the winapi_check warnings.
2007-10-23 18:19:42 +02:00
Rob Shearman
06b2da9560
ntdll: Fix RtlValidAcl to accept newer ACL revisions.
2007-10-23 18:18:29 +02:00
Rob Shearman
866ec27044
advapi32: Add some tests for ACL functions.
2007-10-23 18:18:29 +02:00
Rob Shearman
8bfb77b958
advapi32: Runtime link to CreateWellKnownSid in the tests for the function, since it isn't available on all platforms.
2007-10-23 18:18:29 +02:00
Hans Leidekker
35c0511d2b
advapi32: Remove tests for the sha context structure.
2007-10-23 12:22:52 +02:00
Lionel Debroux
5c1334e775
advapi32/tests: Fix memory leak (found by Smatch).
2007-10-22 15:58:22 +02:00
Mikołaj Zalewski
cf509c29f1
advapi32: Make CreateWellKnownSid create domain sids (with test).
2007-10-22 14:54:39 +02:00
Mikołaj Zalewski
b06379b2b3
advapi32: Add a test for CreateWellKnownSid and implement two more SIDs.
2007-10-22 14:54:39 +02:00
Mikołaj Zalewski
8bc12f3f41
advapi32/tests: Define OBJECT_BASIC_INFORMATION in source file as it is not defined in Windows SDK winternl.h.
2007-10-22 14:54:39 +02:00
Mikołaj Zalewski
05cb54fcc8
advapi32/tests: Make the SDDL test pass under Vista.
2007-10-22 14:54:39 +02:00
Bang Jun-young
27213de046
advapi32: Fix AdjustTokenPrivileges() to match the PSDK.
2007-10-17 13:44:01 +02:00
Rob Shearman
2cecc630b6
advapi32: Don't link to CreateWellKnownSid at compile time in the security tests.
...
It isn't available on some Windows platforms.
2007-10-16 13:17:29 +02:00
Rob Shearman
12e44bf299
server: Fix token_access_check to allow full access to security descriptors with present but NULL DACLs.
2007-10-16 13:17:22 +02:00
Rob Shearman
a006b06080
ntdll: Fix the return code from RtlSetDaclSecurityDescriptor when daclpresent is FALSE.
2007-10-16 13:17:14 +02:00
Rob Shearman
d1a3e2ede5
advapi32: Add tests for AccessCheck with NULL DACLs and blank DACLs.
2007-10-16 13:17:09 +02:00
Louis Lenders
22e9da0dd7
advapi32: Improve stub for EnumServicesStatusExA a bit.
2007-10-15 16:56:11 +02:00
Francois Gouget
d16a634c38
Better match the PSDK types and update win32.api to fix the winapi_check warnings.
2007-10-15 14:06:48 +02:00
Francois Gouget
fda899a778
Assorted spelling fixes.
2007-10-11 19:52:49 +02:00
Mikolaj Zalewski
719da96a3e
advapi32: security: Remove unneeded FIXME.
2007-10-04 11:41:06 +02:00
Lionel Debroux
57a67ebcce
advapi32/tests: Fix a typo.
2007-10-03 12:02:48 +02:00
Lionel Debroux
40c66b8977
advapi32/tests: Fix memory leaks (found by Smatch).
2007-10-03 12:02:38 +02:00
Rob Shearman
00bc3d9e48
advapi32: Allow GetFileSecurityA/W to work on files that have been opened already with restricted sharing flags.
...
Only use the minimum required access rights for the information being retrieved.
2007-10-03 11:17:04 +02:00
Rob Shearman
1262d7dbef
advapi32: Implement SetFileSecurityW on top of NtSetSecurityObject.
2007-10-03 11:16:59 +02:00
Mikolaj Zalewski
a8b8ddd865
advapi32: Fix GetServiceDisplayNameA for cchBuffer == 0.
2007-09-28 11:30:00 +02:00
Mikolaj Zalewski
8fd1cf0f56
advapi32: Implement GetPrivateObjectSecurity (with test).
2007-09-28 11:26:45 +02:00
Mikolaj Zalewski
0590dc9b5c
advapi32: In ConvertStringSecurityDescriptorToSecurityDescriptor "AU" should be checked before "A" (with testcase).
2007-09-28 11:26:25 +02:00
Mikolaj Zalewski
8188ce6fb1
advapi32: Make ConvertStringSecurityDescriptorToSecurityDescriptor write the ACL.
2007-09-28 11:26:18 +02:00
Mikolaj Zalewski
611f57bc20
advapi32/ntdll: GetSecurityDescriptorOwner/Group should fill isDefaulted also for NULL sids.
2007-09-28 11:26:10 +02:00
Mikolaj Zalewski
3c51b2c645
advapi32/ntdll: MakeRelativeSD should preserve NULL pointers (with testcase).
2007-09-28 11:26:00 +02:00