Commit Graph

808 Commits

Author SHA1 Message Date
Paul Vriens b6f92f10c6 wininet/ftp: Move a definition in FTP_FtpFindFirstFileW (Coverity). 2007-03-21 11:54:56 +01:00
Paul Vriens 9a7fb5f1e7 wininet/ftp: Simplify FTP_FtpGetFileW a bit. 2007-03-21 11:54:42 +01:00
Hans Leidekker 13a04ac0a8 wininet: Fix buffer size calculation in INTERNET_InternetOpenUrlW.
Spotted by Ron Yorston.
2007-03-13 20:31:22 +01:00
Francois Gouget fa41be3fdb wininet: Fix a couple of reversed checks that could result in leaked socket handles. 2007-03-08 22:16:41 +01:00
Francois Gouget 53e76f8370 wininet: Check file handles against INVALID_HANDLE_VALUE, not NULL.
Simplify the file handle handling in FTP_FtpPutFileW().
2007-03-08 22:16:36 +01:00
Rob Shearman 07daeff8f4 wininet: Always make copies of strings passed to INTERNET_SendCallback.
This ensures that applications that change the strings received in
status callbacks don't affect the data needed to successfully connect to
the correct server.
2007-03-05 16:43:26 +01:00
Paul Vriens 23473ccc9e wininet/ftp: Let CreateFile deal with last error. 2007-03-01 12:17:47 +01:00
Ken Thomases b33057986a wininet: Use "ping -c 1" instead of "ping -w 1" for InternetCheckConnection. 2007-02-28 21:29:43 +01:00
Paul Vriens 443ae2290a wininet/tests: Add another test. 2007-02-27 12:23:49 +01:00
Andrew Talbot 46fc9c2e11 wininet: Constify some variables. 2007-02-26 13:38:37 +01:00
Paul Vriens 63806a94b5 wininet/tests: Add a few more tests. 2007-02-22 11:26:51 +01:00
Rob Shearman ba590a185a wininet: Fix the case of partial SSL reads from the peek buffer.
Don't return FALSE for a partial read. Fall through to SSL_read and use 
the logic for partial reads there instead of having separate logic and 
recursively calling NETCON_recv. Based on a patch by Michael Moss.
2007-02-21 19:49:50 +01:00
Francois Gouget 56da1eeadc wininet/tests: Fix some tests so they succeed on Windows 98. 2007-02-21 19:48:25 +01:00
Paul Vriens 8bc9bc2e29 wininet/ftp.c: Fix some typos. 2007-02-21 10:54:14 +01:00
Francois Gouget 93494f2ac0 Assorted spelling fixes. 2007-02-20 20:30:51 +01:00
Francois Gouget eb2bf541f2 wininet/tests: Tell the user which ftp server we're using for the tests so he can try to connect to it manually in case of trouble. 2007-02-20 20:29:51 +01:00
Francois Gouget f410bbf098 wininet/tests: Dynamically load some functions so the test runs on Windows 98. 2007-02-20 20:29:46 +01:00
Francois Gouget da64fe5d56 wininet: Move a bunch of misplaced API documentation. 2007-02-20 20:29:38 +01:00
Paul Vriens 8316b93386 wininet/ftp.c: Fix some returned error codes. 2007-02-20 11:40:09 +01:00
Hans Leidekker 316383dd49 wininet: Don't discard the extra info part of a URL in InternetOpenUrl. 2007-02-20 11:39:00 +01:00
Paul Vriens 5b04d3d67d wininet/ftp.c: Fix some returned error codes. 2007-02-19 12:04:42 +01:00
Hans Leidekker 890f63a1d8 wininet: Fix a test that fails on Windows. 2007-02-13 11:50:07 +01:00
Hans Leidekker 2024f68753 wininet: Skip empty accept type strings in HttpOpenRequest. 2007-02-13 11:50:01 +01:00
Paul Vriens f0f3e15ac2 wininet/ftp.c: Fix some returned error codes. 2007-02-13 11:49:40 +01:00
Paul Vriens 00b7b29c3a wininet/ftp.c: Add tests to show the order of parameter checking. 2007-02-13 11:49:22 +01:00
Paul Vriens 2ba1cdad69 wininet/ftp.c: Add another test. 2007-02-12 13:58:56 +01:00
Paul Vriens d20833fc52 wininet/ftp.c: Fix some returned error codes. 2007-02-12 13:47:11 +01:00
Paul Vriens 54c80612ac wininet/ftp.c: Fix some returned error codes. 2007-02-12 13:47:03 +01:00
Paul Vriens 6c05048756 wininet/ftp.c: Fix some returned error codes. 2007-02-12 13:46:52 +01:00
Paul Vriens 1f5e5a2b75 wininet/ftp.c: Fix some returned error codes. 2007-02-09 11:50:09 +01:00
Paul Vriens 37eb0955cd wininet/tests: Add a few more tests. 2007-02-07 21:41:58 +01:00
Paul Vriens 70be65b76e wininet/ftp: Remove unneeded (double) checks. 2007-02-07 21:41:53 +01:00
Paul Vriens ce8ededf3b wininet/ftp: Remove unneeded (double) checks. 2007-02-07 21:41:44 +01:00
Paul Vriens e849f758ba wininet/ftp: Remove unneeded (double) checks. 2007-02-07 21:41:37 +01:00
Paul Vriens 00ff67ef09 wininet/ftp: Remove unneeded (double) checks. 2007-02-07 21:41:30 +01:00
Paul Vriens a571476a74 wininet/ftp: Remove unneeded (double) checks. 2007-02-07 21:41:23 +01:00
Paul Vriens 7a1ef2c1ef wininet/ftp: Remove unneeded (double) checks. 2007-02-07 21:41:16 +01:00
Paul Vriens 7c7271d465 wininet/ftp: Remove unneeded (double) checks. 2007-02-07 21:41:07 +01:00
Paul Vriens 2831cf5d3e wininet/ftp: Remove unneeded (double) checks. 2007-02-07 21:41:00 +01:00
Paul Vriens 0e8ad3019a wininet/ftp: Remove unneeded (double) checks. 2007-02-07 21:40:52 +01:00
Paul Vriens 0cc5a68e2c wininet/ftp.c: Remove unneeded check. 2007-02-07 11:03:59 +01:00
Paul Vriens 46812a4bba wininet: Remove unused function. 2007-02-06 12:30:45 +01:00
Paul Vriens 8e9a81ea08 wininet/tests: Add ftp tests. 2007-02-05 21:04:26 +01:00
Bang Jun-Young b71e42b794 wininet: config.h police. 2007-02-05 12:25:55 +01:00
Francois Gouget aab5e5856e Don't put single quotes around '%s' when using the debugstr_*() functions. 2007-01-18 12:55:50 +01:00
Rob Shearman 1ec14b0b25 wininet: Fix HTTP_EncodeBasicAuth by passing an out buffer to the second set of character set conversion calls. 2007-01-17 11:24:09 +01:00
Mikołaj Zalewski b8e1dcb374 wininet: Add Polish translation. 2007-01-15 12:42:29 +01:00
Rob Shearman a9ebc706e3 wininet: Change HTTP_EncodeBase64 to operate on a series of bytes, instead of text.
Change HTTP_EncodeBasicAuth to convert the username and password into 
utf8 before base64 encoding.
2007-01-15 12:31:11 +01:00
Rob Shearman 9efe083ec5 wininet: HTTP_HttpQueryInfoW deals with bytes, not characters so update the callers that have this wrong assumption. 2007-01-15 12:30:53 +01:00
Rob Shearman 7b002a39b8 wininet: Allow a NULL value to be passed into HTTP_ProcessHeader
instead of crashing so that when used with the replace flag it will
delete an existing value.
2007-01-15 12:30:46 +01:00
Rob Shearman 392ceba61f wininet: Don't try to read anything if 0 bytes are to be read. 2007-01-10 22:25:44 +01:00
Francois Gouget e66d1cd5e9 wininet: Consistenly use INTERNET_SetLastError(). 2007-01-10 11:58:47 +01:00
Rob Shearman 47a8b86b53 wininet: Use Keep-Alive for HTTP requests if specified by the flags passed into HttpOpenRequest. 2007-01-08 12:39:50 +01:00
Rob Shearman a9c2cfa8d9 wininet: Fix the handling of Accept types passed into HttpOpenRequest
by properly coalescing all the types into the Accept header value,
rather than just adding the first.
2007-01-08 12:39:47 +01:00
Rob Shearman 7e8ef764b8 wininet: Rename HTTP_Base64 to HTTP_EncodeBase64 to more accurately reflect what it does. 2007-01-08 12:39:42 +01:00
Francois Gouget bf81fdc248 wininet/tests: Print GetLastError() in decimal with '%u'. 2007-01-08 12:06:27 +01:00
Jeff Latimer d7697bd55e wininet: Ensure null check before dereference. 2007-01-05 20:26:30 +01:00
Rob Shearman 06b19b018a wininet: Fix the releasing of the wrong reference count in HTTP_CloseHTTPRequestHandle.
lpwhr obviously already has a reference count of 0 because it is being destroyed.
2007-01-04 21:17:53 +01:00
Rob Shearman 272954bd81 wininet: Change the HTTP code to not assume that the connection will be closed at the end of every request. 2007-01-04 21:17:34 +01:00
Rob Shearman f0163ae7d6 wininet: Don't send callbacks in HTTP_CloseConnection if not connected. 2007-01-04 21:17:19 +01:00
Rob Shearman ac1b527498 wininet: Use the Content-Length header to work out how much HTTP data there is left to be read
and don't try to read any more than what is available.
2007-01-04 21:17:12 +01:00
Rob Shearman cf43b16036 wininet: Always send a Connection header set to "close" because that is what we expect for the moment. 2007-01-04 21:16:38 +01:00
Rob Shearman 09dbb1b5a0 wininet: Use correct types for socket functions to avoid warnings when compiling on BSD-based systems. 2007-01-04 21:16:30 +01:00
Rob Shearman 14fb418942 wininet: Fix HTTP redirects by reseting loop_next after one loop. 2007-01-04 21:14:54 +01:00
Rob Shearman 02c89e5c6f wininet: Remove the custom thread pool implementation and use QueueUserWorkItem instead. 2007-01-04 21:13:53 +01:00
Louis Lenders e39a3be860 wininet: Update Dutch resource. 2007-01-04 09:53:23 +01:00
Jacek Caban 49f5ee746c wininet: Get rid of ASYNC_FUNC enum. 2006-12-26 12:50:19 +01:00
Jacek Caban f08ff892be wininet: Use proc instead of enum in FTPFINDNEXTW request. 2006-12-26 12:50:09 +01:00
Jacek Caban 3a08f1f656 wininet: Use proc instead of enum in FTPRENAMEFILEW request. 2006-12-26 12:50:00 +01:00
Jacek Caban 97157ccee0 wininet: Use proc instead of enum in FTPREMOVEDIRECTORYW request. 2006-12-26 12:49:53 +01:00
Jacek Caban ee99b3f0c5 wininet: Use proc instead of enum in FTPDELETEFILEW request. 2006-12-26 12:49:47 +01:00
Jacek Caban 054108368e wininet: Use proc instead of enum in FTPGETFILEW request. 2006-12-26 12:49:41 +01:00
Jacek Caban 3c90016f2f wininet: Use proc instead of enum in FTPOPENFILEW request. 2006-12-26 12:49:32 +01:00
Jacek Caban 3b77ff24c2 wininet: Use proc instead of enum in FTPGETCURRENTDIRECTORYW request. 2006-12-26 12:49:27 +01:00
Jacek Caban 0d464ba8db wininet: Use proc instead of enum in FTPFINDFIRSTFILEW request. 2006-12-26 12:49:19 +01:00
Jacek Caban c4aa47badd wininet: Use proc instead of enum in FTPCREATEDIRECTORY request. 2006-12-26 12:49:08 +01:00
Jacek Caban f28b0e3b10 wininet: Use proc instead of enum in FTPSETCURRENTDIRECTORY request. 2006-12-26 12:49:01 +01:00
Jacek Caban 4adce67cf6 wininet: Use proc instead of enum in FTPUTFILE request. 2006-12-26 12:48:53 +01:00
Jacek Caban 662c885a0b wininet: Use proc instead of enum in INTERNETREADFILEEXA request. 2006-12-26 12:48:40 +01:00
Jacek Caban 8c3ca8d817 wininet: Use proc instead of enum in INTERNETOPENURLW request. 2006-12-26 12:48:30 +01:00
Jacek Caban 5dd5536a9a wininet: Remove not used HTTPOPENREQUESTW request. 2006-12-26 12:48:21 +01:00
Jacek Caban c156845560 wininet: Use proc instead of enum in HTTPSENDREQUESTW request. 2006-12-26 12:48:09 +01:00
Jacek Caban e30037f0d5 wininet: Use proc instead of enum in SENDCALLBACK request. 2006-12-26 12:47:57 +01:00
Rob Shearman 72575a06ca wininet: Make a function for resolving the server name for an HTTP request
and sending the appropriate callbacks and use it to remove some duplicated code.
2006-12-07 11:42:51 +01:00
Rob Shearman 4319ec6b83 wininet: Make HTTP_HandleRedirect no longer call HTTP_HttpSendRequestW.
Make the redirect handling in HTTP_HttpSendRequestW iterate instead of recurse.
2006-12-07 11:42:38 +01:00
Paul Vriens cae03f7658 wininet/test: Free memory after use. 2006-12-06 11:26:52 +01:00
Francois Gouget c66628b73f Consistently use SUBLANG_NEUTRAL for Italian resources. 2006-12-05 11:28:38 +01:00
Francois Gouget 89f4cd9336 wininet: Add a Portuguese translation (contributed by Americo Jose Melo). 2006-11-28 12:13:22 +01:00
Francois Gouget b5f104d05b Replace SUBLANG_DEFAULT with the specific SUBLANG_XXX constant for languages that have multiple sublanguages. 2006-11-24 11:49:32 +01:00
Andrew Talbot 4ef6043a57 wininet: Cast-qual warnings fix. 2006-11-22 11:45:05 +01:00
Rob Shearman 01425f603a wininet: Don't return an error for INTERNET_OPTION_SEND/RECEIVE_TIMEOUT not being implemented
on protocols other than HTTP, just print a FIXME. Reported by Michael Moss.
2006-11-02 21:57:17 +01:00
Jacek Caban 1031c5f9c6 wininet: Revert commit 760043c245.
After more testing I've checked that current code is bad, but my patch
was also wrong and causes regression in WoW.
2006-11-02 21:01:05 +01:00
Jacek Caban 5c53baac8d wininet: Inherit INET_CALLBACKW from parent handler. 2006-10-31 11:46:49 +01:00
Jacek Caban 7bd385b714 wininet: Use handle stored in WININETHANDLEHEADER instead of WININET_FindHandle. 2006-10-31 11:46:47 +01:00
Jacek Caban 760043c245 wininet: Call SendCallback in destructor instead of InternetCloseHandle. 2006-10-30 11:36:16 +01:00
Jacek Caban ae430f9323 wininet: Store handle in WININETHANDLEHEADER and use it in SendCallback. 2006-10-30 11:36:09 +01:00
Jacek Caban 957516f8e6 wininet: Remove lpwhparent from WININETHANDLERHEADER. 2006-10-30 11:36:02 +01:00
Jacek Caban 550ffef212 wininet: Store WININETFTPSESSIONW pointer in WININETFTPFILEW. 2006-10-30 11:35:56 +01:00
Jacek Caban 51ba292716 wininet: Store WININETFTPSESSIONW pointer in WININETFTPFINDNEXTW. 2006-10-30 11:35:43 +01:00
Jacek Caban 91312d7d57 wininet: Move ftp FindNextFile implementation to ftp.c. 2006-10-30 11:35:36 +01:00
Jacek Caban 2a50d52c04 wininet: Use lpAppInfo instead of lpwhparent where possible. 2006-10-30 11:35:18 +01:00
Jacek Caban 96c0c6c5d9 wininet: Store WININETAPPINFOW pointer in WININETFTPSESSIONW. 2006-10-30 11:35:09 +01:00
Jacek Caban 61a1cef6f6 wininet: Use lpHttpSession instead of lpwhcalback where possible. 2006-10-30 11:34:58 +01:00
Jacek Caban a9bdc01e19 wininet: Store pointer to WININETHTTPSESSIONW in WININETHTTPREQUESTW. 2006-10-30 11:34:51 +01:00
Jacek Caban a541a44f51 wininet: Use lpAppInfo instead of lpwhparent where possible. 2006-10-30 11:34:41 +01:00
Jacek Caban c250617d88 wininet: Store WININETAPPINFOW pointer in WININETHTTPSESSIONW. 2006-10-30 11:34:21 +01:00
Jacek Caban cdbab7ddf2 wininet: Fixed declaration of INTERNET_STATUS_CALLBACK. 2006-10-30 11:17:24 +01:00
Francois Gouget 9fe4673347 Don't include windows.h & co in the Wine sources.
Remove uneeded COM_NO_WINDOWS_H defines.
2006-10-24 17:47:09 +02:00
Mikołaj Zalewski 58bd35c8c5 resources: Change Dutch sublanguage code to SUBLANG_NEUTRAL. 2006-10-24 17:45:51 +02:00
Mikołaj Zalewski e32aa55703 resources: Change German sublanguage code to SUBLANG_NEUTRAL. 2006-10-24 11:45:12 +02:00
Jacek Caban cc7a86ec7e wininet: Use HTTP_ADDHDR_FLAG_REPLACE flag in HTTP_HttpSendRequest to add Content-Length header. 2006-10-23 12:28:58 +02:00
Francois Gouget 0a20f18a80 wininet: HttpSendRequestW() returns ERROR_IO_PENDING when called on an async socket. But that does not mean that it failed. 2006-10-20 14:10:41 +02:00
Byeong-Sik Jeon e1fd734c97 Korean: Use SUBLANG_NEUTRAL in Korean resources. 2006-10-20 13:49:39 +02:00
Hans Leidekker 781f3f78a0 wininet: Cast-qual warnings fix. 2006-10-14 20:16:49 +02:00
Andrew Talbot c54a2480ec wininet/tests: Cast-qual warning fix. 2006-10-06 12:32:51 +02:00
Hans Leidekker cd2c458588 wininet: Win64 printf format warning fixes. 2006-10-05 17:45:14 +02:00
Hans Leidekker de3b5be338 wininet/tests: Win64 printf format warning fixes. 2006-10-05 17:45:09 +02:00
Michael Stefaniuc 85ce5117c5 Add a WINE_NO_LONG_INT define to many makefiles to ease the transition of DWORD/LONG/ULONG from long to int. 2006-09-29 16:08:30 +02:00
Alexandre Julliard c56eec22e2 wininet/tests: Don't fail the tests if the network is unreachable. 2006-09-21 12:44:56 +02:00
Alexandre Julliard 32ab895e46 makefiles: Generate the dependencies line to avoid some code duplication. 2006-09-14 09:38:16 +02:00
Jan Zerebecki 91bbec013b wininet: Fix fd leak on failure case. 2006-09-07 16:11:15 +02:00
Alexandre Julliard 5cf75e615a makefiles: Only run test and documentation targets in directories that need them. 2006-08-28 13:37:44 +02:00
Andrew Talbot 5ea47faf8b wininet/tests: Write-strings warnings fix. 2006-08-11 11:56:16 +02:00
Paul Chitescu 8b1b381872 wininet: MSG_WAITALL support in NETCON_recv with SSL. 2006-08-10 10:54:12 +02:00
Ulrich Czekalla f6c0a461ec wininet: Add INTERNET_OPTION_SECURITY_FLAGS stub to InternetSetOptionW. 2006-08-07 20:00:03 +02:00
James Hawkins 8c6040fccc wininet: Only copy the relative filename into the UrlEntry structure. 2006-07-29 11:51:21 +02:00
Paul Vriens 5a086a5210 wininet: FTP_FtpDeleteFileW expects a LPWININETFTPSESSIONW. 2006-07-20 12:11:34 +02:00
Paul Vriens 5ede40ab5d wininet: FTP_FtpRenameFileW expects a LPWININETFTPSESSIONW. 2006-07-19 18:16:02 +02:00
James Hawkins a1544731db wininet: Add more tests for InternetCrackurl. 2006-07-17 13:46:11 +02:00
Alexandre Julliard eb8a40c368 libs: Merged libwine_unicode into libwine.
Most dlls use libwine_unicode at this point, so there's nothing to
gain by having two separate libraries.
2006-07-11 19:33:22 +02:00
Alexandre Julliard 77dc0d9be5 .gitignore: Added wildcards to ignore generated resource files. 2006-07-10 21:39:00 +02:00
Alexandre Julliard 0fa8baafcb make_dlls: Recursively ignore .ok files in all tests directories. 2006-07-10 21:26:50 +02:00
Alexandre Julliard edd100b899 make_dlls: Recursively ignore testlist.c in all tests directories. 2006-07-10 21:19:42 +02:00
Alexandre Julliard 5258e061dc make_dlls: Ignore generated import libraries from the top-level .gitignore. 2006-07-10 20:55:58 +02:00
Alexandre Julliard cc2b3b48e6 Take advantage of the recursive nature of .gitignore for Makefile entries.
Prefix other entries with '/' to make them non-recursive.
2006-07-10 20:47:54 +02:00
Paul Vriens 3a831bab51 wininet: Use correct way of determining the password for anonymous ftp. 2006-07-07 16:57:34 +02:00
Paul Vriens 7687e0477c wininet: Return NULL handle if no connection is established. 2006-07-06 16:07:38 +02:00
James Hawkins 545309c97f wininet: Error out if hInternet is a bad handle. 2006-07-06 12:05:09 +02:00
James Hawkins 8e96015ebb wininet: Use a blank password if none is provided in FTP_Connect. 2006-07-06 12:04:35 +02:00
Andrew Talbot cf371a1ef8 wininet/tests: Write-strings warnings fix. 2006-06-21 11:15:28 +02:00
Mike McCormack 39c905f6d0 wininet: Make sure to null terminate a string before copying it. 2006-06-19 20:53:31 +02:00
Alexandre Julliard 68e4cf4a0b wininet/tests: Use lstrlenA instead of strlen in ok() to avoid printf format warnings. 2006-06-13 13:58:30 +02:00
Alexandre Julliard 9936feef07 include: Make the Dll* entry points hidden. 2006-06-12 16:18:01 +02:00
Phil Lodwick 3575918411 wininet: ftp: Fix crash if input buffer is larger than MAX_PATH. 2006-06-08 10:17:41 +02:00
Phil Lodwick 5ea41cc5fb wininet: ftp: 125 is an acceptable response code for the STORE command. 2006-06-08 10:17:27 +02:00
Mike McCormack 24b886d916 wininet: Simple tests for InternetGetCookie's parameters. 2006-06-02 20:44:11 +02:00
Mike McCormack 68d18612a0 wininet: Fix up and test InternetSetCookie parameter checking. 2006-06-02 20:44:04 +02:00
Mike McCormack 7b3cf21dc1 wininet: Remove some dead code (Coverity). 2006-06-02 20:43:58 +02:00
Mike McCormack 739cd1ea32 wininet: Don't crash when querying NULL values. 2006-05-30 19:29:52 +02:00
Mike McCormack 8af1faec24 wininet: Add a test for basic authentication. 2006-05-30 19:29:48 +02:00
Andrew Ziem 7053321926 wininet: Constify data. 2006-05-25 11:01:06 +02:00
Mike McCormack e480b6d07d wininet: Fix a possible NULL pointer deference. 2006-05-24 14:37:05 +02:00
Jonathan Ernst 360a3f9142 Update the address of the Free Software Foundation. 2006-05-23 14:11:13 +02:00
Robert Shearman d4245634ca wininet: Fix a failing test. 2006-05-23 11:36:41 +02:00
Mike McCormack 854808d9d4 wininet: Add a standalone http test. 2006-05-16 20:21:34 +02:00
Mike McCormack 8dcb4479f3 wininet: Make sure hIC is valid before trying to use it. (Coverity) 2006-05-16 20:21:28 +02:00
Mike McCormack 2eec6b04c0 wininet: Return correct errors in InternetOpenUrlW. 2006-05-16 12:40:31 +02:00
Mike McCormack f57360af52 wininet: Return correct errors in InternetConnectW 2006-05-16 12:40:23 +02:00
Mike McCormack 746bf215e0 wininet: Remove broken code for HTTP_QUERY_FLAG_COALESCE, which is unimplemented according to MSDN. 2006-05-15 11:04:50 +02:00
Mike McCormack 35f0965c43 wininet: Check for null parameters in FtpSetCurrentDirectoryW. 2006-05-15 11:04:32 +02:00
Mike McCormack a27eee868e wininet: Fix a typo (spotted by Coverity). 2006-05-11 12:10:20 +02:00
Michael Stefaniuc a87520036f janitorial: Remove redundant NULL pointer checks before HeapFree'ing them.
Some HeapFree's are hidden behind macros. Found by smatch.
2006-05-10 11:31:41 +02:00
Robert Shearman 64ff0e54a3 wininet: Initialise the LPWITHREADERROR structure after it has been allocated. 2006-05-05 16:35:48 +02:00
Mike McCormack c1dce86f1f wininet: Fix peeking of http data with a nul byte in it. 2006-05-05 16:33:30 +02:00
Robert Shearman d133ff9afb wininet: Don't allocate memory for the thread error structure until it is needed.
Don't allocate memory for the thread error structure until it is
needed, as it is quite large and wastes memory for threads that don't
call any wininet function.
2006-04-20 15:16:52 +02:00
Antonio Codazzi 33a232a4a2 wininet: Added Esperanto language. 2006-04-11 11:31:02 +02:00
Antonio Codazzi f2d320b0a6 wininet: Italian language update. 2006-04-11 11:26:30 +02:00
Robert Shearman c564ee826f wininet: Fix some string length calculations.
Fix some string length calculations that didn't account for the
different sized characters with Unicode.
2006-03-30 21:55:37 +02:00
Robert Shearman 4f40f17226 wininet: Only access the URL in the cache by the provided offset. 2006-03-30 21:55:29 +02:00
Mike McCormack 92ddc1c851 wininet: Clean up HTTP_GetCustomHeaderIndex. 2006-03-30 12:41:04 +02:00
Mike McCormack 7f5e273214 wininet: Use a lookup table sorted by index so we don't need a loop to do lookups. 2006-03-30 12:40:47 +02:00
Mike McCormack ae300883fa WININET: Clean up HttpQueryInfo.
Fixes another return FALSE without SetLastError.
2006-03-30 12:40:05 +02:00
Mike McCormack 2571fa004a wininet: Make sure to set LastError when returning FALSE in HttpQueryInfo. 2006-03-30 12:38:14 +02:00
Francois Gouget 6bddeb1cf7 Assorted spelling fixes. 2006-03-21 20:10:39 +01:00
Robert Shearman dc03c0e3f3 wininet: Document InternetCrackUrlW. 2006-03-21 16:19:06 +01:00
Robert Shearman 80e4fb5975 wininet: InternetCreateUrlW should return the number of bytes needed.
InternetCreateUrlW should return the number of bytes needed to store
the URL, not the number of characters (reported by Sven Paschukat).
2006-03-21 16:19:06 +01:00
Robert Shearman 15a7d3b2b4 wininet: Copy from the start of the cookie name, not the cookie data.
Copy from the start of the cookie name, not the cookie data when
parsing cookies with a NULL cookie name.
2006-03-20 12:01:25 +01:00
András Kovács a2a4029e40 wininet: Added Hungarian translation. 2006-03-15 11:34:10 +01:00
Robert Shearman 74cb03247d wininet: Move URL-related tests to a separate file. 2006-03-14 18:49:19 +01:00
Robert Shearman 366fc247fc wininet: Make InternetCrackUrlW set the components related to net_loc
to NULL when net_loc isn't present in the input URL.
2006-03-14 17:51:51 +01:00
Robert Shearman 153aac0194 wininet: Move cookie-related stubs to cookie.c 2006-03-14 17:51:31 +01:00
Robert Shearman 5b5d45586e wininet: Implement setting of send and receive timeouts. 2006-03-14 17:50:41 +01:00
Robert Shearman 0252e5e875 wininet: Fix the conversion of NULL component values from InternetCreateUrlA. 2006-03-13 13:33:03 +01:00
Robert Shearman f18305b176 wininet: Host name isn't present when two slashes aren't present in InternetCrackUrl.
The test for "about:" in InternetCrackUrlW should be more general so
that only URLs without double slashes should also be assumed not to
have a host name.

Add another test for this case and remove an unreliable
InternetCreateUrl test.
2006-03-13 13:32:45 +01:00
Robert Shearman ae677d356c wininet: InternetCrackUrl should set nPort to the default port if not specified. 2006-03-13 13:32:20 +01:00
Robert Shearman ef20936c53 wininet: Don't duplicate empty strings. 2006-03-10 21:40:57 +01:00
Robert Shearman 1b8f7f0605 wininet: Fix InternetGetCookie with no matching cookies.
Return FALSE and an error of ERROR_NO_MORE_ITEMS from
InternetGetCookie when there are no cookies for the specified
domain. This fixes a bug in sending a blank cookie to HTTP servers.
2006-03-09 22:48:08 +01:00
Robert Shearman e4adc07333 wininet: Fix an off-by-one error in InternetCreateUrlW.
Fix an off-by-one error in the size of buffer used to store the port
number in InternetCreateUrlW.
2006-03-09 22:47:50 +01:00
Robert Shearman b0fcaf9d48 wininet: Further InternetCreateFileW fixes.
- Add the slash after the port number.
- Only add the port number if the host name is present.
2006-03-09 22:47:35 +01:00
Robert Shearman d3047aaeba wininet: If necessary, add a slash between the hostname and path in
InternetCreateUrlW.
2006-03-09 22:47:16 +01:00
Robert Shearman 8eab78c235 wininet: More InternetCreateUrlW fixes.
- Don't add double slashes for opaque URLs.
- The default port number for all other schemes is 0.
2006-03-09 22:47:00 +01:00
Robert Shearman e58a448c4a wininet: Parse the scheme the string in InternetCreateFileW.
Parse the scheme the string in InternetCreateFileW and rewrite
url_uses_default_port using schemes instead of strings.
2006-03-09 22:46:45 +01:00
Robert Shearman 02839948d2 wininet: Get the string for the scheme if specified only by the
INTERNET_SCHEME enumeration in InternetCreateUrlW.
2006-03-09 22:46:30 +01:00
Robert Shearman 01219c65aa wininet: The host name is optional in InternetCreateUrlW. 2006-03-09 22:46:07 +01:00
Robert Shearman ed90c868a9 wininet: Use an array of schemes for mapping from a string to an INTERNET_SCHEME.
Use an array of schemes so that it can be re-used for mapping from
INTERNET_SCHEME back to a string and simplify the code in
GetInternetSchemeW.
2006-03-09 22:45:56 +01:00
Robert Shearman e2b7bc1efd wininet: Fix Trace in InternetCreateUrl.
The url passed in to InternetCreateUrl is an out parameter, so don't
dump it.
2006-03-09 22:45:26 +01:00
Robert Shearman 0590025e3c wininet: Fix redirects with relative URIs instead of absolute URIs. 2006-03-09 22:45:18 +01:00
Robert Shearman 414d1ddeb9 wininet: Rewrite InternetCreateUrlW.
- Rewrite InternetCreateUrlW to respect the lengths passed in via the
  URL_COMPONENTS structure and fall back to a strlenW call when a
  length is zero.
- Expand the number of protocols supported when determining whether
  the port number should be added.
- Fix a test by passing in the correct length of scheme.
2006-03-06 20:00:53 +01:00
Robert Shearman 9981f337e3 wininet: Don't continue to connect to a secure server without SSL support since it won't work.
Don't continue to connect to a secure server without SSL support since
it won't work. Return an error back to the application instead.
2006-03-06 20:00:21 +01:00
Robert Shearman 8bfc85957a wininet: More tests for InternetCreateUrl.
Fix an InternetCreateUrl test so that it correctly sets the scheme
length and add tests which show the behaviour when the lengths are set
to zero and when the https scheme is used.
2006-03-06 20:00:08 +01:00
Victor Pelt 472ad3a450 wininet: Add stub for missing InternetSetOption. 2006-03-06 19:56:21 +01:00
Juan Lang 89529f8a8e wininet: Use CertNameToStr for INTERNET_OPTION_SECURITY_CERTIFICATE_STRUCT
and update comment.
2006-02-16 12:19:00 +01:00
Robert Shearman 7a2357a480 wininet: Documentation fixes. 2006-02-14 11:34:14 +01:00
Petr Tesarik 3a9b7b4b17 wininet: Czech language resources encoding fix. 2006-02-13 13:28:37 +01:00
Dmitry Timoshkov 03434c728e wininet: Fix InternetQueryOption test to pass under Windows. 2006-02-06 20:59:21 +01:00
Vijay Kiran Kamuju 7660614b0d wininet: Add tests for InternetQueryOption. 2006-02-06 14:12:22 +01:00
Eric Pouech e66e227dbe Fixes for missing prototypes warnings. 2006-02-06 13:13:28 +01:00
Fatih Aşıcı 7578e31735 wininet: Turkish translation. 2006-02-06 13:06:49 +01:00
Aric Stewart 8b0883576e wininet: INTERNET_OPTION_SECURITY_CERTIFICATE_STRUCT work.
Beginning of framework to implement handling of InternetQueryOption
for INTERNET_OPTION_SECURITY_CERTIFICATE_STRUCT.
2006-01-20 20:16:56 +01:00
Aric Stewart 21712d3d15 wininet: Handle NULL lpBuffersIn in HttpSendRequestExW. 2006-01-13 13:52:38 +01:00
Jacek Caban ad02317248 wininet: lpvStatusInfo in INTERNET_STATUS_NAME_RESOLVED,
INTERNET_STATUS_CONNECTING_TO_SERVER and
INTERNET_STATUS_CONNECTED_TO_SERVER should be strings, not
sockaddr_in.
2006-01-05 14:37:06 +01:00
Robert Shearman 7b4b4b7930 wininet: Handle the cache being full better in CommitUrlCacheEntryInternal.
Move the freeing of allocation blocks for an entry into
URLCache_DeleteEntry.
Call URLCache_DeleteEntry to rollback from failure in
CommitUrlCacheEntryInternal.
2005-12-31 13:21:19 +01:00
Robert Shearman 13f2ce26dd wininet: Create new hash tables for URL cache on demand. 2005-12-31 13:20:54 +01:00
Robert Shearman 2ceb052496 wininet: Move URL cache hash table creation to a separate function. 2005-12-31 13:20:29 +01:00
Aric Stewart 1e946d3e14 wininet: HTTP headers reworking.
Redo how headers are handled, eliminating the concept of Standard
Headers and allow all headers to be added multiple times.
Allow querying of headers with an index to get the multiple headers.
Respect response vs request headers in HttpQueryInfo.
Add a number of tests to extensively test header adding and replacing.
2005-12-13 17:07:41 +01:00
Marcus Meissner 73893a74fd wininet: Reinitialise NETCON on redirect. 2005-12-13 11:12:09 +01:00
Aric Stewart 7bca41a739 wininet: Handle HTTP_QUERY_CUSTOM.
In HttpQueryInfo if dwInfoLevel includes HTTP_QUERY_CUSTOM then
lpBuffer is In/Out because the header we are querying is there.
Additionally standard headers can be queried in this manner as well
(such as Set-Cookie).
2005-12-08 12:44:45 +01:00
Aric Stewart d30cec77d3 wininet: A->W bugfix.
When converting SendRequestExA -> W we need to set the lpcszHeader
parameter to NULL if the original one is NULL.
2005-12-08 11:54:24 +01:00
Patrick Ammann d437f37f58 wininet: compilation fix
- make netconnection.c compile when HAVE_OPENSSL_SSL_H or 
HAVE_OPENSSL_ERR_H are not defined.
2005-12-05 12:01:56 +01:00
Robert Shearman efd067f2c3 wininet: Correctly set the last error when a called Unix network
function fails.
2005-12-03 18:10:14 +01:00
Robert Shearman 067f09604a wininet: global function/data cleanup
Make some functions and a structure static since they are only used in
one file.
2005-12-03 18:03:08 +01:00
Robert Shearman 1e5153cf3c Cleanup SSL connections properly, do a few security checks in
NETCON_secure_connect and display errors from SSL on failure. Don't
use SSL_set_bio as SSL_set_fd is cleaner for us.
2005-12-01 11:18:43 +01:00
Robert Shearman 03aea8c1b1 Test the behaviour of HttpSendRequestEx when putting data into the
lpvBuffer.
2005-11-30 12:31:38 +01:00
Robert Shearman f6252cf43e Remove duplicated code by modifying HTTP_HttpSendRequest so that it
can be used by both HttpSendRequest and HttpSendRequestEx.
Also allow HttpSendRequestEx to be used asynchronously.
2005-11-30 12:31:22 +01:00
Robert Shearman dc5f1cbd5d Remove call to StrCatW by passing in NULL for lpszExtraInformation in
the call to InternetCrackUrl, which concatenates the params onto the
path.
Some other minor cleanups.
2005-11-30 12:01:50 +01:00
Robert Shearman 4350357634 HttpSendRequestExA/W doesn't touch lpBuffersIn->Next, so simplify the
code a bit.
Modify test case to demonstrate this.
2005-11-29 11:42:23 +01:00
Robert Shearman 8a8ce9c4c7 More lpszServerName -> lpszHostName fixes. 2005-11-29 11:35:19 +01:00
Robert Shearman efac01b525 Fix redirects from secure to non-secure and vice versa. 2005-11-29 11:25:31 +01:00
Robert Shearman de2666fd5f Change all SendAsyncCallback calls into the synchronous
INTERNET_SendCallback where INTERNET_FLAG_ASYNC is already handled
properly.
2005-11-29 10:44:05 +01:00
Ge van Geldorp 1a1583a364 Match PSDK STATUS_* definitions. 2005-11-28 17:32:54 +01:00
Aric Stewart 1fc760d4a7 Allow HttpEndRequest to process 302 and 301 redirects. Append Host
port if non standard on the redirect host header and make sure to
append the extra information (parameters) and such to the location if
present.  Additionally check to see if we are redirecting to https and
if so set the appropriate port.
2005-11-28 17:31:02 +01:00
Robert Shearman 0e7c41e979 Add support for using secure (SSL/TLS) connections through a proxy
server.
2005-11-28 11:55:16 +01:00
Robert Shearman 13d371da54 Move the initiation of the SSL connection into a separate function. 2005-11-28 11:54:31 +01:00
Robert Shearman 3592110af7 Add a host port field that preserves the requested port of the
destination URL.
2005-11-28 11:53:05 +01:00
Robert Shearman cc44f3a5c7 Fix "http://" prefix detection on the proxy URL. 2005-11-28 11:31:11 +01:00
Robert Shearman 0adec2b3dc Replace some useless checks in HTTP_AddProxyInfo with asserts. 2005-11-28 11:28:06 +01:00
Robert Shearman 225a9facd4 Simplify and fix Set-Cookie handling. 2005-11-28 11:24:41 +01:00
Robert Shearman 22edb3e99e Simplify HTTP_InsertProxyAuthorization. 2005-11-28 11:17:06 +01:00
Robert Shearman 8c8c81a1ef Change some SendAsyncCallback calls to INTERNET_SendCallback as the
tests show that the callbacks happen either synchronously or within an
alternative asynchronous call.
Remove a check for a NULL lpfnStatusCB that is already performed by
INTERNET_SendCallback and add a comment about a difference to native.
2005-11-28 11:00:18 +01:00
Robert Shearman 29a436fd87 Add parsing of the Content-ID and Proxy-Connection headers.
Sort the table of header to option number mappings correctly.
Change a FIXME to a WARN because there are "X-..." headers that we
aren't supposed to parse.
2005-11-28 11:00:05 +01:00
Robert Shearman 7bb3463166 Add a new field "lpszHostName" to the session to track the host name
of the HTTP server, as opposed to the server that we will connect to
that could be a proxy server. Fixes the "Host:" header that we send to
servers.
2005-11-28 10:40:42 +01:00
Alexandre Julliard 0ec7e1a591 Renamed all .cvsignore files to .gitignore. 2005-11-26 13:10:33 +01:00
Francois Gouget 6d442aeb34 Assorted spelling fixes. 2005-11-23 20:14:43 +01:00
Francois Gouget d69268e77c Documentation tweaks to make winapi_check happy.
Also specify the documented spec file entry.
2005-11-23 20:14:04 +01:00
Aric Stewart ed0eba24f9 HttpEndRequest does not actually send an extra NULL byte at the end of
the request. Help from Rob Shearman on this one.
2005-11-22 16:18:48 +00:00
Aric Stewart 9e68c651d6 Fix some logic to allow HTTP_ADDREQ_FLAG_ADD to replace existing
headers. Also adding a test for some header adding flags.
2005-11-22 14:53:30 +00:00
Robert Shearman dece43d880 Test the sizes of some of the parameters passed into the callback. 2005-11-22 11:59:16 +00:00
Robert Shearman 756f197945 Rename SendAsyncCallback to INTERNET_SendCallback. 2005-11-22 11:59:07 +00:00
Robert Shearman b27457c91c Fix an incorrect entry in the HTTP header field table causing broken
Location field parsing.
2005-11-22 11:58:50 +00:00
Aric Stewart be918f48b6 Implement HttpSendRequestEx and HttpEndRequest. Restructure, breaking
some things out of HTTP_SendRequestW to avoid duplicate code.
2005-11-21 15:17:55 +00:00