ReceiveTempSMS
/
Sweden-Number
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

wininet: Fix up and test InternetSetCookie parameter checking.

This commit is contained in:
Mike McCormack 2006-06-02 19:49:09 +09:00 committed by Alexandre Julliard
parent 7b3cf21dc1
commit 68d18612a0
2 changed files with 34 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
dlls/wininet/cookie.c
View File

@ -402,9 +402,9 @@ BOOL WINAPI InternetSetCookieW(LPCWSTR lpszUrl, LPCWSTR lpszCookieName,
TRACE("(%s,%s,%s)\n", debugstr_w(lpszUrl),
debugstr_w(lpszCookieName), debugstr_w(lpCookieData));
if (!lpCookieData || !strlenW(lpCookieData))
if (!lpCookieData)
{
TRACE("no cookie data, not adding\n");
SetLastError(ERROR_INVALID_PARAMETER);
return FALSE;
}
if (!lpszCookieName)

32
dlls/wininet/tests/internet.c
View File

@ -123,6 +123,9 @@ static void test_null(void)
{
HINTERNET hi, hc;
static const WCHAR szServer[] = { 's','e','r','v','e','r',0 };
static const WCHAR szEmpty[] = { 0 };
static const WCHAR szUrl[] = { 'h','t','t','p',':','/','/','a','.','b','.','c',0 };
BOOL r;
hi = InternetOpenW(NULL, 0, NULL, NULL, 0);
ok(hi != NULL, "open failed\n");
@ -152,6 +155,35 @@ static void test_null(void)
ok(hc == NULL, "connect failed\n");
InternetCloseHandle(hi);
r = InternetSetCookieW(NULL, NULL, NULL);
ok(GetLastError() == ERROR_INVALID_PARAMETER, "wrong error\n");
ok(r == FALSE, "return wrong\n");
r = InternetSetCookieW(szServer, NULL, NULL);
ok(GetLastError() == ERROR_INVALID_PARAMETER, "wrong error\n");
ok(r == FALSE, "return wrong\n");
r = InternetSetCookieW(szUrl, szServer, NULL);
ok(GetLastError() == ERROR_INVALID_PARAMETER, "wrong error\n");
ok(r == FALSE, "return wrong\n");
r = InternetSetCookieW(szUrl, szServer, szServer);
ok(r == TRUE, "return wrong\n");
todo_wine {
r = InternetSetCookieW(szUrl, NULL, szServer);
ok(r == TRUE, "return wrong\n");
}
r = InternetSetCookieW(szUrl, szServer, szEmpty);
ok(r == TRUE, "return wrong\n");
r = InternetSetCookieW(szServer, NULL, szServer);
todo_wine {
ok(GetLastError() == ERROR_INTERNET_UNRECOGNIZED_SCHEME, "wrong error\n");
}
ok(r == FALSE, "return wrong\n");
}
START_TEST(internet)