fc86392af8
Preserve A/W when creating propsheet dialogs.
2003-07-09 02:49:52 +00:00
4e1ef0c114
For all DLLs with defined DllMain and which do not require
...
DLL_THREAD_ATTACH/DLL_THREAD_DETACH notifications, call
DisableThreadLibraryCalls() in order to slightly improve performance
on thread creation/exiting.
2003-06-30 20:53:48 +00:00
de08661413
- Localization to Portuguese of Brazil
...
- Revision and addition of missing resources
- Minor typo fix and codepage fix in programs/winefile resource.
2003-06-30 20:22:35 +00:00
9591836ffb
'sizeof type' is best avoided as it won't always compile (e.g. 'int
...
main() {return sizeof int;}'). Use 'sizeof(type)' instead.
2003-06-18 19:45:22 +00:00
c5f775a9c7
Typos/spelling fixes.
2003-06-18 03:30:39 +00:00
d2b8e39b5c
- Unbreak vertical trackbars
...
- Make it more closely resemble the native control
- Add focus rectangle
- Misc fixes and cleanups
2003-06-16 19:39:27 +00:00
7614f27f3b
- Make button text centre correctly when dropdown arrow is present
...
- Centre dropdown arrow
2003-06-13 16:30:24 +00:00
36d0e2ba63
Align the text vertically in single line labels (spotted by BiGgUn).
2003-06-06 18:13:47 +00:00
bc9de0500e
Remove bFirstPain funky optimization, it is causing too much grief.
2003-06-04 20:19:11 +00:00
66855d4a22
Fix listview custom draw notification for CDDS_ITEMPREPAINT and
...
CDDS_SUBITEMPREPAINT messages.
2003-05-22 03:37:10 +00:00
f644c787ee
Update ordering on insertion of an item.
2003-05-22 03:34:54 +00:00
bb993e0127
Inserting column zero should not modify the main item (spotted by
...
Robert Shearman).
2003-05-21 18:25:10 +00:00
2c4fd4289c
New comctl32 test directory and test case for DPA_Search.
2003-05-15 23:58:48 +00:00
29ef801b40
DPA_Search: Handle DPAS_INSERTBEFORE on empty list.
2003-05-15 23:55:12 +00:00
d8d12a0bca
Revert change for resizing buttons.
2003-05-13 23:38:01 +00:00
535e0f6238
Fixed bad non-client calculation.
2003-05-13 22:05:50 +00:00
89e2766fc7
Fix DTM_SETSYSTEMTIME.
...
Make the show/hide button actually do something.
Add support for the 'yyyy' format.
2003-05-13 22:04:40 +00:00
32eb1c7354
Get rid of direct ImageList access hacks.
2003-05-13 03:36:54 +00:00
e43edbd557
Rearrange members of HIMAGELIST to match Windows.
...
Reuse image and mask DCs.
2003-05-13 03:36:27 +00:00
c00aa9985a
Fix use of freed memory.
2003-05-13 00:30:10 +00:00
130e21795c
Fixed a possible memory corruption.
...
Fixed a memory leak.
2003-05-12 03:19:35 +00:00
442dd75420
Implemented Get/SetToolTips functions.
2003-05-11 03:44:13 +00:00
dd74d9d889
Ordinals 410-413 are the window subclassing functions.
2003-05-11 03:40:59 +00:00
c6e988eaa0
Fix custom draw for item 0.
2003-05-11 03:29:25 +00:00
5594fcea74
Invalidate the window when the range is changed.
2003-05-11 02:38:05 +00:00
97b7bc1984
Added a lot of Russian translations.
2003-05-04 02:33:08 +00:00
a982259e3e
When items are inserted in a partially populated treeview, the first
...
visible item was not correctly updated.
The first visible item was sometimes used to calculate the location of
other items when it had been freed.
2003-05-02 20:15:36 +00:00
06d610ec9b
Check the mask flags in the item structure to determine how much
...
memory to read/write.
2003-05-02 20:14:33 +00:00
266a2f297e
Change return code comparison in AVI control (from patch by
...
stanleyg76@yahoo.com ).
2003-04-30 23:59:46 +00:00
0485fc19b6
Fix bounding rectangle computation for an ownerdraw tab.
2003-04-30 00:50:26 +00:00
dfdeaaf922
Generate custom draw notifications for ownerdraw listviews (based on a
...
patch by Maxime Bellengé).
Reorganize the custom draw code for better reuse.
2003-04-30 00:49:44 +00:00
8410e71fb5
Implemented message TCM_SETPADDING with the Dimitri's advice.
2003-04-27 20:34:30 +00:00
dcaf137736
Fix the computation of the trackbar's size.
2003-04-27 00:31:06 +00:00
5b44c77fb4
Remove the sending of NM_TOOLTIPSCREATED which is non existent under
...
Windows during the creation of the trackbar.
2003-04-26 02:07:43 +00:00
4bddbe8b19
Fix buffer overflow in datetime.
2003-04-02 23:25:01 +00:00
9e3772f699
Zero initialize the reserved bytes in the toolbar details returned by
...
TOOLBAR_GetButton().
2003-04-02 23:19:45 +00:00
1420acef09
Fix ImageList_Read - the root cause of ugly toolbar icons.
2003-04-02 23:18:17 +00:00
d0300d92e3
TreeView should not send two click notifications when bTrack is true.
2003-03-27 00:00:42 +00:00
b27587dd0a
TREEVIEW_GetItemA should ignore stateMask.
2003-03-26 23:35:50 +00:00
044a353161
Correct the check for changed treeview items, so item sets repaint
...
properly.
2003-03-26 01:22:10 +00:00
a50bd8117f
Send LVN_ODCACHEHINT notification for LVS_OWNERDATA style in all modes
...
(based on a patch by Vitaliy Margolen).
2003-03-24 19:28:50 +00:00
114a31a2a8
Take advantage of new winebuild syntax to remove redundant function
...
names in spec files.
2003-03-20 03:53:12 +00:00
cd4234aa49
Documentation updates.
2003-03-18 18:35:48 +00:00
c7b1874b54
Fix the tab height so the labels don't clip, and restore the offset
...
constant to what it was before.
2003-03-17 04:43:26 +00:00
22813d4634
Fix a typo.
2003-03-17 04:43:05 +00:00
eded087e4e
Changes for Icon and SmallIcon modes:
...
- fix typo causing wrong scroll boundaries
- reverse mouse wheel scroll directions
- fix navigation with keyboard when auto arranged
2003-03-15 00:05:46 +00:00
d39af613a3
Spacing information is signed (debugged and fixed by Vitaliy
...
Margolen).
Decode spacing information in the window procedure.
Some spelling fixes.
2003-03-14 22:58:22 +00:00
7ce3a5ad63
Replace DPRINTF with TRACE.
2003-03-14 04:11:17 +00:00
c6914b202a
- Reduced tab offset constant slightly to avoid clipping the label.
...
- Prevent label overdraw of updown control by reducing the width of
the invalidated region.
2003-03-12 20:14:12 +00:00
6b2d22a0f6
It's not just height that can be set to the default by passing zero to
...
TCM_SETITEMSIZE, but also width.
2003-03-10 19:04:13 +00:00
a4944ff123
TOOLBAR_AddBitmap() and TOOLBAR_ReplaceBitmap() are not supposed to
...
modify the bitmap - we call ImageList_AddMasked() which turns all
masked pixels black. Fixed by making a copy of the bitmap to give to
ImageList_AddMasked().
2003-03-07 23:02:46 +00:00
64eff97f51
When shifting the list's indices, we must not send notify messages if
...
we have to refocus. Item modification handlers are not supposed to be
called here.
2003-03-07 20:35:30 +00:00
1af319d9e2
PROPSHEET_CreateDialog() is documented to return -1 on failure, and
...
the dialog handle on success.
2003-03-07 20:29:58 +00:00
e295d3996e
Janitorial. Get rid of W->A call.
2003-03-06 22:43:43 +00:00
292d8429ab
TREEVIEW_UpdateScrollBars() now copes with an empty tree.
2003-03-06 22:41:59 +00:00
e6af4ec6bd
Fix invisible tabs in TabControls with fixed tab width.
2003-03-04 04:34:03 +00:00
efa2b0c159
Accept either TVI_ROOT or NULL for the parent to imply sort the entire
...
tree.
2003-02-25 03:59:12 +00:00
745a78f490
Remove some unreachable code.
2003-02-24 20:48:45 +00:00
a89063e3dc
Added handling for PSNRET_INVALID in PSN_APPLY notification.
2003-02-24 20:40:45 +00:00
65a9f4daac
Support the undocumented behavior of deleting column zero.
2003-02-14 23:31:45 +00:00
00ccf38987
Correctly remember the first paint event, but delay item metrics
...
calculation until we actually have some items.
2003-02-14 19:24:11 +00:00
820157b836
Avoid warnings caused by assert(...).
2003-02-12 21:28:04 +00:00
15e0657f6b
Compute matrix of first paint when we actually have some items
...
(problem first spotted & debugged by Duane Clark).
2003-02-11 22:17:31 +00:00
43690e9e47
Removed no longer needed inclusion of heap.h.
2003-01-24 00:54:58 +00:00
9b0b1e078a
Remove (POINTER)NULL casts.
2003-01-14 23:43:41 +00:00
0fd521fee3
Change RECT to use LONG to match win32 standard headers and fix format
...
strings to use %ld for RECT elements.
2003-01-08 21:09:25 +00:00
297f3d898d
Define NONAMELESS{STRUCT,UNION} explicitly in the files that need them.
2003-01-07 20:36:20 +00:00
b4a4c05aed
Removed a few more #ifdef __WINE__.
2003-01-04 00:19:17 +00:00
cef5961d2b
Eliminate lots of __WINE__ conditionals from the headers.
2003-01-03 19:12:55 +00:00
5e36ae56b2
Check the value of the pfnCallback in addition to the callback bit.
2003-01-03 03:06:42 +00:00
fa93b446d0
Listview should scroll by at least one column, fixes bug where item
...
being wider than listview prevents any scrolling from occuring. Added
printing of the scroll code text during tracing of scroll functions.
2003-01-03 03:04:22 +00:00
0e162e4643
Let ANIMATE_OpenA return FALSE (= failure) upon a request to close a
...
previously opened AVI clip when there isn't one.
2003-01-02 17:54:23 +00:00
521aa7412d
Validate imagelists with christmas magic.
2003-01-02 17:51:13 +00:00
3d2e380244
Report mode padding tweaks.
...
Fix to LISTVIEW_GetSubItemRect.
2002-12-23 02:02:06 +00:00
6c79930413
Add config.h/port.h to allow compilation/linking in MSVC.
...
Fix some unsigned/signed warnings.
2002-12-16 22:43:58 +00:00
096becedd8
Implemented StrStrIW.
2002-12-13 23:25:59 +00:00
4f7ec6335c
Typo found by compiling with standard MSVC warning level.
2002-12-13 00:35:44 +00:00
9c50730354
Get rid of generic notification support in comctrl32. The MS docs were
...
misleading in that all controls send these notifications. They don't.
2002-12-10 19:07:59 +00:00
5720007370
- Plug a bunch of memory leaks.
...
- Make ranges_destroy behave more like free().
- Fix messed up indentation from tabs set to 4 chars.
- Updated the documentation.
2002-12-10 19:07:27 +00:00
3db0008552
Define PSH_WIZARD97 (problem reported by jaymz@free.fr).
2002-12-06 23:19:54 +00:00
1f5315c80f
Make sure that no files except unknwn.h include wine/obj_base.h
...
directly.
2002-12-05 20:33:07 +00:00
18d029722f
Removed input.h, queue.h, spy.h and sysmetrics.h and moved their
...
contents to user.h.
Moved message.h and winproc.h to dlls/user.
2002-12-03 23:34:52 +00:00
d2667a4ce3
Removed unnecessary HANDLE typecasts.
2002-12-02 18:10:57 +00:00
d2e881d543
- Typesafe parameters from TREEVIEW_NotifyFormat.
...
- Rewrite TREEVIEW_NotifyFormat.
- Fix several invocations of TREEVIEW_SendTreeviewNotify.
2002-11-27 20:15:49 +00:00
1e6258fca5
Added the missing cx member to the MyDLGITEMTEMPLATEEX struct.
2002-11-25 02:45:19 +00:00
eb56d81956
LVN_GETDISPINFO seems to always be Ansi.
2002-11-25 01:11:11 +00:00
80a6620815
Added Simplified Chinese support.
2002-11-20 19:47:44 +00:00
bb0fd59674
Setting the horizontal scrollbar can change the values for the
...
vertical one so make sure we compute them separately.
2002-11-18 19:51:11 +00:00
0fe326c499
Use DeleteDC instead of DeleteObject to free HDCs (spotted by Dietrich
...
Teickner <Dietrich_Teickner@t-online.de>).
Clear the imagelist structure on deletion, as some stupid apps free
imagelists multiple times.
2002-11-18 19:45:22 +00:00
fbf98737d2
- Add support for multiple image lists.
...
- Add TBN_INITCUSTOMIZE notification.
- Correctly populate TBN_QUERYDELETE.
- Support TBN_GETBUTTONINFOW.
2002-11-13 21:21:03 +00:00
8d74ef1030
Check the return value of ImageList_GetImageInfo before adjusting the
...
size.
2002-11-13 19:39:09 +00:00
91befd6902
Fix some NULL dereferencing.
2002-11-11 22:19:42 +00:00
add721769b
Do not draw the text of the item being edited.
2002-11-06 22:32:00 +00:00
c6ff9064d0
Fix the 'jumping selection' bug ( #1108 ).
...
Misc small cleanups.
2002-11-06 22:01:56 +00:00
1e1313d54c
Made the dll entry point default to DllMain and removed most of the
...
'init' spec file declarations.
2002-11-04 23:53:41 +00:00
5347222b23
lParam was not properly sent in COMBOEX_DrawItem.
2002-10-31 22:02:47 +00:00
40dab82a13
Append columns with large column indices.
2002-10-31 22:01:33 +00:00
601a3abec1
Fix some types and function prototypes according to Platform SDK
...
definitions.
2002-10-31 01:04:39 +00:00
4bbd7b3e26
Fix some treeview notification codes between ANSI/Unicode mode.
2002-10-31 00:54:53 +00:00
d9310e76c4
Fix for listview wheelmouse message handling.
2002-10-29 23:08:33 +00:00
f9768f4792
Fixed font object leak in WM_SETFONT handler.
2002-10-29 21:28:37 +00:00
02af550a2a
Send the right notification code (A/W) depending on the Unicode
...
setting.
2002-10-29 21:25:35 +00:00
26a470e1f0
set_main_item: ignore meaningless bits in stateMask for LVS_OWNERDATA
...
instead of failing.
2002-10-28 21:21:42 +00:00
2d2e6acbbd
We should always have a main item in report mode.
2002-10-28 20:40:21 +00:00
7e12841030
Properly fill lParam in NMLISTVIEW.
2002-10-28 20:38:39 +00:00
173d40a493
Fix crash-inducing typo/thinko.
2002-10-28 20:38:03 +00:00
5574e750c5
Mark immutable objects as const. Fix inconsistent *-style.
2002-10-28 20:37:28 +00:00
f5221578f6
Add LVHITTESTINFO debug helper. More tracing.
2002-10-28 20:36:52 +00:00
17b97eb929
Despite what the docs say, we have to invalidate the list on
...
WM_SETREDRAW(TRUE).
2002-10-28 20:36:16 +00:00
ccc8f7dca9
Eliminate flicker when resizing, docs updates.
2002-10-28 20:35:44 +00:00
19a1c42386
Cleanup, and simplification of UpdateSize.
2002-10-28 20:35:09 +00:00
9a9fcab763
Handle focus item properly in SetItemCount.
2002-10-28 20:34:34 +00:00
f9e70d8b81
Remove only the necessary selections when setting the item count.
2002-10-28 20:34:00 +00:00
28a2f193a3
Rewrite of the SetItemCount: bugs got squashed,
...
LVSICF_{NOSCROLL,NOINVALIDATEALL} implemented.
2002-10-28 20:33:18 +00:00
5803819971
lParam was not properly sent in TTM_ADDTOOLW.
2002-10-28 18:50:36 +00:00
392defd3ef
lParam was not properly sent in CBEN_GETDISPINFOW.
2002-10-28 18:50:14 +00:00
6e256c72fe
- fix some pselling
...
- enhance some TRACEs
2002-10-25 19:09:02 +00:00
5a11b009f1
Do not invalidate list on WM_SETREDRAW.
...
Update size info even if redrawing is disabled.
Trivial cleanups, and some tracing.
2002-10-25 03:21:25 +00:00
221398344e
We can avoid flicker on column resize only if it's left align.
2002-10-25 03:20:43 +00:00
fa5b29acd3
Always draw the main item in full row select.
2002-10-25 03:20:03 +00:00
f7441d00ed
Use iterators to render over the columns, in report mode.
2002-10-25 03:19:24 +00:00
863d6a87f5
Small iterator-over-range[s] cleanup.
2002-10-25 03:18:47 +00:00
83679e6b88
Eliminate most of the flicker when resizing columns.
...
More debug tracing.
2002-10-25 03:18:07 +00:00
ab97b86902
Fix subitem background color in full row select.
2002-10-25 03:17:36 +00:00
b14c82a8b8
We should callback for inexistent subitems.
...
Do not store callback items for subitems, even if we're asked to.
Small cleanup.
2002-10-25 03:17:04 +00:00
16db256923
Fix crash when computing the item width of a report with no columns.
...
Override custom draw bkgnd color for selection items.
Fill background for all items that have a bkgnd colour.
2002-10-25 03:16:26 +00:00
3520c83275
Keep autoarranging items until one is moved.
2002-10-25 03:15:51 +00:00
01e82f2b27
Abstract autoarranging decision to a helper function.
2002-10-25 03:15:18 +00:00
5b8361463d
Do not do screen work if refreshing is disabled.
...
Reimplement SetRedraw to cope with the changes.
2002-10-25 03:14:44 +00:00
c4e45d7f94
Rewrite the UpdateScroll function: simpler, faster.
...
Add debugging helper for SCROLLINFO.
Fix potential bug in debugging helpers.
2002-10-25 03:14:06 +00:00
89ab25a737
Avoid division by 0 by initializing the item size in on creation.
...
Rename update_icon_size to set_icon_size, fix parameters order.
Assorted cleanups.
2002-10-23 23:32:50 +00:00
5ffde298fe
Append to the end of the DPA, if insert index is too large.
2002-10-23 23:32:19 +00:00
9fa51e4172
Fixed duplicated arrows in header control.
2002-10-23 23:31:35 +00:00
b894605987
Fix thinko that slipped in with the prev patch (reenables refresh).
...
Mark a few things that needs looking at.
Small cleanup.
2002-10-23 22:32:25 +00:00
9cdcd44eaa
Do not invalidate the window before the first paint job.
...
Assorted cleanups.
2002-10-23 22:31:47 +00:00
f7051c88ae
Use InvalidateItem instead of explicit InvalidateRect, it is cleaner,
...
and faster when redraw is disabled.
2002-10-23 22:31:13 +00:00
c093196c05
Transform the invalidation macros to proper functions.
2002-10-23 22:30:39 +00:00
bf46fab650
Delay some size computations until after first paint.
2002-10-23 22:29:47 +00:00
7d9b04dbe2
Reorganize the item size calculation (a bit simpler, and faster).
2002-10-23 22:28:44 +00:00
1fd077939f
Search through all items when LISTVIEW_FindItemW is called with
...
LVFI_PARAM flag.
2002-10-23 22:28:03 +00:00
bf761a331c
Delete the items if we actually own them.
2002-10-23 22:25:42 +00:00
8f15b6e6b3
Do not callback to the parent for lParam when in LVS_OWNERDATA.
...
Docs update.
2002-10-23 22:25:10 +00:00
353529b2c8
- fix the "int format, HANDLE arg" type of warnings for comctl32
...
- compile the comctl32 dll with -DSTRICT
2002-10-23 22:19:10 +00:00
85e40cf37a
Add casts to compile with -DSTRICT.
2002-10-23 20:58:33 +00:00
5acd96bb4e
Do not crash if callback text is not filled (behave like native).
...
Render report mode from top to bottom (easier on the eye).
Docs updates, type fixes, more traces.
2002-10-23 20:57:13 +00:00
6608328f76
Collect all bugs, missing features, etc in the header doc.
...
Minor cleanups.
2002-10-23 20:56:30 +00:00
9ff0da09ff
Do not autoarrange if we insert/delete from the end of the list.
2002-10-23 20:55:05 +00:00
c5da549d10
Rework SetItemPosition, bunch of bugs squashed in the process.
...
Complete icon alignment rewrite: cleaner, incremental, etc.
Completely avoid aligning all icons on every insert
- icon placement is incrementally computed now: it's fast.
Small cleanups, docs update, etc.
2002-10-23 20:54:23 +00:00
c5e2731939
Rename LISTVIEW_ITEM to ITEM_INFO for consistency.
...
Rename LISTVIEW_SUBITEM to SUBITEM_INFO for same reason.
Fix type in comment spotted by Bobby Bingham.
2002-10-23 20:53:42 +00:00
cf07e10017
Don't use wine/unicode.h in the header files, include it directly
...
where needed instead.
2002-10-23 20:20:59 +00:00
f3d1893f80
Add needed casts for a "no warnings" compile of comctl32.
2002-10-23 20:19:22 +00:00
513eb2a24a
Collect all bugs, missing features, etc in the header doc.
2002-10-23 18:43:32 +00:00
d664540782
Bring header's height more inline with native's.
2002-10-22 00:41:45 +00:00
254e7484fa
DPAs can't have more than 0x8000 elements (fixed with lots of help
...
from Carlos <clozano@andago.com).
2002-10-21 19:54:06 +00:00
c7fbc1b2c9
No need to increment item size, it's already adjusted by DPA_SetPtr
...
(found, and fixed by Carlos <clozano@andago.com>).
2002-10-21 19:49:44 +00:00
6168b98176
Do not rely on HeapReAlloc to allocate a NULL pointer.
2002-10-21 19:49:12 +00:00
7888385d76
Rewrite DPA_InsertPtr in terms on DPA_SetPtr, so that it's simpler,
...
cleaner, and more correct.
It now expands the array to accomodate larger than current size
indexes.
2002-10-21 19:48:37 +00:00
a87b685350
Do not send uninitialized lParams on notification msgs (found by Rein
...
Klazes <rklazes@xs4all.nl>).
2002-10-21 19:46:46 +00:00
6deae0b86d
Complete rewrite of the rcView implementation.
...
Lots of bugs fixed in rcView computation.
Assorted cleanups, and simplifications.
2002-10-21 19:46:08 +00:00
c9e0133357
Split ranges_destroy in ranges_clear, and ranges_destroy.
...
Rewrite DeleteAllItems, for cleaner, faster, more correct code.
2002-10-21 19:45:29 +00:00
62f4c61d22
Updated header documentation to the latest, and greatest.
2002-10-21 19:44:51 +00:00
06701fb09e
Optimize invalidation on insert.
...
Share the invalidation code between {Delete,Insert}Item.
2002-10-21 19:44:18 +00:00
f18e271bff
Rewrite DeleteItemT: cleaner, a lot faster.
...
Number of bug were fixed.
The minimum possible is redrawn.
2002-10-21 19:43:37 +00:00
c859242ac8
Implement most of LVM_ARRANGE.
...
Make use of it, where it was appropriate.
Use infoPtr->dwStyle directly, in most places.
Assorted cleanups.
2002-10-21 19:43:03 +00:00
56c17651a0
Proper (type wise) return types.
2002-10-21 19:42:30 +00:00
214c721160
Reorganize header notifications.
...
Support notifications that don't have embedded size info.
Invalidate columns on format change (if needed).
Assorted cleanups.
2002-10-21 19:41:56 +00:00
713d0a061f
Crash on internal NULL pointers, don't test all over the place.
2002-10-21 19:41:00 +00:00
e37692bd33
When removing focus, no need to go through all elements.
2002-10-21 19:40:26 +00:00
feb326118f
Fix colors for selected items in full row select mode.
...
Fix bug caused by use of uninitialized state.
2002-10-21 19:39:45 +00:00
7c26e53ac0
Fix computation of subitem box, when invalidating it.
2002-10-21 19:34:38 +00:00
2223014df3
Assert on inconsistent range list states.
...
Various code cleanups, few potential bugs fixed.
2002-10-21 19:33:59 +00:00
074e2b4caa
Do not grow the item list to arbritary index: if requested index is
...
larger than current count, just append.
Miscellaneous cleanups.
2002-10-21 19:33:14 +00:00
be0641face
SetColumnWidth rewrite: simpler, cleaner code. Bugs squashed.
2002-10-21 19:32:38 +00:00
bf965278b5
Handle generic column width changes.
...
Fix bug in SetColumnT which rendered it unusable.
Column code cleanup.
2002-10-21 19:32:07 +00:00
0acaf0e961
Assert on internal invariants, rather than fail gracefully.
2002-10-21 19:31:34 +00:00
88c26b9c01
More docs compliant alignment handling for subitems.
2002-10-21 19:31:01 +00:00
f8514f5b3c
Fix notification from header, on item changed.
...
Small indentation fixes.
2002-10-21 18:22:51 +00:00
d126f4768c
Correct the behavior for disabled toolbar buttons.
2002-10-21 18:19:02 +00:00
0def1dd4e4
Do not create a range list for an empty range.
2002-10-19 19:26:17 +00:00
0613b7212a
Store the entire format bitmap in the column info.
...
Rewrite GetColumnT to take advantage of that.
Related cleanups, and simplifications.
2002-10-19 19:25:41 +00:00
569de03864
Column zero has the image enabled always, irrespective of format.
2002-10-19 19:25:01 +00:00
231e9ef25b
Unify {Insert,Set}ColumnT as much as possible.
...
Fix a bunch of problems in SetColumnT.
2002-10-19 19:24:24 +00:00
3893cb7fb2
Fix function header documentation.
2002-10-19 19:23:31 +00:00
e877b77a9d
Better report mode.
...
Use the new column information to simplify, and speed up the code.
Enable support for images in subitems (in LVS_REPORT mode).
2002-10-19 19:20:35 +00:00
0dbab63fa6
When deleting an item, remove selection, don't add it!
2002-10-19 00:59:34 +00:00
0ba3dc7589
More traces to help us make sense of the output.
...
Faster, cleaner ranges_{add,del}.
2002-10-19 00:21:02 +00:00
c79eb2de5f
Fix ranges insertion bug (specify DPAS_SORTED when searching).
...
Add a lot of assert-ed consistency checks.
Add bunch of trace messages.
2002-10-19 00:20:21 +00:00
a2dd8ecc33
Inspect style bits independently on style change.
2002-10-19 00:19:28 +00:00
b50692ee82
Rewrite StyleChanged procedure
...
o some bugs have been fixed
o cleaner, simpler code
Fix some corner case, icon size computation bugs.
Assorted docs updates.
2002-10-19 00:18:48 +00:00
323f9c23f0
Keep track of per-column information inside the listview.
...
Cache header rectangles.
Used the cached info instead of calling to the header each time.
Update the listview as we track column width changes.
Unify column handling between {Insert,Delete}Column, and width
changes.
Simplify RefreshReport, by using the new column info.
2002-10-19 00:18:11 +00:00
a72e9f617e
Do not query items that are just being inserted.
2002-10-19 00:17:24 +00:00
f8f559fa3c
Reorganize things a bit so that we no longer need the 'valid' flag on
...
each item.
Small comments update.
2002-10-19 00:16:37 +00:00
23bb3715f7
Added support for building certain dlls with -DSTRICT.
...
Added -DWINE_NO_STRICT flag to dlls that don't support STRICT yet.
2002-10-18 23:46:28 +00:00
fe7d46a221
pszText is stored as Unicode, so call DrawTextW() instead of
...
DrawTextA().
2002-10-18 00:20:04 +00:00
c18c7332b8
Instrument SetItemT to change only _one_ item at a time. That is, if
...
we have to change focus, we call it recursively to first remove the
focus from the item that has it. This allows simpler, and more correct
invalidation handling.
2002-10-17 21:55:41 +00:00
8f38417376
Unify set_{owner,main}_item functions.
...
Fix {old,new}state and lParam reporting in LVN_ITEMCHANG{ING,ED}.
Fix sanity check conditions for LVS_OWNERDATA.
2002-10-17 21:54:57 +00:00
96dca36cc8
More, better tracing to help nail down some crashes.
...
Fix typo in GetItemT (found, and fixed by Huw Davies).
Exit right away from GetItemT if nothing is asked (mask == 0).
Assorted code cleanups.
2002-10-17 21:53:56 +00:00
305fb4c3dd
Deal with sparsely populated listviews.
...
Crash on internal corruption.
2002-10-17 21:38:21 +00:00
ef4a6fc7e5
Add ability to create an iterator over a range list.
...
Fix memory leak when destroying ranges.
Add function that will to a 'deep' clone of a range list.
Add function that will subtract a range list from another.
Do not crash on NULL ranges (similar in spirit to HDPAs).
Fancy deselection routines uses the above infrastructure to deselect
the minimum possible.
Modify SetGroupSelection to take advantage of all this new
infrastructure, to avoid flicker on selection extension.
2002-10-17 21:37:24 +00:00
fa81ec674b
Change the definition of ranges to exclude the upper bound.
2002-10-17 21:36:29 +00:00
bac35001fe
Handle range tracing in a consistent fashion.
2002-10-17 21:35:47 +00:00
58b2ad925b
Remove dated comments.
2002-10-17 21:35:08 +00:00
66dd824dbc
Better encapsulation of the ranges concept.
2002-10-17 21:34:15 +00:00
be8189bd9c
Notification code cleanup, more traces, etc.
2002-10-17 01:20:18 +00:00
7d789599d5
Added missing RemoveProp calls.
2002-10-17 01:18:52 +00:00
89eb8fdba3
We need to provide focus info always in ICON mode (spotted by Huw
...
Davies).
2002-10-16 19:57:31 +00:00
bcfffe7b08
Duplicate selected items list in LISTVIEW_RemoveAllSelections to
...
prevent infinite loops.
2002-10-16 19:56:06 +00:00
3dd4dabffb
Remember the global colors in custom draw mode.
2002-10-16 19:05:43 +00:00
ef9adbb6f5
Compute only the old state that we're gonna look at.
2002-10-16 19:05:02 +00:00
8d2f7224f1
Instrument SetItemT to avoid repainting if nothing changed.
...
Teach RemoveAllSelections to skip an item, so we can eliminate the
flicker when we click on a selected item.
2002-10-16 19:04:07 +00:00
3c9591b413
Fix bug in edit label when sending the text to the app.
...
Cleanup the handling of nEditLabelItem.
2002-10-16 19:03:25 +00:00
07a6a3975a
Edit label cleanup.
2002-10-16 19:02:32 +00:00
6b4a11af0a
Fix bug in ranges_shift which was corrupting selections.
...
Fix click notification (found and fixed by Alexandre Julliard).
Fix bug in setting item's state (some selection changes were lost).
Simplify selection code substantially.
Add a lot of debug tracing.
2002-10-16 19:01:38 +00:00
da9bac4d9e
Add comment on what is known about the current state of the controls
...
relative to comctl32.dll version 6.0.
2002-10-16 18:57:14 +00:00
db14dbf12b
Fix iterator creation for LVS_LIST mode.
...
Do not update the infoPtr->nItemWidth in set_main_item.
Better handling of text bk colour in custom draw.
Rename GetItemListOrigin to GetItemOrigin.
A bunch of code cleanups, simplifications, etc.
2002-10-15 21:08:09 +00:00
17dce17a58
No longer compute the ill-defined bounds in GetItemMetrics.
...
Fix a bunch of bug in subitem metrics computation.
Properly implement GetSubItemRect in terms of GetItemMetrics.
Documentation updates, and code cleanups.
2002-10-15 21:07:01 +00:00
3a5105c957
Teach GetItemMetrics to deal with subitems in report mode as well.
...
Unify Draw{,Sub}Item, simplify RefreshReport.
2002-10-15 21:06:14 +00:00
f378bbd5a5
Fix iterator creation for LVS_LIST mode.
...
Use assert() instead of hand-made hack.
2002-10-15 21:05:29 +00:00
3baa344a43
Fix iterators to properly deal with LVS_{,SMALL}ICON modes.
...
Unify the Refresh{List,Icon} functions.
Simplify HitTest to make full use of the iterators.
Fix selection bounds in HitTest.
Avoid empty default to silence warning in gcc 3.2.
2002-10-15 21:03:10 +00:00
50b4688c7e
Iterator updates:
...
Add the notion of a special item which sits at the start of the
list.
Add the ability to iterate in both directions through the list.
Document the iterator interface.
Remove iterator_visibleitems.
Rename iterator_clippeditems to iterator_visibleitems for
consistency.
Use the new bidirectionality to paint the items in decreasing order.
2002-10-15 21:01:57 +00:00
0bc4b56595
Do not merge image with garbage background. Based on a patch by Carlos
...
<clozano@andago.com>.
2002-10-15 02:15:09 +00:00
2cf92565df
Fixed division by zero, when range is 0.
2002-10-15 01:20:51 +00:00
e14cfc497a
Add function to get size of in-memory resource and used this function
...
to copy resource to writable memory.
2002-10-13 17:54:48 +00:00
00ea0868ba
Rename GetItemHeight to CalculateMaxHeight, for consistency
...
Fix usage of nItemWidth vs. iconSpacing.cx
Misc cleanups.
2002-10-11 23:34:32 +00:00
a1ca0122b9
Use the item box rather than the bounds when invalidating.
...
Implement 'bPartial' in EnsureVisible.
2002-10-11 23:33:25 +00:00
ed29ffdea4
Unify DrawLargeItem with DrawItem.
2002-10-11 18:47:03 +00:00
0b93d5c4c5
Use GetItemMetrics instead of GetItemMeasures.
...
Remove GetItemMeasures.
Add GetItemBox which only returns the boundary of the item.
2002-10-11 18:46:21 +00:00
ac756afcc2
Be real tough on internal programming errors.
2002-10-11 18:00:28 +00:00
dda1e31ce7
Remove support for owner drawn listviews in non-REPORT mode. We need
...
to do this since Windows supports owner draw *only* in report mode,
and hence apps are not prepared to handle drawing in other modes.
2002-10-11 17:59:39 +00:00
4150f31f58
Use GetItemMetrics instead of GetItemMeasures when drawing.
2002-10-11 17:58:56 +00:00
01b5226508
Make use of the new GetItemMetrics in HitTest, to avoid code
...
duplication.
2002-10-11 17:58:11 +00:00
f1f447931e
Separate item metrics computation from positioning
...
Add support for computing state icon metrics.
2002-10-11 17:57:27 +00:00
5feaff534b
LVS_OWNERDRAWFIXED should only take effect in REPORT mode.
2002-10-11 04:19:20 +00:00
1c6c29e313
Fix drawing bug introduced with the custom notification
...
reorganization.
2002-10-10 22:57:45 +00:00
01dbe3999e
Simplify the report mode, and item drawing considerably.
...
Fix full row select in report mode.
2002-10-10 22:55:21 +00:00
ffd4bd37d0
Handle custom draw notifications properly.
...
Various cleanups, and simplifications.
2002-10-10 22:54:06 +00:00
d2d4baf96b
Remove superfluous abstractions which make the code harder to
...
understand.
2002-10-10 22:52:56 +00:00
6d6be0e1d4
Move the custom draw notifications into the Draw.*Item functions.
2002-10-10 22:52:12 +00:00
a994fb8135
Move the custom draw item notifications down into DrawLargeItem.
2002-10-10 22:51:27 +00:00
7ac890984d
Fix silly redraw bug introduced in previous patch.
...
Tidy up, and simplify large item drawing.
2002-10-10 22:50:49 +00:00
50ed9b9962
Implement WM_SETREDRAW properly.
2002-10-10 22:50:09 +00:00
12dca97b9d
Rework the mouse click notifications
...
Assorted cleanups, and simplifications.
2002-10-10 22:49:29 +00:00
1094c63c0e
Use (semi)standard HitTest, rather then our own little invention.
...
Get rid of GetItemAtPt.
Fix HitTest but in REPORT mode.
2002-10-10 22:48:36 +00:00
bc54d78532
- change the internal functions in windows/cursoricon.c to use 32bit
...
handles
- move the implementation of ExtractAssociatedIcon16 to
ExtractAssociatedIconA
- convert HICON to a void*
- fixed some handle conversions that happened to be in the way while
doing the above
2002-10-10 21:22:09 +00:00
8b3da5e3ba
Scroll the listview when doing multiple selections.
2002-10-10 18:56:50 +00:00
05b4a09357
Narrow down the items we iterate over in LIST, and REPORT mode.
...
Fix a Client --> List coordinate transformations in FindItem.
Fix bug in HitItem (in LIST and REPORT mode).
Avoid the last bit of drawing in REPORT mode.
2002-10-10 03:13:14 +00:00
9d678ff740
Draw _only_ the items that are invalidated.
...
Fix serious bug when deleting from a range.
Pass in a range to the ranges_{add,del} functions.
Tidy up the RefreshIcon function.
Assorted cleanups.
2002-10-10 03:12:05 +00:00
0295e4fceb
Reimplement FindItem (cleaner, faster, more compliant with MSDN).
2002-10-10 03:10:20 +00:00
1313431b1b
Rewrite HitTest to make it pretty, and very fast.
2002-10-10 03:08:45 +00:00
a80ced02e9
Introduce the notion of item iterators, and use them to clean up code.
2002-10-10 03:07:04 +00:00
Mike McCormack