Zebediah Figura
44e7943274
winedevice: Make driver (un)loading synchronous.
...
This essentially reverts 440482d2ef
.
440482d
was aimed towards making it possible to load multiple drivers
asynchronously, as well as to allow reentrancy. Unfortunately, asynchronicity
is incorrect, as demonstrated by bug 38836, and some trivial testing shows
that the SCM database lock is held for the entirety of the driver entry and
exit routines, and that StartService() and ControlService() block until they
complete. 5726824
and dd2624a
nullified the effects of 440482d
, making driver
loading all but synchronous (with the exception of the added 30 second
timeout, but this is actually incorrect: drivers can block indefinitely).
This patch therefore does not change any behaviour, but rather removes the
use of threadpools and "async" functions, essentially reverting back to the
implementation prior to 440482d
. The incidental change to unload_driver()
made by that patch (viz. never to unload a driver without a DriverUnload()
routine) is kept.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-29 22:01:38 +02:00
Francois Gouget
fb6b48d3e2
xcopy: Spelling fix in a comment.
...
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-23 20:01:56 +02:00
Michael Stefaniuc
83e481fee2
explorer: Use the ARRAY_SIZE() macro.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-21 23:21:52 +02:00
Michael Stefaniuc
e011370f13
dxdiag: Use the ARRAY_SIZE() macro.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-21 23:21:52 +02:00
Alistair Leslie-Hughes
006d3f3365
regedit: Don't expand items on initial tree creation.
...
The Message TVM_EXPAND is captured in treeview_notify, then passes
g_pChildWnd->hTreeWnd on to OnTreeExpanding which hasn't been
initialized yet. The function get_last_key is already called after
the hTreeWnd has been assigned to select the previous selected
item (if it exists).
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-21 23:02:31 +02:00
Michael Stefaniuc
04413abcc7
cmd: Use the ARRAY_SIZE() macro.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-21 23:02:30 +02:00
Zebediah Figura
e525e49976
winedbg/gdbproxy: Silence some noisy debug messages.
...
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-20 09:07:55 +02:00
Nikolay Sivov
25ba7708d3
winecfg: Update changed state on associations checkbox click.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-17 09:12:25 +02:00
Zebediah Figura
2592690540
msiexec: Don't keep the custom action GUID in the main thread's stack.
...
Since it could potentially change on us during an asynchronous custom action.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-16 18:41:14 +02:00
Dmitry Timoshkov
186ae9ed31
winecfg: Allow to disable MIME-type associations.
...
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-16 18:38:51 +02:00
Fabian Maurer
d175419f0b
cmd: Handle quotes when parsing the folders in the PATH environment variable.
...
Semicolons are also allowed inside a path, as long as they are quoted.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45552
Signed-off-by: Fabian Maurer <dark.shadow4@web.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-16 13:14:10 +02:00
Zebediah Figura
05e54ac6e6
winedbg: Ignore EXCEPTION_INVALID_HANDLE.
...
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-16 11:07:37 +02:00
Zebediah Figura
1dbab1cd0d
winedbg/gdbproxy: Simplify packet_verbose().
...
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-16 11:07:37 +02:00
Zebediah Figura
00349e3f2a
winedbg/gdbproxy: Don't try to single-step a terminated process.
...
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-16 11:07:37 +02:00
Zebediah Figura
6159431cd7
winedbg/gdbproxy: Use the WINEDEBUG interface for debugging winedbg.
...
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-16 11:07:37 +02:00
Michael Stefaniuc
27c88fc4a6
netstat: Use the ARRAY_SIZE() macro.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: André Hentschel <nerv@dawncrow.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-15 21:01:09 +02:00
Michael Stefaniuc
84f2249284
winhlp32: Avoid an ARRAY_SIZE-like macro.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-14 10:16:03 +02:00
Michael Stefaniuc
038d9e8ab9
winhlp32: Use the ARRAY_SIZE() macro.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-14 10:16:03 +02:00
Michael Stefaniuc
c33c75fc77
winemenubuilder: Use the ARRAY_SIZE() macro.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-14 10:16:03 +02:00
Michael Stefaniuc
d4f1d510aa
winebrowser: Use the ARRAY_SIZE() macro.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-14 10:16:03 +02:00
Michael Stefaniuc
33f4548ae6
regsvr32: Use the ARRAY_SIZE() macro.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-14 10:16:03 +02:00
Michael Stefaniuc
6784ffcb63
extrac32: Use the ARRAY_SIZE() macro.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-14 10:16:03 +02:00
Michael Stefaniuc
91fda02ff6
msinfo32: Use the ARRAY_SIZE() macro.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-14 10:16:00 +02:00
Zebediah Figura
6925846988
msi: Generate unique names for 32- and 64-bit custom action server pipes.
...
Signed-off-by: Zebediah Figura <zfigura@codeweavers.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-14 10:15:59 +02:00
Michael Stefaniuc
0b788e9a72
winetest: Use the ARRAY_SIZE() macro.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-14 09:44:12 +02:00
Michael Stefaniuc
e4f68323fc
wordpad: Use the ARRAY_SIZE() macro.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-14 09:44:12 +02:00
Michael Stefaniuc
0f5b224bfa
wineboot: Use the ARRAY_SIZE() macro.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-14 09:44:12 +02:00
Michael Stefaniuc
dbf2426b74
uninstaller: Use the ARRAY_SIZE() macro.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-14 09:44:12 +02:00
Michael Stefaniuc
effac73e72
msiexec: Use the ARRAY_SIZE() macro.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-14 09:43:00 +02:00
Michael Stefaniuc
ae375252dc
ipconfig: Use the ARRAY_SIZE() macro.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-14 09:42:56 +02:00
Michael Stefaniuc
f559c605cb
taskkill: Use the ARRAY_SIZE() macro.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-14 09:42:51 +02:00
Michael Stefaniuc
beb464358e
net: Use the ARRAY_SIZE() macro.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-14 09:42:48 +02:00
Michael Stefaniuc
7487e5f4e8
icinfo: Use the ARRAY_SIZE() macro.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-14 09:42:45 +02:00
Michael Stefaniuc
d3188ce1f9
hostname: Use the ARRAY_SIZE() macro.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-14 09:42:41 +02:00
Michael Stefaniuc
b762bd7b17
clock: Use the ARRAY_SIZE() macro.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-14 09:42:37 +02:00
Michael Stefaniuc
094f5b4270
attrib: Use the ARRAY_SIZE() macro.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-14 09:42:34 +02:00
Michael Stefaniuc
0b88a53acd
taskmgr: Use the ARRAY_SIZE() macro.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-14 09:42:09 +02:00
André Hentschel
13f9461e99
winedbg: Check for visible window station before displaying crash dialog.
...
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=35928
Signed-off-by: André Hentschel <nerv@dawncrow.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-16 21:28:45 +02:00
Hugh McMaster
6b620e6d61
regedit: Do not overwrite a hex data type with REG_BINARY when modifying a value.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-16 21:28:45 +02:00
Hugh McMaster
a131cff7a8
regedit: Replace Hungarian notation used with struct edit_params members.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-16 21:28:45 +02:00
Hugh McMaster
32f487bdb2
regedit: Always display DWORD values in hexadecimal when initializing the editor dialog.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-16 21:28:45 +02:00
Hugh McMaster
a7a08e2927
regedit: Free allocated memory after calling GetValueName().
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-16 21:28:45 +02:00
Hugh McMaster
1291c6ded4
regedit: Don't check if heap_xalloc() succeeded in the caller.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-16 21:28:44 +02:00
Hugh McMaster
2686166cc1
regedit: Remove array already present in main.h.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-16 21:28:44 +02:00
Jason Edmeades
6cb520476a
cmd: Fix statements after 'else' inside for loops.
...
When inside a for loop, an 'if' statement is processed and the true part
taken. Once all the commands in the true are processed, the else part is
parsed, and a flag set to skip all commands in the else part. Unfortunately
this flag is left on even when the if statement ends, meaning subsequent
commands are also skipped.
Signed-off-by: Jason Edmeades <us@edmeades.me.uk>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-16 09:19:20 +02:00
Jason Edmeades
dce5f89e48
cmd: Expand the storage space for qualifiers.
...
When parsing a command, after the first '/' we store the characters away
in quals. The command itself can be MAXSTRING in bytes, but the quals was
limited to MAX_PATH. This is incorrect, as you can provide very long
qualifiers as well. Expand the space to allow the maximum size possible.
Signed-off-by: Jason Edmeades <us@edmeades.me.uk>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-16 09:19:04 +02:00
Jason Edmeades
4030a95209
cmd: Handle special case tokens=* in for /f.
...
for /f allows a special syntax of tokens=* (rather than tokens=1* for example)
which just means put the whole line into the next variable). Note the handling of
the 'next variable' was wrong in the case of it being 'A' or 'a' as the wrap
calculation was wrong, but this only affected using this new syntax.
Signed-off-by: Jason Edmeades <us@edmeades.me.uk>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-16 09:18:23 +02:00
Jason Edmeades
f634fe15db
cmd: Fix handle leak in if exists.
...
Fixes regression in f53d57c854
.
Signed-off-by: Jason Edmeades <us@edmeades.me.uk>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-16 09:16:48 +02:00
Michael Stefaniuc
414fe80aeb
start: Use the ARRAY_SIZE() macro.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-13 19:10:02 +02:00
Michael Stefaniuc
cd82a649aa
wmic: Use the ARRAY_SIZE() macro.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-13 19:10:01 +02:00
Michael Stefaniuc
1066283874
winefile: Use the ARRAY_SIZE() macro.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-13 19:10:01 +02:00
Michael Stefaniuc
f140ad6e05
wscript: Use the ARRAY_SIZE() macro.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-13 19:10:01 +02:00
Michael Stefaniuc
a9933cc2d1
winemine: Use the ARRAY_SIZE() macro.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-13 19:10:01 +02:00
Michael Stefaniuc
c99d5f3152
xcopy: Use the ARRAY_SIZE() macro.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-13 19:10:01 +02:00
Michael Stefaniuc
8969cf98cf
wineconsole: Use the ARRAY_SIZE() macro.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-13 19:10:01 +02:00
Zebediah Figura
457431ab5b
msi: Reuse the custom action server process where possible.
...
We use a named pipe to communicate between the client (i.e. the process that
called MsiInstallProduct() and the custom action server. The naïve approach
has the client send custom action GUIDs to the server and the server send
back the results of executing the action, but this fails in the case of
nested custom actions, so instead we send back handles of threads for the
client to wait on.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-11 15:45:11 +02:00
Zebediah Figura
7908d6ee39
msi: Create the custom action thread inside msiexec.exe.
...
This patch is effectively a no-op by itself, but makes the next patch
architecturally much simpler. We need the main thread to be non-blocking
to allow nested custom actions to work, so creating the thread inside of
msiexec allows the custom action thread to write the result of the action to
the server pipe while the main thread simply reads from it.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-11 15:45:11 +02:00
Michael Stefaniuc
4341c4495f
oleview: Use the ARRAY_SIZE() macro.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-09 22:21:26 +02:00
Michael Stefaniuc
e9e96bc39a
view: Use the ARRAY_SIZE() macro.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-09 22:21:24 +02:00
Jason Edmeades
1bfe68512d
xcopy: Add support for xcopy /k.
...
xcopy should remove read only permissions from the destination file unless the
/k option is supplied.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=40706
Signed-off-by: Jason Edmeades <us@edmeades.me.uk>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-05 11:42:41 +02:00
Jason Edmeades
ab46a89c3b
cmd: Fix issue in WCMD_assoc highlighted by valgrind.
...
In an error condition, the wrong variable was being used for an insert,
resulting in a read from uninitialized data. This could be triggered for
example by 'ftype jason=', and the error message should have included
jason but instead was just ''.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=38849
Signed-off-by: Jason Edmeades <us@edmeades.me.uk>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-05 11:38:58 +02:00
Jason Edmeades
254dc78c2c
cmd: Call and goto finds the next matching label.
...
A call or a goto will find the next matching label not the first one in the
file. This means it could be later in the file or it could be earlier in the
file, so make goto (which 'call' also uses) first scan from current file
position to the end of the file, and subsequently from the start of the file
to the wrap point.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=42823
Signed-off-by: Jason Edmeades <us@edmeades.me.uk>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-05 11:38:13 +02:00
Jason Edmeades
daee8b753c
cmd: Support "c:<space>" etc when changing drive letters.
...
This allows whitespace and any other text on the line when changing drive letters.
Mostly I expect it crops up when commands are concatenated and the readability
whitespace is added to the end of the command. For example C: & dir results in
"C: " and "dir" as the two commands. We cannot unconditionally remove whitespace
as some commands rely on it.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=40694
Signed-off-by: Jason Edmeades <us@edmeades.me.uk>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-05 11:29:44 +02:00
Zebediah Figura
fc14753dc0
explorer: Wrap the desktop window procedure instead of replacing it.
...
Signed-off-by: Zebediah Figura <zfigura@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-04 19:07:22 +02:00
Michael Stefaniuc
962b31c80b
include: Add a generic available ARRAY_SIZE().
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-04 10:39:15 +02:00
Zebediah Figura
2831fe2f84
regedit: Print Latin-1 characters.
...
This makes spot-checking differences with Windows a little easier.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-03 11:28:03 +02:00
Austin English
53cc1da18f
winecfg: Recommend against overriding secur32.
...
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45344
Signed-off-by: Austin English <austinenglish@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-03 11:12:43 +02:00
Jason Edmeades
c8fcedcf26
xcopy: Fix copying empty directories.
...
Signed-off-by: Jason Edmeades <us@edmeades.me.uk>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-27 11:01:16 +02:00
Jason Edmeades
8a84148e52
xcopy: Return code 1 for no files is never returned.
...
Signed-off-by: Jason Edmeades <us@edmeades.me.uk>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-27 11:01:12 +02:00
Jason Edmeades
7396f32920
xcopy: Handle multiple switches concatenated without whitespace.
...
Signed-off-by: Jason Edmeades <us@edmeades.me.uk>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-27 11:01:12 +02:00
Marcus Meissner
85f1a79be8
icinfo: vsnprintfw takes characters as buffer size not bytes.
...
Signed-off-by: Marcus Meissner <meissner@suse.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-26 22:10:48 +02:00
Jason Edmeades
15215bd071
cmd: Fix subdirectory prefix in for loops.
...
A for loop can be working through a wildcarded subdirectory, but when
processing the first file in the subdirectory, it stores the prefix in
a static variable which gets overwritten during the 'for' body
processing.
Signed-off-by: Jason Edmeades <us@edmeades.me.uk>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-25 21:44:48 +02:00
Jason Edmeades
f53d57c854
cmd: Add support for wildcards in if exist.
...
Signed-off-by: Jason Edmeades <us@edmeades.me.uk>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-25 21:44:48 +02:00
Zebediah Figura
14da5bfbd5
winedbg: Suppress all message boxes if ShowCrashDialog is disabled.
...
Signed-off-by: Zebediah Figura <zfigura@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-21 11:18:39 +02:00
Zebediah Figura
dc1f45b3ae
winedbg: Provide a more helpful error message when unable to attach to a process.
...
Signed-off-by: Zebediah Figura <zfigura@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-20 11:27:27 +02:00
Francois Gouget
9b1431459d
winetest: Don't show dll=skipped messages for skipped tests.
...
This spams the report when using WineTest to run a few tests.
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-20 11:22:55 +02:00
Zebediah Figura
1bb4a8676d
winetest: Increase maximum tag length.
...
This should hopefully make those failures surrounding newtb-wvistau64-zh-CN go away.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-20 11:21:48 +02:00
Józef Kucia
ff84b2f202
winedbg: Get rid of ifdefs.
...
Signed-off-by: Józef Kucia <jkucia@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-19 20:52:30 +02:00
Michael Stefaniuc
0c8e555e4c
winedbg: Use the available ARRAY_SIZE() macro.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-19 20:48:52 +02:00
Zebediah Figura
d0451d5734
msi: Mark exported wine functions CDECL.
...
Signed-off-by: Zebediah Figura <zfigura@codeweavers.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-19 20:46:50 +02:00
Zebediah Figura
c1adb6ea1c
winedbg/gdbproxy: Handle VS thread renaming.
...
Signed-off-by: Zebediah Figura <zfigura@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-15 12:56:48 +02:00
Alexandre Julliard
2fb792bd7c
winedbg: Fix some compiler warnings.
...
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-14 11:05:14 +02:00
Zebediah Figura
8b3294a4dd
winedbg: Always start the interactive debugger in 64-bit mode if in a 64-bit prefix.
...
Signed-off-by: Zebediah Figura <zfigura@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-14 09:29:14 +02:00
Zebediah Figura
1244759036
winedbg/gdbproxy: Store the register map inside the be_cpu struct.
...
Signed-off-by: Zebediah Figura <zfigura@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-14 09:29:12 +02:00
Zebediah Figura
5caaba7e3e
winedbg: Implement debugging 32-bit processes on x86_64.
...
Signed-off-by: Zebediah Figura <zfigura@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-14 09:29:07 +02:00
Zebediah Figura
cf349cea69
winedbg: Add a backend-specific vector for setting a thread's context.
...
Signed-off-by: Zebediah Figura <zfigura@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-13 22:13:27 +02:00
Zebediah Figura
2326179312
winedbg: Add a backend-specific vector for retrieving a thread's context.
...
Signed-off-by: Zebediah Figura <zfigura@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-13 22:13:27 +02:00
Zebediah Figura
45e0654591
winedbg: Use WOW64_CONTEXT instead of CONTEXT for i386 backend.
...
Signed-off-by: Zebediah Figura <zfigura@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-13 22:13:27 +02:00
Zebediah Figura
b459c88caa
winedbg/gdbproxy: Remove unnecessary checks for supported context flags.
...
And simplify the assignment to use CONTEXT_ALL instead. If we don't support
reading from a register then we just ignore its value.
Signed-off-by: Zebediah Figura <zfigura@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-13 22:13:27 +02:00
Zebediah Figura
42bbeedbe4
winedbg: Make be_cpu process-specific.
...
Signed-off-by: Zebediah Figura <zfigura@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-13 22:13:27 +02:00
Austin English
4739647405
dism: Add stub program.
...
Signed-off-by: Austin English <austinenglish@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-05 09:25:55 +02:00
Fabian Maurer
914d387214
find: Add stub program.
...
Signed-off-by: Fabian Maurer <dark.shadow4@web.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-01 19:54:33 +02:00
Fabian Maurer
96a6165776
fc: Add stub program.
...
Signed-off-by: Fabian Maurer <dark.shadow4@web.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-01 19:54:08 +02:00
Francois Gouget
fec1aca300
wscript/tests: Fix a typo in the WScript.BuildVersion check.
...
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-01 19:42:39 +02:00
Michael Stefaniuc
d72112eda8
wscript/tests: Use the available ARRAY_SIZE() macro.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-29 09:28:48 +02:00
Michael Stefaniuc
ea6cc7245c
cmd/tests: Use the available ARRAY_SIZE() macro.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-29 09:28:44 +02:00
Hugh McMaster
c7718d31c7
regedit: Pass NULL instead of the address of an empty WCHAR.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-28 22:08:23 +02:00
Hugh McMaster
cc200d0a50
regedit: Confirm whether to delete a registry value from framewnd.c.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-28 22:08:23 +02:00
Hugh McMaster
5bc81188fe
regedit: Do not directly include resource.h anymore.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-23 17:33:57 +02:00
Michael Stefaniuc
d98be23eab
notepad: Use the available ARRAY_SIZE() macro.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-23 09:22:46 +02:00
Hugh McMaster
5509d84e9a
regedit: Sort function declarations alphabetically by source file.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-21 16:29:10 +02:00
Hugh McMaster
3526746b06
regedit: Remove implicit extern keywords from function declarations.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-21 16:29:07 +02:00
Hugh McMaster
a926e05446
regedit: Do not directly include stdio.h any longer.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-21 16:28:07 +02:00
Hugh McMaster
20e5b9e82f
regedit: Simplify boolean comparisons in edit.c.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-21 16:27:58 +02:00
Hugh McMaster
b24ee836bd
regedit: Simplify the detection of existing registry values.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-21 16:27:19 +02:00
Hugh McMaster
a20f99b548
regedit: Use the ARRAY_SIZE macro.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-21 16:26:27 +02:00
Hugh McMaster
73220a3d6f
regedit: Remove regproc.h.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-21 16:26:01 +02:00
Hugh McMaster
f6476c79e3
regedit: Move regedit.c functions from regproc.h to main.h.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-21 16:23:09 +02:00
Hugh McMaster
ff1f664d08
regedit: Move regproc.c functions from regproc.h to main.h.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-21 16:22:58 +02:00
Hugh McMaster
78732a6d46
regedit: Replace the COUNT_OF macro with ARRAY_SIZE.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-21 16:22:34 +02:00
Zebediah Figura
a602405efd
winedbg: Use gdb's default handling of breakpoints.
...
We're essentially doing the same thing, so there's no reason not to leave
the handling entirely to gdb.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-18 16:33:20 +02:00
Michael Stefaniuc
7fdb828abf
winecfg: Use the available ARRAY_SIZE() macro.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-18 11:20:43 +02:00
Michael Stefaniuc
8f420443d7
winecfg: Remove an ARRAY_SIZE()-like macro.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-18 11:20:37 +02:00
Alexandre Julliard
7d7eee09b5
winecfg: Constrain DPI values to the commonly supported ones.
...
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-15 12:37:28 +02:00
Fabian Maurer
37654ceba8
wineconsole: When loading settings for an application, respect a 0 in FontSize.
...
Signed-off-by: Fabian Maurer <dark.shadow4@web.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-09 19:53:43 +02:00
Hugh McMaster
0aead094a5
reg: Stop exporting REG_SZ data at the first NUL character.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-08 10:41:38 +02:00
Hugh McMaster
62027322b0
regedit: Stop exporting REG_SZ data at the first NUL character.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-08 10:41:35 +02:00
Hans Leidekker
623543bedc
programs: Add a stub winmgmt service.
...
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-03 14:08:30 +02:00
Zebediah Figura
3849270aa7
winedbg: Add support for starting on a user-supplied port.
...
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-03 10:36:33 +02:00
Zebediah Figura
085c577a25
services: Fall back to the current architecture if GetBinaryType fails.
...
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-01 10:30:19 +02:00
Bernhard Übelacker
f95b85a856
cmd: Avoid having first parameter to start.exe ignored.
...
Signed-off-by: Bernhard Übelacker <bernhardu@mailbox.org>
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-27 17:07:48 +02:00
Zebediah Figura
85d1fb62b3
msi: Execute custom actions in a separate process.
...
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-26 13:27:10 +02:00
Hugh McMaster
65717d6726
reg: Null terminate hex-formatted REG_SZ data if necessary.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-24 00:25:15 +02:00
Hugh McMaster
829c0ced69
regedit: Null terminate hex-formatted REG_SZ data if necessary.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-24 00:25:15 +02:00
Hugh McMaster
448344c5e4
reg/tests: Add tests for values with embedded null characters.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-19 17:38:10 +02:00
Hugh McMaster
7cd90766bb
regedit/tests: Add tests for values with embedded null characters.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-19 17:38:09 +02:00
Hugh McMaster
6bca0abb68
regedit: Use the correct window class name.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-19 17:38:07 +02:00
Alistair Leslie-Hughes
dd2624a24f
winedevice: Improve error handling when a driver fails to load.
...
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-09 19:59:11 +02:00
Dmitry Timoshkov
b5c1a8f635
services: Add a 3000 ms timeout to StartService.
...
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-09 19:58:14 +02:00
Louis Lenders
add31e1d7a
iexplore/iexplore.inf: Add svcVersion reg key and update to win7.
...
Signed-off-by: Louis Lenders <xerox.xerox2000x@gmail.com>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-09 09:55:55 +02:00
André Hentschel
a6becd791f
progman: Fix warning in PUT_SHORT macro (clang).
...
Signed-off-by: André Hentschel <nerv@dawncrow.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-04 22:04:27 +02:00
Alex Henrie
d3dc6f900a
ping: Distinguish between timeouts and other failures.
...
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-04 22:04:26 +02:00
Alistair Leslie-Hughes
57268241f7
winedevice: Wait until driver has started before returning.
...
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-26 11:34:51 +02:00
Martin Storsjo
e0780c258f
ntdll: Update the ARM64 CONTEXT struct to match Win SDK 10.0.16299.0.
...
Signed-off-by: Martin Storsjo <martin@martin.st>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-19 13:13:59 +01:00
Zebediah Figura
80ec0bc4b2
regedit: Fix updating the scrollbar in the hex edit dialog.
...
The scrollbar should be updated every time the line width is recalculated.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-12 18:03:08 +01:00
Zebediah Figura
c52cfd3129
regedit: Make hexedit dialog a little larger.
...
Both in the interest of having an even 8 bytes per line, and of having more
than two lines visible at once.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-12 18:03:04 +01:00
Zebediah Figura
ce94f686d5
regedit: Also display the byte offset in the hex edit dialog.
...
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-12 18:02:53 +01:00
Zebediah Figura
31e41a942e
regedit: Use monospace font for hex edit dialog.
...
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-12 18:02:45 +01:00
Zebediah Figura
bd74183b1e
explorer: Pass the full path to ParseDisplayName().
...
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-06 15:46:09 -06:00
Alexandre Julliard
acc6306bcf
makefiles: Generate the winetest resource list from makedep.
...
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-05 06:23:27 -06:00
Isira Seneviratne
b1e9177c13
ping: Implement -l, -w, -n using IcmpSendEcho.
...
Signed-off-by: Isira Seneviratne <isirasen96@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-01 19:25:59 +01:00
Alexandre Julliard
d5f316bf0a
makefiles: Disable binary installation in the individual makefiles on Wow64.
...
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-22 14:16:33 +01:00
Huw Davies
ca9f7cc5eb
winedbg: Add cvtdq2ps and cvtps2pd opcodes.
...
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-19 16:57:52 +01:00
Huw Davies
e5b9057ba0
winedbg: Fix the operand order of some XMM instructions.
...
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-19 16:57:52 +01:00
Andrew Eikum
b29157e101
services: Fix reading past end of struct (Coverity).
...
Signed-off-by: Andrew Eikum <aeikum@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-12 16:24:47 +01:00
Zebediah Figura
67d7eb980e
winedbg: Remove a misplaced \n.
...
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-12 11:09:44 +01:00
Michael Stefaniuc
6542c3e860
reg: Use the global HeapAlloc() wrappers.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-08 09:42:12 +01:00
Fabian Maurer
e62000c5c0
cmd.exe: Parse parameters in "FOR /F" properly.
...
We must not remove the quotes from parameters, or strings like
"param=value" will get parsed incorrectly.
Signed-off-by: Fabian Maurer <dark.shadow4@web.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-07 22:22:53 +01:00
Henri Verbeet
fc3ea7d1ef
winedbg: Handle byte-sized registers in cpu_register() and cpu_register_hex_from().
...
Like for example the recently added floating-point TagWord on AMD64.
Signed-off-by: Henri Verbeet <hverbeet@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-07 19:38:30 +01:00
Vladimir Bespalov
57ccf8221f
winedbg: Fix enum value compilation warning.
...
Signed-off-by: Vlad Bespalov <vlad.botanic@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-07 19:38:29 +01:00