Commit Graph

727 Commits

Author SHA1 Message Date
Alexandre Julliard 2cfe907584 comdlg32: Build with msvcrt.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-05-29 11:38:38 +02:00
Michael Stefaniuc 773e1788ce comdlg32: Avoid using the comma operator.
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-03-22 19:50:13 +01:00
Alistair Leslie-Hughes 211fd67ace comdlg32: Improve Printer Setup dialog.
Reset the tab order to be more like Windows, add Help button.

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-02-13 21:08:30 +01:00
Alistair Leslie-Hughes 0bee07ec57 comdlg32: Improve PRINT32 dialog.
Correct TAB order, and move Help button to bottom right.

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-02-05 11:03:27 +01:00
Dmitry Timoshkov 5a622342d9 comdlg32: When FOS_PICKFOLDERS is specified item selection box should contain full path name.
Otherwise when selecting a folder using IFileOpenDialog interface
the caller instead of C:\Temp receives C:\Temp\Temp. This matches
both an old GetOpenFileName behaviour and what IFileOpenDialog returns
under Windows.

Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-12-20 15:34:45 +01:00
Alex Henrie fedd1cb3d3 comdlg32: Turn several variables into static constants.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-12-04 16:13:10 +01:00
Zhiyi Zhang d07f31e376 comdlg32/tests: Fix failures on newer Windows 10.
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-09-18 20:59:38 +02:00
Zhiyi Zhang 616e5fa733 comdlg32: Check invalid options in IFileDialog::SetOptions.
Fix Steam chat unable to select files.

Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-09-18 20:59:38 +02:00
Zhiyi Zhang b89e0e70e0 comdlg32/tests: Fix crashes.
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-09-18 20:59:38 +02:00
Alexandre Julliard 75ff2c1234 comdlg32/filedlg: Resize the Places toolbar along with the dialog.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-05 19:08:35 +02:00
Michael Stefaniuc 962b31c80b include: Add a generic available ARRAY_SIZE().
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-04 10:39:15 +02:00
Michael Stefaniuc 31ea5a2ab5 comdlg32/tests: Don't undefine ARRAY_SIZE().
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-27 22:03:33 +02:00
Michael Stefaniuc 7b5668a6e7 include: Make ARRAY_SIZE() available in wine/test.h.
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-25 12:09:17 +02:00
Nikolay Sivov ffd84dc429 comdlg32: Fix some leaks on error paths (Coverity).
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-02 12:28:12 +02:00
Nikolay Sivov 855d7b0fd8 comdlg32: Add some traces for custom Places (Coverity).
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-02 12:28:12 +02:00
Michael Stefaniuc e2dae70fe0 comdlg32: Use the available ARRAY_SIZE() macro.
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-29 17:27:45 +02:00
Nikolay Sivov 1b04429965 comdlg32: Hide Read-only checkbox for Save dialogs.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-26 11:28:19 +02:00
Nikolay Sivov 725c02614b comdlg32: Use shell API directly.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-21 10:13:05 +01:00
Nikolay Sivov 8bbb32c99d comdlg32: Add support for Places bar customization.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-21 10:12:52 +01:00
Nikolay Sivov 0092e2ea0f comdlg32: Use flat navigation toolbar.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-21 10:12:50 +01:00
Nikolay Sivov fe572072c3 comdlg32: Remove most of Combo macros.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-20 11:40:34 +01:00
Nikolay Sivov 2118ce0fa9 comdlg32: Add a helper to test if file dialog hook is enabled.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-20 11:40:29 +01:00
Nikolay Sivov 7514475c1c comdlg32: Use ARRAY_SIZE macro.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-20 11:40:25 +01:00
Nikolay Sivov b8d1e929e7 comdlg32: Detach file dialog data after child windows were destroyed.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-20 11:40:19 +01:00
Nikolay Sivov 38898e939c comdlg32: Use memory allocation helpers.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-20 11:40:15 +01:00
Nikolay Sivov 69d7e05179 comdlg32: Implement Places toolbar for file dialogs.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-19 12:35:11 +01:00
Nikolay Sivov 284bfc677b comdlg32/tests: Remove a macro.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-16 16:41:25 +01:00
Alexandre Julliard 908fa3eb8d comdlg32: Correctly initialize the item dialog structure.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-02 15:40:36 +01:00
Alexandre Julliard 77d65c3948 comdlg32: Add a helper function to select a combo box item.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-18 19:51:22 +01:00
Fabian Maurer aa7941d41b comdlg32/fontdlg: Allow setting value by typing it into the edit fields.
The font-dialog allows the user to select a value from the combobox by
typing it into its edit field. This operation seems unique to the
fontdialog. It works case-insensitively and doesn't change the
selection in the edit field.

Signed-off-by: Fabian Maurer <dark.shadow4@web.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-11-20 12:37:15 +01:00
Fabian Maurer 823c4b14b4 comdlg32: Use proper size for combobox controls.
Signed-off-by: Fabian Maurer <dark.shadow4@web.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-31 18:55:25 +02:00
Nikolay Sivov 1c1db33aba comdlg32: Improve tracing messages.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-31 10:53:58 +02:00
Nikolay Sivov c4b133e231 comdlg32: Simplify notification helper.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-31 10:53:56 +02:00
Nikolay Sivov 3c33ebd662 comdlg32: Use existing symbol for Help button id.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-11 10:17:50 -05:00
Huw Davies 5d9ab56d9e comdlg32: Select the correct font before querying the extents.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-05 14:12:18 +02:00
Huw Davies e77771c0bf comdlg32: Set the radiobuttons' font if they're part of a visual group.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-05 14:12:18 +02:00
Huw Davies 00994524f5 comdlg32: Use pixel sizes throughout.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-05 14:12:18 +02:00
Huw Davies 6df0198a2b comdlg32: Scale the control size limits with dpi.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-05 00:19:54 +02:00
Huw Davies 6891b5a044 comdlg32: Don't ask for icon information since it's unused.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-25 11:47:19 +02:00
Nikolay Sivov a44a608378 comdlg32: Take nMaxFile into account when converting A->W.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-13 19:28:11 +01:00
Nikolay Sivov b47de18ce1 comdlg32: Use GetPropW() to get to file dialog data.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-21 13:57:36 +01:00
Nikolay Sivov c23a91cb63 comdlg32: Consolidate file dialog initialization to avoid duplication.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-21 13:57:36 +01:00
Nikolay Sivov aef84332a2 comdlg32: Expand initial directory path for file open dialog.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-21 13:57:36 +01:00
Alex Henrie e07d20f3f3 comdlg32: Don't crash if an IShellFolder could not be created.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-14 22:46:58 +01:00
Alex Henrie bd1b3c104e comdlg32: Use localized "Path does not exist" string.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-14 22:46:57 +01:00
Józef Kucia 1707df3da2 comdlg32: Delay OleInitialize() until after file dialog window is created.
This fixes a problem exposed by commit
f65e04770d.

Signed-off-by: Józef Kucia <jkucia@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-02 20:40:13 +01:00
Józef Kucia 5dda6495eb comdlg32/tests: Add test for OLE initialization in file dialogs.
Signed-off-by: Józef Kucia <jkucia@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-02 20:40:13 +01:00
Nikolay Sivov 6c4aaf776f comdlg32: Always use original Open File dialog template.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-26 10:37:08 +01:00
Michael Stefaniuc eff2ecc39a comdlg32: Avoid some superfluous pointer casts.
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-12-08 13:56:02 +01:00
Alistair Leslie-Hughes 3126d9ca4c comdlg32/tests: Test when a directory is passed to OpenFileName Dialog.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-10-27 18:06:29 +02:00