Commit Graph

1496 Commits

Author SHA1 Message Date
Michael Jung 3676640e64 Added test to show that Windows does not allocate a new pidl in
SHBindToParent.
2005-08-29 21:45:49 +00:00
Michael Jung 060bfac706 Use StringFromGUID2 instead of StringFromCLSID in
UNIXFS_is_rooted_at_desktop.
2005-08-29 21:45:31 +00:00
Alexandre Julliard cc4da88563 Explicitly import kernel32 in tests that use it. 2005-08-27 09:27:09 +00:00
Michael Jung b0b4777422 Implemented 'My Documents' folder. 2005-08-26 10:05:34 +00:00
Michael Jung 868921648f Added some tests for CLSID_FolderShortcut objects. 2005-08-23 09:37:59 +00:00
Mike McCormack f49f36f9eb Fix gcc 4.0 warnings. 2005-08-23 09:37:30 +00:00
Michael Jung 6235c076a4 Initialize all members in UnixFolder constructor.
Support NULL value pidls in GetDisplayNameOf method.
2005-08-22 18:56:36 +00:00
Mike McCormack eafa666bee Fix some gcc 4.0 warnings. 2005-08-22 09:26:53 +00:00
Saulius Krasuckas 94feee327b Make file operations succeed on Win9x too. 2005-08-22 09:14:35 +00:00
Michael Jung b6d97d5654 Added stubbed implementation of IPersistPropertyBag interface.
Register unixfs as CLSID_FolderShortcut.
2005-08-19 13:58:52 +00:00
Jason Edmeades 602f0c10c7 Handle context menu->refresh, and F5 to initiate a refresh of the file
dialog.
2005-08-19 10:02:51 +00:00
Jason Edmeades c1cd0d22e0 Add the time to the file display dialog modified column. 2005-08-19 10:01:25 +00:00
Michael Jung f9fd061e95 Implemented IPersist::GetClassID. 2005-08-19 10:01:07 +00:00
Alexandre Julliard 702c959c7b Added missing ntdll imports. 2005-08-18 10:59:47 +00:00
Francois Gouget 5b5e5086d7 Test "%l" and "%L". At the same time this tests alternate verbs.
Test %1, %l and %L with no quotes.
test->todo is a bitmask so fix the checks accordingly.
2005-08-18 10:47:53 +00:00
Francois Gouget 0b5cc286e3 Fix ShellExecute("\"foo.doc\"") for Internet Explorer 6.
Update the conformance tests accordingly.
Tweak a trace because it's very confusing to see the path with no
escaped quotes in ShellExecuteA() and then with escaped quotes in
ShellExecuteExW32() (due to debugstr_w()).
2005-08-17 09:53:30 +00:00
Francois Gouget 7f65f6a4e2 Dynamically load StrRetToBufW(). This lets shell32_test.exe run on
systems that have version 4.72 of shlwapi.dll.
2005-08-16 19:29:40 +00:00
Francois Gouget 1fddb3ff20 Verify the parameters received by the child process using code lifted
from kernel32/tests/process.c.
Test passing parameters to .lnk files that point to an executable.
2005-08-16 19:29:27 +00:00
Michael Jung 2fac564cc5 Remove "initguid.h" include from shellpath test. 2005-08-16 16:00:07 +00:00
Ge van Geldorp 75139a3e01 Fix resource leak on error paths. 2005-08-15 14:50:18 +00:00
Mike McCormack 61aabd66f5 Warning fixes for gcc 4.0. 2005-08-15 10:49:39 +00:00
Saulius Krasuckas 6400c8e3dd Fix some SHGetSpecialFolderPathA exceptions on WinME:
- pass pointer to valid buffer as lpszPath.
- disable check passing NULL as lpszPath.
2005-08-15 10:22:56 +00:00
Alexandre Julliard 640bf7c6e8 Authors: Michael Jung <mjung@iss.tu-darmstadt.de>, Ge van Geldorp <gvg@reactos.com>
- Prepend Desktop folder path for files/directories stored in the
  filesystem Desktop folder when GetDisplayNameOf is called with the
  SHGDN_FORPARSING flags.
- Add testcases.
2005-08-15 09:41:58 +00:00
Saulius Krasuckas 7be2cd973c XP returns E_INVALIDARG on failure. 2005-08-15 09:40:45 +00:00
Saulius Krasuckas 68d4ca1f6a Win98 returns HRESULT_FROM_WIN32(ERROR_FILE_NOT_FOUND)) on failure. 2005-08-12 10:33:37 +00:00
Michael Jung e4d2ef4559 Use wine_get_dos_file_name instead of GetFullPathName. 2005-08-12 10:32:47 +00:00
Francois Gouget df6ed2f4e8 Fix the return value of SHELL_Argify() so it once again returns true
if a '%1' or equivalent placeholder was found. This fixes
ShellExecuteEx(lpFile="foo.txt", lpClass="txtfile").
2005-08-11 17:04:31 +00:00
Steven Edwards c8857c0786 Correct definition of SFGAO_STORAGEANCESTOR. 2005-08-11 10:33:21 +00:00
Francois Gouget efe2bbd0ec Fix handling of SEE_MASK_CLASSNAME and SEE_MASK_CLASSKEY. They are not
disjoint flags.
2005-08-11 10:29:44 +00:00
Alexandre Julliard 78340756f3 Use ERR instead of DPRINTF in dump_pidl_hex. 2005-08-09 20:48:17 +00:00
Saulius Krasuckas c3760e7de1 Remove trailing backslash. 2005-08-08 18:03:47 +00:00
Alexandre Julliard d37f0abf07 Don't prefix the functions DllCanUnloadNow, DllGetClassObject and
Dll(Un)RegisterServer with the dll name so that the compiler can check
the prototypes.
2005-08-08 17:35:28 +00:00
Saulius Krasuckas 843314ed9a Wine and NT4 returns E_FAIL on failure. 2005-08-08 11:04:30 +00:00
Alexandre Julliard 49b7fdcfc0 Removed the broken mmap64 configure check, and moved the
_FILE_OFFSET_BITS define to wine/port.h. Made sure that all files that
need the define include it.
2005-08-03 21:25:10 +00:00
Mike McCormack bc4a576a06 gcc 4.0 RegSetValueEx warning fixes. 2005-08-03 11:03:44 +00:00
Saulius Krasuckas 60f2d44e1f Added test for IShellFolder_ParseDisplayName. 2005-08-02 14:41:51 +00:00
Jozef Stefanka 3a29a309a4 Fixed browsing to other directories in Word 2003 file open
dialog. Double clicking on a folder in the File->Open dialog works
now.
2005-07-30 19:03:32 +00:00
Alexandre Julliard b1a9701bb5 Replace the _ICOM_THIS_From macros by inline functions the way it's
already done in shelllink.c.
2005-07-27 11:10:52 +00:00
Alexandre Julliard 89cbfd8fac Get rid of the _ICOM_THIS macros and call the inline function
directly instead.
2005-07-26 20:02:25 +00:00
Alexandre Julliard b8d3075d83 Uncomment the typedef in the DECLARE_INTERFACE macro, and get rid of
duplicate typedefs.
2005-07-26 18:32:53 +00:00
Paul Vriens 5b325a6d15 Skip test that crashes on W2K/WinXP/W2K. 2005-07-24 17:12:06 +00:00
Francois Gouget 5179aa1bae Get started testing ShellExecute(). 2005-07-24 16:26:53 +00:00
Vincent Béron 05b2c1cc81 Remove multiple declarations of the same function, keeping the public
one as reference.
2005-07-24 16:17:28 +00:00
Troy Rollo d1b575e940 Return attributes for the correct file in the unixfs ParseDisplayName. 2005-07-21 11:00:57 +00:00
Michael Jung 39a6c8b456 Initial support for the IPersistFolder3 interface. 2005-07-20 10:44:54 +00:00
Michael Jung 47c0906369 Only initialize shell folders via the IPersistFolder3 interface in
SHELL32_CoCreateInitSF if the pidl which specifies the child is of
type 'Folder'. Otherwise fall back to IPersistFolder.
2005-07-20 10:29:05 +00:00
Troy Rollo 2a52813024 When using PATHMODE_UNIX, all files are in the file system. 2005-07-19 11:40:36 +00:00
Michael Jung 1032fdc595 Use CP_UNIXCP instead of CP_ACP when converting paths (Pointed out by
Troy Rollo).
2005-07-18 13:13:42 +00:00
Michael Jung ff23dd29be Release shell folders only if they were successfully acquired. 2005-07-18 13:13:05 +00:00
Michael Jung 4ec5aa68b2 Append filename extension if necessary in IShellFolder::SetNameOf. 2005-07-18 09:12:20 +00:00
Michael Jung 9568893940 Add file type column in detailed shell view.
Make the order of shell view columns 'prefix-compatible' with
shfldr_fs.
Don't remove filename extensions for path pidls in GetDisplayNameOf.
2005-07-15 11:43:25 +00:00
Michael Jung 6b7778f36b Do filename postprocessing in GetDisplayNameOf (Hide filename
extensions if appropriate).
2005-07-15 09:58:03 +00:00
Michael Jung 1e6fe17958 Don't cache child pidls in UnixFolder, but create them on the fly. 2005-07-12 17:00:36 +00:00
Detlef Riekenberg a7a6927d9b Printers_RegisterWindowW / Printers_UnregisterWindow implemented as
stub.
Show the FIXME in Printer_LoadIconsW only when needed.
2005-07-11 18:02:20 +00:00
Francois Gouget 28dc5a8afc Assorted spelling fixes. 2005-07-11 10:59:41 +00:00
Michael Jung 9ccea1149b Don't use unix filesystem specific attributes in UnixFolder's pidls. 2005-07-11 10:24:09 +00:00
Michael Jung 5dd3e48154 Release parent shell folder in GetAttributesOf. 2005-07-11 10:23:56 +00:00
Michael Jung 433197172d Fail in SHGetDataFromIDList when called on special folder. 2005-07-08 14:18:32 +00:00
Michael Jung 8b87bdd76b Partially implemented UnixFolder's ISFHelper::CopyItems method. 2005-07-08 14:18:14 +00:00
Michael Jung 9f4c67d50d Return correct HRESULT code in UnixFolder's IEnumIDList::Next.
Corresponding test.
2005-07-08 11:30:18 +00:00
Mike McCormack d7b9a23afd gcc 4.0 -Wpointer-sign fixes (Reg* functions). 2005-07-06 19:08:05 +00:00
Michael Jung 6d6ec608d8 Implemented UnixFolder's ISFHelper::DeleteItems interface. 2005-07-06 15:43:51 +00:00
Alexandre Julliard 6b6d937c89 Authors: Michael Lin <mlin@corvu.com.au>, Michael Jung <mjung@iss.tu-darmstadt.de>
Implemented UnixFolder's ISFHelper::AddFolder.
2005-07-06 11:11:00 +00:00
Detlef Riekenberg b6b4787e95 Printer_LoadIconsW: implemented minimal version. 2005-07-05 20:59:35 +00:00
Alexandre Julliard d201828370 Authors: Michael Lin <mlin@corvu.com.au>, Michael Jung <mjung@iss.tu-darmstadt.de>
ISFHelper interface support for UnixFolder (currently only stubs).
2005-07-05 20:55:43 +00:00
Alexandre Julliard 9fef38488a Authors: Michael Lin <mlin@corvu.com.au>, Michael Jung <mjung@iss.tu-darmstadt.de>
Implemented UnixFolder's IShellFolder::SetNameOf.
2005-07-05 16:18:00 +00:00
Marcelo Duarte af80bbe701 Update shell32 resources for Portuguese. 2005-07-05 10:59:11 +00:00
Michael Jung 8130a6eb44 Return correct attributes in ParseDisplayName. 2005-07-05 10:58:11 +00:00
Mike McCormack e28c014a84 -Wpointer-sign fixes. 2005-07-03 12:03:35 +00:00
Mike McCormack b8fc783be2 Avoid warnings in generated tests by casting sizeof(x) to an int. 2005-07-03 11:23:30 +00:00
Robert Shearman d5714dfc50 Implement ShellDDEInit. 2005-06-30 20:45:57 +00:00
Michael Jung 7110f82795 Register unixfs at desktop level in DllRegisterServer. 2005-06-30 11:00:03 +00:00
Michael Jung c0995c2c93 Fix two more corner cases in UNIXFS_get_unix_path and UNIXFS_path_to_pidl. 2005-06-30 10:59:51 +00:00
Saulius Krasuckas 5678f65c07 Prepare for adding new tests.
- Put OleInitialize and OleUninitialize in the main block.
- Move test_BindToObject before test_EnumObjects_and_CompareIDs.
2005-06-30 10:23:14 +00:00
Michael Jung 9393580ab5 If the unixfs is rooted at the Desktop folder, forward
ParseDisplayName calls to it instead of to MyComputer.
2005-06-29 11:17:33 +00:00
Vitaliy Margolen eed690f973 ILFree is not available on all versions. 2005-06-29 11:00:59 +00:00
Aric Stewart b152076d3b Fix the BrowseForFolder dialog so that when it does the callbacks it
uses the correct message instead of always sending BEFM_INITIALIZED.
2005-06-27 18:46:47 +00:00
Michael Jung ad6bac918c Precisely compute the necessary pidl length in UNIXFS_path_to_pidl. 2005-06-27 18:46:36 +00:00
Saulius Krasuckas c48c3abd92 Additional test cases for IShellFolder_BindToObject. 2005-06-27 09:41:48 +00:00
Michael Jung 114975d937 Fix a lurking infinite loop in SHGetPathFromIDList. 2005-06-25 18:32:17 +00:00
Michael Jung 526377c511 Use the CallForAttributes registry value, instead of promoting the
root folder's SFGAO_FILESYSTEM flag to the registry.
2005-06-25 17:56:13 +00:00
Michael Jung 11cadc368a Support for shellfolder's CallForAttributes registry value. 2005-06-25 17:55:53 +00:00
Michael Jung bb562118c0 Added tests for ShellFolder's CallForAttributes value. 2005-06-24 11:33:35 +00:00
Alexandre Julliard f84401aa17 Sort entry points in the same order as Windows. 2005-06-23 09:57:11 +00:00
Saulius Krasuckas 77577822e3 - Move test init code back to START_TEST(shlfolder).
- Move creation and cleanup of a test-folders nearer to
  test_EnumObjects.
2005-06-22 18:04:04 +00:00
Saulius Krasuckas b98a26853c Cleanup the shlfolder test a bit more. 2005-06-21 20:04:17 +00:00
Michael Jung 8765e4a522 Propagate the root folder's attributes to the registry. 2005-06-21 09:42:38 +00:00
Vitaly Lipatov b39c3981c2 - Realize DoEnvironmentSubstA via ExpandEnvironmentStringsA.
- Fix types and return values.
- Add prototype into shellapi.h.
2005-06-20 15:33:48 +00:00
Stefan Huehner ac6f562b52 Fix more -Wstrict-prototypes warnings. 2005-06-20 14:18:03 +00:00
Michael Jung 74afc7f12e Use stat's dev/inode to compare paths instead of comparing the
strings. Defer building a folder's children SHITEMIDS until explicitly
asked for.
2005-06-20 11:42:23 +00:00
Stefan Leichter fcd6764928 Make shell32 tests loadable on NT4. 2005-06-20 10:31:14 +00:00
Mike McCormack 383302c11e Make functions static. 2005-06-20 10:30:15 +00:00
Francois Gouget 6394a15314 Assorted spelling fixes. 2005-06-17 20:59:49 +00:00
Francois Gouget 9769816b6e Fix winapi_check documentation warnings. 2005-06-17 20:58:33 +00:00
Francois Gouget f9280a3a95 Protect the unistd.h and sys/stat.h includes.
Include config.h.
Fixes warnings reported by winapi_check.
2005-06-17 20:56:02 +00:00
Michael Jung ff75b415d2 Remove trailing backslash from DOS paths in GetDisplayNameOf. 2005-06-17 12:12:35 +00:00
Marcus Meissner 96ebd31066 ExtractAssociatedIconA needs to allocate enough space to have EAIW
fill in lpIconPathW.
2005-06-17 09:52:33 +00:00
Mike McCormack 4d2d627c3f - forward AddRef, Release, QueryInterface and GetClassID to internal
implementations
- implement GetClassID properly
2005-06-16 10:43:50 +00:00
Mike McCormack 64a3b82831 SHCreateStreamOnFileW is implemented in shlwapi, so we don't need
another implementation in shell32.
2005-06-16 09:46:17 +00:00
Mike McCormack 0a44661d6f Switch IShellLink to use shlwapi.SHCreateStreamOnFileW. 2005-06-16 09:46:05 +00:00
Michael Jung e5ef9dd8dc Test GetAttributesOf on the MyComputer shellfolder. 2005-06-16 09:44:50 +00:00
Michael Jung e2dbc8044a Added tests for SHGetPathFromIDList. 2005-06-15 18:07:55 +00:00
Huw Davies 47db6bc567 Unquote the icon file path if it's quoted. 2005-06-15 18:07:43 +00:00
Mike McCormack c62940a1ac Remove some uses of wine/unicode.h functions. 2005-06-15 10:21:46 +00:00
Michael Jung ebb1aaee86 Implement SHGetPathFromIDList based on GetDisplayNameOf. 2005-06-15 10:20:00 +00:00
Michael Jung 8b4b4b3af2 Replace magic error constant. 2005-06-14 19:18:26 +00:00
Michael Jung 81b7509f3b Use SHGetPathFromIDList instead of SHELL32_GetPathFromIDList. 2005-06-14 19:17:41 +00:00
Michael Jung bb19a58a93 Return the correct attributes for the desktop folder.
Corresponding tests.
2005-06-14 18:10:24 +00:00
Michael Jung 5664a68033 Added tests to compare SHGetPathFromIDList and GetDisplayNameOf. 2005-06-14 17:21:25 +00:00
Mike McCormack 215bd9a70b Add the IContextMenu interface to the ShellLink object. 2005-06-14 11:38:55 +00:00
Mike McCormack 0569609e3d Implement ShellLink's IShellExtInit::Initialize() method. 2005-06-13 19:04:17 +00:00
Mike McCormack d4eb4f54ed - add the IShellExtInit interface to the ShellLink object
- use inline functions rather than macros to resolve the
  implementation pointer from an interface pointer
2005-06-13 11:50:09 +00:00
Michael Jung 71404a7372 Set the FILESYSANCESTOR and FILESYSTEM flags correctly in
GetAttributesOf.
2005-06-10 19:31:59 +00:00
Saulius Krasuckas 83ac47e53c Get current directory during tests on win9x too. 2005-06-09 12:05:50 +00:00
Mike McCormack fa1b7822a5 Add the IShellLinkDataList interface to the ShellLink object. 2005-06-09 12:05:38 +00:00
Mike McCormack 8e2cb0835c Add a cast to get rid of a warning. 2005-06-09 09:46:23 +00:00
Michael Jung d1f59dba67 Use shell icon cache instead of an own IExtractIcon implementation. 2005-06-09 09:43:18 +00:00
Mike McCormack b64186ad22 Warning fixes for -Wmissing-declarations and -Wwrite-strings. 2005-06-07 20:30:30 +00:00
Juan Lang ab88fd34dc Const-ify a mask. 2005-06-07 20:03:39 +00:00
Dmitry Timoshkov eba47f1dfe Make remaining OLE interface vtables const. 2005-06-06 19:50:35 +00:00
Michael Jung d20fde8a80 Allow for unixfs folders to be rooted at desktop level.
Moved dos->unix path conversion into canonicalize_path.
Fail in BindToObject, if called with empty pidl.
2005-06-06 19:37:47 +00:00
Michael Jung 38f2ee9d04 Let BindToObject fail, if called with empty relative pidl.
Tests to show that it should do so.
Fix SHBrowseForFolder to not pass an empty pidl to BindToObject.
2005-06-06 10:04:15 +00:00
Juan Lang 4571d0187f Set default for "My Documents" to $HOME, and "Desktop" to ~/Desktop. 2005-06-02 19:39:24 +00:00
Mike McCormack 4c6149ee0c Eliminate some -Wwrite-strings warnings. 2005-06-01 11:04:26 +00:00
Stefan Dösinger ea18de5f58 *Handle cidl==0 in shfldr_desktop, shfldr_fs and shfldr_mycomp.
*Remove the dwAttributes member from the IGenericSFImpl class, it's
not needed and can't be initialised in Initialize and InitializeEx.
2005-05-26 16:09:12 +00:00
Michael Jung 3c3495ea51 Add a new CLSID for UnixDosFolder, which is identical to UnixFolder,
but does unix <-> dos path conversion for GetDisplayNameOf and
ParseDisplayName.
2005-05-24 11:45:47 +00:00
Michael Jung 8016f6cc62 More robustly query the SHGDN_FORPARSING flag in the shell32's folders
GetDisplayNameOf methods.
2005-05-23 16:31:42 +00:00
Alexandre Julliard aebb745488 Comment out stub WEP entry points so that we can call WEP for builtin
dlls too.
2005-05-23 10:12:26 +00:00
Alexandre Julliard 0ddd30b0b6 Removed unnecessary code in the 16-bit DllEntryPoint function of some
dlls, and also fixed its ordinal in a few places.
2005-05-23 10:00:26 +00:00
Michael Jung 82ed0ce999 Consider only the GIL_FORSHORTCUT flag in SIC_CompareEntries. 2005-05-20 18:58:35 +00:00
Kouji Sasaki c1f2824429 Added the processing for determination of SFGAO_HASSUBFOLDER flag in
SHELL32_GetItemAttribute function.
2005-05-18 09:43:39 +00:00
Juan Lang f12eadf7bf - only log unsupported flags in ShellExecute
- environment variables are expanded, so SEE_MASK_DOENVSUBST is
  supported
2005-05-14 11:06:54 +00:00
Ge van Geldorp 40cb98269b Overlay icons for .lnk files with a small arrow in the lower left
corner.
2005-05-13 17:48:33 +00:00
Mike McCormack 3e2cb75349 Remove some unused include files. 2005-05-13 13:59:15 +00:00
Michael Jung a858a5a76c Replace '\\' by '/' in strings passed to ParseDisplayName to be able
to handle DOS-style relative paths.
2005-05-13 13:55:03 +00:00
Mike McCormack 1ae212a105 Split SHGetFileInfoW into two functions. 2005-05-12 09:56:48 +00:00
Michael Lin 9bd101d012 - Implement IPersistFolder2.
- Retrieve the correct attributes in ParseDisplayName().
2005-05-12 09:56:04 +00:00
Juan Lang 2439b5fdda Fixes to IShellFolder::GetAttributesOf implementations, spotted by
silverblade_:
- a count of zero is allowed to GetAttributesOf if apidl is NULL
- SFGAO_VALIDATE must be cleared upon return
2005-05-10 08:28:11 +00:00
Mike Hearn 25abe7c537 Fix SHELL_GetPathFromIDList[AW] to return the desktop path given an
empty PIDL.
2005-05-10 08:27:23 +00:00
Michael Jung ea3793b79d Support folder relative paths in UnixFolders' ParseDisplayName
method.
2005-05-09 19:33:01 +00:00
Alexandre Julliard 34fa35dc99 Added rules for building import libraries in the individual dll
makefiles, and added support for building a .def.a static import
library too.
2005-05-09 14:42:30 +00:00
Michael Jung 3a117bccd8 Always pass fully qualified paths to stat system call. 2005-05-09 09:26:02 +00:00
Huw Davies da13552c55 It makes no sense to have a left pointing arrow as the desktop icon.
Replace it with something more appropiate.
2005-05-09 09:25:28 +00:00
Robert Lunnon f4949b8d80 Make references to NAME_MAX refer to PATH_MAX instead. 2005-05-07 14:50:00 +00:00
Alexandre Julliard d62356aa1e Added rules to build import libraries in the individual dll makefiles.
Generate import libraries with the right name right away instead of
using an intermediate .spec.def file.
2005-05-07 12:39:52 +00:00
Michael Jung fc40dcf985 Make the root of the shell extension map to the root of the unix
filesystem.
2005-05-07 12:17:02 +00:00
Michael Jung 15934680f7 Return a cloned PIDL by SHBrowseForFolder to avoid heap corruption. 2005-05-06 19:33:06 +00:00
Michael Jung 94e5f01275 Display a drive icon for the unix root directory. 2005-05-06 19:32:54 +00:00
Francois Gouget 821d4c4645 Fix nativeapi.pm so it knows about AC_HEADER_STAT().
Make the error message about unexpected '#ifdef HAVE_XXX' clearer.
Protect sys/stat.h #includes with the corresponding '#ifdef HAVE_XXX'
check.
2005-05-06 16:22:54 +00:00
Francois Gouget f5c9da6860 Assorted spelling fixes. 2005-05-06 15:44:31 +00:00
Michael Jung 45bcdd2be1 Fixed GetDisplayNameOf method to not depend on incorrect behaviour
regarding the SHGDN_INFOLDER flag.
2005-05-05 10:30:51 +00:00
Michael Jung ddc26aa94e Fixed MyComputer's GetDisplayNameOf method. 2005-05-05 10:30:39 +00:00
Mike McCormack 2b2c6f2fba Remove static variables in SHBrowseForFolder implementation. 2005-05-04 09:48:15 +00:00
Mike McCormack 95a58eba7d Split up the window procedure. 2005-04-28 18:26:58 +00:00
Gerald Pfeifer 039869eed1 Include <limits.h> to get a definition of NAME_MAX. 2005-04-27 08:12:08 +00:00
Michael Jung 3abb5bd6bb Support for regular files (as opposed to directories). 2005-04-25 10:56:29 +00:00
Michael Jung 025bc2d8a2 Use the shell32 typical binary format for ITEMIDLISTs. 2005-04-22 21:29:17 +00:00
Michael Jung 2a788026a3 Fixed incorrect IShellFolder::EnumOjects API usage. 2005-04-22 19:07:00 +00:00
Mike McCormack 5960e7c93c MSI advertised shortcuts don't require a product ID. 2005-04-22 19:06:12 +00:00
Peter Berg Larsen 56c34e1b2c Rewritten DoEnvironmentSubst16. 2005-04-21 17:14:39 +00:00
Francois Gouget 4527aae24f Assorted spelling fixes. 2005-04-19 09:49:38 +00:00
Troy Rollo 98d336c363 Fix SEGV for non-fully-qualified destination paths.
Don't fail ShFileOperationW if FOF_ALLOWUNDO is passed.
2005-04-19 09:49:05 +00:00
Francois Gouget 3b36eee083 Add trailing '\n's to ok() calls. 2005-04-19 09:48:44 +00:00
Peter Berg Larsen 6e3bcb5a54 Replace strncpy with memcpy or lstrcpyn. 2005-04-18 10:30:55 +00:00
Huw Davies 7ac969d560 When we're hiding file extensions then SetNameOf should append the
original extension if SHGDN_FORPARSING isn't set.
The flags passed to SetNameOf refer to the dst string not the src
pidl.
2005-04-15 16:11:45 +00:00
Martin Fuchs d3b5018275 Correct comments of some export ordinals. 2005-04-13 15:17:16 +00:00
Huw Davies 0e5b772cdc Add a unicode pidl type.
Improve support for PT_YAGUID.
Improve IShellLink debugging.
2005-04-13 14:39:27 +00:00
Steven Edwards ad7f4daf35 Register Shell Drag and Drop Helper. 2005-04-13 11:07:49 +00:00
Michael Jung 9a4f552f2f Implemented the UnixFolder's IShellFolder2::CompareIDs method. 2005-04-13 11:01:10 +00:00
Huw Davies be428abd3e Better icon handling for some special folders.
Identify and add defines for a bunch of shell icons.
2005-04-12 12:00:40 +00:00
Michael Jung d1f1d34c2b Implemented enough of IShellFolder2 to make UnixFolder work within the
open/save-dialogs.
2005-04-12 11:58:05 +00:00
Huw Davies 52cf1992ea If ICommDlgBrowser_OnDefaultCommand returns anything other than S_OK
then we should call the default handler.
2005-04-12 10:16:35 +00:00
Juan Lang 7376f57c30 Use Unicode string result from GetDisplayNameOf if it isn't
representable using ANSI.
2005-04-12 10:15:29 +00:00
Huw Davies 8dabf51d39 Directory items should have the SFGOA_FILESYSANCESTOR attribute.
Add a test for this and cleanup the shlfolder test a bit.
2005-04-11 18:50:01 +00:00
Huw Davies 861282bf28 Fix the icon resource ids (most were off by one).
Fix IExtractIcon_{GetIconLocation,Extract} to use -ve icon resource
ids and fix bugs relating to confusion between resource ids and the
system imagelist indicies.
Extend the system imagelist initialization hack to load both +ve and
-ve resource ids.
Add a printer icon (that'll be used by an upcoming printer folder
patch).
2005-04-11 13:04:41 +00:00
Mike McCormack 7340a357ba Fix up PIDL dumping code. 2005-03-31 10:05:59 +00:00
Francois Gouget 6b10c324c5 Assorted spelling fixes. 2005-03-30 17:08:31 +00:00
Mike McCormack a5cb5a2ab3 Use api definitions, remove duplicate code. 2005-03-27 17:54:48 +00:00
Paul Vriens 0b3b35116a Print retval in decimal to avoid confusion.
NT4 fails with ERROR_INVALID_TARGET_HANDLE instead of
ERROR_REDIR_PAUSED.
Use some correct messages on error.
Extra tracing.
2005-03-25 20:47:50 +00:00
Jakob Eriksson 9ed61de9a2 Get rid of HeapAlloc casts. 2005-03-24 21:01:35 +00:00
Francois Gouget 93416cdaf7 Assorted spelling fixes. 2005-03-23 13:15:18 +00:00
Jakob Eriksson 4fead33f30 If the device gets interrupted, we just give up. 2005-03-22 21:16:24 +00:00
Jakob Eriksson b718b0b019 StrRetToStrNAW returns ok on NT4, though it should return FALSE. 2005-03-22 18:19:13 +00:00
Mike McCormack 17c3106896 Eliminate casts of the return value of HeapAlloc. 2005-03-21 11:25:13 +00:00
Mike McCormack fd40ace3d3 Fix usage of STGM_ enumerations, remove forward declaration. 2005-03-19 17:09:14 +00:00
Mike McCormack 2597b1beca Remove forward declarations of interface methods. 2005-03-19 17:09:03 +00:00
Mike McCormack b7cc006c33 Remove an unused function. 2005-03-19 17:08:52 +00:00
Jon Griffiths dbf222f3aa Use LMEM_ flags for LocalAlloc(), not GMEM_ (GlobalAlloc). 2005-03-17 20:53:37 +00:00
Aric Stewart 984931bd09 For ShellExecuteExA we need to copy out the hProcess value from the W
structure.
2005-03-17 20:50:53 +00:00
Mike McCormack 4098dc64ca Remove some dead code and some ifdefs. 2005-03-17 18:55:49 +00:00
Mike McCormack c9bd224f0f Fix a regression in the file open dialog. 2005-03-17 18:55:16 +00:00
Mike McCormack b12ce9b446 Convert path to unicode, rearrange to remove forward declaration. 2005-03-17 13:57:38 +00:00
Filip Navara 9f2bbd6566 _dbg_ILGetNext returns NULL if pidl->mkid.cb is zero, fix the loops
accordingly.
2005-03-16 19:51:13 +00:00
Juan Lang 2786964da2 Correct registering shell folders (values in Shell Folders key weren't
getting written).
2005-03-16 11:37:46 +00:00
Martin Fuchs 824353d01b - switch to correct shell desktop context menu
- launch desk.cpl when activating the desktop context menu entry
  "properties"
- don't send WM_COMMAND if we didn't get a shell view window
2005-03-14 10:49:03 +00:00
Michael Jung 015d2a4dbe Beginning of a shell namespace extension to browse the unix
filesystem.
2005-03-09 16:41:17 +00:00
Dimitrie O. Paun c02dd0a902 Add support for .exe's with exported functions. 2005-03-08 16:55:26 +00:00
Mike McCormack 2c8367a3de Use lstrcmpiA in preference to strcasecmp. 2005-03-07 11:05:03 +00:00
Huw Davies 5be005b0d5 Don't prepend '\\' to the subkey name. 2005-03-03 13:52:06 +00:00
Francois Gouget fbb3343547 Assorted spelling fixes. 2005-03-02 13:53:50 +00:00
Juan Lang 316df99bf9 Convert more API calls to Unicode. 2005-03-02 10:16:41 +00:00
Michael Jung 6bc9999e08 Fixed parsing of ITEMIDLIST in InitializeTreeView.
Added some documentation.
Fixed a crash occuring when the user double-clicks a leaf item.
2005-03-01 11:45:32 +00:00
Juan Lang 88cf8ce5ac Convert tabs to space, wrap long lines, make indenting consistent. 2005-03-01 10:41:14 +00:00
Juan Lang b7dac96974 Convert a few calls to Unicode. 2005-02-26 17:41:26 +00:00
Mike McCormack 64c3208e10 - implement loading and saving of MSI advertised shortcut info
- make more test cases pass
- read and write the location block
- improve the binary compatibility of lnk files
2005-02-25 16:19:57 +00:00
Jon Griffiths eb5bf7dd38 Documentation spelling fixes. 2005-02-25 14:07:56 +00:00
Mike McCormack d68294f06f Remove tabs and reformat. 2005-02-23 15:41:39 +00:00
Francois Gouget d95630ebf3 Add the -noname flag to match the Platform SDK. 2005-02-23 15:41:14 +00:00
Mike McCormack f8a4f6b59b - handle IFileSystemBindData in ISF_Desktop_fnParseDisplayName
- more Unicode conversion
2005-02-23 12:45:12 +00:00
Francois Gouget 14de57089e Don't hardcode ordinals if which are not hardcoded on Windows. 2005-02-23 12:44:43 +00:00
Mike McCormack 3b2019badb Make lstr* functions inline inside Wine. 2005-02-22 15:50:13 +00:00
Mike McCormack 0d735ac9be - handle IFileSystemBindData in IShellFolder::ParseDisplayName
- convert IShellFolder::ParseDisplayName to use Unicode
2005-02-22 15:47:21 +00:00
Mike McCormack 3d9ba61478 Cleanup, create unicode versions of _ILCreateFromPath,
_ILCreateGuidFromStr, and _ILCreateFromFindData.
2005-02-22 14:50:35 +00:00
Hans Leidekker 2294e30dd4 - Revert wrong -noname markup for Drag*, DoEnvironmentSubst and
SHGetNewLinkInfo{A,W}.
- Also mark stub exports -noname when they are exported by ordinal
  only on win98/2k.
- Implementation level stubs for SheChangeDirA, SheGetDirA,
  SHHelpShortcuts_RunDLL{A,W}.
- New spec file stubs for Control_RunDLLAsUserW,
  FixupOptionalComponents, OCInstall, SHChangeNotifySuspendResume,
  SHCreateProcessAsUserW, SHExtractIconsW,
  SHInvokePrinterCommand{A,W}, SHIsFileAvailableOffline,
  SHLoadNonloadedIconOverlayIdentifiers, SHPathPrepareForWrite{A,W},
  ShellExec_RunDLL{,A,W}, SHGetIconOverlayIndex{A,W}.
2005-02-21 18:37:33 +00:00
Mike McCormack 59ce35aba8 Remove tabs and make formatting consistent. 2005-02-21 18:36:47 +00:00
Hans Leidekker c6806cd204 Mark exports -noname when they are exported by ordinal only on
win98/2k.
2005-02-18 20:13:01 +00:00
Dmitry Timoshkov 9074f257e0 Convert winemenubuilder to unicode. 2005-02-17 11:51:44 +00:00
Joris Huizer e889f71269 - renamed file_operation_delete and to shfileops_delete
- renamed file_operation_checkFlags to shfileops_check_flags
- added helper function shfileops_do_operation()
- added helper function shfileops_get_parent_attr()
- added helper function shfileops_get_parent_attr2()
- various cleanups in SHFileOperationW using these functions
2005-02-17 11:50:25 +00:00
Alex Villacís Lasso 18bfe6a095 Change SUBLANG_DEFAULT to SUBLANG_NEUTRAL for LANG_SPANISH in all
resources, so that Spanish locales other than Spain also use Spanish
resources.
2005-02-16 21:10:59 +00:00
Huw Davies 084e596a95 SetPath("") should return S_OK.
SetPath("nonexistent_path") should return S_FALSE.
2005-02-16 16:27:42 +00:00
Dmitry Timoshkov 39f960bdfa - Fix prototypes of GetClassLongA/W, GetClassLongPtrA/W and
SetClassLongA/W according to SDK definitions.
- Add prototypes for SetClassLongPtrA/W, protect some GWL_ and GCL_
  constants from using in Wine or in _WIN64 mode.
- Fix all places in Wine affected by the above changes.
2005-02-15 21:51:06 +00:00
Mike McCormack af882e0e41 Reindent some code to improve readability. 2005-02-15 20:45:53 +00:00
Mike McCormack a830bf55ca Define some extra SHFGI values. 2005-02-15 15:43:54 +00:00
Francois Gouget 208df0eb52 Test the interaction between IShellLink::SetIDList() and
IShellLink::SetPath().
Check what default values one gets on a fresh IShellLink object.
Add some more tests verifying nothing is lost in an IShellLink
save/load cycle. Merged the empty shelllink test with these.
2005-02-14 11:52:29 +00:00
Marcelo Duarte 574c0edabb Update the resources for Portuguese. 2005-02-14 11:12:30 +00:00
Marcus Meissner 30ed10004b Output some more informations.
Mark one global variable static.
2005-02-14 11:07:55 +00:00
Filip Navara 4d20d165ff Don't crash if ShellFolder doesn't implement the IID_ISFHelper
interface.
2005-02-14 11:06:48 +00:00
Ge van Geldorp a912c2a885 Error numbers >= 32 are to be expected. 2005-02-14 11:03:21 +00:00
Francois Gouget 4d801b66e6 Assorted spelling fixes. 2005-02-10 19:19:35 +00:00
Ge van Geldorp 9cc5e6cd03 - Fix quoting of .cpl filename.
- Use "cplopen" verb to execute .cpl files.
2005-02-09 13:25:13 +00:00
Francois Gouget da8b3dd7f2 Assorted spelling fixes. 2005-01-26 21:09:04 +00:00
Mike McCormack 18fb9ace14 Implement GetAdvise and SetAdvise. 2005-01-21 10:16:11 +00:00
Henning Gerhardt e34aac5038 A small spelling fix and a small update (thank to Andreas Mohr). 2005-01-17 19:32:58 +00:00
Henning Gerhardt 038c5cbcbf Update German resources. 2005-01-17 13:43:16 +00:00
Joris Huizer 2d58a624dd - add file_operation_delete
- add file_operation_checkFlags
- use these in SHFileOperationW replacing inline code
2005-01-14 16:51:14 +00:00
James Hawkins ba92d2924a - Use Interlocked* instead of ++/-- in AddRef/Release.
- Use only stored result of Interlocked* in AddRef/Release.
- Expand TRACEs to display the ref count.
2005-01-14 16:02:20 +00:00
Klemens Friedl a4d4652dd1 Update German language file. 2005-01-14 15:13:56 +00:00
Robert Shearman 3dad1f9043 Don't sort the children of My Computer in shell browse for folder
dialog.
2005-01-11 10:40:14 +00:00
Eric Pouech cf1d00bb08 Removed excessive statement (break after return or goto, not useful
break, not needed vars...)
2005-01-09 16:42:53 +00:00
Hans Leidekker c1236fd120 Stub implementations for SHUpdateImageA, SHHandleUpdateImage,
SHObjectProperties, SHGetNewLinkInfo{A,W}, SHStartNetConnectionDialog,
SHEmptyRecycleBin{A,W}, SHFormatDrive, SHQueryRecycleBin{A,W}.
'HeapAlloc can fail' fix for ExtractIconExA.
Implement ExtractAssociatedIconA -> W.
Correct prototype for SHObjectProperties.
Forward SHGetNewLinkInfo to SHGetNewLinkInfoA.
2005-01-03 20:26:06 +00:00
Jacek Caban 76d4edf1f0 Get rid of W->A call. 2005-01-03 14:39:08 +00:00
Rein Klazes 3714a39867 Correct cases where arguments of ok() calls depend on the order in
which they are evaluated.
2004-12-27 17:26:37 +00:00
Michael Stefaniuc 5ad7d858e0 Do not check for non NULL pointer before HeapFree'ing it. It's
redundant.
2004-12-23 17:06:43 +00:00
Alexandre Julliard 758b2887e9 Remove some no longer needed AW functions. 2004-12-17 19:20:07 +00:00
Rein Klazes 71e322b29f ShellExecuteEx, ExtractIconEx, SHFileOperation, SHGetFileInfo,
SHGetPathFromIDList spec entries always refer to the Ansi
version. Problem found by Paul Vriens.
2004-12-17 19:05:46 +00:00
Jon Griffiths f82272c92f Remove unneeded headers to reduce unneeded rebuilds. 2004-12-16 14:35:55 +00:00
Eric Pouech 4056d7ef8c Fixed some errors in function prototypes. 2004-12-13 21:19:01 +00:00
Alexandre Julliard ebe3c529b1 Janitorial: C booleans must not be compared against TRUE. 2004-12-09 14:07:59 +00:00
José Manuel Ferrer Ortiz 7a03fd6763 Added some Spanish translations. 2004-12-09 13:44:20 +00:00
Klemens Friedl 586930973d More Windows-like About dialog. 2004-12-09 11:39:31 +00:00
Robert Shearman cba8763c33 Remove unnecessary WNDPROC casts. 2004-12-06 11:51:29 +00:00
Stefan Leichter 9cc5c15795 Fix missing imports of the test program on NT4. 2004-12-06 11:45:13 +00:00
Juan Lang d179f8be8c Revert shell32 version to Win2K SP4 level. 2004-12-06 11:34:07 +00:00
Eric Pouech 0a258964c2 Const correctness fixes. 2004-11-30 21:38:57 +00:00
Tom Wickline 5c38e1b561 Version resources cleanup. 2004-11-23 13:59:34 +00:00
Alexandre Julliard 405568801e Removed a couple of no longer needed entries. 2004-11-19 18:28:05 +00:00
Robert Shearman 18988663c2 - Use more specific error codes than E_FAIL, where possible.
- Move vtable to end, give it the const modifier, and remove unneeded
  function declarations.
2004-11-19 18:14:47 +00:00
Aric Stewart 990ea44e98 Implementation of PathCleanupSpec. 2004-11-04 04:54:08 +00:00
Fabrice Ménard 7ce764669e Check the type of error returned by SHCreateDirectoryExW. 2004-11-02 05:22:39 +00:00
Rolf Kalbermatter e50a27de04 Use SHCreateDirectoryEx function instead of doing explicit recursive
directory creation.
2004-10-28 20:58:51 +00:00
Rolf Kalbermatter a2ebf8b356 Add test for SHCreateDirectoryEx function.
Fixed some typos.
2004-10-28 20:58:38 +00:00
Fabrice Ménard 8818ded2dc Some French translations added. 2004-10-27 21:36:17 +00:00
Rolf Kalbermatter 87fb440e71 Fix bad memory allocation for unicode buffer. 2004-10-27 21:18:35 +00:00
Juan Lang c639af64be _SHExpandEnvironmentStrings should return input string if no % found
to expand, and should call ExpandEnvironmentStringsW if it doesn't
handle an environment variable directly.  Based on a patch from Dan
Kegel.
2004-10-27 21:17:30 +00:00
Ge van Geldorp b3f2c53155 Use only one .res file. 2004-10-27 00:47:53 +00:00
Juan Lang 217bd082c6 Update shell32's version to WinXP level. 2004-10-26 21:17:50 +00:00
Juan Lang 535679aec7 Fix CSIDL_CONTROLS and CSIDL_PRINTERS PIDL types, and update tests now
that they pass.
2004-10-26 00:17:31 +00:00
Juan Lang 4a6a898e2d Avoid copying invalid data on error. 2004-10-25 21:53:18 +00:00
Sami Aario c2dcecc362 Check the return value of the SHGetDesktopFolder call. 2004-10-25 21:45:36 +00:00
Francois Gouget 3bb5b093e8 Assorted spelling fixes. 2004-10-22 22:27:51 +00:00
Alexandre Julliard 2d2e2e1e55 Avoid copying invalid data on error. 2004-10-22 20:26:23 +00:00
Francois Gouget a1779c1e33 Fix the function pointer declarations so MSVC likes them.
CSIDL_PROFILES is not defined in the Windows SDK.
snprintf and strcasecmp don't exist on Windows. Replace them with
wnsprintfA and lstrcmpiA respectively.
2004-10-22 20:25:46 +00:00
Mike McCormack 43149f490c Add a test for creating empty shelllink files. 2004-10-22 19:52:33 +00:00
Rolf Kalbermatter eb883577e4 - SHCreateDirectory should create intermediate directories if
necessary.
- Remove extra boolean parameter in SHNotifyMoveFile as it is not
  used.
- Use in SHFileOperation the function SHNotifyCreateDirectory instead
  of SHCreateDirectoryEx as it does not anymore what is needed here.
- Fix several unsigned/signed mismatch warnings.
2004-10-21 22:29:42 +00:00
Ge van Geldorp 9b399da426 - Don't double-quote an already double-quoted argument.
- Properly increment the fmt pointer.
2004-10-21 20:59:25 +00:00
Juan Lang 9cbc42bbae - the correct registry location to override is User Shell Folders, not
Shell Folders
- if User Shell Folders doesn't exist in HKCU, HKLM should be tried
- SHGetSpecialFolderPath should call SHGetFolderPath, not vice-versa
- the default values should be localizable
- some of the parameter checking and returned LPITEMIDLISTs were a bit
  off
2004-10-21 19:59:46 +00:00
Vincent Béron 6c644d68cf Fix various function prototypes. 2004-10-19 23:55:15 +00:00
Mike McCormack d5b0e0f01e Convert the shellmenu code to use unicode. 2004-10-19 03:56:40 +00:00
Vincent Béron 4eeae1adb3 Fix some types problems. 2004-10-18 22:39:21 +00:00
Rolf Kalbermatter 20952a5d23 Modify ANSI functions to allocate intermediate Unicode strings on the
heap instead of stack.
2004-10-18 21:45:16 +00:00
Rolf Kalbermatter 29d4ec4f85 Added SHFreeNameMappings implementation. 2004-10-18 19:33:45 +00:00
Vitaliy Margolen 64c63dd4b8 Sort files/folders before testing. 2004-10-11 19:52:23 +00:00
Francois Gouget 486d020c1b Don't define COBJMACROS in objbase.h.
Update the Wine sources accordingly.
2004-10-07 03:06:48 +00:00
Francois Gouget 75be67c6c0 Conformance tests must not include wine/debug.h. 2004-10-07 02:59:11 +00:00
Rolf Kalbermatter 18514ca547 Fix bug found by Piotr Caban, where our function tried to delete a
directory eventhough the user canceled the operation.
2004-10-06 00:04:39 +00:00
Francois Gouget 67aa858a31 Assorted spelling fixes. 2004-10-05 18:15:29 +00:00
Alexandre Julliard 739e5b06da Avoid depending on the non-standard IUnknown_METHODS macro in Wine
internal headers.
2004-10-05 04:16:21 +00:00
Alexandre Julliard ed19983d65 Fixed typo in ProgramsW.
Changed the case of windows and system directories to match the
directories we create by default.
2004-10-04 20:49:51 +00:00
Piotr Caban 304e0796cd Added Polish translation. 2004-10-04 19:31:50 +00:00
Ge van Geldorp 3db9386195 Can't pass NULL as default value to GetPrivateProfileString. 2004-10-04 19:05:02 +00:00
Alexandre Julliard 72c9008e73 Authors: Klemens Friedl <frik85@hotmail.com>, Martin Fuchs <martin-fuchs@gmx.net>
- drive icon artwork
- display different drive icons depending on the drive type
2004-09-29 21:13:58 +00:00
Robert Shearman 8e80468170 Simplify getting custom icons for a folder by utilising the new
SHELL32_GetCustomFolderAttribute function.
2004-09-28 19:33:57 +00:00
Robert Shearman 5ad2d3517f - Add support for custom shell folders, such as the History folder.
- Always try to initialize folder using IPersistFolder3 interface and
  then fall back on IPersistFolder if not supported.
2004-09-28 19:33:44 +00:00
Ge van Geldorp 535387aeb1 Call GetProcessHeap() instead of passing its address. 2004-09-27 20:34:49 +00:00
Martin Fuchs 7ccc2d25a2 - Use system metrics to determine icon sizes.
- Move invalid index from 1 to 0.
2004-09-24 01:10:31 +00:00
Martin Fuchs 09878e1c6a At least print message if we're not returning requested data. 2004-09-23 22:52:03 +00:00
Ge van Geldorp e63e3781c6 Some windres versions don't like POPUP"", change to POPUP "". 2004-09-23 04:28:04 +00:00
Steven Edwards e85b67bd9e Remove some unneeded include statements. 2004-09-23 04:27:24 +00:00
Robert Shearman bbdac5e475 GetWindowLong -> GetWindowLongPtr. 2004-09-22 19:14:08 +00:00
Martin Fuchs 1c8d9b66c3 Store absolute path in .lnk file. 2004-09-22 19:11:27 +00:00