Hugh McMaster
9be3c53701
regedit: Use the heap_*() functions in regedit.c where possible.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-27 17:04:04 +02:00
Hugh McMaster
a3e043b82e
regedit: Use the heap_*() functions in framewnd.c where possible.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-27 17:04:04 +02:00
Hugh McMaster
6238cd46f2
regedit: Use the heap_*() functions in edit.c where possible.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-27 17:04:04 +02:00
Hugh McMaster
c193bffb3e
regedit: Use the heap_*() functions in childwnd.c where possible.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-27 17:04:04 +02:00
Hugh McMaster
1b3afb27c7
regedit: Use heap_xrealloc() for consistency.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-27 17:04:04 +02:00
Hugh McMaster
f7bdf34029
regedit: Use a helper function to free allocated memory.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-27 17:04:04 +02:00
Hugh McMaster
79ff4148c2
regedit: Use a helper function to allocate memory and check for a valid pointer.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-27 17:04:04 +02:00
Hugh McMaster
976c2aa649
regedit: Prevent out-of-bounds reads when unescaping a string (Valgrind).
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-26 22:14:00 +02:00
Hugh McMaster
5bd636dc16
regedit: Check for a valid subkey pointer before attempting to delete a registry key (Coverity).
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-24 18:58:31 +02:00
Hugh McMaster
b501b2388d
regedit: Free the value name buffer from the default value name parser state if necessary (Valgrind).
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-24 18:58:31 +02:00
Hugh McMaster
d62fb29866
regedit: Re-size the data export buffer using the required size instead of doubling it.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-20 16:27:05 +02:00
Hugh McMaster
9d23db6b12
regedit: Remove unused header includes from regproc.c.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-20 16:27:04 +02:00
Hugh McMaster
cc1d2525c4
regedit: Remove an unused #define.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-20 16:27:04 +02:00
Hugh McMaster
6effc48365
regedit: Export value names from the export_data() function.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-19 19:13:29 +02:00
Hugh McMaster
97383a14f7
regedit: Append a newline to the end of the export file.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-19 19:13:29 +02:00
Hugh McMaster
37b5607ff6
regedit: Export REG_SZ data via the export_data() function.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-19 19:13:29 +02:00
Hugh McMaster
6515837ada
regedit: Use a helper function to export hex data and REG_DWORD data.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-19 19:13:29 +02:00
Hugh McMaster
bb147fbaa7
regedit: Export REG_DWORD data from a separate function.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-19 18:52:08 +02:00
Hugh McMaster
40ce665836
regedit: Export value names from a separate function.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-19 18:51:57 +02:00
Hugh McMaster
c189effeb3
regedit: Read registry value information before exporting.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-19 10:50:04 +02:00
Hugh McMaster
efe3bc87e7
regedit: Re-implement some parts of the export operation.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-19 10:47:36 +02:00
Nikolay Sivov
cbd6e05e68
regedit: Simplify double-click listview handler.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-14 10:51:58 +02:00
Hugh McMaster
5a391e18cb
regedit: Use UpdateStatusBar() instead of updating the text manually.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-13 18:34:54 +02:00
Hugh McMaster
683b9992f6
regedit: Remove the listview's sub-class and move its messages to childwnd.c.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-12 19:51:55 +02:00
Hugh McMaster
aa42d81e6d
regedit: Move treeview notify messages to a separate function.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-12 19:51:55 +02:00
Hugh McMaster
9e1278dd47
regedit: Remove the unused _CmdWndProc callback function from listview.c.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-12 19:51:55 +02:00
Hugh McMaster
c4a06a3034
regedit: Update string resources associated with key deletion.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-12 19:51:54 +02:00
Hugh McMaster
66dcf0a87d
regedit: Update some resource strings associated with key parsing.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-12 19:51:54 +02:00
Hugh McMaster
ae147a5bf6
regedit: Output an error message and exit with error code zero instead of calling exit(1).
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-12 19:51:53 +02:00
Hugh McMaster
7d0f2deca3
regedit: Update the listview path when renaming a treeview node.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-12 19:51:53 +02:00
Hugh McMaster
182b6fb545
regedit: Update the status bar text when a treeview node is renamed.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-12 19:51:53 +02:00
Hugh McMaster
7f11a24fee
regedit: Null-terminate REG_EXPAND_SZ and REG_MULTI_SZ hex data during concatenation if we reach EOF.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-10 20:51:11 +02:00
Michael Stefaniuc
a9987fa11a
regedit: Remove a redundant NULL check before HeapFree().
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-07 19:48:32 +02:00
Hugh McMaster
e2ae9e3c58
regedit: Use a function to free the parser data.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-07 19:48:32 +02:00
Hugh McMaster
6f24426692
regedit/tests: Test the effects of EOF on hex data during concatenation.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-07 19:48:32 +02:00
Hugh McMaster
3908296237
regedit: Null-terminate REG_EXPAND_SZ and REG_MULTI_SZ data if the parsed hex data does not end in a null-terminating character.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-06 18:50:48 +02:00
Hugh McMaster
7b95ddcb04
regedit: Hex data lines may be terminated by a semicolon.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-06 18:50:48 +02:00
Hugh McMaster
23c93d3026
regedit/tests: Add some more tests for importing hex data.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-06 18:50:48 +02:00
Hugh McMaster
3afa0e42c8
regedit/tests: Add another test for "0x" prefixes in the hex data type.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-06 18:50:47 +02:00
Hugh McMaster
499733f400
regedit/tests: Check if regedit.exe has elevated privileges before starting some tests.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-06 18:50:47 +02:00
Hugh McMaster
b811b16694
regedit: Do not import the line if a hex data type has a "0x" prefix.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-05 18:21:37 +02:00
Hugh McMaster
1a4c3e5d28
regedit: Check if any hex data exists before attempting to parse it.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-05 18:21:18 +02:00
Hugh McMaster
5cc1b227b7
regedit: Do not remove lines beginning with a semicolon from the read buffer.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-05 18:21:10 +02:00
Nikolay Sivov
d2697467b2
regedit: Remove commented out block.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-05 18:21:06 +02:00
Hugh McMaster
5d8a1283f2
regedit: Do not remove lines beginning with '#' from the read buffer.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-04 19:49:57 +02:00
Hugh McMaster
e336c86359
regedit: Skip blank and whitespace-only lines during hex data concatenation.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-04 19:49:49 +02:00
Hugh McMaster
6ffa89ebd3
regedit: Skip lines that do not begin with a hexadecimal character during hex data concatenation.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-04 19:49:42 +02:00
Hugh McMaster
50caf838b6
regedit: Simplify a while loop for skipping whitespace.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-04 19:49:32 +02:00
Hugh McMaster
50fee455c4
regedit/tests: Test whether the "0x" prefix is valid when importing hex data.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-04 19:49:25 +02:00
Hugh McMaster
506d4fd052
regedit/tests: Test whether registry keys ending with trailing backslashes are imported and created.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-04 19:49:21 +02:00
Hugh McMaster
032d32f940
regedit: Improve the parsing of multiline hex data during the registry import operation.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-03 15:57:44 +02:00
Hugh McMaster
c750c2a98d
regedit: Remove un-necessary parser state assignment if we are returning to the same state.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-03 15:57:44 +02:00
Hugh McMaster
2db2a7aeef
regedit/tests: Test the effect of whitespace-only lines during hex data concatenation.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-03 15:57:44 +02:00
Hugh McMaster
55d43d13e4
regedit/tests: Fix another incorrectly named registry key.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-03 15:57:44 +02:00
Hugh McMaster
817cd2ac59
regedit/tests: Correct out of sequence test numbering.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-29 18:32:06 +02:00
Hugh McMaster
a905b4d6ba
regedit/tests: Test comma placement when parsing hex data.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-29 18:32:06 +02:00
Nikolay Sivov
f4e98d813f
regedit: Remove explicit iIndent field initialization.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-28 18:24:14 +02:00
Nikolay Sivov
b84f228805
regedit: Use notification message to clean up item data.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-28 18:24:11 +02:00
Hugh McMaster
b25337e6d6
regedit: Free the binary data buffer after saving the new value (Coverity).
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-28 18:23:04 +02:00
Hugh McMaster
ec0043f083
regedit/tests: Test whether EOF invalidates a hex data line ending in a backslash.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-27 19:13:54 +02:00
Hugh McMaster
82d3be8094
regedit/tests: Test whether a forward slash can be used as a concatenation marker.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-27 19:13:50 +02:00
Hugh McMaster
81fa517436
regedit/tests: Test the effects of comments and new lines that appear between valid hex data lines.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-27 19:13:48 +02:00
Hugh McMaster
a9726d0b90
regedit/tests: Test whether a line beginning with a backslash can follow a line ending in a backslash.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-27 19:13:44 +02:00
Hugh McMaster
a31f070ada
regedit/tests: Test line concatenation with comments, new lines and comma variations before a new default registry value.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-27 19:13:41 +02:00
Hugh McMaster
db9e4199e0
regedit/tests: Test line concatenation with comments, new lines and comma variations before a new registry value.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-27 19:13:38 +02:00
Hugh McMaster
82263293f6
regedit/tests: Test line concatenation with a new registry key on the next line.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-27 19:13:34 +02:00
Hugh McMaster
6b36ce329d
regedit/tests: Test backslashes with whitespace variations and comma placement.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-27 19:13:32 +02:00
Hugh McMaster
73af2479c7
regedit/tests: Use the verify_key*() functions where possible.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-26 18:19:34 +02:00
Hugh McMaster
f0e21863c9
regedit/tests: Use verify_key() for consistency with the verify_reg*() functions.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-26 18:19:32 +02:00
Hugh McMaster
758340a6e1
regedit: Free the buffer and reset data information on error and after setting the value.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-26 18:19:09 +02:00
Hugh McMaster
a76ce84fce
regedit/tests: Add tests to determine the effects of backslashes in hex data.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-23 15:19:36 +02:00
Hugh McMaster
a1b35b3bc4
regedit/tests: Add tests for parsing hex data.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-22 19:25:16 +02:00
Hugh McMaster
4a70d33552
regedit: Display data for all values in the GUI.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-21 19:15:12 +02:00
Hugh McMaster
878a0a4e14
regedit: Display all registry data types in the GUI.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-21 19:15:12 +02:00
Hugh McMaster
8803b9616b
regedit: Fail when parsing any hex data type that is greater than ULONG_MAX on Windows.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-21 19:15:12 +02:00
Hugh McMaster
e3234f6ede
regedit: Use a generic data type to correctly process all data types.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-20 18:43:30 +02:00
Hugh McMaster
cb563dbac6
regedit: Re-insert the default value item after deleting its data.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-16 15:25:38 +02:00
Hugh McMaster
7f76cf6c26
regedit: Use the correct mask flags with LVM_GETNEXTITEM.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-16 15:25:38 +02:00
Hugh McMaster
1f08ee2453
regedit: Allow the deletion of registry keys beginning with a lowercase 'H'.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-16 15:25:38 +02:00
Hugh McMaster
f535341d2b
regedit: Use a case insensitive comparison when parsing registry classes from registry file versions 4 and 5.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-16 15:25:37 +02:00
Hugh McMaster
8504a1563d
regedit: Free the memory used by the REG_DWORD and hex data types after saving the registry value.
...
We use a BOOL to handle all hex types, including those that are undefined (e.g.0x100).
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-16 15:25:37 +02:00
Hugh McMaster
a1924ae2da
regedit: Export hex data types without warning about unsupported data types.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-16 15:25:37 +02:00
Hugh McMaster
300df08e70
regedit: Remove an unused #define.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-16 15:22:07 +02:00
Hugh McMaster
191b81dbd3
regedit: Add data parsing operations to the state machine.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-15 21:54:38 +02:00
Hugh McMaster
d60c31eadb
regedit: Perform value name operations in the state machine.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-15 18:51:08 +02:00
Hugh McMaster
ca98e23451
regedit: Perform key operations in the state machine.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-15 18:51:08 +02:00
Hugh McMaster
ec87800856
regedit: Introduce a partial state machine for importing registry data.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-15 18:51:08 +02:00
Hugh McMaster
b1e48fb469
regedit: Free the stringValueData buffer before using it again (Coverity).
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-15 15:02:14 +02:00
Hugh McMaster
06b0a6d94d
regedit/tests: Test whether "" is interpreted as the default registry value.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-15 15:02:10 +02:00
Hugh McMaster
c414b2b570
regedit/tests: Output "(Default)" when referring to the default registry value.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-15 15:02:07 +02:00
Hugh McMaster
a726343fa5
regedit: Add status bar text for the 'Expand'/'Collapse' menu item.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-13 20:56:20 +02:00
Hugh McMaster
5058fa70a3
regedit/tests: Test the accepted range of the hex-based data types.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-13 20:56:19 +02:00
Hugh McMaster
955766a13b
regedit/tests: Test case sensitivity when creating and deleting registry keys.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-13 20:56:19 +02:00
Hugh McMaster
8096e23798
regedit/tests: Remove an un-needed tab character from a key in the key deletion tests.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-09 09:18:53 +02:00
Hugh McMaster
afde1624ca
regedit: Do not use REG_NONE as the default data type if strtoulW() fails.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-08 16:44:58 +02:00
Hugh McMaster
5669282e1d
regedit: Do not create registry keys that end without a closing bracket.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-08 16:44:58 +02:00
Hugh McMaster
eca563e9ce
regedit/tests: Add tests for value deletion.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-08 16:44:58 +02:00
Hugh McMaster
247e611de5
regedit/tests: Add tests for key creation and key deletion.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-08 16:44:57 +02:00
Hugh McMaster
75fed2d5a1
regedit: Use shared code to add favourite key items to the 'Remove' listbox.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-06 13:08:46 +02:00
Hugh McMaster
f0949baafc
regedit: Update handling of the 'Modify' menu items.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-05 11:14:12 +02:00
Hugh McMaster
adf298685f
regedit: Only show the 'Modify' menu items when the listview has focus.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-05 11:14:09 +02:00
Hugh McMaster
46bff016ab
regedit: Use the treeview item label in the 'Favourites' menu instead of the key path.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-05 11:12:36 +02:00
Hugh McMaster
27b2519ca4
regedit: Re-implement favourite registry key handling.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-05 11:12:32 +02:00
Hugh McMaster
b332c1a6d5
regedit: Update handling of the 'Modify' menu item.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-02 17:25:30 +02:00
Hugh McMaster
6c752aaf8d
regedit: Update handling of the new subkey and new value menu items.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-01 20:32:20 +02:00
Hugh McMaster
576d300e49
regedit: Update some resource strings.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-01 20:32:18 +02:00
Hugh McMaster
63a2a07e86
regedit: Add status bar text for the 'Modify Binary Data' menu item.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-01 20:30:41 +02:00
Hugh McMaster
6eef9a9554
regedit: Add status bar text for adding a new expandable string value.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-01 20:29:56 +02:00
Hugh McMaster
898ee58aa0
regedit: Fix handling of 'Copy Key Name' menu items.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-01 19:36:48 +02:00
Hugh McMaster
48716cba98
regedit: Update handling of the 'Copy Key Name' menu item.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-31 20:51:47 +02:00
Hugh McMaster
2aff2f612a
regedit: Update handling of the 'Rename' menu item.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-31 20:51:47 +02:00
Hugh McMaster
4144847aa5
regedit: Update handling of the 'Delete' menu item.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-31 20:51:46 +02:00
Hugh McMaster
948278cb7b
regedit: Never disable the 'Find' and 'Find Next' menu items.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-31 20:51:46 +02:00
Hugh McMaster
2689792cd4
regedit: Update the status bar when moving to the 'Computer' root node.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-31 20:51:46 +02:00
Hugh McMaster
06eceb3af2
regedit: Delete a listview item without refreshing the listview.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-30 21:49:51 +02:00
Hugh McMaster
9cd1fc3fc4
regedit: Update the data in a listview subitem without refreshing the listview.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-30 21:49:50 +02:00
Hugh McMaster
f3c4cca7bf
regedit: Add listview entries without refreshing the listview.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-30 21:49:50 +02:00
Hugh McMaster
ebfe566c16
regedit: Update a value name without refreshing the listview.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-30 21:49:50 +02:00
Hugh McMaster
c04f66a59f
regedit: Allow handling of return values from listview notification messages.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-30 21:49:50 +02:00
Hugh McMaster
fe38c9abad
regedit: Move the listview's NM_SETFOCUS handling to listview.c.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-30 21:49:50 +02:00
Hugh McMaster
51743827c9
regedit/tests: Add tests for importing Windows 3.1 registry data.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-26 08:10:41 +02:00
Hugh McMaster
d763aecc24
regedit: Use a separate pop-up menu for the 'Computer' root node.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-24 16:23:59 +02:00
Hugh McMaster
d09571d181
regedit: Add 'Expand' and 'Collapse' options to the treeview pop-up menu.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-24 16:22:18 +02:00
Hugh McMaster
0c9de25955
regedit: Remove duplicate HINSTANCE declaration from main.h.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-24 15:30:23 +02:00
Hugh McMaster
e880c9ca8c
regedit: Only show the 'New' pop-up menu when right-clicking beneath the listview item list.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-22 21:08:08 +02:00
Hugh McMaster
7bf054f198
regedit: Update and sort the pop-up menus.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-22 21:06:20 +02:00
Hugh McMaster
c5d38ce427
regedit: Re-select the listview item after renaming is complete.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-22 21:02:37 +02:00
Hugh McMaster
5474b7a43e
regedit: Always assign focus to the default value when refreshing the listview.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-22 21:02:33 +02:00
Hugh McMaster
7ea0892343
regedit/tests: Re-order the REG_NONE import tests and fix some copy/paste errors.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-19 17:44:22 +02:00
Nikolay Sivov
02b178e791
regedit: Fix a crash when exporting from top level key.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-18 16:17:48 +02:00
Hugh McMaster
d37a49f362
regedit/tests: Add tests for importing REG_BINARY data.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-17 21:57:12 +02:00
Hugh McMaster
5aea192a5a
regedit/tests: Add tests for importing REG_EXPAND_SZ data.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-17 21:57:12 +02:00
Hugh McMaster
2060e426a6
regedit/tests: Add tests for importing REG_NONE data.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-17 21:57:12 +02:00
Hugh McMaster
00a65cd507
regedit/tests: Test whether blank lines affect multi-line concatenation.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-17 21:57:12 +02:00
Hugh McMaster
3ce4beb0a7
regedit/tests: Test if REG_SZ and REG_DWORD support line concatenation.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-17 21:57:12 +02:00
Hugh McMaster
a0f5a2cc12
regedit/tests: Add tests for key name and value name concatenation.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-17 21:57:11 +02:00
Hugh McMaster
82246874d2
regedit: Merge processRegLinesA/W() into their caller.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-05 14:12:18 +02:00
Hugh McMaster
e8f0a8b38b
regedit: Merge header checks from processRegLinesA/W() to their caller.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-05 14:12:18 +02:00
Hugh McMaster
8753a1b271
regedit: Use a function pointer to read each registry line instead of calling get_lineA/W() directly.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-03 22:58:02 +02:00
Hugh McMaster
76b9e6c712
regedit: Return a Unicode line from get_lineA().
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-03 22:58:02 +02:00
Hugh McMaster
6b596ecf9e
regedit: Simplify clean-up in get_lineA/W().
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-03 22:58:02 +02:00
Hugh McMaster
8b5291bca6
regedit: Pass RegQueryValueEx() the actual buffer size (Coverity).
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-01 19:29:14 +02:00
Hugh McMaster
85e34436cd
regedit: Add a missing 'break' statement (Coverity).
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-01 19:29:14 +02:00
Huw Davies
6bc8ecafe8
regedit: Use the system metrics to retrieve the treeview icon sizes.
...
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-27 19:00:25 +02:00
Hugh McMaster
2392743146
regedit: Re-implement processSetValue().
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-25 20:53:07 +02:00
Hugh McMaster
9aff5c88ad
regedit: Validate REG_SZ import data before processing it any further.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-25 20:53:07 +02:00
Hugh McMaster
0481f31d4c
regedit: Simplify parseKeyName.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-25 20:53:07 +02:00
Hugh McMaster
2926c2822c
regedit/tests: Add some more import tests.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-24 20:30:18 +02:00
Hugh McMaster
6f667d1c42
regedit: Only show the context menu if the mouse is over a treeitem.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-20 18:58:46 +02:00
Hugh McMaster
ab0d0c6ee4
regedit: Select the targeted treeview item on right mouse click.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-20 18:58:46 +02:00