Slash some todos (#540)

This commit is contained in:
Nathan Mattes 2022-11-14 17:53:37 +01:00
parent 105a98a395
commit 082e0933d2
3 changed files with 29 additions and 30 deletions

View File

@ -548,6 +548,6 @@ extension SceneCoordinator: MastodonLoginViewControllerDelegate {
}
func nextButtonPressed(_ viewController: MastodonLoginViewController) {
//TODO: @zeitschlag implement, show ASWebAuthentication and stuff
viewController.login()
}
}

View File

@ -133,10 +133,10 @@ class MastodonLoginViewController: UIViewController, NeedsDependency {
}
@objc func nextButtonPressed(_ sender: Any) {
login(sender)
delegate?.nextButtonPressed(self)
}
@objc func login(_ sender: Any) {
@objc func login() {
guard let server = viewModel.selectedServer else { return }
authenticationViewModel
@ -157,7 +157,6 @@ class MastodonLoginViewController: UIViewController, NeedsDependency {
assertionFailure(error.localizedDescription)
case .success(let isActived):
assert(isActived)
// self.dismiss(animated: true, completion: nil)
self.coordinator.setup()
}
}
@ -183,9 +182,10 @@ class MastodonLoginViewController: UIViewController, NeedsDependency {
switch completion {
case .failure(let error):
//TODO: @zeitschlag show error
break
let alert = UIAlertController.standardAlert(of: error)
self.present(alert, animated: true)
case .finished:
// do nothing. There's a subscriber above resulting in `coordinator.setup()`
break
}
} receiveValue: { [weak self] info in
@ -251,7 +251,6 @@ class MastodonLoginViewController: UIViewController, NeedsDependency {
self.view.layoutIfNeeded()
}
}
}
// MARK: - OnboardingViewControllerAppearance

View File

@ -317,7 +317,7 @@ uploaded to Mastodon.";
"Scene.Register.LetsGetYouSetUpOnDomain" = "Lets get you set up on %@";
"Scene.Login.Title" = "Welcome Back!";
"Scene.Login.Subtitle" = "Log you in with the server where you created your account";
"Scene.Login.ServerSearchField.Placeholder" = "Search for your server";
"Scene.Login.ServerSearchField.Placeholder" = "Search server or enter URL";
"Scene.Register.Title" = "Lets get you set up on %@";
"Scene.Report.Content1" = "Are there any other posts youd like to add to the report?";
"Scene.Report.Content2" = "Is there anything the moderators should know about this report?";