Commit Graph

10384 Commits

Author SHA1 Message Date
arvidn d22c44c057 fix kludge and down-cast to send upload_only. Promote upload-only to a top-level peer feature 2017-09-23 07:51:51 -07:00
Alden Torres 1d9b10a32b fix warning for Xcode 9, added const and minor code refactor to bt_peer_connection.cpp 2017-09-22 04:46:16 -07:00
Steven Siloti 8648de3706 DHT nodes should only handle requests on their socket (#2355) 2017-09-21 21:00:38 -07:00
Alden Torres a8c020892a more use of auto, const and minor code refactor in ut_pex.cpp 2017-09-21 04:33:42 +02:00
Alden Torres 5c91301e6d more use of auto, const, size, minor code refactor and cleanup 2017-09-18 23:59:41 +02:00
arvidn 6b55096ebd switch some using declarations to new-style typedefs. remove some redundant parenthesis 2017-09-18 09:38:51 +02:00
arvidn 65d16142aa remove redundant null check 2017-09-18 00:51:26 +02:00
arvidn 9839507ecd simplify to_string to not apply unary - to an unsigned integer 2017-09-17 21:23:24 +02:00
arvidn 7717c02c2f run sonarqube with deprecated functions disabled. fix some of its code smells 2017-09-17 18:06:53 +02:00
arvidn 646581f8a2 use new instead of malloc 2017-09-17 17:13:57 +02:00
Steven Siloti 0232dc35cd deprecate lock_files (#2344)
File locking interacts poorly with the path to replace a read only file handle
with a read/write one. For performance reasons the old handle is not closed
until the new one is put in place. With file locking this obviously cannot
work because the first handle is holding a lock on the file. As a result,
file_pool::open_file fails in this case. Even if we dropped the reference to
the read only file handle before attempting to re-open it, the open could still
fail if another thread is holding a reference to the read only handle.

There doesn't seem to be a good way around this. The simple solution would be
to always open files in read/write mode, but that has obvious safety downsides.
Any other solution would significantly complicate the file pool code.
Deprecating file locking seems to be the least bad option.
2017-09-17 10:43:27 +02:00
arvidn 240b5f73b1 merged RC_1_1 into master 2017-09-16 21:07:29 +02:00
arvidn 1a8660bca7 don't shadow static_category in alerts 2017-09-16 19:58:11 +02:00
arvidn 1ddc710be1 fix uTP path MTU discovery issue on windows (DF bit was not set correctly) 2017-09-16 19:56:42 +02:00
arvidn 8d6b51d54c minor cleanups 2017-09-16 13:48:11 +02:00
Alden Torres 582d9dfc24 removed leading :: in posix_fadvise to allow for fix in old android API build (#2341) 2017-09-16 13:47:49 +02:00
arvidn 17d5d34272 fix documemtation of storage_moved_alert 2017-09-16 12:35:35 +02:00
Steven Siloti 87832ce706 fix building/running unit tests with cmake
Make test_common a propper library so that it can inherit build
properties from libtorrent.
Set the working directory to the test directory so that tests can find
their data files.
Remove reference to obsolete bdecode_benchmark test.
2017-09-16 10:19:10 +02:00
arvidn 4e9b84d901 use release builds for sonar scan 2017-09-14 12:36:10 +02:00
arvidn 20c8558257 only analyze src/ and include/ 2017-09-13 10:47:18 +02:00
arvidn 8122a6079d only run sonar scan on master 2017-09-13 08:55:26 +02:00
arvidn 93bb84d94c some random cleanup 2017-09-13 08:28:46 +02:00
arvidn 5860655581 make sonar only analyze c++ 2017-09-12 13:56:21 +02:00
arvidn 965f45a9ce fix sonar_scan build 2017-09-12 12:43:50 +02:00
arvidn ebf0dbc3a8 force rebuild when scanning build for sonarqube 2017-09-12 12:29:52 +02:00
arvidn 686e3ed27b merged RC_1_1 2017-09-12 00:22:55 +02:00
arvidn ccbd6cbcfe remove rss_reader.py, since rss has been reprecated. fix python binding for torrent_handle, to be hashable. update client_test.py to not use deprecated APIs and follow best (libtorrent) practice 2017-09-11 22:28:57 +02:00
arvidn ec11996466 strip dead code in gprof2dot.py 2017-09-11 10:41:37 +02:00
Steven Siloti fdd6a3862d python: return file index by value
Fixes TypeError: No Python class registered for C++ class
2017-09-11 07:23:05 +02:00
arvidn 4ef2e095bb simplify client_test and remove some old scanf and fopen use 2017-09-10 21:10:34 +02:00
arvidn 7dccf3db75 attempt to make sonar_scan to work with shallow clones 2017-09-10 21:10:07 +02:00
arvidn 735f6fd1f4 remove redundant virtual specificers when override is present 2017-09-10 19:28:18 +02:00
Steven Siloti df8a57efb7 select which DHT port to report based on the connection's local endpoint (#2316) 2017-09-10 10:25:04 +02:00
arvidn 55228756e5 make disk job flags type safe 2017-09-10 08:56:52 +02:00
Steven Siloti 1cd40ee7e3 python: return torrent handles in alerts by value
This is needed to avoid a dangling reference if the client stores a
reference to the handle.
2017-09-10 08:55:02 +02:00
Alden Torres a86bc767de minor cleanup and code refactor in web_peer_connection.cpp (#2322) 2017-09-10 08:52:31 +02:00
arvidn eac7266dcd don't run sonarqube scan on pull requests 2017-09-10 00:35:56 +02:00
arvidn 9f177ad413 analyze with sonarqube 2017-09-08 22:19:48 +02:00
Alden Torres 7cc2619aad more use of auto and minor code refactor in routing_table.cpp 2017-09-08 08:49:06 +02:00
arvidn c848f6d978 improve some asserts in storage.cpp 2017-09-07 23:00:58 +02:00
arvidn 9bf0658090 merged RC_1_1 into master 2017-09-06 13:51:36 +02:00
arvidn 1280361236 update build docs 2017-09-05 19:45:40 +02:00
arvidn e36b066020 make logging alerts enabled by default in autoconf builds 2017-09-05 09:21:08 +02:00
arvidn bb51dcdbb9 move dht_settings into its own header cpp file-pair and dht_settings into the dht namespace 2017-09-04 22:38:16 +02:00
arvidn 95c8c3018a use span in gzip, http_parser and http_connection 2017-09-04 22:33:38 +02:00
arvidn 3da7d1d3da fix documentation issue 2017-09-04 16:50:11 +02:00
arvidn 061732ddec bump version 2017-09-04 15:35:45 +02:00
arvidn 53ff169db1 use string_view in find_metric_idx 2017-09-04 07:50:13 +02:00
arvidn 9c7f87ed5d fix python binding of port_mapping_t 2017-09-04 07:49:36 +02:00
arvidn fe1c395579 merged RC_1_1 into master 2017-09-03 13:57:19 +02:00