novabbs
/
rocksolid-light
3
0
Fork 1
Code Issues 22 Pull Requests Releases Wiki Activity

Fix bug where empty string identified as false in overboard.php.

This commit is contained in:
Retro_Guy 2024-05-07 04:46:29 -07:00
parent 187e1b917b
commit 256dfcb07d
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Rocksolid_Light/rocksolid/overboard.php
View File

@ -292,7 +292,6 @@ function display_threads($threads, $oldest)
$newonly = true; $newonly = true;
} }
} }
// Build display array // Build display array
$nicole = array(); $nicole = array();
foreach ($threads as $key => $value) { foreach ($threads as $key => $value) {
@ -311,7 +310,9 @@ function display_threads($threads, $oldest)
foreach ($nicole as $key => $value) { foreach ($nicole as $key => $value) {
// Skip if not in registered users sub list // Skip if not in registered users sub list
if (! $foundgroup_head = check_group_for_user($key, $userdata, $user_config, true)) { if (! $foundgroup_head = check_group_for_user($key, $userdata, $user_config, true)) {
continue; // testing: continuing here may break newsgroup identification
// and not display articles that should be displayed
// continue;
} }
$target_head = $this_overboard['msgids'][$key]; $target_head = $this_overboard['msgids'][$key];
if (! isset($target_head['msgid'])) { if (! isset($target_head['msgid'])) {
@ -321,6 +322,7 @@ function display_threads($threads, $oldest)
$result_count = count($value); $result_count = count($value);
foreach ($value as $new) { foreach ($value as $new) {
if (! $foundgroup = check_group_for_user($new, $userdata, $user_config, true)) { if (! $foundgroup = check_group_for_user($new, $userdata, $user_config, true)) {
echo "FAIL";
continue; continue;
} }
$target = $this_overboard['msgids'][$new]; $target = $this_overboard['msgids'][$new];
@ -622,10 +624,10 @@ function check_group_for_user($msgid, $userdata, $user_config, $check_section =
$logfile = $logdir . '/overboard.log'; $logfile = $logdir . '/overboard.log';
if (! is_array($userdata)) { if (! is_array($userdata)) {
// No logged in user // No logged in user
return ''; return true;
} }
if (! isset($user_config['hide_unsub']) || $user_config['hide_unsub'] != 'hide') { if (! isset($user_config['hide_unsub']) || $user_config['hide_unsub'] != 'hide') {
return ''; return true;
} }
$newsgroups = get_newsgroups_by_msgid($msgid); $newsgroups = get_newsgroups_by_msgid($msgid);
if ($newsgroups == false) { if ($newsgroups == false) {