Werner Lemberg
c90cc6443b
ftbitmap.h: Improve documentation.
2018-08-23 13:13:20 +02:00
Werner Lemberg
45524679c6
[truetype] Improve legibility of `glyf' parsing.
...
* src/truetype/ttgload.c (ON_CURVE_POINT, X_SHORT_VECTOR,
Y_SHORT_VECTOR, REPEAT_FLAG, X_POSITIVE, SAME_X, Y_POSITIVE, SAME_Y,
OVERLAP_SIMPLE): New macros.
(TT_Load_Simple_Glyph): Use new macros to make code more readable.
Remove useless adjustment of `outline->tags' elements.
2018-08-22 10:31:05 +02:00
Werner Lemberg
a3e842f9c6
Minor formatting and documentation fixes.
2018-08-22 10:30:08 +02:00
Werner Lemberg
0a33b44e6e
* src/sfnt/ttcpal.c (tt_face_load_cpal): Add missing safety check.
...
Reported as
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=9981
2018-08-21 10:52:14 +02:00
Werner Lemberg
4873eb1d31
Update `CHANGES' file.
2018-08-19 07:27:21 +02:00
Werner Lemberg
4dc0d48f7b
[psaux] Avoid slow PS font parsing in case of error.
...
Reported as
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=9955
* src/psaux/psobjs.c (ps_parser_to_bytes): Set `parser->cursor' even
in case of error to avoid potential re-scanning.
2018-08-18 14:39:20 +02:00
Werner Lemberg
2550fc75a5
[cff] Fix heap buffer overflow in old engine.
...
Reported as
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=9967
* src/psaux/cffdecode.c (cff_decoder_parse_charstrings)
<cff_op_blend> [CFF_CONFIG_OPTION_OLD_ENGINE]: `num_designs' must be
non-zero.
2018-08-18 13:38:48 +02:00
Young Xiao
c94162a220
* builds/mac/ftmac.c (parse_fond): Fix buffer overrun.
...
Reported as bug #54515 , duplicate of #43540 .
2018-08-16 08:25:47 -04:00
Werner Lemberg
33cd1eedcf
* builds/*/ftsystem.c (FT_COMPONENT): Updated also.
2018-08-16 05:55:18 +02:00
Alexei Podtelezhnikov
efa2a3babf
Revert BDF copyright years.
2018-08-15 23:49:07 -04:00
Alexei Podtelezhnikov
af9662e60b
Ouch. BDF copyright year.
2018-08-15 22:58:11 -04:00
Alexei Podtelezhnikov
923fcbcdd8
[bdf] Don't track duplicate encodings.
...
There is no harm except some umbiguity in broken fonts with duplicate
encodings.
* src/bdf/bdflib.c (_bdf_parse_glyphs): Remove duplicate tracking.
(_bdf_parse_t): Remove large `have' bitfield.
2018-08-15 22:50:06 -04:00
Werner Lemberg
a0dd16fb3d
Don't use `trace_' prefix for FT_COMPONENT arguments.
...
* include/freetype/internal/ftdebug.h (FT_TRACE_COMP,
FT_TRACE_COMP_): New auxiliary macros to add `trace_' prefix.
(FT_TRACE): Use `FT_TRACE_COMP'.
*/* (FT_COMPONENT): Updated.
2018-08-15 18:13:17 +02:00
Werner Lemberg
1d7b034cd8
Use formatting string in FT_TRACEX calls for non-simple arguments.
...
* src/psaux/cffdecode.c (cff_decoder_parse_charstrings)
<cff_op_hstem, cff_op_hintmask, cff_op_hlineto, cff_op_vhcurveto>:
Do it.
* src/psaux/pshints.c (cf2_hintmap_build): Ditto.
* src/psaux/psintrp.c (cf2_interpT2CharString) <cf2_cmdHSTEM,
cf2_cmdVSTEM, cf2_cmdHLINETO, cf2_cmdRRCURVETO, cf2_cmdCALLSUBR,
cf2_escHSTEM3, cf2_cmdHINTMASK, cf2_cmdHVCURVETO>: Ditto.
* src/truetype/ttinterp.c (TT_RunIns): Ditto.
2018-08-14 15:56:28 +02:00
Alexei Podtelezhnikov
e001a17d73
[bdf] Remove unused fields.
...
* src/bdf/bdf.h (bdf_font_t): Remove `nmod', `umod', and `modified',
which were set but never used.
* src/bdf/bdflib.c (_bdf_parse_{glyphs,properties}, bdf_load_font):
Updated accordingly.
2018-08-14 07:10:57 -04:00
Werner Lemberg
44db1addd8
[cff] Fix another segv in old engine.
...
Reported as
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=9872
* src/psaux/cffdecode.c (cff_decoder_parse_charstrings)
[CFF_CONFIG_OPTION_OLD_ENGINE]: Disallow invalid T1 opcodes in
dictionaries.
2018-08-14 10:01:00 +02:00
Werner Lemberg
1937b55734
[cff] Fix missing error handling.
...
Reported as
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=9865
* src/psaux/cffparse.c (cff_parser_run)
[CFF_CONFIG_OPTION_OLD_ENGINE]: Don't ignore return value of
`parse_charstrings_old'.
2018-08-14 07:54:25 +02:00
Alexei Podtelezhnikov
ac2ea865f3
[bdf] Remove unused overflow storage.
...
* src/bdf/bdf.h (bdf_glyphlist_t): Remove this type.
(bdf_font_t): Remove `overflow' field.
* src/bdf/bdflib.c (bdf_free_font): Remove `overflow' freeing.
2018-08-13 21:33:24 -04:00
Werner Lemberg
757bdf1aef
[cff] Fix segv.
...
Reported as
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=9864
* src/psaux/cffdecode.c (cff_decoder_parse_charstrings)
<cff_op_random> [CFF_CONFIG_OPTION_OLD_ENGINE]: Use top dict's
`random' field directly if parsing dictionaries.
2018-08-14 02:02:26 +02:00
Alexei Podtelezhnikov
f5fe6e2f17
[bdf] Use unsigned types.
...
* src/bdf/bdf.h (bdf_glyph_t): Unsign `encoding'.
(bdf_font_t): Unsign `default_char'.
* src/bdf/bdfdrivr.h (BDF_encoding_el): Unsign `enc'.
* src/bdf/bdflib.c (_bdf_add_property, _bdf_parse_glyphs,
_bdf_parse_start): Updated accordingly.
* src/bdf/bdfdrivr.c (bdf_cmap_char_{index,next}): Ditto.
2018-08-13 09:01:53 -04:00
Werner Lemberg
50486df1e6
* src/type42/t42parse.c (t42_parse_sfnts): One more format check.
...
Reported as
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=9832
2018-08-13 08:46:53 +02:00
Armin Hasitzka
37c7b81794
Remove deprecated constant in documentation.
...
* include/freetype/ftdriver.h: Suggest using `FT_HINTING_ADOBE' since
`FT_CFF_HINTING_ADOBE' is deprecated.
2018-08-12 01:42:00 +02:00
Werner Lemberg
5b904409fc
* src/base/ftcalc.c (FT_Matrix_Check): Fix integer overflow.
...
Reported as
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=9811
2018-08-11 06:41:35 +02:00
Alexei Podtelezhnikov
88c0e12109
* src/sfnt/ttsbit.c (tt_sbit_decoder_load_compound): Follow specs.
2018-08-10 21:24:40 -04:00
Ben Wagner
96b5e50090
* src/sfnt/sfobjs.c (sfnt_done_face): Fix memory leak ( #54435 ).
2018-08-10 22:24:26 +02:00
Nikhil Ramakrishnan
1a21ca7b91
Minor formatting.
2018-08-10 19:32:31 +05:30
Werner Lemberg
1aa73fa83d
* src/base/ftobjs.c (FT_Render_Glyph_Internal): Improve tracing.
2018-08-10 05:41:32 +02:00
Werner Lemberg
c8ef0fd07c
Fix clang warnings.
...
* src/base/ftdebug.c (ft_trace_level_enabled,
ft_trace_level_disabled): Add `static' keyword.
2018-08-10 04:44:22 +02:00
Alexei Podtelezhnikov
e16bfbec4c
[raster, smooth] Reinstate bitmap size limits.
...
This again moves outline and bitmap size checks one level up.
* src/base/ftoutln.c (FT_Outline_Render): Explicitly reject enormous
outlines.
* src/raster/ftrend1.c (ft_raster1_render): Reject enormous bitmaps
and, therefore, outlines that require them.
* src/smooth/ftsmooth.c (ft_smooth_render_generic): Ditto.
* src/raster/ftraster.c (ft_black_render): Remove outline size checks.
* src/smooth/ftgrays.c (gray_raster_render): Ditto.
[STANDALONE]: Remove `FT_Outline_Get_CBox' copy.
2018-08-09 22:18:00 -04:00
Alexei Podtelezhnikov
6a97c95800
[pcf] Revert massive unsigning.
2018-08-08 22:17:35 -04:00
Werner Lemberg
f60c98feaf
[smooth] Improve tracing.
...
* src/smooth/ftgrays.c (gray_convert_glyph_inner): Only use tracing
if called the first time.
(gray_convert_glyph): Updated.
2018-08-08 18:15:53 +02:00
Werner Lemberg
c9bbc2419a
Add internal functions `FT_Trace_Disable' and `FT_Trace_Enable'.
...
It sometimes makes sense to suppress tracing informations, for
example, if it outputs identical messages again and again.
* include/freetype/internal/ftdebug.h: Make `ft_trace_levels' a
pointer.
(FT_Trace_Disable, FT_Trace_Enable): New declarations.
* src/base/ftdebug.c (ft_trace_levels): Rename to...
(ft_trace_levels_enabled): ... this.
(ft_trace_levels_disabled): New array.
(ft_trace_levels): New pointer.
(FT_Trace_Disable, FT_Trace_Enable): Implement.
(ft_debug_init): Updated.
2018-08-08 18:12:31 +02:00
Werner Lemberg
2e3dec5509
Debugging improvements.
...
* src/base/ftobjs.c (pixel_modes): Move this array to top level
from ...
(FT_Load_Glyph): ... here.
(FT_Render_Glyph_Internal): Use `width' x `height' in trace message.
Use `pixel_modes'.
2018-08-08 13:51:18 +02:00
Alexei Podtelezhnikov
c633378a5e
[pcf] Massive unsigning (part 2).
...
Treat all size related properties as unsigned values.
* src/pcf/pcf.h (PCF_ParsePropertyRec): Use unsigned `name' and
`value'.
* src/pcf/pcfread.c (pcf_get_propeerties, pcf_load_font): Updated
parsing code and handling of AVERAGE_WIDTH, POINT_SIZE, PIXEL_SIZE,
RESOLUTION_X and RESOLUTION_Y.
2018-08-08 01:21:54 -04:00
Alexei Podtelezhnikov
3d4ab6bac1
[pcf] Massive unsigning (part 1).
...
Unofficial specifications hesitate to use unsigned 32-bit integers.
Negative values caused a lot of trouble in the past and it is safer
and easier to treat some properties as unsigned.
* src/pcf/pcf.h (PCF_AccelRec): Use unsigned values for `fontAscent',
`fontDescent', and `maxOverlap'.
* src/pcf/pcfread.c (pcf_load_font, pcf_get_accel): Updated.
* src/pcf/pcfdrivr.c (PCF_Glyph_Load, PCF_Size_Select,
PCF_Size_Request): Updated.
2018-08-08 00:09:16 -04:00
Alexei Podtelezhnikov
705bac50d3
* src/pcf/pcfread.c (pcf_get_bitmaps): Unsign `offsets' and `bitmapSizes'.
2018-08-07 22:49:55 -04:00
Werner Lemberg
7ec9598f47
More comment formattings.
...
This helps in the forthcoming transition to markdown syntax.
2018-08-06 17:35:14 +02:00
Werner Lemberg
b09e773591
* devel/ftoption.h: Synchronize with main `ftoption.h'.
2018-08-06 11:02:51 +02:00
Alexei Podtelezhnikov
f24dbb2811
[pcf] Use unsigned types.
...
* src/pcf/pcf.h (PCF_Encoding): Use unsigned `enc'.
* src/pcf/pcfdrivr.c (pcf_cmap_char_{index,next}): Ditto.
* src/pcf/pcfread.c (pcf_get_encodings): Use unsigned types.
2018-08-06 04:58:18 -04:00
Werner Lemberg
86e7385342
Minor comment formatting.
2018-08-06 10:24:08 +02:00
Werner Lemberg
720ae67f35
* src/truetype/ttgload.c (compute_glyph_metrics): Fix overflow.
...
Reported as
https://bugs.chromium.org/p/chromium/issues/detail?id=777151
2018-08-05 07:21:10 +02:00
Werner Lemberg
ced9c311f6
Ditto.
2018-08-04 07:03:57 +02:00
Werner Lemberg
be81acc4bf
* src/truetype/ttinterp.c (opcode_name): Fix typos.
2018-08-04 07:01:04 +02:00
Werner Lemberg
799d27b0b6
Fix clang warnings.
...
* src/base/ftoutln.c (FT_Outline_EmboldenXY): Fix type of
`orientation'.
* src/gxvalid/gxvcommn.c (gx_lookup_value_read): Fix signature.
* src/pcf/pcfread.c (pcf_get_encodings): Fix type of some variables.
Add cast.
* src/type1/t1load.c (parse_weight_vector): Fix cast.
2018-08-04 06:39:11 +02:00
Werner Lemberg
1897186fb7
* src/cid/cidtoken.h: Handle `XUID' keyword.
2018-07-31 10:48:07 +02:00
Werner Lemberg
8e57746c4b
[cid] Trace PostScript dictionaries.
...
* src/cid/cidload.c: Include FT_INTERNAL_POSTSCRIPT_AUX_H
(cid_load_keyword, cid_parse_font_matrix, parse_fd_array,
parse_expansion_factor, cid_parse_dict): Add tracing calls.
(parse_font_name): New function to trace `/FontName' keywords in
/FDArray dict.
(cid_field_records): Register `parse_font_name'.
2018-07-31 10:46:57 +02:00
Werner Lemberg
85e8bea4fd
Minor documentation improvement.
2018-07-31 10:42:21 +02:00
Werner Lemberg
578bcf103a
[cff] Fix typo.
...
Reported as
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=9409
* src/cff/cffdrivr.c (cff_get_cid_from_glyph_index): Fix boundary
check.
2018-07-30 11:28:04 +02:00
Werner Lemberg
00968d8fd6
* src/pcf/pcfread.c (pcf_get_encodings): Another thinko.
...
Reported as
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=9608
2018-07-29 10:22:59 +02:00
Alexei Podtelezhnikov
0f8aebfd51
* builds/unix/configure.raw: Minor.
2018-07-28 23:21:28 -04:00