IRC_NJOIN(): Code cleanup

No functional changes.
This commit is contained in:
Alexander Barton 2015-12-13 21:00:46 +01:00
parent e8dacb68dc
commit 98e9467c85
1 changed files with 70 additions and 49 deletions

View File

@ -252,58 +252,79 @@ IRC_NJOIN( CLIENT *Client, REQUEST *Req )
strcpy(nick_out, "");
channame = Req->argv[0];
ptr = strtok(nick_in, ",");
while( ptr )
{
while (ptr) {
is_owner = is_chanadmin = is_op = is_halfop = is_voiced = false;
/* cut off prefixes */
while ((*ptr == '~') || (*ptr == '&') || (*ptr == '@') ||
( *ptr == '%') || ( *ptr == '+' ))
{
if( *ptr == '~' ) is_owner = true;
if( *ptr == '&' ) is_chanadmin = true;
if( *ptr == '@' ) is_op = true;
if( *ptr == '%' ) is_halfop = true;
if( *ptr == '+' ) is_voiced = true;
(*ptr == '%') || (*ptr == '+')) {
if (*ptr == '~')
is_owner = true;
if (*ptr == '&')
is_chanadmin = true;
if (*ptr == '@')
is_op = true;
if (*ptr == '%')
is_halfop = true;
if (*ptr == '+')
is_voiced = true;
ptr++;
}
c = Client_Search(ptr);
if( c )
{
if (!c) {
/* Client not found? */
Log(LOG_ERR,
"Got NJOIN for unknown nick \"%s\" for channel \"%s\"!",
ptr, channame);
goto skip_njoin;
}
Channel_Join(c, channame);
chan = Channel_Search(channame);
assert(chan != NULL);
if( is_owner ) Channel_UserModeAdd( chan, c, 'q' );
if( is_chanadmin ) Channel_UserModeAdd( chan, c, 'a' );
if( is_op ) Channel_UserModeAdd( chan, c, 'o' );
if( is_halfop ) Channel_UserModeAdd( chan, c, 'h' );
if( is_voiced ) Channel_UserModeAdd( chan, c, 'v' );
if (is_owner)
Channel_UserModeAdd(chan, c, 'q');
if (is_chanadmin)
Channel_UserModeAdd(chan, c, 'a');
if (is_op)
Channel_UserModeAdd(chan, c, 'o');
if (is_halfop)
Channel_UserModeAdd(chan, c, 'h');
if (is_voiced)
Channel_UserModeAdd(chan, c, 'v');
/* announce to channel... */
IRC_WriteStrChannelPrefix( Client, chan, c, false, "JOIN :%s", channame );
/* Announce client to the channel */
IRC_WriteStrChannelPrefix(Client, chan, c, false,
"JOIN :%s", channame);
/* set Channel-User-Modes */
/* Announce "channel user modes" to the channel, if any */
strlcpy(modes, Channel_UserModes(chan, c), sizeof(modes));
if (modes[0])
{
/* send modes to channel */
IRC_WriteStrChannelPrefix( Client, chan, Client, false, "MODE %s +%s %s", channame, modes, Client_ID( c ));
}
IRC_WriteStrChannelPrefix(Client, chan, Client, false,
"MODE %s +%s %s", channame,
modes, Client_ID(c));
if( nick_out[0] != '\0' ) strlcat( nick_out, ",", sizeof( nick_out ));
if( is_owner ) strlcat( nick_out, "~", sizeof( nick_out ));
if( is_chanadmin ) strlcat( nick_out, "&", sizeof( nick_out ));
if( is_op ) strlcat( nick_out, "@", sizeof( nick_out ));
if( is_halfop ) strlcat( nick_out, "%", sizeof( nick_out ));
if( is_voiced ) strlcat( nick_out, "+", sizeof( nick_out ));
/* Build nick list for forwarding command */
if (nick_out[0] != '\0')
strlcat(nick_out, ",", sizeof(nick_out));
if (is_owner)
strlcat(nick_out, "~", sizeof(nick_out));
if (is_chanadmin)
strlcat(nick_out, "&", sizeof(nick_out));
if (is_op)
strlcat(nick_out, "@", sizeof(nick_out));
if (is_halfop)
strlcat(nick_out, "%", sizeof(nick_out));
if (is_voiced)
strlcat(nick_out, "+", sizeof(nick_out));
strlcat(nick_out, ptr, sizeof(nick_out));
}
else Log( LOG_ERR, "Got NJOIN for unknown nick \"%s\" for channel \"%s\"!", ptr, channame );
/* search for next Nick */
skip_njoin:
/* Get next nick, if any ... */
ptr = strtok(NULL, ",");
}