meta: specify electron version in webpack.config.js and add electron updating info to CONTRIBUTING.md

This commit is contained in:
Xymorot 2021-01-06 01:06:33 +01:00
parent 657ec825ab
commit 571f3c5402
2 changed files with 10 additions and 2 deletions

View File

@ -171,7 +171,15 @@ In the best case a simple `npm update` does the trick, but to upgrade to a new m
#### Electron
Updating Electron also updated the Node.js and Chromium version it uses internally. When upgrading to a new major Node version, the Node.js version in the development environment should also be updated. This also means updating the `node` version key under `engines` in [package.json](package.json).
Updating Electron also updates the Node.js and Chromium version it uses internally.
When upgrading to a new major Node version, the Node.js version in the development environment should also be updated.
This also means potentially updating:
- the `node` version key under `engines` in [package.json](package.json)
- the `@types/node` package
- the electron version in the `target` field of the [webpack config](scripts/webpack.config.js)
- the `compilerOptions.target` fields of the [main](tsconfig.json) and [renderer](tsconfig.renderer.json) typescript configuration files
## Design

View File

@ -3,7 +3,7 @@ const path = require('path');
module.exports = {
mode: 'production',
entry: path.resolve(__dirname, '../src/renderer.ts'),
target: 'electron-renderer',
target: 'electron10-renderer',
output: {
path: path.resolve(__dirname, '../frontend'),
filename: 'bundle.js',