diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index cd2d27c..90c175b 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -171,7 +171,15 @@ In the best case a simple `npm update` does the trick, but to upgrade to a new m #### Electron -Updating Electron also updated the Node.js and Chromium version it uses internally. When upgrading to a new major Node version, the Node.js version in the development environment should also be updated. This also means updating the `node` version key under `engines` in [package.json](package.json). +Updating Electron also updates the Node.js and Chromium version it uses internally. +When upgrading to a new major Node version, the Node.js version in the development environment should also be updated. + +This also means potentially updating: + +- the `node` version key under `engines` in [package.json](package.json) +- the `@types/node` package +- the electron version in the `target` field of the [webpack config](scripts/webpack.config.js) +- the `compilerOptions.target` fields of the [main](tsconfig.json) and [renderer](tsconfig.renderer.json) typescript configuration files ## Design diff --git a/scripts/webpack.config.js b/scripts/webpack.config.js index aebc088..5cad003 100644 --- a/scripts/webpack.config.js +++ b/scripts/webpack.config.js @@ -3,7 +3,7 @@ const path = require('path'); module.exports = { mode: 'production', entry: path.resolve(__dirname, '../src/renderer.ts'), - target: 'electron-renderer', + target: 'electron10-renderer', output: { path: path.resolve(__dirname, '../frontend'), filename: 'bundle.js',