Commit Graph

4023 Commits

Author SHA1 Message Date
Alex Henrie c565145b0e comctl32: Remove redundant if (button) statements.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
2015-10-07 21:28:50 +09:00
Piotr Caban aa39614e77 comctl32: Test TrackMouseEvent flags when LVS_EX_ONECLICKACTIVATE style is used.
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
2015-10-07 21:28:49 +09:00
Piotr Caban 4dd26ee814 comctl32: Don't ask for WM_MOUSEHOVER messages when LVS_EX_TRACKSELECT was not specified.
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
2015-10-07 21:28:49 +09:00
Michael Müller 1e2c0a3029 comctl32/tests: Add tests for LoadIconMetric function.
Signed-off-by: Michael Müller <michael@fds-team.de>
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
2015-10-06 00:01:55 +09:00
Michael Müller 088eb87e3b comctl32: Add implementation for LoadIconMetric.
Signed-off-by: Michael Müller <michael@fds-team.de>
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
2015-10-06 00:01:55 +09:00
Michael Müller c098c13ee2 comctl32: Add semi-stub implementation for LoadIconWithScaleDown.
Thanks to Nikolay Sivov and Alistair Leslie-Hughes for various comments
and ideas for improvements.

Signed-off-by: Michael Müller <michael@fds-team.de>
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
2015-10-06 00:01:54 +09:00
Huw Davies 4f06425a03 comctl32: Set the item size after LISTVIEW_ScrollColumns().
LISTVIEW_ScrollColumns() increments the item width by the scroll
delta, so we need the original width to still be present.
2015-09-08 14:48:09 +09:00
André Hentschel 80f887a064 comctl32/tests: Add ARM and ARM64 arch strings. 2015-08-12 22:52:24 +09:00
Francois Gouget f8a7d6ed74 Assorted spelling fixes. 2015-08-07 23:50:48 +09:00
Huw Davies f6653a93eb comctl32/tests: Extra WM_PAINT messages are occasionally sent on Vista and Win 7. 2015-07-06 20:08:21 +09:00
Huw Davies 2a71d13b6b comctl32: Implement the legacy notifications during restore. 2015-07-02 16:54:01 +09:00
Huw Davies 6c95445559 comctl32: Set the default separator width when notifying a -ve cmd id. 2015-07-02 16:53:58 +09:00
Huw Davies eddfefa54f comctl32: Reset the string and lparam fields between notifications. 2015-07-01 19:18:27 +09:00
Huw Davies 96a6184c30 comctl32: All negative entries in the toolbar save state are special cases. 2015-07-01 19:18:27 +09:00
Huw Davies 77ed3733af comctl32: The number of buttons is set by the first TBN_RESTORE notification. 2015-07-01 19:18:27 +09:00
Huw Davies 063c7866f5 comctl32: Implement toolbar saving. 2015-07-01 19:18:26 +09:00
Huw Davies 199f51ff78 comctl32: Don't leak button text. 2015-07-01 19:18:26 +09:00
Huw Davies 01cd45cce1 comctl32: Add a helper to free button text. 2015-07-01 19:18:25 +09:00
Huw Davies a29b6958e1 comctl32: Add helpers to set the button text. 2015-07-01 19:18:25 +09:00
Nikolay Sivov 035d0a1594 comctl32/monthcal: Fix title to use properly localized year/month format. 2015-06-18 21:41:02 +09:00
Bernhard Übelacker ccf2ea6179 comctl32/tests: Free memory used by property sheet page (Valgrind). 2015-06-18 21:41:02 +09:00
Nikolay Sivov b7969dfd94 comctl32/toolbar: Remove always true condition (Coverity). 2015-06-03 19:29:49 +09:00
Mark Harmstone bae599092a comctl32: Use DPI settings for checkbox size. 2015-05-25 14:34:07 +09:00
Huw Davies a1d54447b8 comctl32/tests: Skip the hover tests if the listview's parent is not the foreground window. 2015-05-21 20:01:29 +09:00
Huw Davies 5c4dc9fc56 comctl32: Fix a typo in the TB_SAVERESTOREA handler. 2015-05-20 22:10:07 +09:00
Huw Davies 0634f3b409 comctl32: If necessary add the width of a dropdown arrow while wrapping.
This also fixes the layout code for the BTNS_WHOLEDROPDOWN case.
2015-05-19 22:57:36 +09:00
Huw Davies 797f42699e comctl32: Wrap the buttons inside the toolbar's client rect.
The toolbar need not be the same width as the parent.
2015-05-19 22:57:27 +09:00
Huw Davies 0bcadfa88f comctl32: Layout the toolbar after a potential resize. 2015-05-19 22:57:22 +09:00
Huw Davies 9d218048a6 comctl32: Don't store the width in the toolbar info structure.
It's only set and used by a single function.
2015-05-19 22:57:16 +09:00
Nikolay Sivov 6be21eeb3f comctl32: Remove LoadString() fallback when loading from same module. 2015-05-18 19:59:28 +09:00
Alex Henrie ad49634bbe comctl32: Send WM_NOTIFY when expanding ancestors of the new selection. 2015-05-18 19:59:27 +09:00
Alex Henrie 36297f2cb0 comctl32: Do not send WM_NOTIFY if selecting an already-selected item. 2015-05-18 19:59:27 +09:00
Alex Henrie a0ebe244c4 comctl32: Close previously selected treeview item at common ancestor.
Also, send WM_NOTIFY mesages when collapsing the previous selection and
expanding the new one.
2015-05-18 19:59:27 +09:00
Alex Henrie 9f93080754 comctl32/tests: Extend TVS_SINGLEEXPAND tests. 2015-05-18 19:59:27 +09:00
Huw Davies eb8df37a69 comctl32: Remove button wrap states when TBSTYLE_WRAPABLE is cleared. 2015-04-30 16:17:59 +09:00
Huw Davies abd673bde9 comctl32: A change in TBSTYLE_WRAPABLE should produce a recalc. 2015-04-28 20:23:59 +09:00
Huw Davies e82b9dc32e comctl32: Move the style change code to the TB_SETSTYLE handler. 2015-04-28 20:23:59 +09:00
Aric Stewart aba3b131bc comctl32: TTM_SETTOOLINFO does not change subclassing flags. 2015-04-27 19:33:28 +09:00
Thomas Faber 13b65faf4e comctl32: Avoid use-after-free in DPA_Merge (DPH). 2015-04-20 14:37:57 +09:00
Huw Davies 60e305d983 comctl32: Invalidate the toolbar if the button size is changed. 2015-04-20 14:37:00 +09:00
Huw Davies 5b7b911f06 comctl32: TBSTYLE_EX_MIXEDBUTTONS doesn't mean buttons should be auto-sized. 2015-04-20 14:36:55 +09:00
Mark Harmstone b0a9fb6b0d comctl32: Fix drawing of buddy background for updown controls. 2015-04-09 14:55:17 +09:00
Marcus Meissner b4ec412203 comctl32: Avoid integer overflow (Coverity). 2015-04-07 15:15:11 +09:00
Nikolay Sivov af30ffaa43 comctl32/tests: Fix couple of metrics tests that fail on some systems. 2015-04-02 23:14:36 +09:00
Nikolay Sivov 82bab3283b comctl32/dsa: Implement DSA_GetSize(). 2015-03-31 16:44:29 +09:00
Nikolay Sivov ff0634dfe1 comctl32/dsa: Implement DSA_Clone(). 2015-03-31 16:43:49 +09:00
Nikolay Sivov 30cdd59252 comctl32/listview: Always forward HDM_SETORDERARRAY to a header. 2015-03-31 14:47:56 +09:00
Nikolay Sivov d12c2f8b6f comctl32/listview: Use defined name instead of magic value. 2015-03-31 14:47:54 +09:00
Nikolay Sivov 9fcfaaa64a comctl32/listview: Support header item image/bitmap in LVSCW_AUTOSIZE_USEHEADER case. 2015-03-31 14:47:52 +09:00
Mark Harmstone 961c7b887b comctl32: Redraw themed button on WM_ENABLE. 2015-03-31 14:47:37 +09:00
Alexandre Julliard 9f1f5d885c comctl32: Print full flag values in traces. 2015-03-30 19:49:13 +09:00
Nikolay Sivov c4a3651e34 comctl32/listview: Remove outdated TODO comment. 2015-03-30 16:37:44 +09:00
Nikolay Sivov 5c2e7075df comctl32/listview: Always forward LVM_GETCOLUMNORDERARRAY to header. 2015-03-30 16:37:40 +09:00
Nikolay Sivov 3c9db1df60 comctl32/listview: Fix scrolling in LV_VIEW_DETAILS view. 2015-03-30 16:37:34 +09:00
Nikolay Sivov 782253f18d comctl32/listview: Fix focus rectangle for LVS_EX_FULLROWSELECT case. 2015-03-30 16:37:31 +09:00
Nikolay Sivov 326af51ec2 comctl32/listview: Fix item focus rectangle to use proper label/selection bounds. 2015-03-30 16:37:27 +09:00
Nikolay Sivov 59cb4ff6f3 comctl32/tests: Listview doesn't subclass its header. 2015-03-25 19:38:30 +09:00
Nikolay Sivov 524f6860d4 comctl32: Claim success in InitializeFlatSB(). 2015-03-25 15:16:45 +09:00
Mark Harmstone e7116725ff comctl32: Use correct font for themed headers. 2015-03-24 16:42:05 +09:00
Nikolay Sivov 9d0ebc13ac comctl32/tooltips: Allow NULL hinst value when fetching text from resources. 2015-03-24 14:07:17 +09:00
Nikolay Sivov b6dc726bbd comctl32/listview: Update view on style change only if LVS_TYPEMASK styles have changed. 2015-03-23 16:36:06 +09:00
Francois Gouget c04cc70f7d comctl32: Remove unneeded NONAMELESSSTRUCT directives. 2015-03-09 22:06:23 +09:00
Mark Harmstone a20c920bbd comctl32: Draw hot parts of themed scrollbars. 2015-03-05 21:39:21 +09:00
Mark Harmstone d9708ecb93 comctl32: Add hit testing for themed scrollbars. 2015-03-05 21:39:14 +09:00
Mark Harmstone d7c2069721 comctl32: Paint themed scrollbars. 2015-03-03 23:16:46 +09:00
Mark Harmstone 050bda2ece comctl32: Call OpenThemeData on themed scrollbars. 2015-03-02 23:00:30 +09:00
Nikolay Sivov f935a10add comctl32/tests: Fix Monthcal tests failures on some VMs. 2015-03-02 13:54:13 +09:00
Mark Harmstone 129862f369 comctl32: Themed buttons should not draw in System if font unset. 2015-02-18 15:45:04 +09:00
Mark Harmstone 6a8da85c3b comctl32: Do not call HEADER_FillItemFrame twice in a row. 2015-02-18 15:43:04 +09:00
Mark Harmstone 50c2144999 comctl32: Fix graphical error on themed progress bars. 2015-02-16 19:18:52 +09:00
Mark Harmstone 707361321a comctl32: Redraw themed editboxes on focus change. 2015-02-16 19:18:50 +09:00
Mark Harmstone 6f9724d581 comctl32: Use theming when drawing IP address control. 2015-02-16 19:18:49 +09:00
Mark Harmstone ca5184f512 comctl32: Add themed scrollbar stub. 2015-02-16 19:18:48 +09:00
Mark Harmstone 18c41f7128 comctl32: Draw focus rect on themed pushbuttons. 2015-02-16 19:18:47 +09:00
Mark Harmstone f21a968d1c comctl32: Draw the focus rect on themed checkboxes. 2015-02-13 18:20:55 +09:00
Mark Harmstone b8d3f1fe24 comctl32: Always redraw background on checkbox repaint. 2015-02-13 18:20:45 +09:00
Mark Harmstone 26896f1bd5 comctl32: Fix clipping error with themed groupboxes. 2015-02-09 19:02:03 +09:00
Michael Stefaniuc 39045b13d0 comctl32: Remove an unused variable assigment (PVS-Studio). 2015-01-13 19:54:01 +01:00
Austin English 42c4c870af comctl32: Add a stub for LoadIconWithScaleDown. 2014-12-15 14:18:56 +01:00
Michael Stefaniuc 47fa711bbc comctl32: Remove a stray unused GetFocus() statement (PVS-Studio). 2014-12-09 22:16:44 +01:00
Michael Stefaniuc 2db0a3d01e comctl32: Merge two if blocks with identical condition (PVS-Studio). 2014-12-05 11:24:12 +01:00
Nikolay Sivov 44dbf381a7 comctl32/tests: Fix imagelist leak (Valgrind). 2014-12-01 11:00:20 +01:00
André Hentschel ab7228f318 comctl32/tests: Remove unused structs (Clang). 2014-11-25 19:49:33 +01:00
Sebastian Lackner 735e2cd774 comctl32: Allow broken behaviour in StrRStr functions. 2014-11-19 23:36:34 +09:00
Sebastian Lackner 194b7cd5ae comctl32: Fix invalid usage of CompareString in StrRStr functions. 2014-11-18 22:11:06 +09:00
Sebastian Lackner e2c0694901 comctl32: Fix incorrect usage of CompareString in SYSLINK_ParseText. 2014-11-18 22:10:51 +09:00
Sebastian Lackner 766f587f90 comctl32: Fix invalid usage of CompareString in StrStr functions. 2014-11-17 17:29:09 +09:00
Bruno Jesus a2818db03b comctl32/tests: Remove a dead assignment in misc.c (Cppcheck). 2014-11-03 16:32:07 +09:00
Bruno Jesus f4a13b9f1b comctl32/tests: Remove dead assignments in treeview.c (Cppcheck). 2014-11-03 16:32:03 +09:00
Huw Davies dd856be316 comctl32/tests: Post a key-down message rather than use keybd_event. 2014-11-03 16:31:52 +09:00
Bruno Jesus 2c5f05b860 comctl32/tests: Remove a dead assignment from dpa.c (Cppcheck). 2014-10-31 13:14:59 +09:00
Bruno Jesus 2ccd55e56f comctl32/tests: Remove dead assignment in comboex.c (Cppcheck). 2014-10-31 13:14:56 +09:00
Bruno Jesus a54c187886 comctl32: Remove dead assignment in tooltips.c (Cppcheck). 2014-10-31 13:14:52 +09:00
Bruno Jesus f70167df58 comctl32: Avoid magic numbers. 2014-10-31 13:14:47 +09:00
Bruno Jesus 197ea35c5a comctl32: Remove a dead assignment in comctl32undoc.c (Cppcheck). 2014-10-31 13:14:37 +09:00
Huw Davies 433df0d5d8 comctl32: Enable the appropriate wizard buttons before sending DM_SETDEFID. 2014-10-30 23:09:52 +09:00
Michael Stefaniuc 89e9d6db33 comctl32/tests: Add some ImageList_BeginDrag() tests. 2014-10-07 10:14:25 +02:00
Michael Stefaniuc 0a191f85ad comctl32: Don't start a new ImageList Drag if another one is ongoing. 2014-10-07 10:14:23 +02:00
Michael Stefaniuc 753de28cd5 comctl32: Correctly handle the ImageList index in BeginDrag(). 2014-10-07 10:14:21 +02:00
Francois Gouget 0dd5cb1cef Assorted spelling fixes. 2014-09-29 10:36:36 +02:00
Nikolay Sivov 5741ebb8fd comctl32/pager: Reduce pointer scope so it doesn't point to inner scope vars (PVS-Studio). 2014-08-18 12:44:59 +02:00
Huw Davies 552ad2d93e comctl32: Propagate the return value of WM_ERASEBKGND. 2014-07-09 10:27:48 +02:00
Huw Davies 6af0d44166 comctl32: The RECT in the custom draw structure should be the entire item's size. This includes any separated dropdown arrow. 2014-07-08 17:02:04 +02:00
Huw Davies d130ba09fa comctl32: Don't use the RECT from the custom draw structure when referring to the button alone. 2014-07-08 17:02:02 +02:00
Michael Stefaniuc c1cd60957e comctl32: Functions using setjmp can never be inlined. 2014-06-23 10:18:04 +02:00
Sebastian Lackner 392321f4f6 comctl32: Allocate new memory in notify_forward_header() to avoid Free() on wrong pointer. (Valgrind). 2014-06-23 10:12:25 +02:00
Nikolay Sivov 055129485d comctl32/tests: Avoid testing uninitialized value (Valgrind). 2014-06-16 09:28:10 +02:00
Nikolay Sivov f109a084e8 comctl32/imagelist: Update to IImageList2. 2014-06-12 13:19:06 +02:00
Alexandre Julliard 6ad2cf9b53 comctl32/tests: Output message sequences only on failure. 2014-06-12 13:19:05 +02:00
Nikolay Sivov a7fb6c89b3 comctl32/treeview: Send TVN_KEYDOWN in response of WM_KEYDOWN. 2014-06-11 19:15:19 +02:00
Nikolay Sivov 3f8bda94fc comctl32/treeview: Simplify sending parent WM_NOTIFY notifications. 2014-06-11 19:15:18 +02:00
Nikolay Sivov 2a348791ee comctl32/progress: Update position by one step on PBM_SETPOS in PBS_MARQUEE style. 2014-06-11 19:15:17 +02:00
Nikolay Sivov c69a7ecfb6 comctl32/progress: Erase background too on WM_TIMER for marquee animation. 2014-06-11 19:15:16 +02:00
Nikolay Sivov 25279d310e comctl32/progress: Set default marquee animation timer to 30 msec. 2014-06-11 19:15:15 +02:00
Nikolay Sivov a709e3f98d comctl32/treeview: Added a test for NM_RETURN. 2014-05-12 13:51:44 +02:00
Nikolay Sivov fa3e750e2c comctl32/listview: Fix custom draw stage sequence. 2014-05-12 10:55:09 +02:00
Christoph von Wittich 4cc503d164 comctl32/treeview: Notify the parent on a return key press. 2014-05-07 18:57:31 +02:00
Alexandre Julliard 1dd04884d7 comctl32/imagelist: Correctly resize the alpha flags when clearing the image list. 2014-05-01 17:19:54 +02:00
Frédéric Delanoy 2e5cb7aac8 Assorted spelling/grammar fixes. 2014-04-30 18:34:20 +02:00
Nikolay Sivov 9b2ea63311 comctl32/tests: Initialize text buffer pointer (Valgrind). 2014-04-25 10:17:36 +02:00
Nikolay Sivov fe3f12335d comctl32/treeview: Restore hdc before CDDS_ITEMPOSTPAINT. 2014-04-21 11:09:51 +02:00
Nikolay Sivov d24095a7d1 comctl32: Fix LVN_DELETEALLITEMS notification for LVS_OWNERDATA case. 2014-04-09 14:58:17 +02:00
Marcus Meissner 318169a86f comctl32: Process GetKeyState return correctly (Coverity). 2014-04-08 18:28:29 +02:00
Thomas Faber 6609a42334 comctl32: Make Str* functions private. 2014-03-26 19:20:29 +01:00
Nikolay Sivov d60910fc14 comctl32: Fix a leak on error path (Coverity). 2014-03-25 13:55:43 +01:00
Nikolay Sivov 9d1232a1ec comctl32/tests: Fix uninitialized variable case (Coverity). 2014-03-25 10:56:25 +01:00
Frédéric Delanoy 1bf4e13b55 comctl32: Use BOOL type where appropriate. 2014-03-17 17:34:10 +01:00
David Quintana 5b0c288977 comctl32: Fix horizontal separators in vertical toolbars. 2014-03-14 19:06:12 +01:00
Christoph von Wittich 7d5deb2e7f comctl32/tests: CCS_VERT should be set when TBSTYLE_EX_VERTICAL is set. 2014-03-04 11:49:10 +01:00
Christoph von Wittich 37e0a1a5d4 comctl32: Rename TBSTYLE_EX_UNDOC1 to TBSTYLE_EX_VERTICAL. 2014-02-24 15:00:40 -06:00
Nikolay Sivov 35e23dde27 comctl32/tests: Some tests for Button control. 2014-02-17 11:16:16 +01:00
Nikolay Sivov 91672c8453 comctl32/tests: Don't assert() on test failures. 2014-02-13 17:52:13 +01:00
Frédéric Delanoy 0f2bed51bd Assorted spelling fixes. 2014-02-10 15:47:29 +01:00
Nikolay Sivov 0e73e478ff comctl32/tab: Fix TCM_SETCURSEL on negative indices. 2014-02-10 10:41:47 +01:00
André Hentschel 1776ded8e6 comctl32: Use boolean return values in boolean functions. 2014-02-04 11:15:26 +01:00
André Hentschel e32237d34a comctl32/tests: Avoid preprocessor checks to ensure it compiles. 2014-01-27 17:01:56 +01:00
Frédéric Delanoy 3684578a9f comctl32: Avoid TRUE:FALSE conditional expressions. 2014-01-16 10:56:12 +01:00
Andrey Gusev be367393c9 Assorted typos fixes. 2014-01-13 17:37:42 +01:00
Frédéric Delanoy 29b2db009c comctl32/tests: Use BOOL type where appropriate. 2014-01-03 18:08:51 +01:00
Alexandre Julliard 99ef0d6ff0 makefiles: Get rid of the MAKE_TEST_RULES variable. 2014-01-02 12:13:16 +01:00
Alexandre Julliard 5e7416e5c8 makefiles: Get rid of the MAKE_DLL_RULES variable. 2014-01-02 12:08:18 +01:00
Alexandre Julliard 4f3d71cef3 makefiles: Get rid of the no longer used PO_SRCS variables. 2013-12-15 10:23:04 +01:00
Michael Stefaniuc 5092ecf6fe comctl32/tests: Finally compile with -D__WINESRC__. 2013-12-04 11:06:53 +01:00
Michael Stefaniuc 4ecd867706 comctl32/tests: Make treeview.c compile with -D__WINESRC__. 2013-12-04 11:06:14 +01:00
Michael Stefaniuc 133c691f1f comctl32/tests: Avoid non-AW aware TreeView_*() macros. 2013-12-04 11:06:05 +01:00
Frédéric Delanoy 5ba7f79bad Assorted spelling fixes. 2013-12-03 19:41:53 +01:00
André Hentschel 66932a8855 comctl32/tests: Make trackbar.c compile with -D__WINESRC__. 2013-12-03 12:33:24 +01:00
André Hentschel e810a58494 comctl32/tests: Make toolbar.c compile with -D__WINESRC__. 2013-12-02 10:52:20 +01:00
André Hentschel af9073accb comctl32/tests: Make rebar.c compile with -D__WINESRC__. 2013-12-02 10:51:58 +01:00
Michael Stefaniuc 4b59a4266a comctl32/tests: Make monthcal.c compile with -D__WINESRC__. 2013-12-02 10:50:44 +01:00