Commit Graph

888 Commits

Author SHA1 Message Date
Francois Gouget 30230fae5f shell32/tests: Check the child process exit code and close the process handle.
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-29 21:25:19 +09:00
Francois Gouget 3a9b09aa7d shell32/tests: Declare childPrintf() as a printf-style function.
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-29 21:25:18 +09:00
Francois Gouget 38ad0ee01d shell32/tests: Reorder the functions to avoid forward declarations.
This also groups the helpers in a more logical fashion.

Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-29 21:25:18 +09:00
Francois Gouget 759bd96ac2 shell32/tests: Add traces to the WaitForInputIdle() hooking process.
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-29 21:25:17 +09:00
Francois Gouget 78ada2e154 shell32/tests: Fix a couple of okChildPath()/okChildString() mixups.
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-28 15:51:07 +09:00
Francois Gouget 3079179753 shell32/tests: Show that verbs and classes override ShellExecute()'s normal handling of executables.
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-28 15:51:04 +09:00
Francois Gouget 2c0daad786 shell32/tests: Test handling of nonexistent verbs in ShellExecute() & co.
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-28 15:51:00 +09:00
Francois Gouget 198e0d5d78 shell32/tests: Trace the association properties for the DDE tests.
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-26 23:17:57 +09:00
Francois Gouget 7e000abeda shell32/tests: Call okShell() after a shell_execute{_ex}() test.
This ensures all the failed call parameters will be traced.

Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-26 23:17:24 +09:00
Francois Gouget c133ef7326 shell32/tests: Trace the last ShellExecute command whenever a corresponding test fails.
okShell() serves to encapsulate handling of shell_call and also provides a means for further extensions.

Remove the shell_call static initialization to not hide potential
use-before-assignment compiler warnings.

Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-26 23:17:05 +09:00
Francois Gouget 09dac2f482 shell32/tests: Use the shell_execute{_ex}() call site for its traces and error messages.
This makes it easier to match their internal test failures with the site of the real test.

Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-19 21:44:15 +09:00
Francois Gouget 9cc07a2b31 shell32/tests: Trace the effective ShellExecuteEx() flags.
shell_execute_ex() adds some flags for its own internal needs. The
traces should reflect that.

Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-13 23:47:04 +09:00
Francois Gouget f816bc93b0 shell32/tests: Tweak some overly optimistic ok() messages.
ShellExecute() is more likely to have returned an unexpected error code
than it is to have succeeded.

Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-13 23:46:53 +09:00
Francois Gouget 3dff8bc213 shell32/tests: Fix the shortcut vs. class interaction test.
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-12 19:10:04 +09:00
Francois Gouget 201de16e30 shell32/tests: Create_test_association() should either succeed or fail due to insufficient permissions.
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-12 19:10:04 +09:00
Francois Gouget 0a867de22d shell32/tests: Check the hProcess field when ShellExecuteEx() fails.
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-12 19:10:04 +09:00
Francois Gouget 2fb84d5c50 shell32/tests: The expectedArgs parameter of the DDE tests is an argument count, not a boolean.
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-12 19:10:03 +09:00
Nikolay Sivov ccc6cfc1de shell32/tests: Explicitly compare to HRESULT values.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-03 20:04:40 +01:00
Nikolay Sivov 2e4954eb69 shell32/tests: Basic tests for SHCreateSessionKey().
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-12-29 17:09:18 +01:00
Piotr Caban 3a6ac60555 shell32: Improved IDataObject::QueryGetData implementation.
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-25 01:28:32 +09:00
Andrew Eikum aaafeb4cec shell32: Implement IShellDispatch2::ShellExecute.
Signed-off-by: Andrew Eikum <aeikum@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-03 00:33:23 +09:00
Nikolay Sivov 2fff77a0ee shell32/tests: Fix prototype to match implementation (PVS-Studio).
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-21 21:09:13 +09:00
Nikolay Sivov e585d17ff3 shell32/tests: Test icon ids that are invalid on all systems. 2015-09-16 22:11:09 +09:00
Nikolay Sivov e46c32ab46 shell32/ebrowser: Implement EBO_NOBORDER option. 2015-08-03 10:57:46 +02:00
Nikolay Sivov e7acfee978 shell32: Added GetCurrentProcessExplicitAppUserModelID() stub. 2015-07-22 16:42:42 +02:00
Piotr Caban 943ead5022 shell32: Fix SHELL_execute code that removes quote arround file name. 2015-07-16 16:29:12 +09:00
Piotr Caban 8e853a3e90 shell32: Remove code for separating arguments from file path. 2015-07-16 16:29:06 +09:00
Thomas Faber 360cf273ae shell32/tests: Test that shell view windows reference their shell view. 2015-07-07 16:52:21 +09:00
Nikolay Sivov 28caa68d41 shell32/tests: Try harder to close Open With window. 2015-07-07 16:52:20 +09:00
Huw Davies f5e16e0638 shell32/tests: Win 2k doesn't cope with spaces in the path. 2015-07-07 16:52:20 +09:00
Huw Davies c5053f5712 shell32/tests: Win XP splits the args if there are spaces in the path.
This isn't seen on winetest runs, but is when jobs are submitted to
the testbot.  Presumably the path of the executable is different in
the two cases.
2015-07-07 16:52:19 +09:00
Thomas Faber eff884f19b shell32/tests: Destroy shell view windows. 2015-07-06 17:09:50 +09:00
Thomas Faber 71f1c90628 shell32/tests: Fix an ok() print. 2015-07-06 17:09:50 +09:00
Thomas Faber 9551179c0b shell32/tests: Remove a misleading test. 2015-06-30 14:41:43 +09:00
Thomas Faber e582495927 shell32: Use QueryInterface in FolderView_GetFolder.
test_IFolderView has a test that shows that the shell folder's reference
count before and after the call to IFolderView_GetFolder is the same.
However this is misleading because it is not a property of the
IFolderView_GetFolder method, but of the desktop shell folder object
that's used in the folder view. Windows <=2003 uses a cached object and
its AddRef/Release methods return constants.
2015-06-30 14:41:43 +09:00
Thomas Faber c0cd954f98 shell32: Add missing parameter check in ISF_Desktop_fnQueryInterface. 2015-06-30 14:40:43 +09:00
Thomas Faber 9353a36d8f shell32/tests: Do not leak shell folder references. 2015-06-29 21:15:10 +09:00
Huw Davies da5151fd54 shell32/tests: Don't leave behind open explorer windows. 2015-06-23 21:59:40 +09:00
Huw Davies 905e7aad0e shell32/tests: Fix failing test on Win 2k. 2015-06-11 21:05:34 +09:00
Nikolay Sivov 1de3aec336 shell32/tests: Fix error code on win2k. 2015-06-08 15:26:53 +09:00
Nikolay Sivov d5d49464d3 shell32/tests: Fix tests failures on win2k. 2015-06-05 14:11:02 +09:00
Nikolay Sivov 8c11e6b2f0 shell32/tests: Fix one of test failures on win2k. 2015-06-04 15:55:57 +09:00
Nikolay Sivov 98da69a83f shell32/tests: Fix Verbs instance leak (Valgrind). 2015-06-04 15:55:45 +09:00
Akihiro Sagawa d2e9856a56 shell32: Skip buffer allocation when querying drop file numbers. 2015-06-02 20:53:43 +09:00
Akihiro Sagawa 37d7d6f81c shell32/tests: Add tests for DragQueryFile. 2015-06-02 20:53:43 +09:00
Akihiro Sagawa 4c31892ea5 shell32/tests: Make tests run on win2k again. 2015-06-02 14:09:12 +09:00
Nikolay Sivov bf41160c65 shell32: Implement FolderItemVerbs::Item(). 2015-05-11 15:39:26 +09:00
Nikolay Sivov 77c2892d87 shell32: Implement FolderItemVerbs_get_Count(). 2015-05-11 15:39:25 +09:00
Nikolay Sivov 540171bc91 shell32: Added FolderItemVerbs stub. 2015-05-11 15:39:25 +09:00
Nikolay Sivov e013a7e584 shell32: Implement ParseName(). 2015-05-11 15:39:25 +09:00
Alexandre Julliard ed700d16f7 shell32/tests: Avoid duplicate const. 2015-05-11 15:39:25 +09:00
Nikolay Sivov 80d28abdc8 shell32: Partially implement SHGetKnownFolderIDList(). 2015-05-11 15:39:25 +09:00
Nikolay Sivov 4367f4b230 shell32: Silence IMarshal requests to IKnownFolder and IKnownFolderManager. 2015-05-11 15:39:25 +09:00
Nikolay Sivov 3ec3fa5eb7 explorer: Return desktop shellview interface. 2015-05-08 18:33:51 +09:00
Nikolay Sivov ce87d64ab4 shell32: Implement Application property of IShellFolderViewDual. 2015-05-06 18:13:59 +09:00
Nikolay Sivov a7b99a1f89 shell32/tests: A test for shellview QI for IOleWindow. 2015-05-05 10:16:16 +09:00
Nikolay Sivov 478d695ec8 shell32/tests: Fix test crashes when running with wine. 2015-05-04 20:10:53 +09:00
Nikolay Sivov 23d546157a shell32: Better handle creation/destruction of shellview window. 2015-05-04 15:08:43 +09:00
Nikolay Sivov eeabe96abb explorer: Return IShellBrowser in response to SID_STopLevelBrowser. 2015-05-04 15:08:38 +09:00
Nikolay Sivov 3c7bf0350a explorer: Added stub IServiceProvider support for shell browser window. 2015-05-04 15:08:33 +09:00
Nikolay Sivov 68c5fed5cc explorer: Implement Application property. 2015-05-04 15:08:27 +09:00
Nikolay Sivov 58775c878a explorer: Added IDispatch support for ShellBrowserWindow instance. 2015-05-04 15:08:24 +09:00
Nikolay Sivov a74c56a3b9 explorer: Added stub IWebBrowser2 support for desktop shell window. 2015-05-01 15:17:03 +09:00
Nikolay Sivov e91dac5153 shell32: Update to IFolderView2. 2015-05-01 15:15:56 +09:00
Nikolay Sivov f57b5ea2fb shell32/tests: Some more tests for IShellWindows implementation. 2015-04-30 16:20:41 +09:00
Nikolay Sivov dd9813b5f7 shell32: Added a stub implementation of IShellFolderViewDual3. 2015-04-30 16:20:35 +09:00
Nikolay Sivov b4769495bc explorer: Added a stub IShellWindows implementation.
Most of it was done by Andrew Eikum.
2015-04-29 12:26:32 +09:00
Nikolay Sivov fae0f6785a shell32/tests: Some tests for IShellWindows. 2015-04-29 12:25:00 +09:00
Nikolay Sivov d6802318aa include: Added IShellFolderViewDual definition. 2015-04-28 20:23:59 +09:00
Andrew Eikum 8042831061 shell32: Add more knownfolders. 2015-04-14 16:50:07 +09:00
Andrew Eikum 96971ea36d shell32: Add more knownfolders. 2015-04-13 15:04:25 +09:00
Andrew Eikum c6b999b901 shell32: Add more knownfolders. 2015-04-10 15:21:35 +09:00
Andrew Eikum f58c11767a shell32: Add more knownfolders. 2015-04-09 13:24:30 +09:00
Andrew Eikum 915bef8725 shell32: Add more knownfolder definitions. 2015-04-08 23:21:33 +09:00
Dmitry Timoshkov 5acb82fc28 shell32: Fix SHFileOperation(FO_MOVE) for a directory with subdirectories. 2015-03-19 21:05:13 +09:00
Dmitry Timoshkov 5614ae23ee shell32/tests: Add a couple of SHFileOperation(FO_MOVE) tests for a directory. 2015-03-19 21:05:11 +09:00
Andrew Eikum 12d057c8e7 shell32: Install knownfolders to registry during DLL registration. 2015-03-18 19:27:31 +09:00
Andrew Eikum 7c9151c1e6 shell32: Allow updating knownfolder definitions. 2015-03-18 19:26:52 +09:00
Andrew Eikum fdbdad03f3 shell32/tests: Support alternate parent folders. 2015-03-12 13:56:11 +09:00
Andrew Eikum 122f71866e shell32/tests: Fix win8 knownfolder attributes. 2015-03-12 13:55:58 +09:00
Andrew Eikum 7a55f5461a shell32/tests: Remove unused flag. 2015-03-12 13:55:51 +09:00
Andrew Eikum dd275615db shell32/tests: Fix win8 knownfolders relative and parsed paths. 2015-03-12 13:55:40 +09:00
Andrew Eikum 1b4272639b shell32/tests: A couple of win8 fixes. 2015-03-12 13:54:45 +09:00
Michael Stefaniuc 725662003a shell32/tests: Actually test some return values (PVS-Studio). 2015-03-04 21:50:43 +09:00
Alexandre Julliard d28052066d shell32/tests: Use NULL for a null pointer. 2015-03-04 21:50:33 +09:00
Alistair Leslie-Hughes 3121955956 shell32: Implement IApplicationAssociationRegistration QueryCurrentDefault. 2015-02-18 16:40:52 +09:00
Piotr Caban 6dac2f7a77 shell32: Add partial support for Mac trash enumeration. 2015-02-02 22:29:46 +09:00
Piotr Caban d46862b487 shell32: Handle TRASH_EnumItems failures correctly. 2015-02-02 22:29:25 +09:00
Piotr Caban 814ab9ee46 shell32: Create trash test file in temp directory. 2015-02-02 22:29:18 +09:00
Nikolay Sivov aeda103769 shell32: Added stub IPropertyStore for a shell link object. 2014-12-22 13:37:03 +01:00
André Hentschel 2c1287871b shell32/tests: Remove unused variables (Clang). 2014-12-04 14:03:27 +01:00
Michael Stefaniuc 61ed9130bf shell32/tests: Fix a copy and paste error (PVS-Studio). 2014-11-20 22:35:54 +09:00
Michael Stefaniuc 5d43ef68ce shell32: Simplify check for empty string (PVS-Studio). 2014-11-07 18:23:03 +09:00
Nikolay Sivov 730e744e3b shell32: Use E_NOT_SUFFICIENT_BUFFER definition. 2014-10-08 13:13:36 +02:00
Francois Gouget 0dd5cb1cef Assorted spelling fixes. 2014-09-29 10:36:36 +02:00
Francois Gouget c1d592876a shell32/tests: Add a trailing '\n' to a couple of win_skip() calls. 2014-08-19 14:48:27 +02:00
David Hedberg d016dc4004 shell32: Implement IEnumShellItems for IShellItemArray. 2014-08-05 16:39:07 +02:00
David Hedberg 27b45807a7 shell32: Implement IShellItemArray::GetAttributes. 2014-08-04 14:27:48 +02:00
David Hedberg a79be28e8c shell32: Implement SHCreateShellItemFromIDLists. 2014-08-04 14:27:46 +02:00
David Hedberg 815b532b64 shell32: Always initialize shellitem to NULL in SHCreateShellItem. 2014-08-04 14:27:25 +02:00