Huw Davies
841d41bdcf
comctl32: Add support for the sort arrows.
...
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-10-19 08:16:54 -07:00
Huw Davies
23dbdab4fe
comctl32: Make the position variables signed to avoid wrapping in the HDF_RIGHT case.
...
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-10-19 08:12:31 -07:00
Sebastian Lackner
88bf73abb2
comctl32/tests: Fix incorrect usage of broken() function.
...
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-09-08 23:14:59 +09:00
Huw Davies
31963d7da4
comctl32/tests: Restore the cursor position after moving it.
...
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-31 22:23:00 +09:00
Huw Davies
53b703d468
comctl32/tests: Move the cursor off the parent window to avoid mouse messages.
...
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-31 22:23:00 +09:00
Nikolay Sivov
382dc1ded8
comctl32/treeview: Fill full row for TVS_FULLROWSELECT style.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-22 23:05:22 +09:00
Nikolay Sivov
fa846bdb27
comctl32/listview: Fix indentation warnings on GCC 6.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-15 18:31:09 +09:00
Nikolay Sivov
af02e10828
comctl32/treeview: Fix item dragging and selection for TVS_FULLROWSELECT style.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-10 22:23:13 +09:00
Michael Stefaniuc
6531b9b8af
comctl32/tests: Use todo_wine_if().
...
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-10 22:23:03 +09:00
Nikolay Sivov
0220d47c02
comctl32/treeview: Fix hot-tracking with TVS_FULLROWSELECT.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-08 18:42:14 +09:00
Nikolay Sivov
2728909e6c
comctl32/tests: Basic test for TVS_FULLROWSELECT style bit.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-08 18:42:10 +09:00
Michael Stefaniuc
ce17196995
comctl32/tests: Make use of todo_wine_if().
...
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-04 16:50:49 -05:00
Nikolay Sivov
622a24046f
comctl32/listview: Return earlier on allocation failure (Coverity).
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-04 09:08:51 -05:00
Nikolay Sivov
9ef65cf3d6
comctl32/tests: Test that callback mask is stored as is, check more message results.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-02 16:18:05 -05:00
Nikolay Sivov
e0361765ab
comctl32/listview: Remove redundant check in LVM_DELETECOLUMN handler.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-01 05:30:18 -05:00
Nikolay Sivov
5faab43d34
comctl32/listview: Filter invalid indices when setting selection mark.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-01 05:30:17 -05:00
Michael Stefaniuc
b9f552cbec
comctl32/tests: Use SetRectEmpty() instead of SetRect().
...
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-31 16:22:37 +09:00
Michael Stefaniuc
61a6f98a9e
comctl32/tests: Avoid using memset() on RECTs.
...
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-31 16:22:34 +09:00
Michael Stefaniuc
2ea72e8717
comctl32: Avoid using memset on RECTs.
...
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-29 23:43:31 +09:00
Michael Stefaniuc
77fc4697dd
comctl32: Use straight assignments instead of CopyRect().
...
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-29 20:17:38 +09:00
Michael Stefaniuc
302ae44d8b
comctl32: Remove an always true conditional expression.
...
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-29 20:17:35 +09:00
Nikolay Sivov
11beaf9978
comctl32/treeview: Handle WM_SYSKEYDOWN.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-27 12:42:56 +09:00
Nikolay Sivov
5d0a02db69
comctl32/monthcal: Implement MCS_NOSELCHANGEONNAV style.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-26 11:33:48 +09:00
Nikolay Sivov
d73d6b2093
comctl32/treeview: Set hot item when hovering over item, not entire row.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-26 10:53:47 +09:00
Xiaoshan Sun
0d57ff3d1f
comctl32/dsa: Handle overflow in DSA_InsertItem().
...
Signed-off-by: Xiaoshan Sun <sunxs@is.iscas.ac.cn>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-25 15:47:41 +09:00
Alistair Leslie-Hughes
430108c92a
comctl32/trackbar: Use WM_CTLCOLORSTATIC when painting background.
...
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-25 15:47:35 +09:00
Nikolay Sivov
9618aae324
comctl32/tooltips: Fix TTM_GETMARGIN/TTM_SETMARGIN handling.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-22 21:30:45 +09:00
Michael Stefaniuc
23132e6329
comctl32: Avoid using the LPSTREAM COM iface type.
...
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-21 23:36:01 +09:00
Nikolay Sivov
6a237bdb60
comctl32/trackbar: Fix mouse position to thumb position conversion rounding.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-15 11:18:17 +09:00
Nikolay Sivov
cd55d74742
comctl32/trackbar: Update thumb on range change.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-15 11:18:12 +09:00
Michael Stefaniuc
8258d900ca
comctl32: Use InflateRect() too when expanding in just one axis.
...
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-09 15:42:47 +09:00
Michael Stefaniuc
1f74c0a0d1
comctl32: Use InflateRect() instead of open coding it.
...
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-04 17:29:31 +09:00
Michael Stefaniuc
65a2e59a78
comctl32: Avoid using CopyRect() on RECT structs.
...
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-06-24 21:10:32 +09:00
Michael Stefaniuc
cbca4b3f51
comctl32/tests: Use EqualRect() instead of memcmp() to compare RECTs.
...
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-06-21 11:23:34 +09:00
Michael Stefaniuc
085a538ded
comct32: Use EqualRect() instead of memcmp() to compare RECTs.
...
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-06-21 00:23:55 +09:00
Michael Stefaniuc
96185e23b4
comctl32/tests: Use wine_dbgstr_rect() to print RECTs.
...
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-06-08 23:07:45 +09:00
Michael Stefaniuc
fe9f23a2cb
comctl32/tests: Use EqualRect() instead of open coding it.
...
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-06-06 18:47:24 +09:00
Andrey Gusev
ee19a56a94
comctl32: Fix a typo in comment.
...
Signed-off-by: Andrey Gusev <andrey.goosev@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-27 16:21:59 +09:00
Frédéric Delanoy
778717673e
comctl32/tests: Fix a couple typos in ok() calls.
...
Signed-off-by: Frédéric Delanoy <frederic.delanoy@gmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-21 00:53:51 +09:00
Nikolay Sivov
986306cddb
comctl32/syslink: Use wine list to keep items.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-21 00:53:51 +09:00
Sebastian Lackner
f4640b0492
comctl32/syslink: Fix a blocks leak (Valgrind).
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-21 00:53:50 +09:00
Nikolay Sivov
d1594aadda
comctl32/header: Implement HDM_SETFILTERCHANGETIMEOUT.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-18 10:37:18 +09:00
Nikolay Sivov
2f2651a14e
comctl32/monthcal: Take into account day name width when setting calendar column width.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-18 10:36:12 +09:00
Nikolay Sivov
7912acaab9
comctl32/monthcal: Added support for MCS_SHORTDAYSOFWEEK style.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-18 10:36:01 +09:00
Andrey Gusev
7f0531cd40
comctl32/tests: Fix a typo in ok() call.
...
Signed-off-by: Andrey Gusev <andrey.goosev@gmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-17 18:17:19 +09:00
Nikolay Sivov
3febb46237
comctl32/listview: Hit test data pointer is never NULL when sending LVN_ITEMACTIVATE.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-17 11:50:01 +09:00
Alexandre Julliard
7f8bf3e7bb
comctl32/status: Use DrawFrameControl to draw the size grip.
...
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-14 14:39:56 +09:00
Nikolay Sivov
833ff146c4
comctl32/imagelist: Simplify setting ImageList_DragEnter() return code.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-14 14:39:53 +09:00
Nikolay Sivov
ac75a00b0d
comctl32/header: Use proper return type for HDM_CREATEDRAGIMAGE handler.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-14 14:39:53 +09:00
Nikolay Sivov
75059e9ee1
comctl32/tooltips: Cut tooltip text at first tab char unless TTS_NOPREFIX is used.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-04 01:03:27 +09:00
Nikolay Sivov
f4542cf7d7
comctl32/listview: Simplify setting redraw mode flag.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-02 18:31:08 +09:00
Michael Stefaniuc
903ea19122
comctl32: Use SetRect() instead of open coding it.
...
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-29 23:23:36 +09:00
Nikolay Sivov
22bfbfe9fc
comctl32/tests: Remove some casts we don't need.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-29 23:23:18 +09:00
Nikolay Sivov
2771fd9758
comctl32: Improve DrawShadowText().
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-25 18:48:18 +09:00
Nikolay Sivov
af7f8d536b
comctl32/monthcal: Remove commented block.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-19 21:06:10 +09:00
Nikolay Sivov
935db97c24
comctl32: Use wine_dbgstr_rect() to trace RECTs.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-19 21:06:10 +09:00
Nikolay Sivov
b7f1839583
comctl32/tests: Simplify static text data initialization.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-18 15:17:36 +09:00
Nikolay Sivov
025508f755
comctl32/tests: Fix wrong use of HDM_GETITEM when getting item text.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-18 15:17:34 +09:00
Nikolay Sivov
f5ca9b9104
comctl32/listview: Handle DPA_SetPtr() failure (Coverity).
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-08 23:24:53 +09:00
Michael Stefaniuc
87bc2aa607
comctl32/tests: Use SetRect() instead of open coding it.
...
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-08 23:24:48 +09:00
Bruno Jesus
bc35781929
comctl32/tests: Add initial tests for the animation control.
...
Signed-off-by: Bruno Jesus <00cpxxx@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-03-22 00:36:30 +09:00
Nikolay Sivov
a62d178744
comctl32/datetime: Use MCM_GETRANGE result directly in DTM_GETRANGE.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-03-15 10:15:18 +09:00
Nikolay Sivov
6870144022
comctl32/monthcal: Always reset range flags and date limits on MCM_SETRANGE.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-03-15 10:15:13 +09:00
Nikolay Sivov
c075d5aafd
comctl32/monthcal: MCM_GETRANGE does not return BOOL values.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-03-14 19:06:21 +09:00
Michael Stefaniuc
d49201138d
comctl32: Use SetRectEmty() instead of open coding it.
...
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-03-03 22:29:03 +09:00
Joachim Priesner
71a4ac73e2
comctl32: Treeview: Set visible = TRUE when deleting first visible item.
...
This fixes a crash when deleting the first visible item if it has
visibleOrder < 0 and thus the ISVISIBLE macro returns false
(this happens when both insertion and deletion happened while
bRedraw == false).
Signed-off-by: Joachim Priesner <joachim.priesner@web.de>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-19 21:10:54 +09:00
Nikolay Sivov
780ebcc7d9
comctl32/tests: Simplify tests using todo_wine_if().
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-11 01:26:42 +09:00
Christopher Thielen
0bea2f73d3
comctl32: Ensure that trackbar respond only to changes in WM_CAPTURECHANGED handler.
...
Signed-off-by: Christopher Thielen <cthielen@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-02 22:21:31 +09:00
Christopher Thielen
ff063d9e25
comctl32: Ensure that toolbar respond only to changes in WM_CAPTURECHANGED handler.
...
Signed-off-by: Christopher Thielen <cthielen@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-02 22:21:31 +09:00
Joachim Priesner
4c799937f6
comctl32: Treeview: Fix crash when deleting the first visible item while bRedraw == false.
...
Signed-off-by: Joachim Priesner <joachim.priesner@web.de>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-01 21:04:42 +09:00
Joachim Priesner
f0b6584da6
comctl32: Fix comments explaining visibleOrder and firstVisible.
...
Hopefully this clears up the confusion between a) visible as in "all
ancestors are expanded" and b) visible as in "within the part of the
tree that is displayed on the screen".
Also, the claim that firstVisible has visible order 0 was false.
Signed-off-by: Joachim Priesner <joachim.priesner@web.de>
Signed-off-by: Nikolay Sivov<nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-01 17:53:38 +09:00
Akihiro Sagawa
af4a757ad2
comctl32: Prevent invalid focus change notifications from LVS_OWNERDATA lists.
...
Signed-off-by: Akihiro Sagawa <sagawa.aki@gmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-21 00:00:21 +09:00
Akihiro Sagawa
d1841f496b
comctl32/tests: Fix a typo.
...
Signed-off-by: Akihiro Sagawa <sagawa.aki@gmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-20 01:48:52 +09:00
Nikolay Sivov
88ea4c520b
comctl32/trackbar: Update thumb immediately on key press.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-19 00:11:47 +09:00
Nikolay Sivov
a65ddbf153
comctl32/trackbar: Update thumb immediately on TBM_SETPOS.
...
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-11 14:54:47 +09:00
Nikolay Sivov
1fce80024b
comctl32/tests: Separate individual Trackbar tests from each other.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-09 17:30:04 +09:00
Piotr Caban
ddcab8acea
comctl32: Set listview focus in WM_LBUTTONDOWN.
...
This patch reverts commit 098dc7b330
and
moves focus setting after LVN_ITEMCHANGED notification is sent. Writing
tests for it is tricky because native blocks inside WM_LBUTTONDOWN message.
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-12-02 12:59:04 +09:00
Vincent Povirk
45e706a2a7
comctl32/tests: Accept touchscreen-related messages in button tests.
...
Signed-off-by: Vincent Povirk <vincent@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-26 00:12:51 +09:00
Nikolay Sivov
1d19eb15d4
comctl32: Item with negative cChildren acts as if it actually had children.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-24 00:25:04 +09:00
Nikolay Sivov
8d0f060f3b
comctl32/treeview: Use consistent format for hex values in traces.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-24 00:25:03 +09:00
Bruno Jesus
2f5c0b9321
comctl32: Respect an assert in TREEVIEW_RemoveAllChildren.
...
Signed-off-by: Bruno Jesus <00cpxxx@gmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-24 00:25:02 +09:00
Dmitry Timoshkov
acc1092ea9
comctl32/tests: Add a test for system class properties.
...
This is basically a copy of user32/class.c test.
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-23 23:35:17 +09:00
Aric Stewart
bcefe114e8
comctl32: ILC_COLORDDB imagelists can be created with 0 sizes.
...
Negative values are still invalid.
Signed-off-by: Aric Stewart <aric@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-20 22:19:29 +09:00
Hugh McMaster
11669fa5e2
Assorted spelling and grammar fixes.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-17 22:56:40 +09:00
Nikolay Sivov
eb6a872273
comctl32/tests: Enable visual tests in interactive mode, fix build failure.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-16 17:13:40 +09:00
Nikolay Sivov
1b5aaa1639
comctl32/tests: Test more return values (Clang).
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-12 11:29:19 +09:00
Jacek Caban
67819d6ee9
comctl32: Don't use comparisons to FALSE.
...
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-10 11:53:20 +09:00
Nikolay Sivov
60fedd23f9
comctl32: Protect TVM_GETITEM from invalid item pointers.
...
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-05 00:03:34 +09:00
Piotr Caban
7d6ca63154
comctl32/tests: Flush events in listview tests after setting foreground window.
...
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-04 14:41:38 +09:00
Stefan Dösinger
4e2d25c7cd
comctl32: Re-enable the parent before destroying the dialog.
...
Prevent 1602 AD from minimizing when the multiplayer dialog is
closed. When DestroyWindow is called, user32 tries to find a window to
activate, finds the main game window disabled and decides to go to the
desktop. Wined3d will help this process by minimizing the game out of
the way.
Signed-off-by: Stefan Dösinger <stefan@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-02 23:02:23 +09:00
Nikolay Sivov
7a59b27f4d
comctl32/listview: Fix printf format (PVS-Studio).
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-28 22:31:32 +09:00
Dmitry Timoshkov
59cca65ce0
comctl32: Always call BeginPaint/EndPaint when handling a WM_PAINT message for the button.
...
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-21 01:04:35 +09:00
Nikolay Sivov
e0c421ff62
comctl32/syslink: Simplify conditional expression (PVS-Studio).
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-21 00:25:34 +09:00
Nikolay Sivov
83a652a9d4
include: Add a couple of documented Toolbar messages definitions.
...
Thanks to Alan Feldman for pointing this out.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-19 12:20:56 +09:00
Nikolay Sivov
490b4eec4b
comctl32/tests: Fix function prototype (PVS-Studio).
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-14 12:46:13 +09:00
Nikolay Sivov
680ba9330e
comctl32/imagelist: Use proper type for return variable (PVS-Studio).
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-14 12:45:43 +09:00
Michael Stefaniuc
88531272ce
comctl32/tests: IDI_APPLICATION is already an INTRESOURCE (PVS-Studio).
...
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-13 22:24:56 +09:00
Michael Stefaniuc
a16a270751
comctl32/tests: WC_DIALOG is already an INTATOM (PVS-Studio).
...
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-13 22:24:52 +09:00
Piotr Caban
9c87c7e76d
comctl32: Don't use uninitialized LVITEM fields in LISTVIEW_InsertItemT when LVS_EX_CHECKBOXES was specified.
...
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
2015-10-07 21:28:50 +09:00
Alex Henrie
c565145b0e
comctl32: Remove redundant if (button) statements.
...
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
2015-10-07 21:28:50 +09:00
Piotr Caban
aa39614e77
comctl32: Test TrackMouseEvent flags when LVS_EX_ONECLICKACTIVATE style is used.
...
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
2015-10-07 21:28:49 +09:00
Piotr Caban
4dd26ee814
comctl32: Don't ask for WM_MOUSEHOVER messages when LVS_EX_TRACKSELECT was not specified.
...
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
2015-10-07 21:28:49 +09:00
Michael Müller
1e2c0a3029
comctl32/tests: Add tests for LoadIconMetric function.
...
Signed-off-by: Michael Müller <michael@fds-team.de>
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
2015-10-06 00:01:55 +09:00
Michael Müller
088eb87e3b
comctl32: Add implementation for LoadIconMetric.
...
Signed-off-by: Michael Müller <michael@fds-team.de>
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
2015-10-06 00:01:55 +09:00
Michael Müller
c098c13ee2
comctl32: Add semi-stub implementation for LoadIconWithScaleDown.
...
Thanks to Nikolay Sivov and Alistair Leslie-Hughes for various comments
and ideas for improvements.
Signed-off-by: Michael Müller <michael@fds-team.de>
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
2015-10-06 00:01:54 +09:00
Huw Davies
4f06425a03
comctl32: Set the item size after LISTVIEW_ScrollColumns().
...
LISTVIEW_ScrollColumns() increments the item width by the scroll
delta, so we need the original width to still be present.
2015-09-08 14:48:09 +09:00
André Hentschel
80f887a064
comctl32/tests: Add ARM and ARM64 arch strings.
2015-08-12 22:52:24 +09:00
Francois Gouget
f8a7d6ed74
Assorted spelling fixes.
2015-08-07 23:50:48 +09:00
Huw Davies
f6653a93eb
comctl32/tests: Extra WM_PAINT messages are occasionally sent on Vista and Win 7.
2015-07-06 20:08:21 +09:00
Huw Davies
2a71d13b6b
comctl32: Implement the legacy notifications during restore.
2015-07-02 16:54:01 +09:00
Huw Davies
6c95445559
comctl32: Set the default separator width when notifying a -ve cmd id.
2015-07-02 16:53:58 +09:00
Huw Davies
eddfefa54f
comctl32: Reset the string and lparam fields between notifications.
2015-07-01 19:18:27 +09:00
Huw Davies
96a6184c30
comctl32: All negative entries in the toolbar save state are special cases.
2015-07-01 19:18:27 +09:00
Huw Davies
77ed3733af
comctl32: The number of buttons is set by the first TBN_RESTORE notification.
2015-07-01 19:18:27 +09:00
Huw Davies
063c7866f5
comctl32: Implement toolbar saving.
2015-07-01 19:18:26 +09:00
Huw Davies
199f51ff78
comctl32: Don't leak button text.
2015-07-01 19:18:26 +09:00
Huw Davies
01cd45cce1
comctl32: Add a helper to free button text.
2015-07-01 19:18:25 +09:00
Huw Davies
a29b6958e1
comctl32: Add helpers to set the button text.
2015-07-01 19:18:25 +09:00
Nikolay Sivov
035d0a1594
comctl32/monthcal: Fix title to use properly localized year/month format.
2015-06-18 21:41:02 +09:00
Bernhard Übelacker
ccf2ea6179
comctl32/tests: Free memory used by property sheet page (Valgrind).
2015-06-18 21:41:02 +09:00
Nikolay Sivov
b7969dfd94
comctl32/toolbar: Remove always true condition (Coverity).
2015-06-03 19:29:49 +09:00
Mark Harmstone
bae599092a
comctl32: Use DPI settings for checkbox size.
2015-05-25 14:34:07 +09:00
Huw Davies
a1d54447b8
comctl32/tests: Skip the hover tests if the listview's parent is not the foreground window.
2015-05-21 20:01:29 +09:00
Huw Davies
5c4dc9fc56
comctl32: Fix a typo in the TB_SAVERESTOREA handler.
2015-05-20 22:10:07 +09:00
Huw Davies
0634f3b409
comctl32: If necessary add the width of a dropdown arrow while wrapping.
...
This also fixes the layout code for the BTNS_WHOLEDROPDOWN case.
2015-05-19 22:57:36 +09:00
Huw Davies
797f42699e
comctl32: Wrap the buttons inside the toolbar's client rect.
...
The toolbar need not be the same width as the parent.
2015-05-19 22:57:27 +09:00
Huw Davies
0bcadfa88f
comctl32: Layout the toolbar after a potential resize.
2015-05-19 22:57:22 +09:00
Huw Davies
9d218048a6
comctl32: Don't store the width in the toolbar info structure.
...
It's only set and used by a single function.
2015-05-19 22:57:16 +09:00
Nikolay Sivov
6be21eeb3f
comctl32: Remove LoadString() fallback when loading from same module.
2015-05-18 19:59:28 +09:00
Alex Henrie
ad49634bbe
comctl32: Send WM_NOTIFY when expanding ancestors of the new selection.
2015-05-18 19:59:27 +09:00
Alex Henrie
36297f2cb0
comctl32: Do not send WM_NOTIFY if selecting an already-selected item.
2015-05-18 19:59:27 +09:00
Alex Henrie
a0ebe244c4
comctl32: Close previously selected treeview item at common ancestor.
...
Also, send WM_NOTIFY mesages when collapsing the previous selection and
expanding the new one.
2015-05-18 19:59:27 +09:00
Alex Henrie
9f93080754
comctl32/tests: Extend TVS_SINGLEEXPAND tests.
2015-05-18 19:59:27 +09:00
Huw Davies
eb8df37a69
comctl32: Remove button wrap states when TBSTYLE_WRAPABLE is cleared.
2015-04-30 16:17:59 +09:00
Huw Davies
abd673bde9
comctl32: A change in TBSTYLE_WRAPABLE should produce a recalc.
2015-04-28 20:23:59 +09:00
Huw Davies
e82b9dc32e
comctl32: Move the style change code to the TB_SETSTYLE handler.
2015-04-28 20:23:59 +09:00
Aric Stewart
aba3b131bc
comctl32: TTM_SETTOOLINFO does not change subclassing flags.
2015-04-27 19:33:28 +09:00
Thomas Faber
13b65faf4e
comctl32: Avoid use-after-free in DPA_Merge (DPH).
2015-04-20 14:37:57 +09:00
Huw Davies
60e305d983
comctl32: Invalidate the toolbar if the button size is changed.
2015-04-20 14:37:00 +09:00
Huw Davies
5b7b911f06
comctl32: TBSTYLE_EX_MIXEDBUTTONS doesn't mean buttons should be auto-sized.
2015-04-20 14:36:55 +09:00
Mark Harmstone
b0a9fb6b0d
comctl32: Fix drawing of buddy background for updown controls.
2015-04-09 14:55:17 +09:00
Marcus Meissner
b4ec412203
comctl32: Avoid integer overflow (Coverity).
2015-04-07 15:15:11 +09:00
Nikolay Sivov
af30ffaa43
comctl32/tests: Fix couple of metrics tests that fail on some systems.
2015-04-02 23:14:36 +09:00
Nikolay Sivov
82bab3283b
comctl32/dsa: Implement DSA_GetSize().
2015-03-31 16:44:29 +09:00
Nikolay Sivov
ff0634dfe1
comctl32/dsa: Implement DSA_Clone().
2015-03-31 16:43:49 +09:00
Nikolay Sivov
30cdd59252
comctl32/listview: Always forward HDM_SETORDERARRAY to a header.
2015-03-31 14:47:56 +09:00
Nikolay Sivov
d12c2f8b6f
comctl32/listview: Use defined name instead of magic value.
2015-03-31 14:47:54 +09:00
Nikolay Sivov
9fcfaaa64a
comctl32/listview: Support header item image/bitmap in LVSCW_AUTOSIZE_USEHEADER case.
2015-03-31 14:47:52 +09:00
Mark Harmstone
961c7b887b
comctl32: Redraw themed button on WM_ENABLE.
2015-03-31 14:47:37 +09:00
Alexandre Julliard
9f1f5d885c
comctl32: Print full flag values in traces.
2015-03-30 19:49:13 +09:00
Nikolay Sivov
c4a3651e34
comctl32/listview: Remove outdated TODO comment.
2015-03-30 16:37:44 +09:00
Nikolay Sivov
5c2e7075df
comctl32/listview: Always forward LVM_GETCOLUMNORDERARRAY to header.
2015-03-30 16:37:40 +09:00
Nikolay Sivov
3c9db1df60
comctl32/listview: Fix scrolling in LV_VIEW_DETAILS view.
2015-03-30 16:37:34 +09:00
Nikolay Sivov
782253f18d
comctl32/listview: Fix focus rectangle for LVS_EX_FULLROWSELECT case.
2015-03-30 16:37:31 +09:00
Nikolay Sivov
326af51ec2
comctl32/listview: Fix item focus rectangle to use proper label/selection bounds.
2015-03-30 16:37:27 +09:00
Nikolay Sivov
59cb4ff6f3
comctl32/tests: Listview doesn't subclass its header.
2015-03-25 19:38:30 +09:00
Nikolay Sivov
524f6860d4
comctl32: Claim success in InitializeFlatSB().
2015-03-25 15:16:45 +09:00
Mark Harmstone
e7116725ff
comctl32: Use correct font for themed headers.
2015-03-24 16:42:05 +09:00
Nikolay Sivov
9d0ebc13ac
comctl32/tooltips: Allow NULL hinst value when fetching text from resources.
2015-03-24 14:07:17 +09:00
Nikolay Sivov
b6dc726bbd
comctl32/listview: Update view on style change only if LVS_TYPEMASK styles have changed.
2015-03-23 16:36:06 +09:00
Francois Gouget
c04cc70f7d
comctl32: Remove unneeded NONAMELESSSTRUCT directives.
2015-03-09 22:06:23 +09:00
Mark Harmstone
a20c920bbd
comctl32: Draw hot parts of themed scrollbars.
2015-03-05 21:39:21 +09:00
Mark Harmstone
d9708ecb93
comctl32: Add hit testing for themed scrollbars.
2015-03-05 21:39:14 +09:00
Mark Harmstone
d7c2069721
comctl32: Paint themed scrollbars.
2015-03-03 23:16:46 +09:00
Mark Harmstone
050bda2ece
comctl32: Call OpenThemeData on themed scrollbars.
2015-03-02 23:00:30 +09:00
Nikolay Sivov
f935a10add
comctl32/tests: Fix Monthcal tests failures on some VMs.
2015-03-02 13:54:13 +09:00
Mark Harmstone
129862f369
comctl32: Themed buttons should not draw in System if font unset.
2015-02-18 15:45:04 +09:00
Mark Harmstone
6a8da85c3b
comctl32: Do not call HEADER_FillItemFrame twice in a row.
2015-02-18 15:43:04 +09:00
Mark Harmstone
50c2144999
comctl32: Fix graphical error on themed progress bars.
2015-02-16 19:18:52 +09:00
Mark Harmstone
707361321a
comctl32: Redraw themed editboxes on focus change.
2015-02-16 19:18:50 +09:00
Mark Harmstone
6f9724d581
comctl32: Use theming when drawing IP address control.
2015-02-16 19:18:49 +09:00
Mark Harmstone
ca5184f512
comctl32: Add themed scrollbar stub.
2015-02-16 19:18:48 +09:00
Mark Harmstone
18c41f7128
comctl32: Draw focus rect on themed pushbuttons.
2015-02-16 19:18:47 +09:00
Mark Harmstone
f21a968d1c
comctl32: Draw the focus rect on themed checkboxes.
2015-02-13 18:20:55 +09:00
Mark Harmstone
b8d3f1fe24
comctl32: Always redraw background on checkbox repaint.
2015-02-13 18:20:45 +09:00
Mark Harmstone
26896f1bd5
comctl32: Fix clipping error with themed groupboxes.
2015-02-09 19:02:03 +09:00
Michael Stefaniuc
39045b13d0
comctl32: Remove an unused variable assigment (PVS-Studio).
2015-01-13 19:54:01 +01:00
Austin English
42c4c870af
comctl32: Add a stub for LoadIconWithScaleDown.
2014-12-15 14:18:56 +01:00
Michael Stefaniuc
47fa711bbc
comctl32: Remove a stray unused GetFocus() statement (PVS-Studio).
2014-12-09 22:16:44 +01:00
Michael Stefaniuc
2db0a3d01e
comctl32: Merge two if blocks with identical condition (PVS-Studio).
2014-12-05 11:24:12 +01:00
Nikolay Sivov
44dbf381a7
comctl32/tests: Fix imagelist leak (Valgrind).
2014-12-01 11:00:20 +01:00
André Hentschel
ab7228f318
comctl32/tests: Remove unused structs (Clang).
2014-11-25 19:49:33 +01:00
Sebastian Lackner
735e2cd774
comctl32: Allow broken behaviour in StrRStr functions.
2014-11-19 23:36:34 +09:00
Sebastian Lackner
194b7cd5ae
comctl32: Fix invalid usage of CompareString in StrRStr functions.
2014-11-18 22:11:06 +09:00
Sebastian Lackner
e2c0694901
comctl32: Fix incorrect usage of CompareString in SYSLINK_ParseText.
2014-11-18 22:10:51 +09:00
Sebastian Lackner
766f587f90
comctl32: Fix invalid usage of CompareString in StrStr functions.
2014-11-17 17:29:09 +09:00
Bruno Jesus
a2818db03b
comctl32/tests: Remove a dead assignment in misc.c (Cppcheck).
2014-11-03 16:32:07 +09:00
Bruno Jesus
f4a13b9f1b
comctl32/tests: Remove dead assignments in treeview.c (Cppcheck).
2014-11-03 16:32:03 +09:00
Huw Davies
dd856be316
comctl32/tests: Post a key-down message rather than use keybd_event.
2014-11-03 16:31:52 +09:00
Bruno Jesus
2c5f05b860
comctl32/tests: Remove a dead assignment from dpa.c (Cppcheck).
2014-10-31 13:14:59 +09:00
Bruno Jesus
2ccd55e56f
comctl32/tests: Remove dead assignment in comboex.c (Cppcheck).
2014-10-31 13:14:56 +09:00
Bruno Jesus
a54c187886
comctl32: Remove dead assignment in tooltips.c (Cppcheck).
2014-10-31 13:14:52 +09:00
Bruno Jesus
f70167df58
comctl32: Avoid magic numbers.
2014-10-31 13:14:47 +09:00
Bruno Jesus
197ea35c5a
comctl32: Remove a dead assignment in comctl32undoc.c (Cppcheck).
2014-10-31 13:14:37 +09:00
Huw Davies
433df0d5d8
comctl32: Enable the appropriate wizard buttons before sending DM_SETDEFID.
2014-10-30 23:09:52 +09:00
Michael Stefaniuc
89e9d6db33
comctl32/tests: Add some ImageList_BeginDrag() tests.
2014-10-07 10:14:25 +02:00
Michael Stefaniuc
0a191f85ad
comctl32: Don't start a new ImageList Drag if another one is ongoing.
2014-10-07 10:14:23 +02:00
Michael Stefaniuc
753de28cd5
comctl32: Correctly handle the ImageList index in BeginDrag().
2014-10-07 10:14:21 +02:00
Francois Gouget
0dd5cb1cef
Assorted spelling fixes.
2014-09-29 10:36:36 +02:00
Nikolay Sivov
5741ebb8fd
comctl32/pager: Reduce pointer scope so it doesn't point to inner scope vars (PVS-Studio).
2014-08-18 12:44:59 +02:00