Mark Jansen
32520439e1
shell32: Prevent a possible null pointer dereference in SHGetFileInfoW.
...
Signed-off-by: Mark Jansen <mark.jansen@reactos.org>
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-19 19:13:31 +02:00
Alistair Leslie-Hughes
771d3514e9
shell32/tests: Use standard wine_dbgstr_longlong.
...
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-05 09:18:35 +02:00
Nikolay Sivov
8499ace1ff
shell32: Use IS_INTRESOURCE() to test context menu verb kind.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-09 09:18:42 +02:00
Andrey Gusev
8ea9c33829
shell32: Add IApplicationDestinations stub.
...
Signed-off-by: Andrey Gusev <andrey.goosev@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-08 19:22:18 +02:00
Nikolay Sivov
1a5561c0cf
shell32: Avoid zero length allocations when converting path in ExtractIconA() (Valgrind).
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-05 11:07:54 +02:00
Nikolay Sivov
4270c08cd7
shell32/tests: Remove null check after dereference (Coverity).
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-24 15:30:23 +02:00
Akihiro Sagawa
255fd46eeb
shell32: Avoid using isspace() for WCHARs.
...
Found with Coccinelle.
Signed-off-by: Akihiro Sagawa <sagawa.aki@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-17 16:11:19 +02:00
Huw Davies
a7d79fe445
shell32: Load icons with the correct size.
...
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-02 17:51:29 +02:00
Huw Davies
b8bf0c2628
shell32: Simplify imagelist handling.
...
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-02 17:51:27 +02:00
Huw Davies
3a1b289d66
shell32: Fix the icon sizes of the shell imagelists.
...
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-02 17:51:25 +02:00
Nikolay Sivov
627630c262
shell32/shellview: Respond to special interface id CDefView.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-01 10:06:26 +02:00
Nikolay Sivov
a528ddd745
shell32/shellview: Handle NULL folder pointer in SHCreateShellFolderViewEx().
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-01 10:06:21 +02:00
Nikolay Sivov
7a49da5070
shell32/shellview: Set provided callback in SHCreateShellFolderView().
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-01 10:06:18 +02:00
Nikolay Sivov
8ce45458fb
shell32/tests: Don't trace all messages sent to listview.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-01 10:06:13 +02:00
Nikolay Sivov
4478e61d16
shell32: Move SHCreateShellFolderView/SHCreateShellFolderViewEx and tests to corresponding files.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-01 10:05:54 +02:00
Huw Davies
826871ba95
shell32: Release the returned imagelist.
...
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-25 11:47:20 +02:00
Huw Davies
6751e57e0b
shell32: Remove an extraneous '@'.
...
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-24 19:19:05 +02:00
Nikolay Sivov
5badc91a0f
shell32/ebrowser: Respond to IOleWindow from IExplorerBrowser.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-24 15:29:20 +02:00
Nikolay Sivov
f74e1b1fb1
shell32: Fix string leak.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-24 10:02:13 +02:00
Huw Davies
adc439b1a9
shell32/tests: Add tests for the size of the icon returned by SHGetFileInfo().
...
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-21 10:53:44 +02:00
Huw Davies
c4155c523d
shell32: Take a reference on the imagelist returned with SHGFI_SYSICONINDEX.
...
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-21 10:53:31 +02:00
Huw Davies
5f0d1a006b
shell32: Don't copy the imagelist in SHGetImageList().
...
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-21 10:53:05 +02:00
Huw Davies
9072dbd2f2
shell32/tests: Add a test for the size of the icon returned by ExtractIcons().
...
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-21 10:52:55 +02:00
Huw Davies
a33c958ee2
shell32: Use a MENUEX resource for the context menu.
...
This ensures the submenus can be given ids below FCIDM_SHVIEWLAST and
so don't get stripped out by SHELL_MergeMenus().
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-19 20:02:52 +02:00
Huw Davies
734dc8f200
shell32: Use the imagelist to determine the icon size.
...
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-19 14:20:49 +02:00
Huw Davies
524e316a14
shell32: Avoid leaking icon handles.
...
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-19 14:20:48 +02:00
Huw Davies
a2eb5999cb
shell32/tests: Ignore the compressed attribute.
...
The Vista64 testbot VM reports its storage as compressed when run as a stand-alone job,
but not during a winetest run.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-17 13:19:21 +01:00
Huw Davies
aef764d37c
shell32/tests: Return early if the shell folder creation fails in order to avoid a compiler warning.
...
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-17 13:19:18 +01:00
Nikolay Sivov
f2499d20d4
shell32: Implement SHGetPropertyStoreFromParsingName() as a wrapper over IShellItem2.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-27 16:24:55 +01:00
Jacek Caban
d9fc7d271c
shell32: Added SHGetPathFromIDListEx implementation.
...
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-23 20:12:41 +01:00
André Hentschel
995a27472e
shell32: Fix some more spec file entries.
...
Signed-off-by: André Hentschel <nerv@dawncrow.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-23 13:15:44 +01:00
Michael Stefaniuc
f20fa69c9b
shell32/tests: Use the correct field for SW_SHOWNORMAL (coccinellery).
...
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-15 16:33:54 +01:00
Nikolay Sivov
0bfb97dcba
shell32: Pass correct buffer length to RegQueryValueExW().
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-08 16:00:39 +01:00
Nikolay Sivov
258c5279df
shell32: Implement IShellImageData::Draw().
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-08 10:47:52 +01:00
Nikolay Sivov
5222eca2d5
shell32: Implement IShellImageData::GetSize().
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-08 10:47:50 +01:00
Nikolay Sivov
d9d99834f6
shell32: Implement IShellImageData::Decode() when created from file path.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-08 10:47:43 +01:00
Nikolay Sivov
f04b66e68f
shell32: Added IShellImageData stub.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-08 10:47:37 +01:00
Nikolay Sivov
3f4999cc6a
shell32: Added a stub for IShellImageDataFactory.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-06 13:45:09 +01:00
André Hentschel
1c98bc14c9
shell32: Remove dead assignments (clang).
...
Signed-off-by: André Hentschel <nerv@dawncrow.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-31 08:52:59 +01:00
André Hentschel
1eede2926f
shell32: Fix some spec file entries.
...
Signed-off-by: André Hentschel <nerv@dawncrow.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-27 16:31:42 +01:00
Alex Henrie
e42a1d4db2
shell32: Correct dialog title in error message from "Run File" to "Run".
...
This makes the error message match the title in the SHELL_RUN_DLG
resource definition.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-26 19:28:50 +01:00
Nikolay Sivov
8f21b352c2
shell32: Fix return value of GetDetailsOf() for unixfs folder.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-26 10:37:00 +01:00
Nikolay Sivov
2cce196210
shell32/shellview: Set subitem callbacks for every column.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-26 10:36:56 +01:00
Nikolay Sivov
a26d6e375e
shell32/shellview: Get rid of intermediate pointer array when filling ListView.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-26 10:36:51 +01:00
Marcus Meissner
c3e6ecde36
shell32/tests: Fixed CharLowerBuffA size.
...
Signed-off-by: Marcus Meissner <marcus@jet.franken.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-16 22:02:27 +01:00
Nikolay Sivov
dba1a78a20
shell32/tests: Test valid special folder IDs with NameSpace() method.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-10 19:19:16 +01:00
Nikolay Sivov
bd42aaa801
shell32/tests: Some tests for ExtractAssociatedIcon().
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-09 12:09:49 +01:00
Nikolay Sivov
c1645b6dfd
shell32/tests: Some tests for ExtractIcon().
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-09 12:09:47 +01:00
Nikolay Sivov
f7cc41d7ae
shell32: Fix potential destination buffer overrun.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-12-21 19:13:51 +01:00
Nikolay Sivov
490ffe7f40
shell32: Don't trace output string buffer contents.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-12-21 19:13:49 +01:00