Commit Graph

288 Commits

Author SHA1 Message Date
Hans Leidekker f2081fb2bd advapi32: Stub out the Safer* functions a bit more. 2010-07-20 16:29:44 +02:00
James Hawkins 72158ac286 Revert "advapi32: Free descriptor if it isn't returned from GetSecurityInfo().".
This reverts commit dbd76575ef.

According to MSDN, ppSecurityDescriptor must not be NULL if any of the
SID or ACL parameters are non-NULL.  This is wrong, and native
GetSecurityInfo will happily return those pointers, leaving one unable
to free the original security descriptor.
2010-01-18 14:15:23 +01:00
Nikolay Sivov dbd76575ef advapi32: Free descriptor if it isn't returned from GetSecurityInfo(). 2010-01-11 15:46:04 -06:00
Hans Leidekker c0d79c475b advapi32: Improve the stub for GetEffectiveRightsFromAclA. 2009-12-01 13:16:39 +01:00
Rob Shearman 1f3a14e767 advapi32: EqualSid should set last error to ERROR_SUCCESS. 2009-11-16 11:39:28 +01:00
Rob Shearman 1802a5b9ba advapi32: Use a duplicate of the process token if a NULL token is passed into CheckTokenMembership and there is no thread token. 2009-11-11 10:56:03 +01:00
Rob Shearman cf680ed0f2 advapi32: Implement CheckTokenMembership. 2009-11-09 19:44:11 +01:00
Alexandre Julliard 104a0f5439 advapi32: Fix lookup of the current user SID in SetEntriesInAclW. 2009-10-22 13:19:31 +02:00
Paul Vriens e57edfea8b advapi32: Skip leading spaces when parsing. 2009-10-13 16:23:09 +02:00
Andrey Turkin 7de9f842e5 advapi32: Ignore invalid MultipleTrusteeOperation values in SetEntriesInAcl. 2009-10-12 12:14:25 +02:00
Alexandre Julliard 07ec73fcaa advapi32: Retrieve the current user SID from the server in lookup_user_account_name. 2009-10-06 16:49:22 +02:00
Rein Klazes b46e2ef9b1 advapi32: SetEntriesInAclW() should accept account name "CURRENT_USER". 2009-08-17 15:52:57 +02:00
Stefan Leichter 5ffba2da97 advapi32: Add stub for SaferGetPolicyInformation. 2009-08-12 13:28:09 +02:00
Hans Leidekker e5e40ef423 advapi32: Factor out lookup of local usernames and well-known SIDs.
Based on a patch by Aric Stewart.
2009-08-06 17:26:31 +02:00
Louis Lenders 011c5b8fae advapi32: Add a few tests for GetSidSubAuthority and SetLastError correctly. 2009-06-29 15:08:00 +02:00
Alexandre Julliard 3a33ff7df9 advapi32: Fix self-relative security descriptor creation for 64-bit. 2009-06-16 13:28:08 +02:00
Aric Stewart a61885d64d advapi: Correct buffer length in LookupAccountNameW. 2009-05-28 12:42:17 +02:00
Aric Stewart fe30b79d72 advapi32: Handle well qualified names in LookupAccountNameW for account names. 2009-05-19 15:26:05 +02:00
Hans Leidekker dbe5453f7c advapi32: Fix buffer size query for CreateWellKnownSid. 2009-04-15 15:56:38 -05:00
Aric Stewart 9d9a684ef6 advapi32: Handle fully qualified account names for well known sids in LookupAccountName. 2009-04-01 14:23:31 +02:00
Aric Stewart 4ea704d15a advapi32: Alias some sids in LookupAccountName and make comparison case insensitive. 2009-03-30 17:48:24 +02:00
Aric Stewart df1203342c advapi32: Stub TreeResetNamedSecurityInfo for the IE8 installer. 2009-03-25 13:30:42 +01:00
Paul Bryan Roberts be9875fb60 advapi32: Add stub for GetSecurityInfoExA. 2009-02-25 16:06:21 +01:00
Michael Stefaniuc 6a48bb4217 advapi32: Remove superfluous pointer casts. 2009-02-16 16:01:36 +01:00
Marcus Meissner 398b5cfef6 advapi32: LookupAccountNameW removed redundant NULL check (Coverity). 2009-02-09 14:37:22 +01:00
Marcus Meissner fb3d3d020d advapi32: Fixed size of userName. 2009-02-06 13:04:22 +01:00
Juan Lang fc5ea773e5 advapi32: Support the computer name as an account name in LookupAccountNameW. 2009-02-05 14:24:19 +01:00
Aric Stewart 8dc84666a6 advapi32: Add Security Label sids used by IE7. 2009-02-04 12:25:35 +01:00
Nikolay Sivov e7a27694b9 advapi32: Added SaferCreateLevel stub. 2009-01-15 13:06:39 +01:00
Alistair Leslie-Hughes d0ccdfbd4f advapi32: Correct off by one in LookupPrivilegeValueW. 2008-11-10 13:29:27 +01:00
Paul Bryan Roberts 2703721860 advapi32: Add TRACE to GetFileSecurity(). 2008-11-07 12:01:18 +01:00
Marcus Meissner 508ef4ce20 advapi32: Removed redundant NULL check. 2008-10-31 13:04:04 +01:00
Paul Bryan Roberts f04804f44c advapi32: LookupAccountNameW() - only first user account and well known SIDs accepted. 2008-10-21 13:22:50 +02:00
Paul Bryan Roberts 2981650435 advapi32: LookupAccountSidW() - handle first user account. 2008-10-21 13:22:50 +02:00
Paul Bryan Roberts 0e6626958f advapi32: LookupAccountNameW() - NULL account name handled. 2008-10-21 13:22:50 +02:00
Paul Bryan Roberts a37512ee63 advapi32: LookupAccountNameW() - use CreateWellKnownSid() properly. 2008-10-21 13:22:50 +02:00
Paul Bryan Roberts a3e0bc10bb advapi32: LookupAccountNameW() - correct call in SetEntriesInAclW(). 2008-10-21 13:22:50 +02:00
Paul Bryan Roberts 04cccae943 advapi32: LookupAccountNameW() - use ACCOUNT_SIDS domain and name_use fields for well known SIDS. 2008-10-21 13:22:50 +02:00
Paul Bryan Roberts e9e4da8f36 advapi32: LookupAccountNameW() - return correct domain name length for not-so-well-known SIDs. 2008-10-21 13:22:50 +02:00
Paul Bryan Roberts a1a2dd3509 advapi32: LookupAccountNameW() - passes expected SidTypeUser test. 2008-10-21 13:22:50 +02:00
Paul Bryan Roberts 7e0932d627 advapi32: ConvertStringSecurityDescriptorToSecurityDescriptor - more tests (pass). 2008-10-17 12:49:11 +02:00
Austin English 6f23a98c08 advapi32: Quiet a noisy fixme. 2008-10-15 14:02:16 +02:00
Marcus Meissner 49c1f1f464 advapi32: Check for NULL ptr. 2008-10-06 13:54:09 +02:00
Vijay Kiran Kamuju d2625be02f advapi32: Add stub for ConvertToAutoInheritPrivateObjectSecurity. 2008-08-28 11:03:36 +02:00
Dan Hipschman 62e5b6270b advapi32: Implement GetSecurityInfo. 2008-08-18 14:34:10 +02:00
Andrew Talbot 414cdc0475 advapi32: Sign-compare warnings fix. 2008-07-23 13:54:17 +02:00
Andrew Talbot e095a08a38 advapi32: Remove unneeded address-of operator from array name. 2008-07-08 10:47:47 +02:00
Louis Lenders 44afc4488c advapi32: Add stub for GetAuditedPermissionsFromAcl{A/W}. 2008-06-21 11:36:46 +02:00
Dan Hipschman 2904f543f4 advapi32: Add a stub for CreateRestrictedToken. 2008-03-22 11:14:13 +01:00
Rob Shearman b503bcf6e6 advapi32: Implement LookupAccountNameW for well-known groups. 2008-01-23 11:31:42 +01:00
Rob Shearman 6efa903cf0 advapi32: Implement SetEntriesInAclW. 2008-01-23 11:31:42 +01:00
Alexandre Julliard eb2d8458a3 advapi32: Move the EnumDependentServicesA/W stubs in service.c where they belong.
Make the stubs return success.
2007-12-20 15:00:42 +01:00
Andrew Talbot 263cb72e13 advapi32: Remove unneeded casts. 2007-12-03 13:10:21 +01:00
Louis Lenders defbdf76e5 advapi32: Add stub for CreateProcessWithLogonW. 2007-11-29 15:46:50 +01:00
Francois Gouget 81a5701ca9 Assorted spelling fixes. 2007-11-09 13:07:12 +01:00
Alexandre Julliard 0590fe2ecf Make some variables static. 2007-11-06 14:38:54 +01:00
Mikolaj Zalewski a1e0f773e0 advapi32: Add a well known sid. 2007-10-26 14:03:46 +02:00
Rob Shearman 6b081232b9 ntdll: Add a stub for RtlSetControlSecurityDescriptor.
Implement SetSecurityDescriptorControl on top of RtlSetControlSecurityDescriptor.
2007-10-23 18:20:45 +02:00
Francois Gouget b1335db353 Better match the PSDK types and update win32.api to fix the winapi_check warnings. 2007-10-23 18:19:42 +02:00
Mikołaj Zalewski cf509c29f1 advapi32: Make CreateWellKnownSid create domain sids (with test). 2007-10-22 14:54:39 +02:00
Mikołaj Zalewski b06379b2b3 advapi32: Add a test for CreateWellKnownSid and implement two more SIDs. 2007-10-22 14:54:39 +02:00
Bang Jun-young 27213de046 advapi32: Fix AdjustTokenPrivileges() to match the PSDK. 2007-10-17 13:44:01 +02:00
Francois Gouget d16a634c38 Better match the PSDK types and update win32.api to fix the winapi_check warnings. 2007-10-15 14:06:48 +02:00
Mikolaj Zalewski 719da96a3e advapi32: security: Remove unneeded FIXME. 2007-10-04 11:41:06 +02:00
Rob Shearman 00bc3d9e48 advapi32: Allow GetFileSecurityA/W to work on files that have been opened already with restricted sharing flags.
Only use the minimum required access rights for the information being retrieved.
2007-10-03 11:17:04 +02:00
Rob Shearman 1262d7dbef advapi32: Implement SetFileSecurityW on top of NtSetSecurityObject. 2007-10-03 11:16:59 +02:00
Mikolaj Zalewski 8fd1cf0f56 advapi32: Implement GetPrivateObjectSecurity (with test). 2007-09-28 11:26:45 +02:00
Mikolaj Zalewski 0590dc9b5c advapi32: In ConvertStringSecurityDescriptorToSecurityDescriptor "AU" should be checked before "A" (with testcase). 2007-09-28 11:26:25 +02:00
Mikolaj Zalewski 8188ce6fb1 advapi32: Make ConvertStringSecurityDescriptorToSecurityDescriptor write the ACL. 2007-09-28 11:26:18 +02:00
Michael Stefaniuc 790424f0ad advapi32: Move the storage specifier to the beginning of the declaration. 2007-09-27 11:08:21 +02:00
Mikolaj Zalewski 6d5d0eaafa advapi32: Make ConvertSidToStringSid use helper functions of ConvertSecurityDescriptorToStringSecurityDescriptor. 2007-09-26 12:15:14 +02:00
Mikolaj Zalewski 3198809fd5 advapi32: Implement ConvertSecurityDescriptorToStringSecurityDescriptor[AW]. 2007-09-26 12:15:14 +02:00
Christian Gmeiner bb3a968d30 advapi32: fix some compiler warnings when using -Wsign-compare. 2007-09-25 14:12:46 +02:00
Mikolaj Zalewski ff3ab48081 advapi32: Make ConvertStringSidToSid not to ignore the first subauthority. 2007-09-25 11:18:53 +02:00
Mikolaj Zalewski 57ca9ae92d advapi32: Add AddAuditAccessAceEx. 2007-09-25 11:18:45 +02:00
Mikołaj Zalewski 5b4aa62fd2 advapi32: Add some more rights constants for ConvertStringSecurityDescriptorToSecurityDescriptor. 2007-09-24 13:31:30 +02:00
Rob Shearman bcfe954451 advapi32: Fix ImpersonateNamedPipeClient to pass in a pointer to an IO_STATUS_BLOCK to NtFsControl.
Otherwise, NtFsControl file won't do anything except return STATUS_INVALID_PARAMETER.
2007-09-14 14:23:35 +02:00
Rob Shearman ccfa9ad8df advapi32: Set the right pointer so that StringAcl is updated correct in ParseAceStringRights.
The number of allowed hex digits should be 8, not 6.
2007-07-19 11:55:37 +02:00
Rob Shearman 6c24386e03 advapi32: Don't crash in ConvertStringSecurityDescriptorToSecurityDescriptorW if LocalAlloc fails. 2007-07-19 11:55:13 +02:00
Rob Shearman 4d5ce383f5 advapi32: Add the size of the security descriptor structure to the size of memory required in ParseStringSecurityDescriptorToSecurityDescriptor. 2007-07-19 11:55:06 +02:00
Rob Shearman 60d847b074 advapi32: Fix a typo in ParseStringAclToAcl which caused the ACE to be written inside of the ACL memory. 2007-07-19 11:54:59 +02:00
Rob Shearman f56fe2c1bc advapi32: Fix ComputeStringSidSize to work with SIDs with one sub authority.
Use GetSidLengthRequired instead of computing the length in a way that 
won't always be correct.
2007-07-19 11:54:40 +02:00
Rob Shearman d521a2c6d3 advapi32: Always set the requested fields of the security descriptor according to the info flags in GetNamedSecurityInfoW.
Also, set the control flags so that other security descriptor
functions can retrieve the info from it.
2007-06-25 23:21:50 +02:00
Dmitry Timoshkov e79a94d45b advapi32: Add FILE_FLAG_BACKUP_SEMANTICS to the flags passed to CreateFileW to be able to get security information for directories as well as for files. 2007-05-04 13:42:55 +02:00
Dan Kegel 67e2c97a88 advapi: Improve SetEntriesInAclA stub. 2007-04-30 12:20:14 +02:00
Dmitry Timoshkov 481de9d82d advapi32: Thunk GetFileSecurityW to NtQuerySecurityObject. 2007-04-23 13:56:32 +02:00
Jacek Caban 2cd033eee1 advapi: Improve SetEntriesInAclW stub. 2007-03-20 12:39:41 +01:00
Andrew Talbot dea58c017d advapi32: Explicitly initialize nested array element. 2007-03-13 11:52:22 +01:00
Francois Gouget b2656633a6 Add some documentation headers to make winapi_check happy. 2006-11-13 13:01:15 +01:00
Hans Leidekker 4301816d47 advapi32: Win64 printf format warning fixes. 2006-10-03 16:21:58 +02:00
Huw Davies 38d33e33ae advapi32: Fix ADVAPI_GetComputerSid to work correctly if a sid doesn't exist in the registry.
This makes the tests run correctly on first invocation.
2006-09-25 17:55:40 +02:00
Robert Reif f0085e6376 advapi32: Fix LookupAccountSid and tests to pass on windows and wine. 2006-08-26 18:55:12 +02:00
Robert Reif 39b77ec560 advapi32: LookupAccountSid buffer size query fixes. 2006-08-21 12:07:50 +02:00
Robert Reif 0f3cd3f224 advapi32: Add more SIDs to AccountLookupSid. 2006-08-14 11:45:53 +02:00
Robert Reif da44bfc02d advapi32: Add some more well known SIDs. 2006-08-12 11:40:21 +02:00
Robert Reif 1b8cfc5151 advapi32: Add a computer SID to the registry. 2006-08-04 12:04:06 +02:00
Robert Reif 6d4fb08ece advapi32: Add computer sid support to LookupAccountSidW. 2006-07-31 15:04:00 +02:00
Robert Reif 9d43504655 advapi32: Add more helper functions.
Add ADVAPI_GetComputerSid.
2006-07-31 14:49:31 +02:00
Robert Reif 3f000d8c71 advapi32: Make ADVAPI_IsLocalComputer global and remove duplicate copy.
Make debugstr_sid global.
2006-07-31 11:15:21 +02:00
Robert Reif ed9cca6982 advapi32: Fix debugstr_sid to print unsigned SubAuthority. 2006-07-29 11:53:38 +02:00