a02cb3ebd6
ole: Pass a channel into IRpcStubBuffer::Invoke.
...
Create a server channel and store this in the ifstub.
Rename ipid_to_apt_and_stubbuffer to ipid_get_dispatch_params and make
the function return an HRESULT.
Return the channel for the ifstub in ipid_get_dispatch_params.
2006-01-10 20:41:22 +01:00
8e5b36147d
ole: Reduce the access rights required by start_local_service.
2006-01-10 20:41:22 +01:00
c46386ff5c
ole: Return the last error if we couldn't open the requested service.
...
Fix the ok/failed message.
2006-01-10 20:41:22 +01:00
b75db2d9de
ole: Join the MTA if necessary when executing an RPC call.
...
Join the MTA if necessary when executing an RPC call to ensure that it
is executing with a valid apartment and won't fail for certain COM
calls.
2006-01-09 18:41:19 +01:00
1eda42ccac
ole: Prefer services over servers.
...
Attempt to start as a local service before attempting to start as a
local server for the CLSCTX_LOCAL_SERVER case.
2006-01-09 18:40:42 +01:00
e0605afdf6
ole: Add some tests for CLSIDFromString.
2006-01-09 18:40:27 +01:00
cc4669cc5f
ole: Remove __CLSIDFromStringA.
...
Move the ANSI implementation of CLSIDFromString to ole16.c and change
CLSIDFromString to only deal with Unicode strings.
2006-01-09 18:40:17 +01:00
0f81ac3506
ole: Remove a no longer needed smbfs hack.
2006-01-06 21:19:05 +01:00
95312fcb63
ole: Remove "stub" from TRACEs of functions that aren't stubs.
2006-01-06 21:08:09 +01:00
427920f8a2
ole: Fix SmallBlocksToBigBlocks loop.
...
Stop copying data when read returns 0 bytes
2006-01-06 12:16:04 +01:00
dfa74b998e
ole: Check the return value of IStream_SetSize in IStream_Read.
...
Check the return value of IStream_SetSize in IStream_Read, since
otherwise execution could continue on and cause heap corruption.
2006-01-03 12:07:49 +01:00
8f604e925d
ole: Fix mis-handling of return value in StgStreamImpl_Read.
...
BlockChainStream_ReadAt returns a BOOL, not an HRESULT so change
StgStreamImpl_Read to handle this, by returning STG_E_READFAULT on
failure.
2006-01-03 12:07:34 +01:00
85128db39c
Fix detection of V1a prop variant library in test suite.
2005-12-26 12:56:48 +01:00
707fa2c3a2
ole32: Return error instead of asserting if storage file is corrupt.
2005-12-22 17:15:05 +01:00
dbc14a5cb5
ole32: Revert exception handler change.
...
The handler does the opposite of normal page fault handlers.
2005-12-19 17:44:56 +01:00
ae964ac801
Take advantage of the __EXCEPT_PAGE_FAULT macro.
2005-12-16 17:17:57 +01:00
db7920bb44
We no longer need to handle EXCEPTION_PRIV_INSTRUCTION on page faults.
2005-12-16 16:37:12 +01:00
892fc1093d
ole32: Periodically call IDropTarger::DragOver during Drag&Drop.
2005-12-12 12:42:53 +01:00
681b71ed9a
Functions with no paramters must be (void).
2005-12-12 12:42:44 +01:00
28442721fd
Const correctness fixes.
2005-12-12 11:55:49 +01:00
6c3e1f9adf
CreateErrorInfo trace fix.
...
CreateErrorInfo isn't a stub so don't print this in the trace
message.
2005-12-12 11:52:36 +01:00
ef8ae2d763
OLE: Fix a typo where brackets were missing.
2005-12-06 10:57:58 +01:00
5127dc9f49
Assorted spelling fixes.
2005-12-02 16:15:09 +01:00
567919d78f
Implement some user marshal functions and add tests.
2005-11-29 11:35:27 +01:00
e2bdb145ef
Made the Drag&Drop cursors' rubber band visible on a white background.
2005-11-29 11:23:49 +01:00
5f7bb17cf4
Implement IOleObject_DoVerb function by running the object and then
...
delegating to the remote IOleObject_DoVerb function.
2005-11-28 11:24:31 +01:00
b9d7754034
Delegate advises to the remote object to enable the client to receive
...
data change notifications.
2005-11-28 11:16:58 +01:00
bc09238067
Call DefaultHandler_Stop if we fail to start the server running
...
correctly and a few formatting fixes.
2005-11-28 10:58:51 +01:00
5db65cdd51
Correct the hot spot position of the drag&drop 'move' and 'link' cursors.
2005-11-28 10:41:00 +01:00
22cf59ba43
Call the equivalent delegate function for all of the simple
...
functions.
2005-11-28 10:39:19 +01:00
0ec7e1a591
Renamed all .cvsignore files to .gitignore.
2005-11-26 13:10:33 +01:00
45d440a219
Implement CLSCTX_INPROC_HANDLER in CoGetClassObject similar to
...
CLSCTX_INPROC_SERVER by looking at the InprocHandler32 registry key
instead of InprocServer32.
2005-11-12 19:11:21 +00:00
0edbaf7e80
Remove spaces before '\n' in traces.
2005-11-10 12:14:56 +00:00
ae542af541
Improve c2man Documented-Total count.
2005-11-09 10:30:57 +00:00
f7b65cc716
- Extend COM_OpenKeyForCLSID to open a subkey and return an HRESULT.
...
- Fix up the callers and reorganize CoGetClassObject to split out the
inproc code into another function.
2005-11-09 10:29:11 +00:00
2f210917ee
Added tracing to CoCreateInstance.
2005-11-08 12:43:24 +00:00
65581b8489
We shouldn't pass the application name into CreateProcess because the
...
value stored in the registry could include arguments.
2005-11-08 10:56:02 +00:00
fe4015201b
Implement OLE object notifications, making sure to cope with the case
...
of the advise holder not being created because no notifications are
needed.
2005-11-03 19:32:49 +00:00
52c6299538
Delete some temp files created by the ole32 tests.
2005-10-29 10:29:18 +00:00
22c97cd98a
Implement a Stop function and use this to properly implement
...
IOleObject_Close, IAdviseSink_OnClose and the destructor.
2005-10-26 10:12:49 +00:00
a1f9a13997
Use "static const" rather than "const static" as gcc -W complains
...
about the former.
2005-10-06 11:38:45 +00:00
c23cb51d52
Pass WM_QUIT to outer modal loop.
2005-10-03 11:02:37 +00:00
7e22be4d84
We are no longer generating .dbg.c files.
2005-09-29 10:35:58 +00:00
fc68475c80
Add a stubbed out implementation of IAdviseSink and advise the
...
delegate object to use it.
2005-09-29 10:29:44 +00:00
8165b584f6
- Make the interfaces that should be supported by the data cache
...
explicit so their is no confusion in this file as to what it should
be implementing and what this object should implement.
- Delegate some IOleObject methods to the server IOleObject if it is
running.
2005-09-28 18:29:38 +00:00
1e26f9601d
Add NULL check for sinkInterface in DataCache_GetAdvise.
2005-09-28 18:12:58 +00:00
a90c11330e
Add missing ! to fix a reversed condition check in
...
OleCreateDefaultHandler, in order to match intent in comment.
2005-09-28 18:12:45 +00:00
80e023bdea
Use the proper calling convention for 2 16-bit functions.
2005-09-27 09:32:41 +00:00
a8c7284f92
Assorted spelling fixes.
2005-09-26 10:58:41 +00:00
335fce9ce0
Fix .spec declarations for functinos with 64bit arguments (reported by
...
winapi_check).
2005-09-26 09:56:40 +00:00
c86fef8844
Move all 16-bit functions to an appropriate 16-bit file.
2005-09-25 15:17:10 +00:00
53ef9950f2
Implement some IRunningObject functions that actually start the server
...
and initialize it.
2005-09-23 10:08:35 +00:00
3daf39fb0c
Implement OleRegEnumVerbs.
2005-09-23 10:08:25 +00:00
044ccc40f3
Don't fail in CoRegisterClassObject if the class already exists and
...
the REGCLS_MULTIPLEUSE flag is specified.
2005-09-23 10:08:11 +00:00
0ec0f048e6
Removed unused debug channels.
2005-09-22 10:44:40 +00:00
6bc4327c92
- Initialize out pointer to NULL before access check in
...
IStorage_CreateStorage.
- WriteClassStg should return E_INVALIDARG if pstg is NULL instead of
asserting.
- ReadClassStg should return E_INVALIDARG if pstg is NULL instead of
crashing and a NULL pclsid should cause it to return the same
value.
2005-09-22 10:34:40 +00:00
9f1c6de1ef
We are no longer generating .spec.c files.
2005-09-21 14:42:52 +00:00
0a49c1752e
Implement OleIsRunning.
2005-09-20 11:36:56 +00:00
d389b57171
- Fix a trace to refer to the object ID rather than the legacy MID.
...
- Fix the error case of CoMarshalInterThreadInterface to release the
stream.
2005-09-20 11:36:40 +00:00
83f3b370b1
- Remove redunant braces.
...
- Compact multi-line comments that fit into one line.
- Remove comments that state the obvious.
- Remove extra brackets that are redundant because the -> operator
binds tighter than &.
- Change "this" to "This" to make code more like other interface
implementations.
- Remove redundant comparisons with NULL for pointers.
2005-09-19 14:42:53 +00:00
0ceacf017f
Fix the return codes during unmarshaling so that it returns failure
...
codes instead of S_FALSE returned from IStream_Read.
2005-09-19 14:34:04 +00:00
b3a4b59668
Fix ref-counting rules to match native DCOM Dlls.
2005-09-18 11:10:37 +00:00
18bd21d4f1
Re-arrange some functions and vtables so we don't have declarations
...
for all of the functions in the file.
2005-09-17 14:29:11 +00:00
43df8b61bb
Add exception handling for stubs.
2005-09-14 10:07:01 +00:00
5a49e40149
SendMessageTimeout takes a DWORD_PTR not a DWORD.
2005-09-12 20:43:32 +00:00
f8ee161a1b
Fixed some traces to use the right printf format and avoid typecasts.
2005-09-12 10:30:05 +00:00
20a1a203c6
Use a more portable scheme for storing the name of a critical
...
section.
2005-09-09 10:19:44 +00:00
908e9e889e
Relax the share mode validation for transacted storage, with a test.
2005-09-07 09:22:15 +00:00
b379e420ed
Fixes for function prototypes without arguments.
2005-09-06 09:27:37 +00:00
3f912e048e
The [string] attribute is only valid on byte, char and wchar_t types,
...
so replace "unsigned short" by "WCHAR".
2005-09-02 11:19:05 +00:00
611b5acbf8
Authors: Mike Hearn <mh@codeweavers.com>, Robert Shearman <rob@codeweavers.com>
...
Change stub manager to track the number of normal marshals instead of
using the state machine so that multiple marshals of the same object
and interface work correctly.
2005-09-02 11:18:45 +00:00
dab603def3
- Implement IMarshal on proxies so that we don't end up with proxies
...
to proxies, causing potential deadlock issues and performance
problems.
- Add a test for this situation and remove the todo_wine from another
test that now succeeds.
2005-08-27 09:25:16 +00:00
c8aedf9726
Add stub for CoAllowSetForegroundWindow.
2005-08-26 08:47:09 +00:00
bcb251d5b3
Remove unused thread handle entry from the apartment structure.
2005-08-25 09:50:36 +00:00
eafa666bee
Fix some gcc 4.0 warnings.
2005-08-22 09:26:53 +00:00
6c8527c31c
- return a precomputed result for a NULL string
...
- pass strlen an LPSTR to eliminate a sign warning
2005-08-22 09:19:38 +00:00
71af595499
Use LPSTORAGE to better match the PSDK.
...
Document the real SEGPTR type using the standard documentation
mechanisms. Fixes winapi_check warnings.
2005-08-16 16:01:15 +00:00
61aabd66f5
Warning fixes for gcc 4.0.
2005-08-15 10:49:39 +00:00
61b2fba9d7
Added CoCreateInstance16, CoGetClassObject16, OleLoad16 stubs.
2005-08-15 09:46:51 +00:00
628939d567
Use the proper WOW functions everywhere instead of the K32WOW variant.
2005-08-10 10:59:19 +00:00
21e3ba8cd1
Correct mismatches between spec files and comments about export
...
number.
2005-08-10 09:53:47 +00:00
d32610fabe
Remove local declarations already in included public headers.
2005-08-10 09:48:15 +00:00
d37f0abf07
Don't prefix the functions DllCanUnloadNow, DllGetClassObject and
...
Dll(Un)RegisterServer with the dll name so that the compiler can check
the prototypes.
2005-08-08 17:35:28 +00:00
170470ee0b
Implemented ILockBytes16 (memorystream) support for the 16bit compound
...
storage implementation.
Added ReadClassStg, OleDoAutoConvert, GetConvertStg
implementations/stubs.
2005-08-08 11:05:06 +00:00
04b7382db9
Remove duplicate definition of FILE_BEGIN.
2005-07-28 10:24:01 +00:00
b1a9701bb5
Replace the _ICOM_THIS_From macros by inline functions the way it's
...
already done in shelllink.c.
2005-07-27 11:10:52 +00:00
b8d3075d83
Uncomment the typedef in the DECLARE_INTERFACE macro, and get rid of
...
duplicate typedefs.
2005-07-26 18:32:53 +00:00
4f82e547d7
Fix some missing-declarations warnings.
2005-07-24 17:11:59 +00:00
c5feb317b3
Implemented IsValidInterface16, CoMemAlloc.
...
Added debug to HGLOBALLockBytes16_QueryInterface.
2005-07-24 16:15:24 +00:00
1c3054af32
Added OleSetMenuDescriptor16 stub.
2005-07-22 18:29:39 +00:00
c8187b0900
OleInitializeWOW gets 2 arguments.
2005-07-22 18:29:19 +00:00
ba4c61776d
16bit COM interfaces are cdecl, not WINAPI.
2005-07-22 18:26:31 +00:00
d32762808b
16bit interfaces are cdecl, so drop the WINAPI.
2005-07-22 09:03:29 +00:00
4fad9ddc86
Hack around broken state management so InstallShield works.
2005-07-20 10:30:04 +00:00
775898ba97
- Always query for the correct stub interface, otherwise we will be
...
pointing to the completely wrong object when a proxy does a
queryinterface.
- Remove assumption that the stub buffer will handle the lifetime of
the object.
2005-07-19 19:59:41 +00:00
5d873adf9f
Marshal return value from IRemUnknown_RemQueryInterface.
2005-07-19 19:43:05 +00:00
c0d7a25a42
Silence now noisy error messages caused by changes in the way we call
...
ipid_to_stubmanager. Move the error message to the one place it is
needed.
2005-07-19 19:42:33 +00:00
97be0be7e4
- We should be starting with 1 reference.
...
- IRpcStubBuffer_Disconnect can be called more than once.
2005-07-19 19:13:11 +00:00
28479ea4aa
By-pass the RPC runtime if possible when calling an STA by posting a
...
message directly to the apartment window for it to process. Fixes a
deadlock in InstallShield caused by having to create a thread when
freeing an object that comes from an STA apartment. Added tests that
fail without this fix.
2005-07-19 19:12:47 +00:00
e874408d65
Delete the stub manager outside of the apartment critical section
...
because the deletion may require the object to re-enter the
apartment.
2005-07-19 19:12:24 +00:00
0f9ebafbec
Initialize RegisteredClass properly in CoRegisterClassObject to
...
prevent crash in CoRevokeClassObject when accessing (uninitialized)
pMarshalledData.
2005-07-19 11:40:22 +00:00
e633b45300
Added some documentation.
2005-07-07 17:21:44 +00:00
c7fdb4565a
Fix gcc 4.0 -Wpointer-sign warnings.
2005-07-05 11:02:54 +00:00
809edabfbe
Const correctness fixes.
2005-06-27 09:53:46 +00:00
aa0b9aac0d
Sort entry points alphabetically.
2005-06-22 18:38:23 +00:00
863a4b1488
Fix some more -Wstrict-prototypes warnings.
2005-06-21 20:53:13 +00:00
ac6f562b52
Fix more -Wstrict-prototypes warnings.
2005-06-20 14:18:03 +00:00
0a645e8cb9
Convert some registry helper functions to use unicode versions of
...
CLSID & registry functions (untested).
2005-06-20 13:14:22 +00:00
5807cb79f0
Change the RPC code to use the unicode versions of the CLSID &
...
registry functions.
2005-06-20 10:33:28 +00:00
f419880d64
- Change some of the registry helper functions to use the unicode
...
versions of the CLSID & registry functions.
- Reindent CoGetClassObject and output an error message if the class
isn't registered.
- Add tests for the touched functions.
2005-06-20 10:33:17 +00:00
0220d7ac89
Fix declarations in the tests.
2005-06-15 10:20:30 +00:00
c2d5b444b3
Moved the NONAMELESSUNION/STRUCT macros to wine/test.h so that they
...
can be used in all the test.
2005-06-13 12:10:54 +00:00
fd5f7729cb
Fix PropVariant tests on Windows 2000 and above.
2005-06-13 10:02:10 +00:00
a1e466ae77
- Add registry entries for local-only OLE interfaces.
...
- Change IUnknown to local interface.
2005-06-13 10:01:43 +00:00
ec7a5931ae
Removed CLSID_CompositeMoniker (conflicting with static definition).
2005-06-09 09:47:44 +00:00
037bdc0dc0
IUnknown isn't a remotable interface so the stub manager shouldn't
...
need a marshaller for it.
2005-06-09 09:45:59 +00:00
eba47f1dfe
Make remaining OLE interface vtables const.
2005-06-06 19:50:35 +00:00
e46047e4da
Don't disconnect proxies flagged with SORFP_NOLIFETIMEMGMT. It makes
...
no sense and only causes trouble for proxies that depend on these
proxies being available.
2005-06-05 19:19:24 +00:00
e3f990467c
Add some tracing to the IRemUnknown RpcProxyBuffer implementation.
2005-06-05 18:13:47 +00:00
977806a884
- Don't assume the ROT is already empty.
...
- Test that IEnum::Clone doesn't also do a Reset.
2005-06-02 20:06:33 +00:00
95b71ed885
IEnum::Clone shouldn't do a Reset.
2005-06-02 20:06:22 +00:00
885e6298f2
Added tests for file monikers.
2005-06-02 19:43:03 +00:00
54f041ad32
- Base FileMonikerImpl_Save() on XP.
...
- Correct handling of Unicode strings & multibyte locales.
- More error checking.
- Change ERR to WARN.
- Match Windows quick & dirty estimate for GetSizeMax().
2005-06-02 19:42:48 +00:00
4f14044f29
Remove forward declarations.
2005-05-23 16:31:13 +00:00
8d6a673cf7
- Add error messages on failure in file moniker load function.
...
- Fix incorrect pointer check in both monikers.
- Fix max size calculation of item moniker to match native.
2005-05-23 10:27:42 +00:00
27d73d6115
- Add a useful trace message.
...
- Fix more places where custom header size was calculated exclusive of
the data size member.
- Optimize custom marshaling by getting size before calling the custom
marshaler so we can write the header before and not use a second
stream.
2005-05-23 10:27:23 +00:00
aebb745488
Comment out stub WEP entry points so that we can call WEP for builtin
...
dlls too.
2005-05-23 10:12:26 +00:00
0ddd30b0b6
Removed unnecessary code in the 16-bit DllEntryPoint function of some
...
dlls, and also fixed its ordinal in a few places.
2005-05-23 10:00:26 +00:00
b9ecbb6167
- Marshal objects & monikers into the ROT.
...
- Test for this behaviour.
2005-05-23 09:54:53 +00:00
bb4d6f88bf
Implement Hash function on composite moniker.
2005-05-23 09:52:13 +00:00
34d3049360
- Add a generic moniker marshaler that works by saving & loading
...
monikers to & from the stream.
- Use the generic moniker marshal in the file & item monikers and add
a class factory for each.
2005-05-19 14:22:14 +00:00
a890293f33
- Change remaining blocks of code with 2-space indentation to 4-space
...
indentation.
- Make vtables const.
- Remove an unnecessary memcpy and let the compiler do the work.
2005-05-19 12:04:58 +00:00
447ab61288
Write custom header up to and including size, not excluding.
2005-05-19 11:15:50 +00:00
10ee7b36e8
Implement IROTData::GetComparisonData for file & item monikers.
2005-05-18 18:28:15 +00:00
49b1d335d9
Big Endian specific code fixes in order to conform with
...
NONAMELESSSTRUCT.
2005-05-18 09:44:13 +00:00
b45e31608b
Obvious fixes to PropVariantClear and PropVariantCopy for vector
...
types.
2005-05-17 10:18:59 +00:00
ff87ad7ab1
Add a comment, and a no-op cleanup.
2005-05-16 21:37:54 +00:00
e140d02a2b
Differentiate between version 0 and version 1 property storages.
2005-05-16 17:52:36 +00:00
f3d99b2697
Move the Dll init function to compobj.c to avoid having global
...
variables. Remove need of ole32_main.h.
2005-05-16 14:12:53 +00:00
fc61f6c553
Make _xmalloc16() static.
2005-05-16 08:47:40 +00:00
81e2677939
Staticify FTMarshalImpl definition.
2005-05-16 08:47:26 +00:00
45bc1c21a1
Make HGLOBALStream_* functions static.
2005-05-16 08:47:14 +00:00
5d90f2bcf9
Store property names in the code page of the property set.
2005-05-16 08:43:35 +00:00
72f73ac452
Implement the IEnumMoniker interface for the ROT and provide tests to
...
exercise the interface.
2005-05-14 18:50:14 +00:00
2507264e05
- maintain proper byte order
...
- maintain PROPSETFLAG_ANSI flag based on codepage
- update comments
2005-05-14 11:06:44 +00:00
a22c767eb0
Remove function prototypes.
2005-05-13 17:45:50 +00:00
6b7676a1e8
Don't import from ntdll.
2005-05-13 17:42:49 +00:00
e3b43fa458
Make sure a stream can't be created in read only storage.
2005-05-13 13:58:43 +00:00
912ffd6a0f
Remove unnecessary declarations and make functions static.
2005-05-12 09:57:21 +00:00
2c6c67f4ea
Make functions static and remove unnecessary declarations.
2005-05-11 15:56:45 +00:00
3c5790646f
Add a stub implementation of CoIsHandlerConnected.
2005-05-11 12:57:16 +00:00
809cf354e4
Fix a memory leak in the ole storage implementation.
2005-05-10 15:59:59 +00:00
34fa35dc99
Added rules for building import libraries in the individual dll
...
makefiles, and added support for building a .def.a static import
library too.
2005-05-09 14:42:30 +00:00
4d1562495d
Correct/improve error checking in IPropertyStorage.
2005-05-09 09:26:43 +00:00
d62356aa1e
Added rules to build import libraries in the individual dll makefiles.
...
Generate import libraries with the right name right away instead of
using an intermediate .spec.def file.
2005-05-07 12:39:52 +00:00
cabe752d1d
Make ole32 tests loadable on NT4.
2005-05-07 12:09:58 +00:00
6e028f414d
Replace stub entry for StgOpenStorageEx with call to StgOpenStorage.
2005-05-06 14:32:30 +00:00
8188790946
Replace StgCreateStorageEx stub with call to StgCreateDocfile and add
...
required STGFMT_* enumerations.
2005-05-05 16:44:05 +00:00
b99dfb0c1a
Define and use endian conversion macros for big-endian machines.
2005-04-24 17:22:26 +00:00
bf83ba1fa3
- convert strings between property storage's code page and system code
...
page
- add tests for setting code page
- fix tests and behavior to match WinXP
2005-04-23 19:04:49 +00:00
950d678c5e
Make ole32 tests loadable on NT4.
2005-04-22 19:05:51 +00:00
4b9f767845
Specify the proper call convention in the PropSysFreeString()
...
implementation.
2005-04-20 16:21:16 +00:00
3ef8c51c8a
Tweak the API documentation to silence winapi_check warnings.
2005-04-20 15:18:42 +00:00
35356002e6
Zero out an invalidated runningObjectTableInstance pointer.
2005-04-15 16:11:29 +00:00
e68982fcaf
Implement FmtIdToPropStgName & PropStgNameToFmtId, with tests.
2005-04-15 14:09:18 +00:00
f7ff216a15
Fixed a buffer overflow.
2005-04-14 12:50:54 +00:00
e3e5cf19a8
Remove the need for the non-standard (Close|Delete)MetaFile16().
2005-04-13 15:16:40 +00:00
142254d746
Implement PropSys{Alloc|Free}String, and support BSTRs in
...
PropVariant{Clear|Copy} using them.
2005-04-13 11:13:55 +00:00
c1fe67bc36
- add write support to IPropertyStorage, with tests
...
- misc. cleanups the tests turned up
2005-04-11 18:50:45 +00:00
50794ce787
Add traces, add unit tests for IPropertyStorage, and fix the problems
...
they caught.
2005-04-11 14:30:24 +00:00
6714664dee
Eliminate forward declarations, make functions static.
2005-03-31 15:26:30 +00:00
6b10c324c5
Assorted spelling fixes.
2005-03-30 17:08:31 +00:00
9be7f2789f
WriteFmtUserTypeStg doesn't pull a CLSID from the registry - it's
...
unclear when (if at all) this gets written.
2005-03-29 18:56:22 +00:00
e42a23d2d3
Don't close reg key if the open failed.
2005-03-29 13:06:57 +00:00
c822566974
Change prototypes so gcc with some warnings doesn't bark.
2005-03-29 11:32:04 +00:00
a63c2eb30b
Remove function prototypes, make functions static.
2005-03-28 10:01:45 +00:00
e19ce3bd40
Remove unnecessary function prototypes.
2005-03-27 18:16:49 +00:00
1ff3bf8e69
Remove function prototypes, make functions static.
2005-03-27 18:16:25 +00:00
93416cdaf7
Assorted spelling fixes.
2005-03-23 13:15:18 +00:00
461c830745
Eliminate HeapAlloc casts.
2005-03-22 18:26:06 +00:00
665b9ca377
More trace info from storage32 test.
2005-03-22 18:18:43 +00:00
17c3106896
Eliminate casts of the return value of HeapAlloc.
2005-03-21 11:25:13 +00:00
811725ac20
Correct and complete some api documentation.
2005-03-21 10:55:13 +00:00
963b63ecbd
ix test for STGM_SHARE_EXCLUSIVE on nameless DocFiles.
2005-03-21 10:30:01 +00:00
1571df5722
Fix memory leak in OleDuplicateData on error path (found by Smatch).
2005-03-19 17:05:12 +00:00
dbf222f3aa
Use LMEM_ flags for LocalAlloc(), not GMEM_ (GlobalAlloc).
2005-03-17 20:53:37 +00:00
be84f8d9e6
Begin implementing IPropertyStorage.
2005-03-17 20:50:35 +00:00
1b5ebabdce
- Add critsec debugging info.
...
- Move the modal loop called during RPCs into CoWaitForMultipleHandles.
- Use a mutex for long remoting calls to IRemUnknown methods.
- Remove locking in apartment_disconnectproxies as it is not needed.
- Use PostMessage instead of SendMessage so we can run the message
loop or not as appropriate.
2005-03-17 10:26:20 +00:00
ac24801db0
Add a comment about byte order, change types to reduce casting and not
...
cast away constness.
2005-03-17 10:25:13 +00:00
34a0463bca
A few memory checks avoiding memory leaks.
2005-03-14 10:46:50 +00:00
77fc6a5d82
StgOpenStorage shouldn't open zero length storage files.
2005-03-11 13:17:10 +00:00
8971f06225
- Rename apartment functions to become more object-oriented.
...
- Rename register_ifstub to marshal_object to more accurately describe
what it does.
- Add new function, apartment_getoxid, to prepare for a possible
future patch where remoting is started on demand.
2005-03-11 10:19:10 +00:00
23805995a6
Fix the calling convention of DllCanUnloadNow.
2005-03-10 17:25:02 +00:00
6f2f76c410
Shared reading of storage files requires STGM_TRANSACTED.
2005-03-09 11:44:59 +00:00
527ef47d70
Make each ifproxy have its own channel buffer to fix a bug where a
...
proxy with multiple interfaces could invoke the wrong stub buffer on
the server.
2005-03-07 17:14:11 +00:00
e9d334d0c9
Fix more incorrect uses of STGM_ enumerations.
2005-03-07 12:24:42 +00:00
01239efa4a
Implement StgCreatePropSetStg.
2005-03-07 10:59:09 +00:00
a7609ee155
Test and fix grfMode handling in StgOpenDocfile.
2005-03-05 10:48:11 +00:00
53f3d4c65a
Authors: Rob Shearman <rob@codeweavers.com>, Mike Hearn <mh@codeweavers.com>
...
- Add re-entrancy tests to the test suite.
- Run RPCs on a new thread client side so we can pump the message
loop.
2005-03-04 12:30:47 +00:00
607b43e6b4
Implement StgSetTimes.
2005-03-04 10:48:17 +00:00
fbb3343547
Assorted spelling fixes.
2005-03-02 13:53:50 +00:00
d0ee9f9309
Avoid spaces before preprocessor directives, that's not portable.
2005-03-02 12:23:20 +00:00
4c8676cdbf
Move vtbl to end of file and get rid of unnecessary prototypes.
2005-03-01 10:41:25 +00:00
eb5bf7dd38
Documentation spelling fixes.
2005-02-25 14:07:56 +00:00
8922da9ed4
Added some TRACE statements.
2005-02-25 13:58:37 +00:00
db69dcb5c1
Add struct StorageBaseImpl at the start of derived structures instead
...
of trying to keep the first members the same.
2005-02-24 19:39:27 +00:00
a6a91a440b
Implement and test IPropertySetStorage.
2005-02-21 20:58:09 +00:00
4d49d8ca36
Avoid infinite loop when doing a typelib marshalled
...
IUnknown::QueryInterface by only doing an extra QI if requested IID is
not equal to marshalled IID.
2005-02-21 18:35:07 +00:00
4390d003f4
- Better tracing.
...
- Small cleanup of creation functions.
2005-02-18 20:13:23 +00:00
95288f9148
- Move marshaling state machine into stub manager from ifstub.
...
- Add additional needed states for table-weak marshaling, as shown by
tests.
- Protect external reference count from underflows/overflows.
2005-02-18 20:03:23 +00:00
2d2a39cc42
- Use I_RpcGetBuffer, instead of our own buffer routines to fix an
...
occasional test crash caused by heap corruption.
- Zero the memory block passed to RpcServerRegisterIfEx so we don't
pass garbage in some of the fields we don't fill in.
- Return the correct error code from create_server and fix two handle
leaks.
- TODO update.
2005-02-15 21:48:09 +00:00
3b59fa8fce
The Global Interface Table should do table-strong marshaling instead
...
of normal marshaling so that an interface can be retrieved more than
one time.
2005-02-15 15:47:44 +00:00
552cc7d5b3
- Remove cruft left over from previous RPC backend implementation in
...
the apartment structure.
- Don't pass an IPID by value for proxy_manager_create_ifproxy.
- Disable more of RPC_UnregisterInterface to prevent the RPC runtime
using freed memory.
- Rename various external RPC backend functions so that they all have
the same "RPC_" prefix.
- Reduce the timeout of the function that connects to a local server
to 30s, like native.
2005-02-15 15:44:25 +00:00
db6db7cb4c
Make COM use the RPC runtime as the backend for RPC calls. Based on a
...
patch by Ove Kåven.
2005-02-15 15:02:49 +00:00
2ff1711487
Invoke objects in STA's in the correct thread by sending messages to
...
the hidden apartment window.
2005-02-14 11:50:51 +00:00
30ed10004b
Output some more informations.
...
Mark one global variable static.
2005-02-14 11:07:55 +00:00
403d8e23cd
Make Ole tests run on Windows 95.
2005-02-14 11:01:51 +00:00
999766d31b
- Implement CoDisconnectObject.
...
- Change CoLockObjectExternal so that it does the correct action now
and eliminate a fair few lines of now redundant code.
- Rename OLE32_Dll{Register,Unregister}Server to
Dll{Register,Unregister}Server.
2005-02-08 16:51:22 +00:00
514af6ce78
Move object-to-stub-manager mapping rule to register_ifstub.
2005-02-08 14:26:19 +00:00
f8a2edb805
- Split up apartment creation so that the long code paths that don't
...
need locking no longer have locking.
- Add special cases for the threads that join apartments but can't
increase the refcount of the apartment.
- Free TLS storage on thread destruction (including releasing the
apartment the thread is in, if any, and so making another test
pass).
2005-02-08 13:42:15 +00:00
2a46702761
Authors: Mike Hearn <mh@codeweavers.com>, Robert Shearman <rob@codeweavers.com>
...
- Rework RPC dispatch layer to be simpler and not get confused by
server/client duality.
- Make threads shut down at the right time and not access freed memory
after apartment destruction.
- Rename stub_dispatch_thread to client_dispatch_thread.
- Add some more tracing
- Check return value of WaitNamedPipe.
- Change named pipe timeouts to 0.5s, which should be enough for even the slowest machines.
2005-02-08 12:55:26 +00:00
b9aa9e0bdd
- Pass the original IID to IMarshal_UnmarshalInterface and query for
...
the requested interface.
- Unmarshaling IID_NULL means use the IID the interface was originally
marshaled with.
2005-02-02 19:11:23 +00:00
e6afc84873
- Add code for destroying the thread-local storage data, but don't use
...
it yet.
- Don't release apartment on changing modes because we didn't add a
reference anywhere.
- Quieten the RPC_E_DISCONNECTED error message as it is an expected
return code.
- Treat IID_NULL the same as IID_IUnknown.
- Make tests compile on Win95 again.
- Fix copy+paste error where the test failure should be from the
CoUnmarshalInterface function.
2005-02-01 14:18:10 +00:00
9a97360eba
Remove test that fails on Win98 and is not useful.
2005-01-31 11:29:41 +00:00
9dba3479c8
Release the client security objects when no longer needed (reported by
...
Mike McCormack).
2005-01-28 17:19:51 +00:00
9b634b97ae
- More tests.
...
- Change return code of CoGetPSClsid to match test result.
- Do a slight hack to make IRemUnknown proxies be added after the
proxy that uses them to stop them being used after they are
destroyed.
- Fix multiple local server connections.
2005-01-28 12:39:13 +00:00
41d9aef7ef
- Implement CoSetProxyBlanket, CoQueryProxyBlanket and CoCopyProxy.
...
- Update todo list.
2005-01-28 11:27:46 +00:00
5bef770490
Give IUnknown its own ifstub to fix ref-counting and ipid storage
...
issues.
2005-01-27 10:39:44 +00:00
3018974ce3
- Make proxy manager use IMultiQI instead of IInternalUnknown as tests
...
show that IInternalUnknown isn't exposed.
- Implement IMultiQI on top of IRemUnknown calls.
- Silence some fixmes that occur during tests and don't give us any
useful information.
- Fix typo in class factory proxy that caused us to use the wrong
offset into the CFProxy structure, causing us to not call the
outer_unknown properly.
2005-01-26 21:07:05 +00:00
cbbf08a7e2
- Use InterlockedIncrement for the ipid counter instead of a critical
...
section (suggested by Mike Hearn).
- Remove a line added by a bad merge.
- Implement RemUnkStub_Disconnect.
- Remove all of the RPC disconnect code.
2005-01-26 20:53:06 +00:00
963ac3f013
- Implement IRemUnknown.
...
- Use IRemUnknown for life-cycle management instead of the current
hacks.
2005-01-26 20:42:30 +00:00
ce5adcda15
- Move OLE automation interface registration to oleaut32.
...
- Add IRemUnknown to list of interfaces to register.
2005-01-25 19:03:30 +00:00
6e042873d5
Proxies/stubs for IRemUnknown methods, based on code written by Ove
...
Kåven.
2005-01-25 19:02:54 +00:00
ad34f3dc5e
- Generate machine-local IPIDs.
...
- Make pipes be uniquely identified only by their IPID.
2005-01-25 10:57:24 +00:00
6b89a92215
- Add a new flag SORFP_NOLIFETIMEMGMT to tell the proxy manager not to
...
call any IRemUnknown functions.
- Move the low-level unmarshaling code into a new function,
unmarshal_object, so that it can be easily reused for unmarshaling
IRemUnknown.
2005-01-24 11:24:08 +00:00
70c1c26869
Various formatting/style changes.
2005-01-21 10:15:29 +00:00
717eb8fff4
- Consolidate more stub creation details into register_ifstub.
...
- Replace the current wine_marshal_id structure with STDOBJREF for the
on-the-wire format.
2005-01-20 10:35:46 +00:00
6a20b2f476
- Initialize ppv pointer in ClientIdentity_QueryInterface to NULL as
...
apps depend on this.
- Don't release IRpcProxyBuffer on ifproxy destruction - the caller
will do this for us.
- Make find_proxy_manager add a reference to the proxy manager and
make proxy_manager_construct return an object with a valid
ref-count.
- Remove stray not operator to fix a memory leak / crash in
proxy_manager_destroy.
- More debug messages, especially on errors.
- Fix ref-count leak in the Class Factory proxy.
- Add a test case for IClassFactory_CreateInstance.
2005-01-19 17:00:20 +00:00
b5a10936bd
Initialize clsid member to the marshaler clsid to fix custom
...
marshaling.
2005-01-17 19:32:25 +00:00
4c8d59dd91
Implement table marshaling.
2005-01-17 13:39:40 +00:00
5ce396f9bd
- Remove obsolete structs, rearrange things to group the structs
...
together and to group similar functions.
- Document thread-safety of members of structs.
2005-01-14 17:20:27 +00:00
ca608933dd
Make proxy shutdown test succeed by releasing the channel on
...
disconnect.
2005-01-14 17:20:13 +00:00
0e18914481
- Add documentation for most Co* functions.
...
- Move several functions into different files to group them with
similar functions.
2005-01-14 17:05:36 +00:00
6036a773e2
- The apartment reference should be held while the stub manager
...
reference is held.
- Fix same apartment-unmarshal detection.
2005-01-14 16:48:34 +00:00
ead057c4b7
- Don't use the pipe caching code because it doesn't work correctly at
...
the moment.
- Always write disconnect reply packet, even in failure cases.
2005-01-14 15:59:01 +00:00
a84e7d7b75
Destroy stubs on apartment shutdown.
2005-01-14 15:11:55 +00:00
ba0475e738
Force context switch on chanbuf disconnect to avoid a race in the test
...
suite.
2005-01-14 15:11:24 +00:00
a010e3b3fa
CoInitialize(Ex) should return S_FALSE when COM is already initialized
...
for the current thread.
2005-01-12 19:58:09 +00:00
452491bd03
- Document CoSetState & CoGetState.
...
- Rewrite them to only retrieve TLS info once.
- Remove trailing whitespace in COM_CurrentInfo.
2005-01-12 19:48:39 +00:00
2891bc53ba
Remove wine_marshal_data: it is unneeded and there is no equivalent in
...
STDOBJREF.
2005-01-12 19:48:20 +00:00
de95de1865
- Force creation of thread queue to stop PostThreadMessage from
...
failing.
- Remove incorrect comment.
2005-01-12 19:28:37 +00:00
89f5c8241f
The way apartments are used has changed, so fix up the hacks in the
...
RPC code that haven't yet been updated.
2005-01-12 19:27:22 +00:00
36f482cb7d
- Make MTA dynamically allocated so that proxies and other resources
...
are freed at the proper time.
- Changed/removed some incorrect comments regarding apartments.
2005-01-12 19:27:04 +00:00
9c6de52bb2
Corrected testing for multithreaded (based upon observations by Paul
...
Vriens, Christian Costa and Robert Shearman).
Added TRACE for investigating OXID errors.
2005-01-11 15:45:03 +00:00
71424b80e5
Tests and fixes for StgOpenStorage.
2005-01-11 15:08:08 +00:00
68fc5f8890
Add tests for trying to unmarshal from a bad stream and for testing
...
what interfaces the proxy exposes.
2005-01-11 10:45:52 +00:00
c353f85082
- Document how thread-safety is ensured for each member of the
...
stub_manager and ifstub structs.
- Make stub_manager ref counted to ensure it doesn't get freed whilst
it is still being used.
- ifstubs are now freed only when the controlling stub_manager is freed.
- Rename stub_manager_ref/unref to stub_manager_ext_addref/release
respectively and make then take an unsigned long to prevent
malicious callers from passing in a negative value and corrupting
the ref count.
2005-01-11 10:45:34 +00:00
6f20133705
Test and fix a few problems with OLE storage streams.
2005-01-11 10:44:28 +00:00
b146b75c27
Test and fix StgCreateDocFile grfModes.
2005-01-10 12:26:25 +00:00
202b340a51
- use Interlocked* functions in AddRef and Release.
...
- store the result of the Interlocked functions and use only this.
2005-01-09 17:29:21 +00:00
cf1d00bb08
Removed excessive statement (break after return or goto, not useful
...
break, not needed vars...)
2005-01-09 16:42:53 +00:00
86d63bbbac
Rename iid in wine_marshal_id to ipid and use IPIDs instead of IIDs in
...
the stub manager.
2005-01-07 15:33:41 +00:00
090003360f
The current architecture cannot handle pipes changing address, so use
...
a static array. Fixes memory corruption that sometimes occurs when
using multiple pipes.
2005-01-07 15:33:26 +00:00
b2edf2f03c
No need to add a reference to the apartment from new_stub_manager as
...
we don't hold on to an apartment pointer.
2005-01-06 20:43:48 +00:00
23e390a223
- Make struct oletls ref counted so that it is only detached from the
...
apartment on the final CoUninitialize.
- Decrease the size of the crit sec on destroying an apartment - it is
only needed for touching the apartment list.
- Small cleanups.
2005-01-06 19:39:07 +00:00
67bae9f213
ConnectNamedPipe returning ERROR_PIPE_CONNECTED is not an error.
2005-01-06 19:38:48 +00:00
b5e4d1a8d8
The channel buffer can be NULL if the proxy is disconnected, so check
...
for this before releasing it.
2005-01-05 17:30:20 +00:00
9f426df0a8
- Fix race on apartment creation.
...
- Display errors in decimal to make searching for the meaning in
winerror.h easier.
2005-01-05 17:30:04 +00:00
a6a416cb4e
- Make apartment access thread-safe by introducing refcounting and
...
wider usage of the apartment lock.
- Rework OLE TLS management to eliminate uninitialised apartments and
parent chaining.
2005-01-05 17:14:33 +00:00
a246306870
Allow COM to start services containing COM servers.
2005-01-05 13:22:10 +00:00
85763a1711
- Add tracing for proxy ref count functions.
...
- Release the channel on proxy destruction.
2005-01-04 20:33:02 +00:00
73318dab8f
Add a DCOM todo list.
2005-01-04 20:32:47 +00:00
2835633789
Implement proxy manager.
2005-01-04 11:58:23 +00:00
dee74a6ec9
Make the ClassFactory proxy support aggregation.
2005-01-04 11:47:52 +00:00
15a308a9d7
Do not check for non NULL pointer before HeapFree'ing it. It's
...
redundant.
2005-01-03 14:56:42 +00:00
054f9ecc3c
Comment out an assert, as we don't yet implement IRemUnknown.
2005-01-03 14:34:09 +00:00
5d7d188df5
- Move named pipe macros into rpc.c.
...
- Remove unneeded function.
2004-12-27 19:27:57 +00:00
2b747d4e50
Implement COM local servers using table marshaling to avoid doing the
...
marshaling in a child thread where COM has not been initialized.
2004-12-27 19:24:55 +00:00
5475a2e617
- Implement the COM stub manager, refactor the current stub code.
...
- Begin implementing interface stubs.
2004-12-27 19:21:47 +00:00
737e67b17b
Propagate apartments through the intermediate threads, make listener
...
thread apartment scoped.
2004-12-27 16:59:28 +00:00
5ad7d858e0
Do not check for non NULL pointer before HeapFree'ing it. It's
...
redundant.
2004-12-23 17:06:43 +00:00
bcfa5b0900
ReadFile and WriteFile must be passed a parameter for the number of
...
handled bytes when no overlapped operation is done.
2004-12-22 18:38:31 +00:00
827154e451
Add tests for moniker and marshaling functions.
2004-12-21 14:51:27 +00:00
6fb1a20020
Assorted spelling fixes.
2004-12-20 19:27:06 +00:00
b4bb1c931c
Allocate correct amount of memory.
2004-12-16 14:23:16 +00:00
9fdd91fdc4
- Add documentation to several functions.
...
- Coding style changes according to the style Mike and I have agreed
upon for COM related files.
2004-12-14 15:31:05 +00:00
2fa9a0a6fd
Remove unneeded includes and the unused COMPOBJ_hInstance32 variable.
2004-12-14 15:28:58 +00:00
40b4f7f6e6
Use OBJREF on the wire for generic marshaling functions.
2004-12-14 15:14:40 +00:00
398a595377
Fixed incorrect unsigned test.
2004-12-14 11:35:12 +00:00
4056d7ef8c
Fixed some errors in function prototypes.
2004-12-13 21:19:01 +00:00
ebe3c529b1
Janitorial: C booleans must not be compared against TRUE.
2004-12-09 14:07:59 +00:00
2c3de6db24
- Make the wine_marshal_id structure more like the DCOM OBJREF
...
structure, by replacing the process id field by apartment id (OXID),
changing the users of the process id field to use the new field and
renaming the objectid field to oid.
- Fix StdMarshalImpl_UnmarshalInterface to invalidate and release its
stub when doing a same apartment marshal.
2004-12-08 17:49:30 +00:00
36aee71988
Rename the STUBMGR thread to more accurately reflect its purpose.
2004-12-07 17:01:40 +00:00
cba8763c33
Remove unnecessary WNDPROC casts.
2004-12-06 11:51:29 +00:00
3b0a5d0a06
- Add some function declarations to objbase.h.
...
- Add stubs for server ref counting.
- Implement HRESULT marshaling.
2004-12-01 15:33:34 +00:00
0a258964c2
Const correctness fixes.
2004-11-30 21:38:57 +00:00
b547af156b
Trace the OLE error info strings.
2004-11-29 17:00:39 +00:00
a153efc5bb
- Improve OLE function documentation.
...
- Bail out with CO_E_NOTINITIALIZED when apt is null.
2004-11-29 17:00:15 +00:00
aa758eaf82
Implement OleDuplicateData.
2004-11-24 18:12:06 +00:00
405568801e
Removed a couple of no longer needed entries.
2004-11-19 18:28:05 +00:00
Robert Shearman