Nikolay Sivov
1f1f190bf0
shell32/tests: Add a basic test for NewMenu object creation.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-19 13:43:52 +01:00
Michael Müller
2723e9473c
shell32: Use manual redirection for RunDLL_CallEntry16.
...
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-12 11:04:41 +01:00
Mark Jansen
61b89d2c84
shobjidl.idl: Fix some typo's.
...
Signed-off-by: Mark Jansen <mark.jansen@reactos.org>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-29 20:28:59 +01:00
Nikolay Sivov
bb09bb5750
shell32: Fix a trace message.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-23 16:21:33 +01:00
Nikolay Sivov
ce5fb75f7f
shell32: Reduce code duplication in GetCommandString().
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-22 10:16:40 +01:00
Alex Henrie
332898eacd
shell32/tests: Drop shell folder test workarounds for Windows <= 2000.
...
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-12 15:27:07 +01:00
Alex Henrie
dca38ea895
shell32/tests: Drop shell folder test dynamic imports for Windows <= 2000.
...
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-12 15:27:05 +01:00
Alex Henrie
946b4ad270
shell32/tests: Drop progman DDE test workarounds for Windows <= 2000.
...
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-09 16:03:32 +01:00
Alex Henrie
8bb6addb1e
shell32/tests: Add missing return value check to shelllink tests (Coverity).
...
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-08 19:26:44 +01:00
Andrey Gusev
498009c6bd
shell32/tests: Fix resource leak.
...
Signed-off-by: Andrey Gusev <andrey.goosev@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-05 16:13:28 +01:00
Nikolay Sivov
1ee9c2c60b
shell32: Make some strings static constants.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-04 15:13:36 +01:00
André Hentschel
460053b8fc
shell32: Don't cast return value from DPA_GetPtr.
...
Signed-off-by: André Hentschel <nerv@dawncrow.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-02 15:52:22 +01:00
André Hentschel
063fd7a665
shell32/tests: Don't test functions directly when reporting GetLastError().
...
Signed-off-by: André Hentschel <nerv@dawncrow.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-02 11:10:31 +01:00
André Hentschel
5200f3472f
shell32/tests: Don't test functions directly when reporting DdeGetLastError().
...
Signed-off-by: André Hentschel <nerv@dawncrow.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-02 11:10:25 +01:00
Michael Stefaniuc
fd0251996f
shell32/tests: Use the available ARRAY_SIZE() macro.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-12-28 11:18:58 +01:00
Nikolay Sivov
f75d562596
shell32: Fix SHGetFolderPathAndSubDir() trace message.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-12-26 10:12:44 +01:00
Louis Lenders
307b20b97b
shell32: Add stub for Shell_NotifyIconGetRect.
...
Signed-off-by: Louis Lenders <xerox.xerox2000x@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-12-04 11:58:05 +01:00
Zebediah Figura
35d203622b
shell32: Implement the Groups request for Progman DDE.
...
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-12-04 11:42:53 +01:00
Zebediah Figura
7ddd41e326
shell32: Implement the ExitProgman() command for Progman DDE.
...
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-12-04 11:42:41 +01:00
Zebediah Figura
57a94970f5
shell32: Implement the ReplaceItem() command for Progman DDE.
...
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-12-04 11:42:34 +01:00
Zebediah Figura
8b2f586343
shell32/tests: Simplify existing tests and add more tests for Progman DDE.
...
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-12-01 18:43:58 +01:00
Zebediah Figura
64c456af77
shell32: Implement the DeleteItem() command for Progman DDE.
...
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-12-01 18:43:35 +01:00
Zebediah Figura
6e5efd001c
shell32: Implement the AddItem() command for Progman DDE.
...
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-12-01 18:43:33 +01:00
Zebediah Figura
fd851064d8
shell32: Implement the ShowGroup() command for Progman DDE.
...
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-11-30 10:24:15 +01:00
Zebediah Figura
957da4ee07
shell32: Implement the DeleteGroup() command for Progman DDE.
...
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-11-30 10:24:13 +01:00
Zebediah Figura
83ca4e20cc
shell32: Implement the CreateGroup() command for Progman DDE.
...
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-11-30 10:24:11 +01:00
Zebediah Figura
6778023999
shell32: Add a parser for DDE commands.
...
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-11-30 10:24:09 +01:00
Zebediah Figura
106722494a
shell32/tests: Simplify and standardize test structure for progman_dde.
...
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-11-29 21:24:50 +01:00
Lucian Poston
349064216a
shell32: Stub GetRedirectionCapabilities with S_OK.
...
Signed-off-by: Lucian Poston <lucian.poston@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-11-24 17:33:44 +01:00
Fabian Maurer
5e88f928ed
shell32/tests: Add test for IAutoComplete2 with custom source.
...
Signed-off-by: Fabian Maurer <dark.shadow4@web.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-11-20 12:37:15 +01:00
Marcus Meissner
5350eea78d
shell32: Avoid a crash in testsuite.
...
This happens on wow32 builds, we try to call a 64bit program via the
generic typelib marshalling and disp is NULL. We still fail, just
do not pop up the crash dialog.
Signed-off-by: Marcus Meissner <meissner@suse.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-11-13 19:47:19 +01:00
Andrew Eikum
db1a3c617e
shell32: Size ShellView column widths by font width.
...
Signed-off-by: Andrew Eikum <aeikum@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-11-10 16:41:28 +01:00
Andrew Eikum
8d004d5151
shell32: Scale explorer browser sizes by DPI.
...
Signed-off-by: Andrew Eikum <aeikum@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-11-10 13:57:31 +01:00
Andrey Gusev
498578d1bb
shell32: Fix misplaced parenthesis.
...
Signed-off-by: Andrey Gusev <andrey.goosev@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-10-13 14:21:32 +02:00
Nikolay Sivov
4c160b6f8c
shell32: Improve error handling in ParseName() (Coverity).
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-10-03 13:38:29 +02:00
Nikolay Sivov
e9c69fde09
shell32/tests: Fixed some leaks (Valgrind).
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-10-02 22:38:49 +02:00
Nikolay Sivov
937ef12772
shell32: PickIconDlg() is documented now.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-28 11:04:27 +02:00
Nikolay Sivov
c36e7d1ec7
shell32: Added missing arguments to trace messages.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-28 11:03:49 +02:00
Nikolay Sivov
8b661a18e3
shell32: Stop using fixed size buffers for display names.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-28 11:03:45 +02:00
Nikolay Sivov
3e2559b98a
shell32: Get rid of original variant used to create a Folder.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-28 11:03:42 +02:00
Nikolay Sivov
2ef383c01a
shell32: Implement FolderItem::Name() property getter.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-28 11:03:38 +02:00
Nikolay Sivov
876dc3d8fd
shell32: Simplify Verbs() method.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-27 10:20:16 +02:00
Nikolay Sivov
c14c2ebfb7
shell32: Fix IEnumIDList::Next() called for multiple items.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-27 10:20:15 +02:00
Nikolay Sivov
d484650b6d
shell32: Implement ParseName() using shellfolder API.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-27 10:20:13 +02:00
Nikolay Sivov
2406d6cd84
shell32: System shellfolders don't support GetDefaultSearchGUID() in recent versions.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-27 10:20:11 +02:00
Nikolay Sivov
babd22b443
shell32: System shellfolders don't implement GetDefaultColumn().
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-27 10:20:09 +02:00
Alex Henrie
67826491a6
shell32: Implement ShellExec_RunDLL.
...
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-27 09:29:54 +02:00
Nikolay Sivov
76d46fa323
shell32: Silence fixme for tested case.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-26 21:24:08 +02:00
Nikolay Sivov
d935fa69d8
shell32: Implement FolderItem attributes properties.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-26 21:24:08 +02:00
Nikolay Sivov
0d87da46a9
shell32: Store simple full path for FolderItem.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-26 21:24:08 +02:00
Nikolay Sivov
7c638b00c7
shell32: Use shellfolder API to construct FolderItems.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-26 21:24:08 +02:00
Vincent Povirk
8a46b9e5d1
shell32: Add support for find data in IShellLink:GetPath.
...
Signed-off-by: Vincent Povirk <vincent@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-26 08:44:19 +02:00
Vincent Povirk
aa37e696cb
shell32/tests: Setting a PIDL with no path resets the path.
...
Signed-off-by: Vincent Povirk <vincent@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-26 08:44:12 +02:00
Vincent Povirk
3615db9a00
shell32: Set shelllink path when setting pidl.
...
Signed-off-by: Vincent Povirk <vincent@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-26 08:44:06 +02:00
Vincent Povirk
94378704f8
shell32: IShellLink::GetPath returns S_FALSE if there's no path.
...
Signed-off-by: Vincent Povirk <vincent@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-26 08:43:57 +02:00
Vincent Povirk
a796bcaa7f
shell32: Support SFGAO_LINK in unix shell namespace.
...
Signed-off-by: Vincent Povirk <vincent@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-26 08:42:24 +02:00
Nikolay Sivov
709db66f8d
shell32: Use regular helper to trace IID, downgrade QI failures to warnings.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-25 23:29:11 +02:00
Fabian Maurer
4ef3ffd69d
shell32/tests: Fix typo.
...
Signed-off-by: Fabian Maurer <dark.shadow4@web.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-25 23:29:11 +02:00
Nikolay Sivov
f23edde42c
shell32: Partially implement MapColumnToSCID().
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-25 22:21:42 +02:00
Nikolay Sivov
ec42839cd6
shell32: Implement Title property using shellfolder API.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-20 19:03:40 +02:00
Nikolay Sivov
3014fb1617
shell32: Added remaining Application() properties.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-18 09:58:43 +02:00
Nikolay Sivov
58b73fa075
shell32: Implement Parent() property for ShellDispatch objects.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-18 09:58:39 +02:00
Nikolay Sivov
a1f7339137
shell32: Implement Application property for FolderItem.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-15 17:00:54 +02:00
Nikolay Sivov
03cdddc08c
shell32/tests: Remove workarounds that are no longer relevant.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-15 17:00:54 +02:00
Nikolay Sivov
a05d2b76b9
shell32: Implement Application() property for Folder and FolderItems.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-13 17:25:48 +02:00
Alex Henrie
aac8d46c21
shell32: Implement FolderItems_get_Count.
...
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-12 20:32:03 +02:00
Alex Henrie
93dd50666f
shell32: Implement FolderItems_Item.
...
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-12 20:32:02 +02:00
Alex Henrie
02efd35ce2
shell32/tests: Add tests for FolderItems_Item and FolderItems_get_Count.
...
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-12 20:32:02 +02:00
Vincent Povirk
fcd7d4404a
shell32: Stub SHOpenWithDialog.
...
Signed-off-by: Vincent Povirk <vincent@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-12 10:27:43 +02:00
Fabian Maurer
755f49d7c4
shell32: Draw text on message boxes without background.
...
Signed-off-by: Fabian Maurer <dark.shadow4@web.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-05 10:04:06 +02:00
Alexandre Julliard
feac70c1cf
shell32: Avoid zeroing a buffer that will get overwritten.
...
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-28 20:21:37 +02:00
Vincent Povirk
dcb1359b5e
shell32: Change default ProgramData folder and set ProfileList key.
...
Signed-off-by: Vincent Povirk <vincent@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-24 14:08:18 +09:00
Jactry Zeng
d71bc1503b
shell32/tests: Add more tests for SHGetKnownFolderIDList.
...
Signed-off-by: Jactry Zeng <jzeng@codeweavers.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-16 11:05:06 +09:00
Jactry Zeng
5451c7d04f
shell32: Implement SHCreateItemInKnownFolder.
...
Signed-off-by: Jactry Zeng <jzeng@codeweavers.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-16 11:04:59 +09:00
Jactry Zeng
6048090275
shell32: Implement SHCreateItemFromRelativeName.
...
Signed-off-by: Jactry Zeng <jzeng@codeweavers.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-16 11:04:49 +09:00
Mark Jansen
32520439e1
shell32: Prevent a possible null pointer dereference in SHGetFileInfoW.
...
Signed-off-by: Mark Jansen <mark.jansen@reactos.org>
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-19 19:13:31 +02:00
Alistair Leslie-Hughes
771d3514e9
shell32/tests: Use standard wine_dbgstr_longlong.
...
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-05 09:18:35 +02:00
Nikolay Sivov
8499ace1ff
shell32: Use IS_INTRESOURCE() to test context menu verb kind.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-09 09:18:42 +02:00
Andrey Gusev
8ea9c33829
shell32: Add IApplicationDestinations stub.
...
Signed-off-by: Andrey Gusev <andrey.goosev@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-08 19:22:18 +02:00
Nikolay Sivov
1a5561c0cf
shell32: Avoid zero length allocations when converting path in ExtractIconA() (Valgrind).
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-05 11:07:54 +02:00
Nikolay Sivov
4270c08cd7
shell32/tests: Remove null check after dereference (Coverity).
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-24 15:30:23 +02:00
Akihiro Sagawa
255fd46eeb
shell32: Avoid using isspace() for WCHARs.
...
Found with Coccinelle.
Signed-off-by: Akihiro Sagawa <sagawa.aki@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-17 16:11:19 +02:00
Huw Davies
a7d79fe445
shell32: Load icons with the correct size.
...
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-02 17:51:29 +02:00
Huw Davies
b8bf0c2628
shell32: Simplify imagelist handling.
...
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-02 17:51:27 +02:00
Huw Davies
3a1b289d66
shell32: Fix the icon sizes of the shell imagelists.
...
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-02 17:51:25 +02:00
Nikolay Sivov
627630c262
shell32/shellview: Respond to special interface id CDefView.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-01 10:06:26 +02:00
Nikolay Sivov
a528ddd745
shell32/shellview: Handle NULL folder pointer in SHCreateShellFolderViewEx().
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-01 10:06:21 +02:00
Nikolay Sivov
7a49da5070
shell32/shellview: Set provided callback in SHCreateShellFolderView().
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-01 10:06:18 +02:00
Nikolay Sivov
8ce45458fb
shell32/tests: Don't trace all messages sent to listview.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-01 10:06:13 +02:00
Nikolay Sivov
4478e61d16
shell32: Move SHCreateShellFolderView/SHCreateShellFolderViewEx and tests to corresponding files.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-01 10:05:54 +02:00
Huw Davies
826871ba95
shell32: Release the returned imagelist.
...
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-25 11:47:20 +02:00
Huw Davies
6751e57e0b
shell32: Remove an extraneous '@'.
...
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-24 19:19:05 +02:00
Nikolay Sivov
5badc91a0f
shell32/ebrowser: Respond to IOleWindow from IExplorerBrowser.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-24 15:29:20 +02:00
Nikolay Sivov
f74e1b1fb1
shell32: Fix string leak.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-24 10:02:13 +02:00
Huw Davies
adc439b1a9
shell32/tests: Add tests for the size of the icon returned by SHGetFileInfo().
...
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-21 10:53:44 +02:00
Huw Davies
c4155c523d
shell32: Take a reference on the imagelist returned with SHGFI_SYSICONINDEX.
...
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-21 10:53:31 +02:00
Huw Davies
5f0d1a006b
shell32: Don't copy the imagelist in SHGetImageList().
...
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-21 10:53:05 +02:00
Huw Davies
9072dbd2f2
shell32/tests: Add a test for the size of the icon returned by ExtractIcons().
...
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-21 10:52:55 +02:00
Huw Davies
a33c958ee2
shell32: Use a MENUEX resource for the context menu.
...
This ensures the submenus can be given ids below FCIDM_SHVIEWLAST and
so don't get stripped out by SHELL_MergeMenus().
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-19 20:02:52 +02:00
Huw Davies
734dc8f200
shell32: Use the imagelist to determine the icon size.
...
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-19 14:20:49 +02:00
Huw Davies
524e316a14
shell32: Avoid leaking icon handles.
...
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-19 14:20:48 +02:00
Huw Davies
a2eb5999cb
shell32/tests: Ignore the compressed attribute.
...
The Vista64 testbot VM reports its storage as compressed when run as a stand-alone job,
but not during a winetest run.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-17 13:19:21 +01:00
Huw Davies
aef764d37c
shell32/tests: Return early if the shell folder creation fails in order to avoid a compiler warning.
...
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-17 13:19:18 +01:00
Nikolay Sivov
f2499d20d4
shell32: Implement SHGetPropertyStoreFromParsingName() as a wrapper over IShellItem2.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-27 16:24:55 +01:00
Jacek Caban
d9fc7d271c
shell32: Added SHGetPathFromIDListEx implementation.
...
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-23 20:12:41 +01:00
André Hentschel
995a27472e
shell32: Fix some more spec file entries.
...
Signed-off-by: André Hentschel <nerv@dawncrow.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-23 13:15:44 +01:00
Michael Stefaniuc
f20fa69c9b
shell32/tests: Use the correct field for SW_SHOWNORMAL (coccinellery).
...
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-15 16:33:54 +01:00
Nikolay Sivov
0bfb97dcba
shell32: Pass correct buffer length to RegQueryValueExW().
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-08 16:00:39 +01:00
Nikolay Sivov
258c5279df
shell32: Implement IShellImageData::Draw().
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-08 10:47:52 +01:00
Nikolay Sivov
5222eca2d5
shell32: Implement IShellImageData::GetSize().
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-08 10:47:50 +01:00
Nikolay Sivov
d9d99834f6
shell32: Implement IShellImageData::Decode() when created from file path.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-08 10:47:43 +01:00
Nikolay Sivov
f04b66e68f
shell32: Added IShellImageData stub.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-08 10:47:37 +01:00
Nikolay Sivov
3f4999cc6a
shell32: Added a stub for IShellImageDataFactory.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-06 13:45:09 +01:00
André Hentschel
1c98bc14c9
shell32: Remove dead assignments (clang).
...
Signed-off-by: André Hentschel <nerv@dawncrow.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-31 08:52:59 +01:00
André Hentschel
1eede2926f
shell32: Fix some spec file entries.
...
Signed-off-by: André Hentschel <nerv@dawncrow.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-27 16:31:42 +01:00
Alex Henrie
e42a1d4db2
shell32: Correct dialog title in error message from "Run File" to "Run".
...
This makes the error message match the title in the SHELL_RUN_DLG
resource definition.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-26 19:28:50 +01:00
Nikolay Sivov
8f21b352c2
shell32: Fix return value of GetDetailsOf() for unixfs folder.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-26 10:37:00 +01:00
Nikolay Sivov
2cce196210
shell32/shellview: Set subitem callbacks for every column.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-26 10:36:56 +01:00
Nikolay Sivov
a26d6e375e
shell32/shellview: Get rid of intermediate pointer array when filling ListView.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-26 10:36:51 +01:00
Marcus Meissner
c3e6ecde36
shell32/tests: Fixed CharLowerBuffA size.
...
Signed-off-by: Marcus Meissner <marcus@jet.franken.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-16 22:02:27 +01:00
Nikolay Sivov
dba1a78a20
shell32/tests: Test valid special folder IDs with NameSpace() method.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-10 19:19:16 +01:00
Nikolay Sivov
bd42aaa801
shell32/tests: Some tests for ExtractAssociatedIcon().
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-09 12:09:49 +01:00
Nikolay Sivov
c1645b6dfd
shell32/tests: Some tests for ExtractIcon().
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-09 12:09:47 +01:00
Nikolay Sivov
f7cc41d7ae
shell32: Fix potential destination buffer overrun.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-12-21 19:13:51 +01:00
Nikolay Sivov
490ffe7f40
shell32: Don't trace output string buffer contents.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-12-21 19:13:49 +01:00
Hans Leidekker
a2556760ec
shell32/tests: Skip SHFileOperation tests if the user doesn't have admin rights.
...
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-12-20 13:02:15 +01:00
Hans Leidekker
748f7e26cb
shell32/tests: Accept another error from SHFileOperationA.
...
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-12-20 13:02:10 +01:00
Nikolay Sivov
3c6cbc2f91
shell32: Don't access uninitialized buffer (Coverity).
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-12-14 20:56:13 +01:00
VRan Liu
c64cdc1fe6
shell32/tests: Simple test for KF_FLAG_DEFAULT_PATH.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-12-06 18:57:41 +01:00
Nikolay Sivov
a0c259cf56
shell32: Move retrieving folder path logic to SHGetKnownFolderPath().
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-12-06 18:57:36 +01:00
Michael Müller
117c0dc5ba
shell32: Add IDragSourceHelper stub.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-12-01 12:17:12 +01:00
Nikolay Sivov
8e7a041154
shell32: Simplify drag drop helper object creation.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-12-01 12:17:04 +01:00
Nikolay Sivov
794efcceee
shell32: Use standard list for IEnumIDList implementation.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-12-01 12:16:56 +01:00
Nikolay Sivov
252051cb1b
shell32: Respect SFGAO_NONENUMERATED attribute for registered shell extensions.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-11-30 13:26:12 +01:00
Huw Davies
b670fc2c6d
shell32/tests: Updated Windows 7 has a new IShellDispatch6 in its typelib.
...
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-11-30 13:23:34 +01:00
Lauri Kenttä
1c3d6ab9cc
shell32: Cosmetic changes to file type names.
...
Signed-off-by: Lauri Kenttä <lauri.kentta@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-11-29 21:21:31 +01:00
Huw Davies
b70821a74d
shell32/tests: Add some uuids present on Windows 10.
...
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-11-29 15:11:09 +01:00
Nikolay Sivov
6d89f58ec2
shell32: Added stub implementation of ICustomDestinationList.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-11-29 12:17:30 +01:00
Nikolay Sivov
960b5996fc
shell32: Limit displayed volume label length to 32.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-11-28 13:58:10 +01:00
Nikolay Sivov
1c86f97985
shell32: Get rid of some casts by using IShellFolder2 internally.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-11-28 13:56:16 +01:00
Nikolay Sivov
e49878289b
shell32: Remove a couple more casts of object pointers.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-11-28 13:56:09 +01:00
Nikolay Sivov
5ad123f851
shell32: Use interface pointers instead of a pointer to implementation structure.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-11-23 22:36:41 +01:00
Hans Leidekker
567b52cd93
shell32: Implement IKnownFolderManager::GetFolderByName.
...
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-11-22 16:32:00 +01:00
Jared Smudde
906e770121
shell32: Add caption to Run dialog.
...
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-11-09 19:15:50 +01:00
Austin English
6c876de7d0
shell32: Add SHCreateSessionKey stub.
...
Signed-off-by: Austin English <austinenglish@gmail.com>
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-10-19 08:11:55 -07:00
Austin English
e18654edac
shell32: Add SHRemoveLocalizedName stub.
...
Signed-off-by: Austin English <austinenglish@gmail.com>
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-10-19 08:11:37 -07:00
Roman Pisl
6d7a32a107
shell32: Implement NIM_SETVERSION.
...
Signed-off-by: Roman Pisl <rpisl@seznam.cz>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-10-12 09:32:22 +02:00
André Hentschel
410a9832d1
shell32/tests: Mark win10 failure as broken.
...
Signed-off-by: André Hentschel <nerv@dawncrow.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-10-03 11:54:15 +02:00
Sebastian Lackner
f89c3d58df
shell32/tests: Fix incorrect usage of broken() function.
...
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-09-08 20:56:46 +09:00
Sebastian Lackner
d3cb5c24a5
shell32: Remove __SHFreeAndNil macro.
...
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-29 23:54:42 +09:00
Sebastian Lackner
af468590f7
shell32: Remove some unused static inline functions.
...
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-29 23:54:42 +09:00
Nikolay Sivov
91947b35ad
shell32: Use interface pointer instead of implementation one.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-26 23:23:39 +09:00
Sebastian Lackner
a11fb74ffb
shell32: Use the correct memory allocation function in RecycleBin_GetDisplayNameOf.
...
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-24 12:06:53 +09:00
Nikolay Sivov
79e95afbc3
shell32/tests: Fix indentation warning on GCC 6.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-12 12:31:55 +09:00
Nikolay Sivov
27f91d71a2
shell32/tests: Fix indentation warnings on GCC 6.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-10 12:51:34 +09:00
Piotr Caban
f333bf47a8
ntdll: Keep drive letter size in RtlGetFullPathName_U when full path is specified.
...
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-29 23:12:11 +09:00
Jactry Zeng
dad2223ad6
shell32: Use remove() instead of rmdir().
...
rmdir() will fail when target is a symbolic link.
Signed-off-by: Jactry Zeng <jzeng@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-26 20:40:42 +09:00
Andrey Gusev
954560f847
shell32: Use debugstr_guid() and debugstr_w() in TRACE() messages.
...
Signed-off-by: Andrey Gusev <andrey.goosev@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-22 21:34:50 +09:00
Alex Henrie
a615647435
shell32/tests: Change to temp dir to be able to remove winetest dir.
...
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-20 23:05:52 +09:00
Alex Henrie
de37f020a2
shell32/tests: Free winetest BSTR after use.
...
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-20 23:05:49 +09:00
Alex Henrie
a711285137
shell32: Set output interfaces to NULL in FolderItems functions.
...
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-19 22:33:53 +09:00
Alex Henrie
970de7df99
shell32: Return E_INVALIDARG from FolderItems functions on null output.
...
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-19 22:33:48 +09:00
Alex Henrie
ddf76f6a66
shell32/tests: Add tests for FolderItems.
...
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-19 22:33:37 +09:00
Alex Henrie
1ed5773843
shell32: Stub out FolderItems.
...
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-19 22:32:41 +09:00
Alex Henrie
ebf480c430
shell32: Print RIIDs as strings in shell dispatch TRACE statements.
...
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-19 22:29:24 +09:00
Austin English
ebfe169c43
shell32: Add SHGetPropertyStoreForWindow stub.
...
Signed-off-by: Austin English <austinenglish@gmail.com>
Signed-off-by: Andrew Eikum <aeikum@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-19 22:05:18 +09:00
Michael Stefaniuc
afe0ba175c
shell32/tests: Remove redundant NULL checks before CoTaskMemFree().
...
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-08 20:12:48 +09:00
Michael Müller
b05aa34f63
shell32: Correctly compare result of SHFileOperation in UNIXFS copy/delete functions.
...
Signed-off-by: Michael Müller <michael@fds-team.de>
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-04 17:31:01 +09:00
Michael Stefaniuc
df63e1a169
shell32/tests: Avoid casts from a COM object to an iface.
...
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-03 10:20:34 +09:00
Michael Stefaniuc
ee3deec635
shell32: Avoid using CopyRect().
...
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-06-22 22:16:35 +09:00
Francois Gouget
8e548c41c1
shell32/tests: Spelling fix.
...
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-06-13 11:34:14 +09:00
Theodore Dubois
7c915af47e
shell32: Avoid closing the caller's key.
...
Signed-off-by: Theodore Dubois <tblodt@icloud.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-06-08 13:18:21 +09:00
Theodore Dubois
2a7c4ea875
shell32/tests: Fix memory leaks.
...
Signed-off-by: Theodore Dubois <tblodt@icloud.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-06-08 13:17:45 +09:00
Theodore Dubois
fbbac88519
shell32/tests: Fix out of memory errors and their underlying cause.
...
The out of memory errors were happening because getstring_test was using
len unitialized when GetString failed. The underlying cause was that
deleting the keys would fail because RegDeleteKey does not work if the
key has subkeys, and one of the keys has a subkey. The test fails when
the keys are still there. The subkey is now deleted before the key that
contains it.
Signed-off-by: Theodore Dubois <tblodt@icloud.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-06-08 13:17:42 +09:00
Michael Stefaniuc
33f145acc3
shell32/tests: Use wine_dbgstr_rect() to print RECTs.
...
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-06-07 17:08:30 +09:00
Nikolay Sivov
784a74c933
include: Added missing ASSOCF enum members.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-06-01 13:34:11 +09:00
Francois Gouget
cc2a2b0970
shell32: Spelling fixes.
...
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-30 11:55:57 +09:00
Andrey Gusev
7f64817e5e
shell32: Fix a typo in TRACE format in SHPathPrepareForWriteW.
...
Signed-off-by: Andrey Gusev <andrey.goosev@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-23 17:35:54 +09:00
Olivier F. R. Dierick
07156ad007
shell32/tests: Tests for broken apps that check GetLastError() after SHFileOperation().
...
Signed-off-by: Olivier F. R. Dierick <o.dierick@piezo-forte.be>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-02 20:11:49 +09:00
Olivier F. R. Dierick
9f202b7804
shell32: Set last error explicitly in SHFileOperation().
...
Signed-off-by: Olivier F. R. Dierick <o.dierick@piezo-forte.be>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-02 20:11:49 +09:00
Andrey Gusev
83fee7456d
shell32/tests: Fix a typo in comment.
...
Signed-off-by: Andrey Gusev <andrey.goosev@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-02 12:26:19 +09:00
Alex Henrie
1dc0669894
shell32: Add SHLimitInputEdit stub.
...
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-26 22:50:33 +09:00
Francois Gouget
7657845b1b
shell32: Fix a spelling error in an ERR() message.
...
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-25 18:48:18 +09:00
Francois Gouget
9638ddd62c
shell32/tests: A spelling fix for an shlfolder ok() message.
...
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-22 21:04:35 +09:00
Francois Gouget
5d885360f4
shell32/tests: Fix a spelling error in a shellpath comment.
...
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-22 21:04:34 +09:00
Nikolay Sivov
87f081974f
shell32/tests: Use ok() functionality to print line numbers.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-22 21:04:34 +09:00
Nikolay Sivov
e89a7735c3
shell32/tests: Fix some test failures running with limited user.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-22 21:04:34 +09:00
Michael Stefaniuc
816df88a77
shell32: Use wine_dbgstr_rect() to trace RECTs.
...
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-21 18:42:29 +09:00
Michael Stefaniuc
851777dcb1
shell32/tests: Use SetRect instead of open coding it.
...
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-12 21:00:45 +09:00
Francois Gouget
15d9a4a711
shell32/tests: Fix a race condition in the DDE ShellExecute() tests on Windows 10.
...
Even if we have a results file after a failed ShellExecuteEx() call, it
may not correspond to the last call and should thus be ignored.
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-12 12:03:57 +09:00
André Hentschel
1010372778
shell32: Provide helper function a buffer of correct size.
...
Signed-off-by: André Hentschel <nerv@dawncrow.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-03-25 22:31:01 +09:00
Francois Gouget
d02e559b91
shell32/tests: Make shlexec's reset_association_description() static.
...
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-03-22 22:23:42 +09:00
Theodore Dubois
9e05c66c03
shell32/tests: Additional tests for IQueryAssociations.
...
Signed-off-by: Theodore Dubois <tblodt@icloud.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-03-22 00:36:29 +09:00
Theodore Dubois
04a339e770
shell32: Fix return value for ASSOCSTR_FRIENDLYDOCNAME and ASSOCSTR_DEFAULTICON when passed a ProgID.
...
Signed-off-by: Theodore Dubois <tblodt@icloud.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-03-22 00:36:29 +09:00
Francois Gouget
822e78ee04
shell32/tests: Test default verb detection for files as well as for URLs.
...
When Internet Explorer 6 is installer, Windows XP detects non-standard
verbs just fine for files but not for URLs.
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-03-22 00:36:27 +09:00
Francois Gouget
e7065e0c51
shell32/tests: Move a file URL test to test_fileurl().
...
This way it's integrated with the rest of the matching tests and skipped
on plaforms where file URLs don't work right (old Windows XP versions).
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-03-22 00:36:27 +09:00
Francois Gouget
11d77e51d5
shell32/tests: Delete the shlproto test class when done.
...
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-03-22 00:36:27 +09:00
Michael Stefaniuc
fba64b5cac
shell32/tests: Use SetRectEmpty() instead of open coding it.
...
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-03-03 22:29:03 +09:00
Francois Gouget
6e9c7adcee
shell32/tests: Test ShellExecute()'s URL handling.
...
Also tweak the class creation functions and add create_test_class() so
one can create a class without associating it with an extension.
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-22 17:37:11 +09:00
Frédéric Delanoy
9f23eae55f
shell32/tests: Get rid of redundant lok_todo_N macros.
...
Signed-off-by: Frédéric Delanoy <frederic.delanoy@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-22 17:37:10 +09:00
Frédéric Delanoy
61e70dfbc7
shell32/tests: Use todo_wine_if() in tests.
...
Signed-off-by: Frédéric Delanoy <frederic.delanoy@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-22 17:37:10 +09:00
Francois Gouget
bd111803d2
shell32/tests: Only look for Explorer windows for the progman tests.
...
In the Spanish locale the 'Startup' folder is called 'Inicio' which
matches another window. Closing that window causes the shutdown dialog
to pop up, resulting in a test timeout.
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-18 22:58:26 +09:00
Francois Gouget
c8bc68ecb4
shell32/tests: Take into account the Windows 10 DDE race condition.
...
Also improve the description of this race condition.
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-16 12:09:39 +09:00
Francois Gouget
e48a569434
shell32/tests: Use todo_wine_if() in tests.
...
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-16 12:09:39 +09:00
Francois Gouget
43fe3574f4
shell32/tests: Fix an ok() call so it shows which DDE test caused the failure.
...
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-14 12:39:44 +09:00
Francois Gouget
5af9c123f6
shell32/tests: Allow the short and long forms when checking a ShellExecute() path.
...
ShellExecute() sometimes converts a short path to a long one so always accept the long form.
Windows XP SP1 often converts them to short paths instead but consider this behavior to be broken.
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-08 20:03:33 +09:00
Francois Gouget
bfc1244381
shell32/tests: Fix the ShellExecute() environment variable inheritance checks.
...
The child process does not inherit environment variables when the
calling process does not have elevated privileges and specifies
SEE_MASK_NOZONECHECKS.
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-08 20:03:33 +09:00
Francois Gouget
c1636cd279
shell32/tests: Move a test_argify() check so it is run even if we could not create associations.
...
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-08 20:03:33 +09:00
Francois Gouget
96baeb72c2
shell32/tests: Skip a few ShellExecute() tests when the process has insufficient privileges.
...
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-08 20:03:33 +09:00
Francois Gouget
13fdfedead
shell32/tests: Remove support for a todo_wine flag in ShellExecute()'s test_lnks() loop.
...
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-08 20:03:33 +09:00
Francois Gouget
f4130de33e
shell32/tests: Fix a ShellExecute() race condition.
...
On Windows XP SP1 a ShellExecute() call that is supposed to fail
succeeds instead. This means the child process is started but
ShellExecute() returns without waiting for it, resulting in a race
condition on the child's results file. So use our shell_execute_ex()
wrapper instead as it always waits for the child process.
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-08 20:03:33 +09:00
Francois Gouget
cc240bdb14
shell32/tests: Fix test_dde_default_app() on Windows XP SP1.
...
There are three possible sets of results: Windows <= 2000, XP SP1 and >= XP SP2.
Use the first two tests to figure out which results to expect.
Only accept the >= XP SP2 results in Wine.
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-08 20:03:32 +09:00
Francois Gouget
b742145cab
shell32/tests: Fix the DDE tests on Windows 10.
...
Windows 10 does not call WaitForInputIdle() if the DDE server is a
console application. So force the call by adding
SEE_MASK_WAITFORINPUTIDLE. Also Windows calls WaitForInputIdle() with a
60s timeout and while we should not hit it, trace and cap it to 5s
anyway.
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-08 20:03:32 +09:00
Francois Gouget
a090eff243
shell32/tests: Fix okShell()'s tracing so it takes todo and other flags into account.
...
This also causes the ShellExecute() and association descriptions to be
printed with each failing test. This makes the messages more readable in
TestBot's abbreviated logs, at the cost of a lot more redundancy.
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-08 13:46:02 +09:00
Huw Davies
77c313b8d6
shell32: Set the stream and storage attributes where needed.
...
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-29 21:25:21 +09:00
Huw Davies
a77c0ebc80
shell32: The attributes is not an array, so don't label it as such.
...
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-29 21:25:21 +09:00
Francois Gouget
805b5e36a9
shell32/tests: Add server-side DDE checks.
...
Should something go wrong a failed ok() call will leave a clearer trace
in the log than an assert.
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-29 21:25:20 +09:00
Francois Gouget
446ade3b3c
shell32/tests: Test environment variable inheritance with ShellExecute().
...
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-29 21:25:20 +09:00
Francois Gouget
bdfaa8c807
shell32/tests: Check for failures in the child process.
...
Return the number of failures through both the child result file and the process exit code.
Also rename the child result file section to 'Child' since it no longer only contains 'Arguments'.
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-29 21:25:19 +09:00
Francois Gouget
30230fae5f
shell32/tests: Check the child process exit code and close the process handle.
...
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-29 21:25:19 +09:00
Francois Gouget
3a9b09aa7d
shell32/tests: Declare childPrintf() as a printf-style function.
...
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-29 21:25:18 +09:00
Francois Gouget
38ad0ee01d
shell32/tests: Reorder the functions to avoid forward declarations.
...
This also groups the helpers in a more logical fashion.
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-29 21:25:18 +09:00
Francois Gouget
759bd96ac2
shell32/tests: Add traces to the WaitForInputIdle() hooking process.
...
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-29 21:25:17 +09:00
Francois Gouget
78ada2e154
shell32/tests: Fix a couple of okChildPath()/okChildString() mixups.
...
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-28 15:51:07 +09:00
Francois Gouget
3079179753
shell32/tests: Show that verbs and classes override ShellExecute()'s normal handling of executables.
...
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-28 15:51:04 +09:00
Francois Gouget
2c0daad786
shell32/tests: Test handling of nonexistent verbs in ShellExecute() & co.
...
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-28 15:51:00 +09:00
Francois Gouget
198e0d5d78
shell32/tests: Trace the association properties for the DDE tests.
...
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-26 23:17:57 +09:00
Francois Gouget
7e000abeda
shell32/tests: Call okShell() after a shell_execute{_ex}() test.
...
This ensures all the failed call parameters will be traced.
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-26 23:17:24 +09:00
Francois Gouget
c133ef7326
shell32/tests: Trace the last ShellExecute command whenever a corresponding test fails.
...
okShell() serves to encapsulate handling of shell_call and also provides a means for further extensions.
Remove the shell_call static initialization to not hide potential
use-before-assignment compiler warnings.
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-26 23:17:05 +09:00
Francois Gouget
09dac2f482
shell32/tests: Use the shell_execute{_ex}() call site for its traces and error messages.
...
This makes it easier to match their internal test failures with the site of the real test.
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-19 21:44:15 +09:00
Francois Gouget
9cc07a2b31
shell32/tests: Trace the effective ShellExecuteEx() flags.
...
shell_execute_ex() adds some flags for its own internal needs. The
traces should reflect that.
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-13 23:47:04 +09:00
Francois Gouget
f816bc93b0
shell32/tests: Tweak some overly optimistic ok() messages.
...
ShellExecute() is more likely to have returned an unexpected error code
than it is to have succeeded.
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-13 23:46:53 +09:00
Francois Gouget
3dff8bc213
shell32/tests: Fix the shortcut vs. class interaction test.
...
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-12 19:10:04 +09:00
Francois Gouget
201de16e30
shell32/tests: Create_test_association() should either succeed or fail due to insufficient permissions.
...
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-12 19:10:04 +09:00
Francois Gouget
0a867de22d
shell32/tests: Check the hProcess field when ShellExecuteEx() fails.
...
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-12 19:10:04 +09:00
Francois Gouget
2fb84d5c50
shell32/tests: The expectedArgs parameter of the DDE tests is an argument count, not a boolean.
...
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-12 19:10:03 +09:00
Nikolay Sivov
ccc6cfc1de
shell32/tests: Explicitly compare to HRESULT values.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-03 20:04:40 +01:00
Nikolay Sivov
2e4954eb69
shell32/tests: Basic tests for SHCreateSessionKey().
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-12-29 17:09:18 +01:00
André Hentschel
2cff59ed5c
shell32: Minor cleanup of SHELL_execute (Clang).
...
Signed-off-by: André Hentschel <nerv@dawncrow.de>
Signed-off-by: Andrew Eikum <aeikum@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-12-22 20:18:56 +01:00
Francois Gouget
413c6f60cf
Assorted spelling fixes.
...
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-12-02 12:59:52 +09:00
Piotr Caban
3a6ac60555
shell32: Improved IDataObject::QueryGetData implementation.
...
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-25 01:28:32 +09:00
Nikolay Sivov
5cf9539650
shell32: Return as soon as requested CLSID is located (Coverity).
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-11 22:08:45 +09:00
Andrew Eikum
aaafeb4cec
shell32: Implement IShellDispatch2::ShellExecute.
...
Signed-off-by: Andrew Eikum <aeikum@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-03 00:33:23 +09:00
Nikolay Sivov
4e88852415
shell32: Fix temporary item array leak (Valgrind).
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-29 21:20:07 +09:00
Nikolay Sivov
2fff77a0ee
shell32/tests: Fix prototype to match implementation (PVS-Studio).
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-21 21:09:13 +09:00
Nikolay Sivov
186bed3d16
shell32: Properly handle SHGetPathFromIDListW failure (PVS-Studio).
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-21 01:04:29 +09:00
Nikolay Sivov
4ee4c06410
shell32: Cleanup ReadCabinetState exports.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-21 00:25:35 +09:00
Nikolay Sivov
95ecc29a50
shell32: Remove another recurring return code check (PVS-Studio).
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-21 00:25:34 +09:00
Nikolay Sivov
e2275b0a2a
shell32: Remove recurring return value check (PVS-Studio).
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-19 12:22:39 +09:00
Nikolay Sivov
5853e7769c
shell32: Simplify conditional expression (PVS-Studio).
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-15 19:18:26 +09:00
Nikolay Sivov
972a74ddfe
shell32: Added dll manifest file.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
2015-10-01 16:33:28 +09:00
Nikolay Sivov
e585d17ff3
shell32/tests: Test icon ids that are invalid on all systems.
2015-09-16 22:11:09 +09:00
Vincent Povirk
69d57ee72f
shell32: Do nothing if we can't convert PIDL to path in SHAddToRecentDocs.
2015-09-15 17:55:19 +09:00
Zhenbo Li
637bcd5de9
shell32: Fix return type for helper functions of SHFileOption.
2015-09-01 21:11:16 +09:00
Vincent Povirk
8657547d9e
shell32: Fix getting parent shell folder when it's the desktop folder.
...
BindToObject fails in this case.
2015-08-17 14:47:37 +09:00
Vincent Povirk
642b2fe789
shell32: Use return value from IShellFolder_GetAttributesOf.
2015-08-17 14:47:30 +09:00
Hans Leidekker
7ec5f555b0
shell32: Add a stub implementation of SHQueryUserNotificationState.
2015-08-06 21:42:30 +09:00
Mark Harmstone
77b75ca14b
shell32: Don't hardcode icon sizes in SIC_LoadIcon.
2015-08-03 11:00:54 +02:00
Nikolay Sivov
e46c32ab46
shell32/ebrowser: Implement EBO_NOBORDER option.
2015-08-03 10:57:46 +02:00
Nikolay Sivov
118c469598
shell32/ebrowser: Use proper color for pane separator.
2015-08-03 10:57:37 +02:00
Nikolay Sivov
e7acfee978
shell32: Added GetCurrentProcessExplicitAppUserModelID() stub.
2015-07-22 16:42:42 +02:00
Sebastian Lackner
7d3f13a129
shell32: Ensure that commandline is null-terminated when no parameters are given.
2015-07-17 14:28:17 +09:00
Piotr Caban
943ead5022
shell32: Fix SHELL_execute code that removes quote arround file name.
2015-07-16 16:29:12 +09:00
Piotr Caban
663f9f4b21
shell32: Handle executable with space in path in SHELL_execute.
2015-07-16 16:29:09 +09:00
Piotr Caban
8e853a3e90
shell32: Remove code for separating arguments from file path.
2015-07-16 16:29:06 +09:00
Huw Davies
0b9737b1ea
shell32: Fix threading model for the Known Folder Manager and Shell Link objects.
2015-07-08 16:02:23 +09:00
Thomas Faber
360cf273ae
shell32/tests: Test that shell view windows reference their shell view.
2015-07-07 16:52:21 +09:00
Nikolay Sivov
28caa68d41
shell32/tests: Try harder to close Open With window.
2015-07-07 16:52:20 +09:00
Huw Davies
f5e16e0638
shell32/tests: Win 2k doesn't cope with spaces in the path.
2015-07-07 16:52:20 +09:00
Huw Davies
c5053f5712
shell32/tests: Win XP splits the args if there are spaces in the path.
...
This isn't seen on winetest runs, but is when jobs are submitted to
the testbot. Presumably the path of the executable is different in
the two cases.
2015-07-07 16:52:19 +09:00
Thomas Faber
eff884f19b
shell32/tests: Destroy shell view windows.
2015-07-06 17:09:50 +09:00
Thomas Faber
71f1c90628
shell32/tests: Fix an ok() print.
2015-07-06 17:09:50 +09:00
Nikolay Sivov
69733d65e8
shell32: Handle string-to-guid conversion errors (Coverity).
2015-07-06 15:13:24 +09:00
Thomas Faber
9551179c0b
shell32/tests: Remove a misleading test.
2015-06-30 14:41:43 +09:00
Thomas Faber
e582495927
shell32: Use QueryInterface in FolderView_GetFolder.
...
test_IFolderView has a test that shows that the shell folder's reference
count before and after the call to IFolderView_GetFolder is the same.
However this is misleading because it is not a property of the
IFolderView_GetFolder method, but of the desktop shell folder object
that's used in the folder view. Windows <=2003 uses a cached object and
its AddRef/Release methods return constants.
2015-06-30 14:41:43 +09:00
Thomas Faber
c0cd954f98
shell32: Add missing parameter check in ISF_Desktop_fnQueryInterface.
2015-06-30 14:40:43 +09:00
Thomas Faber
9353a36d8f
shell32/tests: Do not leak shell folder references.
2015-06-29 21:15:10 +09:00
Nikolay Sivov
7ca31b8119
shell32: Fix memory leak on NULL return length (Coverity).
2015-06-29 18:51:02 +09:00
Huw Davies
da5151fd54
shell32/tests: Don't leave behind open explorer windows.
2015-06-23 21:59:40 +09:00
Huw Davies
905e7aad0e
shell32/tests: Fix failing test on Win 2k.
2015-06-11 21:05:34 +09:00
Nikolay Sivov
1de3aec336
shell32/tests: Fix error code on win2k.
2015-06-08 15:26:53 +09:00
Nikolay Sivov
d5d49464d3
shell32/tests: Fix tests failures on win2k.
2015-06-05 14:11:02 +09:00
Nikolay Sivov
8c11e6b2f0
shell32/tests: Fix one of test failures on win2k.
2015-06-04 15:55:57 +09:00
Nikolay Sivov
98da69a83f
shell32/tests: Fix Verbs instance leak (Valgrind).
2015-06-04 15:55:45 +09:00
Akihiro Sagawa
d2e9856a56
shell32: Skip buffer allocation when querying drop file numbers.
2015-06-02 20:53:43 +09:00
Akihiro Sagawa
37d7d6f81c
shell32/tests: Add tests for DragQueryFile.
2015-06-02 20:53:43 +09:00
Akihiro Sagawa
4c31892ea5
shell32/tests: Make tests run on win2k again.
2015-06-02 14:09:12 +09:00
Nikolay Sivov
bf41160c65
shell32: Implement FolderItemVerbs::Item().
2015-05-11 15:39:26 +09:00
Nikolay Sivov
8f72117f19
shell32: Added FolderItemVerb stub.
2015-05-11 15:39:25 +09:00
Nikolay Sivov
77c2892d87
shell32: Implement FolderItemVerbs_get_Count().
2015-05-11 15:39:25 +09:00
Nikolay Sivov
540171bc91
shell32: Added FolderItemVerbs stub.
2015-05-11 15:39:25 +09:00
Nikolay Sivov
e013a7e584
shell32: Implement ParseName().
2015-05-11 15:39:25 +09:00
Alexandre Julliard
ed700d16f7
shell32/tests: Avoid duplicate const.
2015-05-11 15:39:25 +09:00
Nikolay Sivov
80d28abdc8
shell32: Partially implement SHGetKnownFolderIDList().
2015-05-11 15:39:25 +09:00
Nikolay Sivov
4367f4b230
shell32: Silence IMarshal requests to IKnownFolder and IKnownFolderManager.
2015-05-11 15:39:25 +09:00
Nikolay Sivov
594e0b674f
shell32: Forward couple of IKnownFolder methods to regular API equivalents.
2015-05-11 15:39:24 +09:00
Nikolay Sivov
3ec3fa5eb7
explorer: Return desktop shellview interface.
2015-05-08 18:33:51 +09:00
Nikolay Sivov
7ce1813fed
shell32: Added IDispatch support for IShellFolderViewDual3.
2015-05-08 18:33:41 +09:00
Nikolay Sivov
c2ecf3b0bf
shell32: Update to IShellDispatch6.
2015-05-06 18:14:22 +09:00
Nikolay Sivov
ce87d64ab4
shell32: Implement Application property of IShellFolderViewDual.
2015-05-06 18:13:59 +09:00