b05aa34f63
shell32: Correctly compare result of SHFileOperation in UNIXFS copy/delete functions.
...
Signed-off-by: Michael Müller <michael@fds-team.de>
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-04 17:31:01 +09:00
df63e1a169
shell32/tests: Avoid casts from a COM object to an iface.
...
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-03 10:20:34 +09:00
ee3deec635
shell32: Avoid using CopyRect().
...
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-06-22 22:16:35 +09:00
8e548c41c1
shell32/tests: Spelling fix.
...
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-06-13 11:34:14 +09:00
7c915af47e
shell32: Avoid closing the caller's key.
...
Signed-off-by: Theodore Dubois <tblodt@icloud.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-06-08 13:18:21 +09:00
2a7c4ea875
shell32/tests: Fix memory leaks.
...
Signed-off-by: Theodore Dubois <tblodt@icloud.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-06-08 13:17:45 +09:00
fbbac88519
shell32/tests: Fix out of memory errors and their underlying cause.
...
The out of memory errors were happening because getstring_test was using
len unitialized when GetString failed. The underlying cause was that
deleting the keys would fail because RegDeleteKey does not work if the
key has subkeys, and one of the keys has a subkey. The test fails when
the keys are still there. The subkey is now deleted before the key that
contains it.
Signed-off-by: Theodore Dubois <tblodt@icloud.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-06-08 13:17:42 +09:00
33f145acc3
shell32/tests: Use wine_dbgstr_rect() to print RECTs.
...
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-06-07 17:08:30 +09:00
784a74c933
include: Added missing ASSOCF enum members.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-06-01 13:34:11 +09:00
cc2a2b0970
shell32: Spelling fixes.
...
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-30 11:55:57 +09:00
7f64817e5e
shell32: Fix a typo in TRACE format in SHPathPrepareForWriteW.
...
Signed-off-by: Andrey Gusev <andrey.goosev@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-23 17:35:54 +09:00
07156ad007
shell32/tests: Tests for broken apps that check GetLastError() after SHFileOperation().
...
Signed-off-by: Olivier F. R. Dierick <o.dierick@piezo-forte.be>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-02 20:11:49 +09:00
9f202b7804
shell32: Set last error explicitly in SHFileOperation().
...
Signed-off-by: Olivier F. R. Dierick <o.dierick@piezo-forte.be>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-02 20:11:49 +09:00
83fee7456d
shell32/tests: Fix a typo in comment.
...
Signed-off-by: Andrey Gusev <andrey.goosev@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-02 12:26:19 +09:00
1dc0669894
shell32: Add SHLimitInputEdit stub.
...
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-26 22:50:33 +09:00
7657845b1b
shell32: Fix a spelling error in an ERR() message.
...
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-25 18:48:18 +09:00
9638ddd62c
shell32/tests: A spelling fix for an shlfolder ok() message.
...
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-22 21:04:35 +09:00
5d885360f4
shell32/tests: Fix a spelling error in a shellpath comment.
...
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-22 21:04:34 +09:00
87f081974f
shell32/tests: Use ok() functionality to print line numbers.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-22 21:04:34 +09:00
e89a7735c3
shell32/tests: Fix some test failures running with limited user.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-22 21:04:34 +09:00
816df88a77
shell32: Use wine_dbgstr_rect() to trace RECTs.
...
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-21 18:42:29 +09:00
851777dcb1
shell32/tests: Use SetRect instead of open coding it.
...
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-12 21:00:45 +09:00
15d9a4a711
shell32/tests: Fix a race condition in the DDE ShellExecute() tests on Windows 10.
...
Even if we have a results file after a failed ShellExecuteEx() call, it
may not correspond to the last call and should thus be ignored.
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-12 12:03:57 +09:00
1010372778
shell32: Provide helper function a buffer of correct size.
...
Signed-off-by: André Hentschel <nerv@dawncrow.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-03-25 22:31:01 +09:00
d02e559b91
shell32/tests: Make shlexec's reset_association_description() static.
...
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-03-22 22:23:42 +09:00
9e05c66c03
shell32/tests: Additional tests for IQueryAssociations.
...
Signed-off-by: Theodore Dubois <tblodt@icloud.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-03-22 00:36:29 +09:00
04a339e770
shell32: Fix return value for ASSOCSTR_FRIENDLYDOCNAME and ASSOCSTR_DEFAULTICON when passed a ProgID.
...
Signed-off-by: Theodore Dubois <tblodt@icloud.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-03-22 00:36:29 +09:00
822e78ee04
shell32/tests: Test default verb detection for files as well as for URLs.
...
When Internet Explorer 6 is installer, Windows XP detects non-standard
verbs just fine for files but not for URLs.
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-03-22 00:36:27 +09:00
e7065e0c51
shell32/tests: Move a file URL test to test_fileurl().
...
This way it's integrated with the rest of the matching tests and skipped
on plaforms where file URLs don't work right (old Windows XP versions).
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-03-22 00:36:27 +09:00
11d77e51d5
shell32/tests: Delete the shlproto test class when done.
...
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-03-22 00:36:27 +09:00
fba64b5cac
shell32/tests: Use SetRectEmpty() instead of open coding it.
...
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-03-03 22:29:03 +09:00
6e9c7adcee
shell32/tests: Test ShellExecute()'s URL handling.
...
Also tweak the class creation functions and add create_test_class() so
one can create a class without associating it with an extension.
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-22 17:37:11 +09:00
9f23eae55f
shell32/tests: Get rid of redundant lok_todo_N macros.
...
Signed-off-by: Frédéric Delanoy <frederic.delanoy@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-22 17:37:10 +09:00
61e70dfbc7
shell32/tests: Use todo_wine_if() in tests.
...
Signed-off-by: Frédéric Delanoy <frederic.delanoy@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-22 17:37:10 +09:00
bd111803d2
shell32/tests: Only look for Explorer windows for the progman tests.
...
In the Spanish locale the 'Startup' folder is called 'Inicio' which
matches another window. Closing that window causes the shutdown dialog
to pop up, resulting in a test timeout.
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-18 22:58:26 +09:00
c8bc68ecb4
shell32/tests: Take into account the Windows 10 DDE race condition.
...
Also improve the description of this race condition.
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-16 12:09:39 +09:00
e48a569434
shell32/tests: Use todo_wine_if() in tests.
...
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-16 12:09:39 +09:00
43fe3574f4
shell32/tests: Fix an ok() call so it shows which DDE test caused the failure.
...
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-14 12:39:44 +09:00
5af9c123f6
shell32/tests: Allow the short and long forms when checking a ShellExecute() path.
...
ShellExecute() sometimes converts a short path to a long one so always accept the long form.
Windows XP SP1 often converts them to short paths instead but consider this behavior to be broken.
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-08 20:03:33 +09:00
bfc1244381
shell32/tests: Fix the ShellExecute() environment variable inheritance checks.
...
The child process does not inherit environment variables when the
calling process does not have elevated privileges and specifies
SEE_MASK_NOZONECHECKS.
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-08 20:03:33 +09:00
c1636cd279
shell32/tests: Move a test_argify() check so it is run even if we could not create associations.
...
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-08 20:03:33 +09:00
96baeb72c2
shell32/tests: Skip a few ShellExecute() tests when the process has insufficient privileges.
...
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-08 20:03:33 +09:00
13fdfedead
shell32/tests: Remove support for a todo_wine flag in ShellExecute()'s test_lnks() loop.
...
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-08 20:03:33 +09:00
f4130de33e
shell32/tests: Fix a ShellExecute() race condition.
...
On Windows XP SP1 a ShellExecute() call that is supposed to fail
succeeds instead. This means the child process is started but
ShellExecute() returns without waiting for it, resulting in a race
condition on the child's results file. So use our shell_execute_ex()
wrapper instead as it always waits for the child process.
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-08 20:03:33 +09:00
cc240bdb14
shell32/tests: Fix test_dde_default_app() on Windows XP SP1.
...
There are three possible sets of results: Windows <= 2000, XP SP1 and >= XP SP2.
Use the first two tests to figure out which results to expect.
Only accept the >= XP SP2 results in Wine.
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-08 20:03:32 +09:00
b742145cab
shell32/tests: Fix the DDE tests on Windows 10.
...
Windows 10 does not call WaitForInputIdle() if the DDE server is a
console application. So force the call by adding
SEE_MASK_WAITFORINPUTIDLE. Also Windows calls WaitForInputIdle() with a
60s timeout and while we should not hit it, trace and cap it to 5s
anyway.
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-08 20:03:32 +09:00
a090eff243
shell32/tests: Fix okShell()'s tracing so it takes todo and other flags into account.
...
This also causes the ShellExecute() and association descriptions to be
printed with each failing test. This makes the messages more readable in
TestBot's abbreviated logs, at the cost of a lot more redundancy.
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-08 13:46:02 +09:00
77c313b8d6
shell32: Set the stream and storage attributes where needed.
...
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-29 21:25:21 +09:00
a77c0ebc80
shell32: The attributes is not an array, so don't label it as such.
...
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-29 21:25:21 +09:00
805b5e36a9
shell32/tests: Add server-side DDE checks.
...
Should something go wrong a failed ok() call will leave a clearer trace
in the log than an assert.
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-29 21:25:20 +09:00
446ade3b3c
shell32/tests: Test environment variable inheritance with ShellExecute().
...
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-29 21:25:20 +09:00
bdfaa8c807
shell32/tests: Check for failures in the child process.
...
Return the number of failures through both the child result file and the process exit code.
Also rename the child result file section to 'Child' since it no longer only contains 'Arguments'.
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-29 21:25:19 +09:00
30230fae5f
shell32/tests: Check the child process exit code and close the process handle.
...
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-29 21:25:19 +09:00
3a9b09aa7d
shell32/tests: Declare childPrintf() as a printf-style function.
...
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-29 21:25:18 +09:00
38ad0ee01d
shell32/tests: Reorder the functions to avoid forward declarations.
...
This also groups the helpers in a more logical fashion.
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-29 21:25:18 +09:00
759bd96ac2
shell32/tests: Add traces to the WaitForInputIdle() hooking process.
...
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-29 21:25:17 +09:00
78ada2e154
shell32/tests: Fix a couple of okChildPath()/okChildString() mixups.
...
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-28 15:51:07 +09:00
3079179753
shell32/tests: Show that verbs and classes override ShellExecute()'s normal handling of executables.
...
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-28 15:51:04 +09:00
2c0daad786
shell32/tests: Test handling of nonexistent verbs in ShellExecute() & co.
...
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-28 15:51:00 +09:00
198e0d5d78
shell32/tests: Trace the association properties for the DDE tests.
...
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-26 23:17:57 +09:00
7e000abeda
shell32/tests: Call okShell() after a shell_execute{_ex}() test.
...
This ensures all the failed call parameters will be traced.
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-26 23:17:24 +09:00
c133ef7326
shell32/tests: Trace the last ShellExecute command whenever a corresponding test fails.
...
okShell() serves to encapsulate handling of shell_call and also provides a means for further extensions.
Remove the shell_call static initialization to not hide potential
use-before-assignment compiler warnings.
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-26 23:17:05 +09:00
09dac2f482
shell32/tests: Use the shell_execute{_ex}() call site for its traces and error messages.
...
This makes it easier to match their internal test failures with the site of the real test.
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-19 21:44:15 +09:00
9cc07a2b31
shell32/tests: Trace the effective ShellExecuteEx() flags.
...
shell_execute_ex() adds some flags for its own internal needs. The
traces should reflect that.
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-13 23:47:04 +09:00
f816bc93b0
shell32/tests: Tweak some overly optimistic ok() messages.
...
ShellExecute() is more likely to have returned an unexpected error code
than it is to have succeeded.
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-13 23:46:53 +09:00
3dff8bc213
shell32/tests: Fix the shortcut vs. class interaction test.
...
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-12 19:10:04 +09:00
201de16e30
shell32/tests: Create_test_association() should either succeed or fail due to insufficient permissions.
...
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-12 19:10:04 +09:00
0a867de22d
shell32/tests: Check the hProcess field when ShellExecuteEx() fails.
...
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-12 19:10:04 +09:00
2fb84d5c50
shell32/tests: The expectedArgs parameter of the DDE tests is an argument count, not a boolean.
...
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-12 19:10:03 +09:00
ccc6cfc1de
shell32/tests: Explicitly compare to HRESULT values.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-03 20:04:40 +01:00
2e4954eb69
shell32/tests: Basic tests for SHCreateSessionKey().
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-12-29 17:09:18 +01:00
2cff59ed5c
shell32: Minor cleanup of SHELL_execute (Clang).
...
Signed-off-by: André Hentschel <nerv@dawncrow.de>
Signed-off-by: Andrew Eikum <aeikum@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-12-22 20:18:56 +01:00
413c6f60cf
Assorted spelling fixes.
...
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-12-02 12:59:52 +09:00
3a6ac60555
shell32: Improved IDataObject::QueryGetData implementation.
...
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-25 01:28:32 +09:00
5cf9539650
shell32: Return as soon as requested CLSID is located (Coverity).
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-11 22:08:45 +09:00
aaafeb4cec
shell32: Implement IShellDispatch2::ShellExecute.
...
Signed-off-by: Andrew Eikum <aeikum@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-03 00:33:23 +09:00
4e88852415
shell32: Fix temporary item array leak (Valgrind).
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-29 21:20:07 +09:00
2fff77a0ee
shell32/tests: Fix prototype to match implementation (PVS-Studio).
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-21 21:09:13 +09:00
186bed3d16
shell32: Properly handle SHGetPathFromIDListW failure (PVS-Studio).
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-21 01:04:29 +09:00
4ee4c06410
shell32: Cleanup ReadCabinetState exports.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-21 00:25:35 +09:00
95ecc29a50
shell32: Remove another recurring return code check (PVS-Studio).
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-21 00:25:34 +09:00
e2275b0a2a
shell32: Remove recurring return value check (PVS-Studio).
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-19 12:22:39 +09:00
5853e7769c
shell32: Simplify conditional expression (PVS-Studio).
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-15 19:18:26 +09:00
972a74ddfe
shell32: Added dll manifest file.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
2015-10-01 16:33:28 +09:00
e585d17ff3
shell32/tests: Test icon ids that are invalid on all systems.
2015-09-16 22:11:09 +09:00
69d57ee72f
shell32: Do nothing if we can't convert PIDL to path in SHAddToRecentDocs.
2015-09-15 17:55:19 +09:00
637bcd5de9
shell32: Fix return type for helper functions of SHFileOption.
2015-09-01 21:11:16 +09:00
8657547d9e
shell32: Fix getting parent shell folder when it's the desktop folder.
...
BindToObject fails in this case.
2015-08-17 14:47:37 +09:00
642b2fe789
shell32: Use return value from IShellFolder_GetAttributesOf.
2015-08-17 14:47:30 +09:00
7ec5f555b0
shell32: Add a stub implementation of SHQueryUserNotificationState.
2015-08-06 21:42:30 +09:00
77b75ca14b
shell32: Don't hardcode icon sizes in SIC_LoadIcon.
2015-08-03 11:00:54 +02:00
e46c32ab46
shell32/ebrowser: Implement EBO_NOBORDER option.
2015-08-03 10:57:46 +02:00
118c469598
shell32/ebrowser: Use proper color for pane separator.
2015-08-03 10:57:37 +02:00
e7acfee978
shell32: Added GetCurrentProcessExplicitAppUserModelID() stub.
2015-07-22 16:42:42 +02:00
7d3f13a129
shell32: Ensure that commandline is null-terminated when no parameters are given.
2015-07-17 14:28:17 +09:00
943ead5022
shell32: Fix SHELL_execute code that removes quote arround file name.
2015-07-16 16:29:12 +09:00
663f9f4b21
shell32: Handle executable with space in path in SHELL_execute.
2015-07-16 16:29:09 +09:00
8e853a3e90
shell32: Remove code for separating arguments from file path.
2015-07-16 16:29:06 +09:00
0b9737b1ea
shell32: Fix threading model for the Known Folder Manager and Shell Link objects.
2015-07-08 16:02:23 +09:00
360cf273ae
shell32/tests: Test that shell view windows reference their shell view.
2015-07-07 16:52:21 +09:00
28caa68d41
shell32/tests: Try harder to close Open With window.
2015-07-07 16:52:20 +09:00
f5e16e0638
shell32/tests: Win 2k doesn't cope with spaces in the path.
2015-07-07 16:52:20 +09:00
c5053f5712
shell32/tests: Win XP splits the args if there are spaces in the path.
...
This isn't seen on winetest runs, but is when jobs are submitted to
the testbot. Presumably the path of the executable is different in
the two cases.
2015-07-07 16:52:19 +09:00
eff884f19b
shell32/tests: Destroy shell view windows.
2015-07-06 17:09:50 +09:00
71f1c90628
shell32/tests: Fix an ok() print.
2015-07-06 17:09:50 +09:00
69733d65e8
shell32: Handle string-to-guid conversion errors (Coverity).
2015-07-06 15:13:24 +09:00
9551179c0b
shell32/tests: Remove a misleading test.
2015-06-30 14:41:43 +09:00
e582495927
shell32: Use QueryInterface in FolderView_GetFolder.
...
test_IFolderView has a test that shows that the shell folder's reference
count before and after the call to IFolderView_GetFolder is the same.
However this is misleading because it is not a property of the
IFolderView_GetFolder method, but of the desktop shell folder object
that's used in the folder view. Windows <=2003 uses a cached object and
its AddRef/Release methods return constants.
2015-06-30 14:41:43 +09:00
c0cd954f98
shell32: Add missing parameter check in ISF_Desktop_fnQueryInterface.
2015-06-30 14:40:43 +09:00
9353a36d8f
shell32/tests: Do not leak shell folder references.
2015-06-29 21:15:10 +09:00
7ca31b8119
shell32: Fix memory leak on NULL return length (Coverity).
2015-06-29 18:51:02 +09:00
da5151fd54
shell32/tests: Don't leave behind open explorer windows.
2015-06-23 21:59:40 +09:00
905e7aad0e
shell32/tests: Fix failing test on Win 2k.
2015-06-11 21:05:34 +09:00
1de3aec336
shell32/tests: Fix error code on win2k.
2015-06-08 15:26:53 +09:00
d5d49464d3
shell32/tests: Fix tests failures on win2k.
2015-06-05 14:11:02 +09:00
8c11e6b2f0
shell32/tests: Fix one of test failures on win2k.
2015-06-04 15:55:57 +09:00
98da69a83f
shell32/tests: Fix Verbs instance leak (Valgrind).
2015-06-04 15:55:45 +09:00
d2e9856a56
shell32: Skip buffer allocation when querying drop file numbers.
2015-06-02 20:53:43 +09:00
37d7d6f81c
shell32/tests: Add tests for DragQueryFile.
2015-06-02 20:53:43 +09:00
4c31892ea5
shell32/tests: Make tests run on win2k again.
2015-06-02 14:09:12 +09:00
bf41160c65
shell32: Implement FolderItemVerbs::Item().
2015-05-11 15:39:26 +09:00
8f72117f19
shell32: Added FolderItemVerb stub.
2015-05-11 15:39:25 +09:00
77c2892d87
shell32: Implement FolderItemVerbs_get_Count().
2015-05-11 15:39:25 +09:00
540171bc91
shell32: Added FolderItemVerbs stub.
2015-05-11 15:39:25 +09:00
e013a7e584
shell32: Implement ParseName().
2015-05-11 15:39:25 +09:00
ed700d16f7
shell32/tests: Avoid duplicate const.
2015-05-11 15:39:25 +09:00
80d28abdc8
shell32: Partially implement SHGetKnownFolderIDList().
2015-05-11 15:39:25 +09:00
4367f4b230
shell32: Silence IMarshal requests to IKnownFolder and IKnownFolderManager.
2015-05-11 15:39:25 +09:00
594e0b674f
shell32: Forward couple of IKnownFolder methods to regular API equivalents.
2015-05-11 15:39:24 +09:00
3ec3fa5eb7
explorer: Return desktop shellview interface.
2015-05-08 18:33:51 +09:00
7ce1813fed
shell32: Added IDispatch support for IShellFolderViewDual3.
2015-05-08 18:33:41 +09:00
c2ecf3b0bf
shell32: Update to IShellDispatch6.
2015-05-06 18:14:22 +09:00
ce87d64ab4
shell32: Implement Application property of IShellFolderViewDual.
2015-05-06 18:13:59 +09:00
a6163247cd
shell32: Implement GetSelectedCount() using IFolderView2::GetSelection().
2015-05-05 10:16:37 +09:00
be6e022f2d
shell32: Forward SetRedraw to IFolderView2.
2015-05-05 10:16:33 +09:00
7e0e82bc9c
shell32: Forward AutoArrange() to IFolderView2.
2015-05-05 10:16:29 +09:00
a897adb67b
shell32: Fix multiline trace message and some magic numbers.
2015-05-05 10:16:25 +09:00
a7b99a1f89
shell32/tests: A test for shellview QI for IOleWindow.
2015-05-05 10:16:16 +09:00
478d695ec8
shell32/tests: Fix test crashes when running with wine.
2015-05-04 20:10:53 +09:00
23d546157a
shell32: Better handle creation/destruction of shellview window.
2015-05-04 15:08:43 +09:00
eeabe96abb
explorer: Return IShellBrowser in response to SID_STopLevelBrowser.
2015-05-04 15:08:38 +09:00
3c7bf0350a
explorer: Added stub IServiceProvider support for shell browser window.
2015-05-04 15:08:33 +09:00
68c5fed5cc
explorer: Implement Application property.
2015-05-04 15:08:27 +09:00
58775c878a
explorer: Added IDispatch support for ShellBrowserWindow instance.
2015-05-04 15:08:24 +09:00
a74c56a3b9
explorer: Added stub IWebBrowser2 support for desktop shell window.
2015-05-01 15:17:03 +09:00
06b60cc4d0
shell32: Forward to CreateViewWindow3().
2015-05-01 15:16:19 +09:00
e91dac5153
shell32: Update to IFolderView2.
2015-05-01 15:15:56 +09:00
5d288771c9
shell32: Update to IShellView3.
2015-04-30 16:20:58 +09:00
f57b5ea2fb
shell32/tests: Some more tests for IShellWindows implementation.
2015-04-30 16:20:41 +09:00
dd9813b5f7
shell32: Added a stub implementation of IShellFolderViewDual3.
2015-04-30 16:20:35 +09:00
b4769495bc
explorer: Added a stub IShellWindows implementation.
...
Most of it was done by Andrew Eikum.
2015-04-29 12:26:32 +09:00
fae0f6785a
shell32/tests: Some tests for IShellWindows.
2015-04-29 12:25:00 +09:00
d6802318aa
include: Added IShellFolderViewDual definition.
2015-04-28 20:23:59 +09:00
8042831061
shell32: Add more knownfolders.
2015-04-14 16:50:07 +09:00
96971ea36d
shell32: Add more knownfolders.
2015-04-13 15:04:25 +09:00
c6b999b901
shell32: Add more knownfolders.
2015-04-10 15:21:35 +09:00
f58c11767a
shell32: Add more knownfolders.
2015-04-09 13:24:30 +09:00
e4868d5635
shell32: Allocate returned array in IKnownFolderManager::GetFolderIds.
2015-04-09 13:24:23 +09:00
915bef8725
shell32: Add more knownfolder definitions.
2015-04-08 23:21:33 +09:00
c01efd0666
shell32: Support setting and retrieving KnownFolder parsing names.
2015-04-08 23:19:35 +09:00
17339f4f94
shell32: Cleanup IShellItem creation calls.
2015-04-08 16:22:30 +09:00
e9d010ef62
shell32: Add support for the OS X 'My Stuff' folders.
2015-04-08 16:21:39 +09:00
1d3d086560
shell32: Remove a couple of redundant lines.
2015-04-07 18:53:44 +09:00
d19790840f
shell32: Cleanup item array creation code.
2015-04-07 18:53:40 +09:00
47f8dbcb36
shell32: Fix allocation size (Valgrind).
2015-04-07 18:53:32 +09:00
e4c285b074
shell32: Point the 'My Documents' symbolic link to the XDG or OS X 'Documents' folder if they exist.
2015-04-03 11:22:00 +09:00
6e638d824b
shell32: Update version information to match XP values.
2015-03-23 16:36:40 +09:00
351d907bbd
shell32: Remove unneeded NONAMELESSXXX directives.
2015-03-20 17:50:06 +09:00
f505e6fb4a
Assorted spelling fixes.
2015-03-19 21:54:14 +09:00
5acb82fc28
shell32: Fix SHFileOperation(FO_MOVE) for a directory with subdirectories.
2015-03-19 21:05:13 +09:00
5614ae23ee
shell32/tests: Add a couple of SHFileOperation(FO_MOVE) tests for a directory.
2015-03-19 21:05:11 +09:00
12d057c8e7
shell32: Install knownfolders to registry during DLL registration.
2015-03-18 19:27:31 +09:00
efbea96142
shell32: Also register knownfolder attributes.
2015-03-18 19:27:18 +09:00
cdf6aecc22
shell32: Allow registering knownfolders without relative paths.
2015-03-18 19:27:11 +09:00
7c9151c1e6
shell32: Allow updating knownfolder definitions.
2015-03-18 19:26:52 +09:00
fdbdad03f3
shell32/tests: Support alternate parent folders.
2015-03-12 13:56:11 +09:00
122f71866e
shell32/tests: Fix win8 knownfolder attributes.
2015-03-12 13:55:58 +09:00
7a55f5461a
shell32/tests: Remove unused flag.
2015-03-12 13:55:51 +09:00
dd275615db
shell32/tests: Fix win8 knownfolders relative and parsed paths.
2015-03-12 13:55:40 +09:00
1b4272639b
shell32/tests: A couple of win8 fixes.
2015-03-12 13:54:45 +09:00
725662003a
shell32/tests: Actually test some return values (PVS-Studio).
2015-03-04 21:50:43 +09:00
d28052066d
shell32/tests: Use NULL for a null pointer.
2015-03-04 21:50:33 +09:00
db35807eb0
shell32: Fall back on CSIDL path for knownfolders without a path in the registry.
2015-03-03 11:47:00 +09:00
103f158c63
shell32: Also return RelativePath in GetFolderDefinition.
2015-03-03 11:46:56 +09:00
32a6ee3887
shell32: Also return ParentFolder ID in GetFolderDefinition.
2015-03-03 11:46:52 +09:00
7c48641100
shell32: Fix incorrect size argument of FormatMessageW.
2015-03-02 13:51:18 +09:00
e56e9c11fa
shell32: Use a helper function to allocate strings from the registry.
2015-03-02 13:48:35 +09:00
b5c12cf9f3
shell32: Use a helper function to get DWORDs from registry.
2015-03-02 13:48:32 +09:00
d7d058482c
shell32: Rearrange error handling in IKnownFolder::GetFolderDefinition.
2015-03-02 13:48:28 +09:00
9491044e44
shell32: Simplify check for an empty string.
2015-02-26 20:11:05 +09:00
aba6a68068
shell32: Fix memory leak in ApplicationAssociationRegistration_QueryCurrentDefault.
2015-02-26 20:11:02 +09:00
81711c7558
shell32: Don't call Drop without valid target.
2015-02-24 23:01:42 +09:00
3121955956
shell32: Implement IApplicationAssociationRegistration QueryCurrentDefault.
2015-02-18 16:40:52 +09:00
6dac2f7a77
shell32: Add partial support for Mac trash enumeration.
2015-02-02 22:29:46 +09:00
8aba9366ed
shell32: Pass trash path to TRASH_EnumItems.
2015-02-02 22:29:32 +09:00
d46862b487
shell32: Handle TRASH_EnumItems failures correctly.
2015-02-02 22:29:25 +09:00
814ab9ee46
shell32: Create trash test file in temp directory.
2015-02-02 22:29:18 +09:00
169923d4b9
shell32: Reset pszHome if it's not usable so we don't try to reuse it when setting up the Desktop symlink.
2015-01-05 20:16:44 +01:00
d7fc48463b
shell32: Fix the IDS_PERSONAL hardcoded default.
...
The corresponding folder is called 'My Documents' but on Linux it's
usually called 'Documents' so that's much more appropriate fallback
than 'Personal'.
2015-01-05 20:16:36 +01:00
aa096fb456
shell32: Fix a trailing '\n' in a FIXME() call.
2015-01-05 20:16:13 +01:00
1449090985
shell32: Don't append a trailing space to the arguments in a shell link if the command info has an empty parameters string.
2014-12-23 15:29:04 +01:00
aeda103769
shell32: Added stub IPropertyStore for a shell link object.
2014-12-22 13:37:03 +01:00
6f98de084b
shell32: Export SHILCreateFromPath by name too.
2014-12-18 20:20:40 +01:00
717385b0ba
shell32: Added a stub for SHAssocEnumHandlers().
2014-12-05 20:47:42 +01:00
2c1287871b
shell32/tests: Remove unused variables (Clang).
2014-12-04 14:03:27 +01:00
8d50a8a246
shell32: Remove unused string (Clang).
2014-12-04 14:03:26 +01:00
61ed9130bf
shell32/tests: Fix a copy and paste error (PVS-Studio).
2014-11-20 22:35:54 +09:00
66662a87c0
shell32: Add a stub for RegenerateUserEnvironment.
2014-11-12 20:07:55 +09:00
5d43ef68ce
shell32: Simplify check for empty string (PVS-Studio).
2014-11-07 18:23:03 +09:00
730e744e3b
shell32: Use E_NOT_SUFFICIENT_BUFFER definition.
2014-10-08 13:13:36 +02:00
0dd5cb1cef
Assorted spelling fixes.
2014-09-29 10:36:36 +02:00
97be8d027b
shell32: Added stub for SHEnumerateUnreadMailAccountsW.
2014-09-15 10:12:20 +02:00
0f3728a692
shell32: Add a trailing '\n' to a FIXME().
2014-08-19 14:48:29 +02:00
c1d592876a
shell32/tests: Add a trailing '\n' to a couple of win_skip() calls.
2014-08-19 14:48:27 +02:00
d016dc4004
shell32: Implement IEnumShellItems for IShellItemArray.
2014-08-05 16:39:07 +02:00
e38d1c9aa1
shell32: Create profile directories available in Vista and above.
2014-08-04 19:28:42 +02:00
27b45807a7
shell32: Implement IShellItemArray::GetAttributes.
2014-08-04 14:27:48 +02:00
a79be28e8c
shell32: Implement SHCreateShellItemFromIDLists.
2014-08-04 14:27:46 +02:00
815b532b64
shell32: Always initialize shellitem to NULL in SHCreateShellItem.
2014-08-04 14:27:25 +02:00
9ff6853478
shell32: Return S_OK only if the flags matches the result exactly.
2014-08-04 14:27:23 +02:00
678434539e
shell32: Mask out attributes we didn't ask for in ShellItem::GetAttributes.
2014-08-04 14:27:21 +02:00
955b487b20
shell32/tests: Tests for IShellItemGetAttributes.
2014-08-04 14:27:19 +02:00
d892239f5a
shell32: Return NULL-terminated list of arguments in CommandLineToArgvW.
2014-07-09 09:29:33 +02:00
f9a19f57e1
shell32: Implement PathYetAnotherMakeUniqueName().
2014-06-30 22:04:52 +02:00
2ba9ee018b
shell32: Fix SHFileOperation when deleting a nonexistent directory.
2014-06-25 11:55:10 +02:00
2ab8729020
Assorted spelling/grammar fixes.
2014-06-20 12:19:31 +02:00
fa8d59c30b
shell32: Set tm_isdst before calling mktime.
2014-06-18 16:26:43 +02:00
d3a034e348
shell32: Release cached desktop folder on process detach.
2014-06-16 09:30:52 +02:00
c318cda8d1
shell32: Update to FolderItem2.
2014-06-11 16:05:55 +02:00
ee13e10cf6
shell32: Fix memory leak.
2014-05-21 19:38:35 +02:00
6f7650aec1
shell32/tests: Fix tests on win 8.
2014-05-15 17:22:28 +02:00
d87aa43ce5
shell32/tests: Fix the tests when run from the top directory.
2014-05-15 17:22:27 +02:00
3ebb9b7b75
shell32/tests: Use SW_HIDE with ShellExecuteA in tests.
2014-05-07 21:28:46 +02:00
2e5cb7aac8
Assorted spelling/grammar fixes.
2014-04-30 18:34:20 +02:00
5c73a4e629
shell32: Use boolean return value in boolean function.
2014-04-29 11:18:32 +02:00
3d1cf168cf
shell32/tests: Use SEE_MASK_NO_CONSOLE with ShellExecuteExA.
2014-04-25 10:22:47 +02:00
2005be6dc9
shell32: Use CREATE_NEW_CONSOLE when SEE_MASK_NOCONSOLE is omitted.
2014-04-25 10:22:44 +02:00
33a2242133
shell32: Pass MASK_NO_CONSOLE through to context menu handlers.
2014-04-25 10:22:41 +02:00
7eebbf3b07
shell32: Respect CMIC_MASK_NO_CONSOLE in ShellLink InvokeCommand.
2014-04-25 10:22:38 +02:00
a08160680b
shell32: Automatically expand CPL applet path string.
2014-04-16 14:35:16 +02:00
3cadbbb4b0
shell32: Use a proper deallocator (Coverity).
2014-04-15 09:45:06 +02:00
0efa2331e2
shell32: Fix a cloned pidl leak (Coverity).
2014-04-10 09:12:03 +02:00
3236c06c20
shell32: Fix a leak of memory pointing to XDG_PARSED_FILE (Coverity).
2014-04-10 09:11:56 +02:00
807998ed4c
shell32/tests: Mark some test results as broken.
2014-04-01 18:20:45 +02:00
e957dd89f9
shell32/tests: Remove todo handling from DDE tests.
2014-04-01 18:20:43 +02:00
c13e106e73
shell32: COM cleanup for IEnumIDList.
2014-03-26 19:28:00 +01:00
0aff99771d
shell32: Simplify the creation of an IEnumIDList.
2014-03-26 19:27:57 +01:00
4903dda319
shell32: Fix a typo.
2014-03-25 19:01:30 +01:00
86bd0603a2
shell32: Forward ShExtractIconsW to user32.PrivateExtractIconsW.
2014-03-25 19:01:27 +01:00
b1b92046c2
shell32: Avoid a variable-length array.
2014-03-25 13:55:46 +01:00
Michael Müller