Commit Graph

3322 Commits

Author SHA1 Message Date
Alex Henrie e42a1d4db2 shell32: Correct dialog title in error message from "Run File" to "Run".
This makes the error message match the title in the SHELL_RUN_DLG
resource definition.

Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-26 19:28:50 +01:00
Nikolay Sivov 8f21b352c2 shell32: Fix return value of GetDetailsOf() for unixfs folder.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-26 10:37:00 +01:00
Nikolay Sivov 2cce196210 shell32/shellview: Set subitem callbacks for every column.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-26 10:36:56 +01:00
Nikolay Sivov a26d6e375e shell32/shellview: Get rid of intermediate pointer array when filling ListView.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-26 10:36:51 +01:00
Marcus Meissner c3e6ecde36 shell32/tests: Fixed CharLowerBuffA size.
Signed-off-by: Marcus Meissner <marcus@jet.franken.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-16 22:02:27 +01:00
Nikolay Sivov dba1a78a20 shell32/tests: Test valid special folder IDs with NameSpace() method.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-10 19:19:16 +01:00
Nikolay Sivov bd42aaa801 shell32/tests: Some tests for ExtractAssociatedIcon().
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-09 12:09:49 +01:00
Nikolay Sivov c1645b6dfd shell32/tests: Some tests for ExtractIcon().
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-09 12:09:47 +01:00
Nikolay Sivov f7cc41d7ae shell32: Fix potential destination buffer overrun.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-12-21 19:13:51 +01:00
Nikolay Sivov 490ffe7f40 shell32: Don't trace output string buffer contents.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-12-21 19:13:49 +01:00
Hans Leidekker a2556760ec shell32/tests: Skip SHFileOperation tests if the user doesn't have admin rights.
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-12-20 13:02:15 +01:00
Hans Leidekker 748f7e26cb shell32/tests: Accept another error from SHFileOperationA.
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-12-20 13:02:10 +01:00
Nikolay Sivov 3c6cbc2f91 shell32: Don't access uninitialized buffer (Coverity).
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-12-14 20:56:13 +01:00
VRan Liu c64cdc1fe6 shell32/tests: Simple test for KF_FLAG_DEFAULT_PATH.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-12-06 18:57:41 +01:00
Nikolay Sivov a0c259cf56 shell32: Move retrieving folder path logic to SHGetKnownFolderPath().
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-12-06 18:57:36 +01:00
Michael Müller 117c0dc5ba shell32: Add IDragSourceHelper stub.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-12-01 12:17:12 +01:00
Nikolay Sivov 8e7a041154 shell32: Simplify drag drop helper object creation.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-12-01 12:17:04 +01:00
Nikolay Sivov 794efcceee shell32: Use standard list for IEnumIDList implementation.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-12-01 12:16:56 +01:00
Nikolay Sivov 252051cb1b shell32: Respect SFGAO_NONENUMERATED attribute for registered shell extensions.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-11-30 13:26:12 +01:00
Huw Davies b670fc2c6d shell32/tests: Updated Windows 7 has a new IShellDispatch6 in its typelib.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-11-30 13:23:34 +01:00
Lauri Kenttä 1c3d6ab9cc shell32: Cosmetic changes to file type names.
Signed-off-by: Lauri Kenttä <lauri.kentta@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-11-29 21:21:31 +01:00
Huw Davies b70821a74d shell32/tests: Add some uuids present on Windows 10.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-11-29 15:11:09 +01:00
Nikolay Sivov 6d89f58ec2 shell32: Added stub implementation of ICustomDestinationList.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-11-29 12:17:30 +01:00
Nikolay Sivov 960b5996fc shell32: Limit displayed volume label length to 32.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-11-28 13:58:10 +01:00
Nikolay Sivov 1c86f97985 shell32: Get rid of some casts by using IShellFolder2 internally.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-11-28 13:56:16 +01:00
Nikolay Sivov e49878289b shell32: Remove a couple more casts of object pointers.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-11-28 13:56:09 +01:00
Nikolay Sivov 5ad123f851 shell32: Use interface pointers instead of a pointer to implementation structure.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-11-23 22:36:41 +01:00
Hans Leidekker 567b52cd93 shell32: Implement IKnownFolderManager::GetFolderByName.
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-11-22 16:32:00 +01:00
Jared Smudde 906e770121 shell32: Add caption to Run dialog.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-11-09 19:15:50 +01:00
Austin English 6c876de7d0 shell32: Add SHCreateSessionKey stub.
Signed-off-by: Austin English <austinenglish@gmail.com>
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-10-19 08:11:55 -07:00
Austin English e18654edac shell32: Add SHRemoveLocalizedName stub.
Signed-off-by: Austin English <austinenglish@gmail.com>
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-10-19 08:11:37 -07:00
Roman Pisl 6d7a32a107 shell32: Implement NIM_SETVERSION.
Signed-off-by: Roman Pisl <rpisl@seznam.cz>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-10-12 09:32:22 +02:00
André Hentschel 410a9832d1 shell32/tests: Mark win10 failure as broken.
Signed-off-by: André Hentschel <nerv@dawncrow.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-10-03 11:54:15 +02:00
Sebastian Lackner f89c3d58df shell32/tests: Fix incorrect usage of broken() function.
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-09-08 20:56:46 +09:00
Sebastian Lackner d3cb5c24a5 shell32: Remove __SHFreeAndNil macro.
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-29 23:54:42 +09:00
Sebastian Lackner af468590f7 shell32: Remove some unused static inline functions.
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-29 23:54:42 +09:00
Nikolay Sivov 91947b35ad shell32: Use interface pointer instead of implementation one.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-26 23:23:39 +09:00
Sebastian Lackner a11fb74ffb shell32: Use the correct memory allocation function in RecycleBin_GetDisplayNameOf.
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-24 12:06:53 +09:00
Nikolay Sivov 79e95afbc3 shell32/tests: Fix indentation warning on GCC 6.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-12 12:31:55 +09:00
Nikolay Sivov 27f91d71a2 shell32/tests: Fix indentation warnings on GCC 6.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-10 12:51:34 +09:00
Piotr Caban f333bf47a8 ntdll: Keep drive letter size in RtlGetFullPathName_U when full path is specified.
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-29 23:12:11 +09:00
Jactry Zeng dad2223ad6 shell32: Use remove() instead of rmdir().
rmdir() will fail when target is a symbolic link.

Signed-off-by: Jactry Zeng <jzeng@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-26 20:40:42 +09:00
Andrey Gusev 954560f847 shell32: Use debugstr_guid() and debugstr_w() in TRACE() messages.
Signed-off-by: Andrey Gusev <andrey.goosev@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-22 21:34:50 +09:00
Alex Henrie a615647435 shell32/tests: Change to temp dir to be able to remove winetest dir.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-20 23:05:52 +09:00
Alex Henrie de37f020a2 shell32/tests: Free winetest BSTR after use.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-20 23:05:49 +09:00
Alex Henrie a711285137 shell32: Set output interfaces to NULL in FolderItems functions.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-19 22:33:53 +09:00
Alex Henrie 970de7df99 shell32: Return E_INVALIDARG from FolderItems functions on null output.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-19 22:33:48 +09:00
Alex Henrie ddf76f6a66 shell32/tests: Add tests for FolderItems.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-19 22:33:37 +09:00
Alex Henrie 1ed5773843 shell32: Stub out FolderItems.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-19 22:32:41 +09:00
Alex Henrie ebf480c430 shell32: Print RIIDs as strings in shell dispatch TRACE statements.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-19 22:29:24 +09:00