Commit Graph

1168 Commits

Author SHA1 Message Date
Nikolay Sivov 568b08047b shlwapi: Fix a string leak (Valgrind).
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-06-13 11:34:14 +09:00
Dmitry Timoshkov 860f5562c7 shlwapi: Fix IStream::Read() return value for partial reads.
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-26 14:52:01 +09:00
Francois Gouget 637799db98 shlwapi/tests: Fix a test failure on Windows 10.
AssocQueryString() can return S_FALSE with the size of the required buffer.

Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-03-18 12:21:10 +09:00
Alexandre Julliard 262a41ca4a shlwapi: Use the standard WideCharToMultiByte instead of wine_utf8_wcstombs.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-25 00:24:59 +09:00
André Hentschel dbc043c3d8 shlwapi/tests: Use todo_wine_if() in tests.
Signed-off-by: André Hentschel <nerv@dawncrow.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-22 17:37:09 +09:00
Nikolay Sivov ed0520e2e2 shlwapi/tests: Fix uninitialized data access in tests (Valgrind).
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-09 17:30:04 +09:00
Nikolay Sivov 37cdf65949 shlwapi: Fix initializer causing compiler warning.
Spotted by Józef.

Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-08 21:38:20 +09:00
Jared Smudde 1c2dd4b3e7 shlwapi: Fix OS_TABLETPC typo.
Signed-off-by: Jared Smudde <computerwhiz02@hotmail.com> 
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-06 18:13:50 +01:00
Nikolay Sivov 9171865661 shlwapi: Remove a cast that's not really needed.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-06 18:08:31 +01:00
Daniel Lehman 74e71b6643 shlwapi: Implement URL_ESCAPE_AS_UTF8.
Signed-off-by: Daniel Lehman <dlehman@esri.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-12-30 08:06:43 +01:00
Nikolay Sivov 0e4be06cd6 shlwapi: Handle NULL pointer in DllGetVersion() (Coverity).
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-12-29 17:13:52 +01:00
Olivier F. R. Dierick 71bbd8da87 shlwapi/tests: Test SHFreeShared with NULL handle.
Signed-off-by: Olivier F. R. Dierick <o.dierick@piezo-forte.be>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-12-03 23:38:22 +09:00
Olivier F. R. Dierick de0d8719d2 shlwapi: SHFreeShared returns TRUE when passed NULL handle.
Signed-off-by: Olivier F. R. Dierick <o.dierick@piezo-forte.be>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-12-03 23:38:11 +09:00
Piotr Caban 31c49c2851 shlwapi: Don't crash in PathStripPath when read-only string is passed and it's not modified.
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-29 10:54:15 +09:00
Nikolay Sivov bef3298e89 shlwapi/tests: Fix a couple of prototypes to match implementation (PVS-Studio).
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-15 19:18:49 +09:00
Nikolay Sivov f51e7900eb shlwapi: Fix SHPropertyBag_ReadLONG prototype (PVS-Studio).
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-15 19:18:43 +09:00
Bruno Jesus ffb4d15117 shlwapi: Reject NULL key on SHRegCloseUSKey with tests. 2015-09-07 15:04:27 +09:00
Marcus Meissner a2869de4d4 shlwapi: Add missing braces (Coverity). 2015-06-15 14:47:32 +09:00
Huw Davies 9327e476d4 shlwapi/tests: Fix failing tests on Vista and Win 2008.
SHMapHandle fails with a variety of errors on these platforms.
2015-06-10 23:36:28 +09:00
Nikolay Sivov b5c2c0b05a shlwapi: Fix error handling in IUnknown_GetClassID (Coverity). 2015-06-08 15:26:36 +09:00
Francois Gouget 7411c72e82 shlwapi/tests: Silence some istream traces that generate too many lines. 2015-05-12 22:32:22 +09:00
Nikolay Sivov d6180c05b5 shlwapi/tests: Fix uninitialized memory reads (Valgrind). 2015-04-13 15:05:12 +09:00
Francois Gouget 14aa446f1d shlwapi: Remove unneeded NONAMELESSXXX directives. 2015-03-20 18:05:07 +09:00
André Hentschel e26e33fa06 shlwapi: Avoid assigning values twice (PVS-Studio). 2015-03-20 12:42:28 +09:00
Michael Stefaniuc a0e28403d4 shlwapi: Remove two unused assignments (PVS-Studio). 2015-03-04 21:50:44 +09:00
Austin English 1b698ccd59 shlwapi: Sync wsprintf implementation from user32. 2015-02-23 21:45:47 +09:00
Michael Müller 8758a8a671 shlwapi: Correctly treat '.' when enumerating files in PathIsDirectoryEmptyW. 2015-01-15 11:36:52 +01:00
Sebastian Lackner 4b33a339cc shlwapi: Add implementation for StrCatChainW.
Based on a patch by Huw Campbell.
2014-12-16 16:32:31 +01:00
Michael Stefaniuc 6ae26c7b53 shlwapi: Remove always true if-check (PVS-Studio). 2014-11-26 17:26:44 +01:00
Sebastian Lackner 1b672e55ce shlwapi: Fix incorrect usage of CompareString in StrRStrIW. 2014-11-19 23:36:34 +09:00
Sebastian Lackner 80d98683d0 shlwapi: Fix incorrect usage of CompareString in StrRStrIA. 2014-11-19 23:36:34 +09:00
Sebastian Lackner 1321644239 shlwapi: Fix invalid usage of CompareString in PathCreateFromUrlW. 2014-11-18 22:10:59 +09:00
Sebastian Lackner 5aec09e4d1 shlwapi: Fix invalid usage of CompareString in StrStr functions. 2014-11-17 17:29:14 +09:00
Michael Stefaniuc e3c44185ed shlwapi/tests: Simplify empty string check (PVS-Studio). 2014-11-04 13:31:47 +09:00
Nikolay Sivov 6ebe8d5a2a shlwapi: Use E_NOT_SUFFICIENT_BUFFER definition. 2014-10-08 13:13:37 +02:00
Sebastian Lackner 403ff3734a shlwapi: Remove unnecessary internal function SHLWAPI_DupSharedHandle. 2014-10-02 20:31:54 +02:00
Sebastian Lackner c95b182d15 shlwapi: Fix swapped argument order in SHMapHandle. 2014-10-02 20:31:52 +02:00
Sebastian Lackner ef065486dd shlwapi/tests: Add test for SHMapHandle. 2014-10-02 20:31:48 +02:00
Frédéric Delanoy 1e214eb5d3 Assorted spelling/grammar fixes. 2014-10-02 16:58:53 +02:00
Sebastian Lackner 5e4f15db1f shlwapi: Fixed swapped argument order in SHLWAPI_DupSharedHandle command. 2014-10-01 10:35:20 +02:00
Sebastian Lackner cad3e3e5dc shlwapi/tests: Add SH*Shared inter-process tests. 2014-10-01 10:35:16 +02:00
André Hentschel badfdaf56c shlwapi/tests: Fix SHFormatDateTimeW tests for right-to-left locales. 2014-08-18 12:44:35 +02:00
Francois Gouget ece6f5c3e0 shlwapi/tests: Make test_PathIsRelative[AW]() static. 2014-07-07 09:11:34 +02:00
Zhenbo Li 9d59d4e550 shlwapi/tests: Add tests for PathIsRelativeA/W. 2014-07-02 19:58:23 +02:00
Christoph von Wittich f26874c523 shlwapi: Avoid buffer overflow in PathCombineA. 2014-06-27 11:02:39 +02:00
Nikolay Sivov 31fb427737 shlwapi/tests: Skip if test ini file wasn't created. 2014-06-13 16:05:55 +02:00
Bruno Jesus 9dacce1b4e shlwapi: Avoid reading past the pointer in PathCreateFromUrlW (valgrind). 2014-06-11 16:11:28 +02:00
Victor Martinez Calvo c2ff8f4005 shlwapi: Check correct attributes in PathRelativePath. 2014-05-05 12:17:50 +02:00
Huw Davies ddf861da00 shlwapi/tests: Fix win8 test failures. 2014-05-01 11:17:06 +02:00
Nikolay Sivov f1706b0387 shlwapi: Implement SHRegCreateUSKeyA(). 2014-04-22 11:26:14 +02:00
Nikolay Sivov 462b2feb35 shlwapi: Fix UrlEscapeW() for non-ASCII range. 2014-04-18 10:47:57 +02:00
Nikolay Sivov 0cb52a9cfa shlwapi: Use a proper deallocator (Coverity). 2014-04-15 09:45:01 +02:00
Nikolay Sivov 14dab8ab4b shlwapi: Always close find handle (Coverity). 2014-04-10 09:12:10 +02:00
David Quintana 2bb1059ad2 shlwapi: SHInvokeCommand last parameter is a command ID, or 0 to use the default. 2014-03-14 19:06:59 +01:00
Hans Leidekker 3a72922e7f shlwapi/tests: Fix test failures on Windows 8. 2014-03-11 19:39:28 +01:00
Frédéric Delanoy b89f92181a shlwapi/tests: Use BOOL type where appropriate. 2014-02-27 09:26:38 -06:00
Dmitry Timoshkov 99eab9d3c7 shlwapi: Avoid a not necessary intermediate variable. 2014-02-19 16:47:52 +01:00
Dmitry Timoshkov 35a9587613 shlwapi: Avoid potential NULL pointer access if HeapAlloc fails. 2014-02-19 16:47:37 +01:00
Dmitry Timoshkov 968d464f17 shlwapi: Return interface instead of implementation pointer. 2014-02-19 16:47:22 +01:00
Frédéric Delanoy 0f2bed51bd Assorted spelling fixes. 2014-02-10 15:47:29 +01:00
Michael Stefaniuc 8612c266db shlwapi/tests: Remove a typedef for a struct. 2014-02-05 13:49:23 +01:00
Michael Stefaniuc 1b0e893d27 shlwapi/tests: Fix the type of the first param of some shlwapi functions. 2014-02-05 13:49:22 +01:00
Michael Stefaniuc 3879d98de4 shlwapi/tests: COM cleanup for the dummy IStream iface. 2014-02-05 13:49:21 +01:00
André Hentschel e98844e5c9 shlwapi/tests: Avoid preprocessor check to ensure it compiles. 2014-01-27 17:39:47 +01:00
Alexandre Julliard 99ef0d6ff0 makefiles: Get rid of the MAKE_TEST_RULES variable. 2014-01-02 12:13:16 +01:00
Alexandre Julliard 5e7416e5c8 makefiles: Get rid of the MAKE_DLL_RULES variable. 2014-01-02 12:08:18 +01:00
Frédéric Delanoy 36e8004291 shlwapi/tests: Constify some character strings. 2013-12-30 19:01:41 +01:00
Frédéric Delanoy bdce3b9994 shlwapi/tests: Fix StrChrNW prototype. 2013-12-30 19:01:40 +01:00
Alexandre Julliard 4f3d71cef3 makefiles: Get rid of the no longer used PO_SRCS variables. 2013-12-15 10:23:04 +01:00
Frédéric Delanoy 9be5df10ae shlwapi/tests: Avoid memory leaks (coverity). 2013-12-04 21:19:04 +01:00
Francois Gouget 387289e547 shlwapi/tests: Fix compilation on systems that don't support nameless unions. 2013-11-15 11:59:05 +01:00
Francois Gouget daf3c95d04 shlwapi/tests: Make test_SHCreateStreamOnFileEx_CopyTo() static. 2013-11-11 12:37:23 +01:00
Alexandre Julliard ec7c250450 shlwapi/tests: Test if SHCreateStreamOnFileEx is present before using it. 2013-11-08 16:29:43 +01:00
David Quintana 899e59ffe3 shlwapi: Test and fix the behaviour of the CopyTo method for file sizes not multiple of the internal buffer size, on SHCreateStreamOnFileEx-returned IStreams. 2013-11-07 15:39:26 +01:00
Sebastian Lackner 7ee2c24a8c shlwapi: Fix UrlCombineW for URLs containing a quotation mark. 2013-11-07 13:14:42 +01:00
Alexandre Julliard 5756ee09f3 makefiles: Add makedep pragmas for rc files that contain translations. 2013-11-05 20:38:19 +01:00
Nikolay Sivov 7513b58329 shlwapi: Implement PathUnExpandEnvStrings. 2013-11-04 11:48:06 +01:00
Nikolay Sivov b70a5d52f1 shlwapi/tests: Compile with -D__WINESRC__. 2013-10-16 11:41:20 +02:00
Michael Stefaniuc 0e681027a2 tests: Compile the tests by default with -D__WINESRC__. 2013-10-02 11:04:02 +02:00
Michael Stefaniuc 9463dba830 tests: Use the explicit LoadLibraryA function. 2013-10-02 11:02:21 +02:00
Dmitry Timoshkov 50c4723aec shlwapi/tests: Skip some of IStream invalid parameter tests under Windows 2000 + IE5. 2013-09-23 11:56:18 +02:00
Dmitry Timoshkov b7e68ae338 shlwapi/tests: Fix stream test failures under some win2000 versions. 2013-09-19 09:31:01 +02:00
Dmitry Timoshkov b145f42b0f shlwapi: Write file access also assumes read access. 2013-09-16 19:50:14 +02:00
Dmitry Timoshkov 75fc26f680 shlwapi/tests: Add a read/write test for IStream on files. 2013-09-16 19:50:11 +02:00
Dmitry Timoshkov b07f431878 shlwapi: Merge two case statements. 2013-09-13 11:18:23 +02:00
Alexandre Julliard 3dc5586e41 shlwapi: Use neutral language for the version resource. 2013-07-09 22:21:58 +02:00
Dmitry Timoshkov f49de6aa08 shlwapi: Correct .spec parameter types for Assoc* APIs. 2013-06-04 10:12:29 +02:00
Alexandre Julliard 20ff6bc913 shlwapi: Don't bother to free thread local storage at process exit. 2013-05-16 12:52:21 +02:00
Austin English b8f072e910 shlwapi: Add a stub for IsInternetESCEnabled. 2013-02-12 10:16:00 +01:00
Andrew Talbot 431b4f52d6 shlwapi: Indentation fix. 2012-12-24 13:32:42 +01:00
Nikolay Sivov 16cc2b8753 shlwapi: Implement IsCharSpaceA(). 2012-12-20 12:22:54 +01:00
André Hentschel b74b8776c0 shlwapi/tests: Fix two tests on win8. 2012-12-11 12:03:40 +01:00
Francois Gouget 58c77f6156 shlwapi: Implement PathCreateFromUrlAlloc(). 2012-10-01 12:07:31 +02:00
Francois Gouget fad0bea304 shlwapi: Fix the PathCreateFromUrlW() implementation. 2012-09-26 10:59:53 +02:00
Francois Gouget 7c42bfe107 shlwapi: UrlIs()'s check for the 'file:' protocol is case insensitive. 2012-09-26 10:59:45 +02:00
Francois Gouget 06439b303a shlwapi: PathCreateFromUrlA() should not crash when given NULL buffers.
Add NULL and insufficient buffer tests for PathCreateFromUrl().
2012-09-25 18:11:18 +02:00
Marcus Meissner 73dfc3d462 shlwapi: Fixed incorrect buffer size. 2012-09-25 11:17:12 +02:00
Francois Gouget 5f55a71b70 Assorted spelling fixes. 2012-09-24 22:27:29 +02:00
Francois Gouget 73f89e7e4c shlwapi/tests: Add more PathCreateFromUrl() tests. 2012-09-24 22:27:28 +02:00
Francois Gouget 709a0b764d Use the CP_ACP and NULL macros instead of numeric literals when converting strings between ANSI and Unicode. 2012-09-24 22:27:28 +02:00
Michael Stefaniuc c637cbc397 shlwapi: Remove gratuitous "stub" from TRACE messages. 2012-09-11 18:06:59 +02:00
Jacek Caban 4d5bebb321 shlwapi: Use proper helpers for iface calls. 2012-08-15 12:18:49 +02:00
Michael Stefaniuc 8d24dd49ee shlwapi: Avoid FALSE:TRUE conditional expressions. 2012-08-13 17:30:13 +02:00
Francois Gouget de049ff1ed shlwapi: Simplify the string comparison functions a bit and use the CSTR_XXX macros. 2012-06-21 08:33:44 +02:00
Michael Stefaniuc a5b0d13741 shlwapi/tests: Fix the expected value in an ok() message. 2012-06-04 19:36:19 +02:00
Michael Stefaniuc 24a01dfef8 shlwapi/tests: Remove useless ok() call on the "out" variable. 2012-05-16 18:30:22 +02:00
Francois Gouget fac36c55e9 Assorted typo, spelling, wording and case fixes. 2012-05-15 16:26:43 +02:00
Carlo Bramini f6524a9f77 shlwapi: Add NULL checks to StrCpyW and StrCatW. 2012-04-19 19:28:12 +02:00
Carlo Bramini f9c9ea6343 shlwapi: Don't remove nonexistent extension in PathRemoveExtension. 2012-04-13 16:29:25 +02:00
Carlo Bramini f2d40ca87d shlwapi: Add stub for AssocGetPerceivedType. 2012-04-09 17:23:08 +02:00
Michael Stefaniuc 0556192994 shlwapi: Print the debug string and not the pointer to it. 2012-03-26 18:15:26 +02:00
Carlo Bramini a1af839516 shlwapi: Implemented StrToInt64ExA/W. 2012-03-16 13:02:47 +01:00
Piotr Caban 3f6142e00d shlwapi: Lowercase schemes in UrlCombine function. 2012-03-08 18:55:04 +01:00
Francois Gouget f445325999 Assorted spelling fixes. 2012-01-23 16:07:32 +01:00
Alexandre Julliard 51bba9ee07 shlwapi: Fix some printf format warnings. 2012-01-17 15:02:49 +01:00
Nikolay Sivov 191bc054a5 shlwapi: Partially implement SHRegCreateUSKeyW. 2011-12-01 18:17:22 +01:00
Alexandre Julliard 3d818c3aa8 shlwapi: Convert dialogs to po files. 2011-11-22 14:20:49 +01:00
Frédéric Delanoy ce3dd89b54 shlwapi: Avoid harcoding array lengths. 2011-11-21 11:05:08 +01:00
Michael Stefaniuc 3e1ee5b8b7 include: Make "long" numeric constants LP64/LLP64 proof (shlwapi.h). 2011-11-14 11:46:40 +01:00
Andrew Talbot 0bed0f4ce6 shlwapi: Suppress sign-extension through integer promotion. 2011-11-09 11:35:06 +01:00
Nikolay Sivov 762aa854ca shlwapi: Fix window style set with SHSetParentHwnd(). 2011-10-24 11:17:57 +02:00
Francois Gouget c8ecf2c721 shlwapi: Don't use a long where an int is more than big enough. 2011-10-18 18:58:50 +02:00
Marcus Meissner c9b6994648 shlwapi: Fixed bad pointer arithmentic by removing sizeof() (Coverity). 2011-10-18 15:18:04 +02:00
Dan Kegel 876d551911 shlwapi/tests: Initialize size parameter in test_SHGetShellKey. 2011-10-14 20:26:44 +02:00
Jacek Caban 4a39433eae shlwapi: Make sure we don't write anything to output buffer if its size is too small to store the whole result. 2011-10-14 20:26:44 +02:00
Francois Gouget bd7b345b26 Assorted spelling fixes & co. 2011-09-27 11:00:13 +02:00
Francois Gouget 3de330db54 tests: Remove unneeded assert.h includes. 2011-09-27 10:59:56 +02:00
Francois Gouget fcb351b40f shlwapi/tests: Skip some tests if not allowed to modify the registry. 2011-09-21 11:35:43 +02:00
Francois Gouget 74459389a5 shlwapi/tests: Some tests require that the user interface be in English.
With MUI versions of Windows checking for the default user language id or locale is insufficient.
2011-09-15 15:41:41 +02:00
Francois Gouget 0ae12c4a3b shlwapi/tests: Fix test_StrFromTimeIntervalA() to print the badly formatted string in case of a failure. 2011-09-15 15:41:41 +02:00
Francois Gouget 8973c20f7d Assorted spelling fixes. 2011-09-13 11:27:01 +02:00
Francois Gouget bdb65df982 shlwapi: Add parentheses to clarify the precedence between '&' and '&&'. 2011-09-12 11:01:10 +02:00
Francois Gouget 5f53f1ad07 shlwapi: Add a message context for 'hr', 'min' and 'sec'. 2011-09-05 16:42:12 +02:00
Francois Gouget c992ca277d Assorted spelling fixes. 2011-08-24 19:07:46 +02:00
Francois Gouget 77f68e30f5 shlwapi/tests: Fix the spelling of IID_Endianness. 2011-08-24 19:07:45 +02:00
Scott Ritchie d38909dade shlwapi/tests: Fix an errant comment. 2011-08-24 13:49:13 +02:00
Frédéric Delanoy 760faf01a9 tests: Assorted spelling fixes. 2011-08-04 18:27:37 +02:00
Frédéric Delanoy 7e309601f3 dlls: Assorted spelling fixes. 2011-08-03 14:15:50 +02:00
André Hentschel 787ab4572d shlwapi/tests: Don't access memory when the allocation failed. 2011-07-28 11:28:16 +02:00
Alexandre Julliard 2bf9c26df6 shlwapi: Add support for 64-bit formats in wsprintf. 2011-07-25 13:38:04 +02:00
Igor Paliychuk 86dd443415 shlwapi: Convert Ukrainian resources into utf-8. 2011-06-20 19:32:04 +02:00
Marcus Meissner e9d4ca069c shlwapi: Removed superflous NULL check (Coverity). 2011-06-15 20:04:38 +02:00
Sergey Khodych 26541471ab shlwapi: Implement URL_APPLY_GUESSFILE in UrlApplyScheme. 2011-05-17 11:45:49 +02:00
Sergey Khodych 2e1bec528f shlwapi: Don't copy valid scheme in UrlApplySchemeW. 2011-05-17 11:45:47 +02:00
Marcus Meissner f5ae978902 shlwapi: Mark internal symbols as hidden. 2011-04-28 18:13:57 +02:00
André Hentschel a4d8b22f43 shlwapi: Implement wow64 reporting. 2011-04-01 11:54:50 +02:00
Thomas Mullaly 65d3eab864 shlwapi: Improved UrlGetPart support when parsing host names. 2011-03-28 17:21:56 +02:00
Austin English a4cc8bc63c shlwapi/tests: Remove win9x hacks. 2011-03-01 13:21:58 +01:00
Detlef Riekenberg ebecd5a779 shlwapi: Add stubs for SHWinHelpOnDemandA/W. 2011-02-15 17:25:04 +01:00
Austin English 92f48ef6ec shlwapi/tests: Remove useless assignments (LLVM/Clang). 2011-02-11 14:49:54 +01:00