ReceiveTempSMS
/
Sweden-Number
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

shlwapi: Write file access also assumes read access.

This commit is contained in:
Dmitry Timoshkov 2013-09-16 17:27:08 +09:00 committed by Alexandre Julliard
parent 75fc26f680
commit b145f42b0f
2 changed files with 1 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
dlls/shlwapi/istream.c
View File

@ -420,12 +420,10 @@ HRESULT WINAPI SHCreateStreamOnFileEx(LPCWSTR lpszPath, DWORD dwMode,
/* Access */
switch (STGM_ACCESS_MODE(dwMode))
{
case STGM_WRITE:
case STGM_READWRITE:
dwAccess = GENERIC_READ|GENERIC_WRITE;
break;
case STGM_WRITE:
dwAccess = GENERIC_WRITE;
break;
case STGM_READ:
dwAccess = GENERIC_READ;
break;

16
dlls/shlwapi/tests/istream.c
View File

@ -222,27 +222,11 @@ static void test_stream_read_write(IStream *stream, DWORD mode)
ret = stream->lpVtbl->Read(stream, buf, 2, &count);
if (written != 0)
{
/* FIXME: Remove once Wine is fixed */
if (mode == STGM_WRITE)
todo_wine
ok(ret == S_OK, "IStream_Read error %#x (access %#x, written %u)\n", ret, mode, written);
else
ok(ret == S_OK, "IStream_Read error %#x (access %#x, written %u)\n", ret, mode, written);
if (mode == STGM_WRITE || mode == STGM_READWRITE)
{
/* FIXME: Remove once Wine is fixed */
if (mode == STGM_WRITE)
{
todo_wine
ok(count == 2, "expected 2, got %u\n", count);
todo_wine
ok(buf[0] == 0x5e && buf[1] == 0xa7, "expected 5ea7, got %02x%02x\n", buf[0], buf[1]);
}
else
{
ok(count == 2, "expected 2, got %u\n", count);
ok(buf[0] == 0x5e && buf[1] == 0xa7, "expected 5ea7, got %02x%02x\n", buf[0], buf[1]);
}
}
else
ok(count == 0, "expected 0, got %u\n", count);