Commit Graph

3707 Commits

Author SHA1 Message Date
Alex Henrie 76e77535c2 shell32: Add modem folder icon.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-22 17:05:19 +02:00
Alex Henrie 8969e6f37f shell32: Add "trash full" icon.
Adapted from user-trash-full in the Tango Icon Library.

Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-22 17:05:19 +02:00
Alex Henrie 905685c383 shell32: Add shutdown icon.
Adapted from system-shutdown in the Tango Icon Library.

Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-22 17:05:19 +02:00
Alex Henrie f9c7dbd55e shell32: Add eject icon.
Adapted from media-eject in the Tango Icon Library.

Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-22 17:05:19 +02:00
Alex Henrie 09cca8fed7 shell32: Add sleep icon.
Adapted from preferences-desktop-screensaver in the Tango Icon Library.

Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-21 10:36:10 +02:00
Alex Henrie df48fd9a27 shell32: Add run icon.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-21 10:36:10 +02:00
Alex Henrie 84e2cf0375 shell32: Add help icon.
Adapted from help-browser in the Tango Icon Library.

Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-21 10:36:10 +02:00
Alex Henrie c1b264ac18 shell32: Add search icon.
Adapted from system-search.svg in the Tango Icon Library.

Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-21 10:31:15 +02:00
Alex Henrie 791b057ecc shell32: Remove alpha channel from 4-bit and 8-bit network icons.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-21 10:31:08 +02:00
Alex Henrie ba0007260e shell32: Remove alpha channel from 4-bit and 8-bit Internet icons.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-21 10:31:08 +02:00
Alexandre Julliard 8204d04b7f shell32: Move image resources to a resources subdirectory.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-20 19:54:48 +02:00
Alex Henrie b9a6f75349 shell32: Add settings icon.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-20 19:48:09 +02:00
Alex Henrie 76e02a8311 shell32: Add recent documents icon.
Adapted from appointment-new.svg in the Tango Icon Library.

Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-20 19:48:09 +02:00
Alex Henrie f0c1f79b07 shell32: Add "Computers Near Me" icon.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-20 19:48:09 +02:00
Alex Henrie f094a3d198 shell32: Switch the "My Network Places" icon to the network icon.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-20 19:48:09 +02:00
Alex Henrie 891b6fda83 shell32: Add network icon.
Adapted from network-workgroup.svg in the Tango Icon Library.

Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-20 19:48:09 +02:00
Alex Henrie 44bb2c8830 shell32: Add Internet icon.
Adapted from internet-web-browser.svg in the Tango Icon Library.

Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-20 19:48:09 +02:00
Alex Henrie d72d37008a shell32: Add 512k and 314k floppy drive icons.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-17 16:51:02 +02:00
Alex Henrie 5ee4e0027c shell32: Add window icon.
Adapted from new-window.svg in the Tango Icon Library.

Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-17 16:51:02 +02:00
Alex Henrie b14d8f9f11 shell32: Add document icon.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-17 09:46:39 +02:00
Alex Henrie 4b5d0f2f43 shell32: Rename IDI_SHELL_DOCUMENT to IDI_SHELL_FILE.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-17 09:46:36 +02:00
Alexandre Julliard 3386c01349 shell32/tests: Don't use strncat with known large enough buffer.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-15 07:08:50 +02:00
Nikolay Sivov 6634b31520 shell32: Support BYREF index in FolderItems::Item().
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-14 12:06:44 +02:00
Serge Gautherie 535f2f9e66 shell32: Fix 2 MSVC warnings about flags.
Signed-off-by: Serge Gautherie <winehq-git_serge_180711@gautherie.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-20 09:10:10 +02:00
Chip Davis efac5d0672 shell32: Don't use Carbon on Mac OS to find the Trash.
Due to a weird interaction between Wine and (what I believe to be)
os_log/os_signpost, we can't use FSPathMakeRef() (nor any other function
that calls that) from a Wine process. We also can't use the
NSSearchPathForDirectoriesInDomains() function. Setting aside the fact
that it's Objective-C (something we can work around, given that NS and
CF types are toll-free bridged), a) support for getting the Trash folder
was only added in 10.8 (when FSFindFolder() was deprecated), and b) it
doesn't even support volume-specific Trash folders.

For now, just hardcode the paths to the Trash folder.

Signed-off-by: Chip Davis <cdavis@codeweavers.com>
Signed-off-by: Ken Thomases <ken@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-20 09:09:33 +02:00
Michael Stefaniuc 1e469c95e6 shell32: Avoid ARRAY_SIZE-like macros.
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-09 10:49:05 +02:00
Michael Stefaniuc 962b31c80b include: Add a generic available ARRAY_SIZE().
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-04 10:39:15 +02:00
Marcus Meissner aba4789b0e shell32: Set size in characters in MENUITEMINFOW struct.
Signed-off-by: Marcus Meissner <meissner@suse.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-03 11:12:43 +02:00
Marcus Meissner 52e27fae47 shell32: Use characters as arguments to GetTempPathW and GetLongPathNameW.
Signed-off-by: Marcus Meissner <marcus@jet.franken.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-26 09:27:32 +02:00
Józef Kucia a8b0a822ff shell32/tests: Remove empty element from known_folders[].
Signed-off-by: Józef Kucia <jkucia@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-22 17:14:44 +02:00
Józef Kucia 0304a312ed shell32/tests: Add tests for SHGetKnownFolderPath() flags.
Signed-off-by: Józef Kucia <jkucia@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-22 17:14:36 +02:00
Józef Kucia bd459ad015 shell32/tests: Reorder known_folders table definition.
To use it in other tests.

Signed-off-by: Józef Kucia <jkucia@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-22 17:14:31 +02:00
Józef Kucia ff7c2c5171 shell32: Accept more flags in SHGetKnownFolderPath().
KF_FLAG_SIMPLE_IDLIST | KF_FLAG_DONT_UNEXPAND doesn't seem to influence
results returned by SHGetKnownFolderPath().

Signed-off-by: Józef Kucia <jkucia@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-22 17:14:20 +02:00
Zebediah Figura b79eff8d91 shell32/tests: Don't test CommandLineToArgv() in test_argify().
This is essentially redundant. We should have tests for all behaviours of
CommandLineToArgv() above; the purpose of test_argify() is to test how
ShellExecute() et al. parses its parameters, and to show that this is
different from CommandLineToArgv().

Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-22 01:01:55 +02:00
Michael Stefaniuc c57b9b8d9f shell32/tests: Use the available ARRAY_SIZE() macro.
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-15 12:56:48 +02:00
Michael Stefaniuc d46205a340 shell32/tests: Avoid sizeof in a trace.
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-15 12:56:48 +02:00
Francois Gouget e523fab898 shell32: Fix a typo in a comment.
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-01 19:43:04 +02:00
Michael Stefaniuc 7b5668a6e7 include: Make ARRAY_SIZE() available in wine/test.h.
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-25 12:09:17 +02:00
Sebastian Lackner e98963f2ab shell32: Create Microsoft\Windows\Themes directory during prefix creation.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-17 10:51:22 +02:00
Andrey Gusev 0dddf2a1ac shell32: Check array index limit first.
Signed-off-by: Andrey Gusev <andrey.goosev@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-15 12:36:01 +02:00
Alistair Leslie-Hughes c88a65f2ab shell32: Choose return value for SHFileOperationA depending on windows version.
Based on a patch by Michael Müller.

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-14 12:11:48 +02:00
Daniel Lehman da8a801a58 shell32: Convert / to \ when parsing file list.
Signed-off-by: Daniel Lehman <dlehman25@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-09 09:45:22 +02:00
Michael Müller 1f08db5654 shell32: Add general tab in file property dialog.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-08 11:08:51 +02:00
Guillaume Gill 794d30dca6 shell32: Fake success in propertystore_[SetValue|Commit].
Signed-off-by: Gijs Vermeulen <gijsvrm@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-07 16:28:57 +02:00
Louis Lenders 730264609f shell32: Handle writing an iconresource entry in SHGetSetFolderCustomSettings.
Signed-off-by: Louis Lenders <xerox.xerox2000x@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-30 20:41:59 +02:00
Louis Lenders 1f42005b17 shell32/tests: Add a test for SHGetSetFolderCustomSettings.
Signed-off-by: Louis Lenders <xerox.xerox2000x@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-27 11:22:00 +02:00
Alistair Leslie-Hughes a7124722aa shell32: Implement SHCreateSessionKey.
Based on a patch by Dmitry Timoshkov.

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-20 17:26:36 +02:00
Alexandre Julliard e8976ceeab shell32: Add 256x256 variants of the standard icons.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-20 17:17:10 +02:00
Louis Lenders 62a84f6a3c shell32: Update specs for SHGetSetFolderCustomSettings to behaviour above win2003.
Signed-off-by: Louis Lenders <xerox.xerox2000x@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-16 10:49:10 +02:00
Nikolay Sivov 738a1a33ea shell32/tests: Remove some tests workarounds.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-10 11:15:21 +02:00
Michael Stefaniuc 9a270d7e2a shell32: Remove redundant NULL checks before heap_free().
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-02 16:02:54 +02:00
Nikolay Sivov 5cb0ac15f6 shell32: Fix destination buffer size (Coverity).
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-02 10:33:09 +02:00
Michael Stefaniuc 250e8437d7 shell32: Use the available ARRAY_SIZE() macro.
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-29 17:27:41 +02:00
Michael Stefaniuc 51b065c5c9 shell32/tests: Use the available ARRAY_SIZE() macro.
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-29 17:27:35 +02:00
Nikolay Sivov e51c9b47b8 shell32: Add SHIL_JUMBO list.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-21 10:13:43 +01:00
Nikolay Sivov 7db6885da7 shell32: Add support for SHIL_SYSSMALL list.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-21 10:13:36 +01:00
Nikolay Sivov 479dc1d8c3 shell32: Add support for SHIL_EXTRALARGE list.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-21 10:13:32 +01:00
Nikolay Sivov 0075b05adf shell32: Move SHGetImageList() to related source file.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-21 10:13:27 +01:00
Nikolay Sivov 09389c4bab shell32: Pass handle arrays between icon cache helpers.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-21 10:13:23 +01:00
Nikolay Sivov ff5cfaab56 shell32: Use array for icon lists.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-21 10:13:18 +01:00
Nikolay Sivov 04ec181c6c shell32/tests: Add a basic test for SHLimitInputEdit().
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-19 12:35:12 +01:00
Nikolay Sivov 612a194133 shell32: Use ARRAY_SIZE macro.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-19 12:35:12 +01:00
Zebediah Figura e864854ce3 shell32/tests: Clean up and expand tests for IShellFolder_ParseDisplayName().
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-06 15:46:09 -06:00
Nikolay Sivov d3f32bd0c7 shell32: Partially implement IShellDispatch::BrowseForFolder().
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-23 15:54:45 +01:00
Nikolay Sivov e3b200bd8a shell32: Use global memory allocation helpers.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-22 14:16:33 +01:00
Nikolay Sivov a6ad34f855 shell32/tests: Use the global memory allocation helpers.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-20 20:13:02 +01:00
Nikolay Sivov 0282f3aade shell32/tests: Run more tests on menus created with SHCreateDefaultContextMenu().
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-19 13:43:52 +01:00
Nikolay Sivov 308a5ff7c8 shell32: Add IObjectWithSite stub for context menus.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-19 13:43:52 +01:00
Nikolay Sivov 408f856f02 shell32: Added IShellExtInit stub for context menus.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-19 13:43:52 +01:00
Nikolay Sivov 68056a3d27 shell32/tests: Run context menu tests on background menu too.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-19 13:43:52 +01:00
Nikolay Sivov 1f1f190bf0 shell32/tests: Add a basic test for NewMenu object creation.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-19 13:43:52 +01:00
Michael Müller 2723e9473c shell32: Use manual redirection for RunDLL_CallEntry16.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-12 11:04:41 +01:00
Mark Jansen 61b89d2c84 shobjidl.idl: Fix some typo's.
Signed-off-by: Mark Jansen <mark.jansen@reactos.org>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-29 20:28:59 +01:00
Nikolay Sivov bb09bb5750 shell32: Fix a trace message.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-23 16:21:33 +01:00
Nikolay Sivov ce5fb75f7f shell32: Reduce code duplication in GetCommandString().
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-22 10:16:40 +01:00
Alex Henrie 332898eacd shell32/tests: Drop shell folder test workarounds for Windows <= 2000.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-12 15:27:07 +01:00
Alex Henrie dca38ea895 shell32/tests: Drop shell folder test dynamic imports for Windows <= 2000.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-12 15:27:05 +01:00
Alex Henrie 946b4ad270 shell32/tests: Drop progman DDE test workarounds for Windows <= 2000.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-09 16:03:32 +01:00
Alex Henrie 8bb6addb1e shell32/tests: Add missing return value check to shelllink tests (Coverity).
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-08 19:26:44 +01:00
Andrey Gusev 498009c6bd shell32/tests: Fix resource leak.
Signed-off-by: Andrey Gusev <andrey.goosev@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-05 16:13:28 +01:00
Nikolay Sivov 1ee9c2c60b shell32: Make some strings static constants.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-04 15:13:36 +01:00
André Hentschel 460053b8fc shell32: Don't cast return value from DPA_GetPtr.
Signed-off-by: André Hentschel <nerv@dawncrow.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-02 15:52:22 +01:00
André Hentschel 063fd7a665 shell32/tests: Don't test functions directly when reporting GetLastError().
Signed-off-by: André Hentschel <nerv@dawncrow.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-02 11:10:31 +01:00
André Hentschel 5200f3472f shell32/tests: Don't test functions directly when reporting DdeGetLastError().
Signed-off-by: André Hentschel <nerv@dawncrow.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-02 11:10:25 +01:00
Michael Stefaniuc fd0251996f shell32/tests: Use the available ARRAY_SIZE() macro.
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-12-28 11:18:58 +01:00
Nikolay Sivov f75d562596 shell32: Fix SHGetFolderPathAndSubDir() trace message.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-12-26 10:12:44 +01:00
Louis Lenders 307b20b97b shell32: Add stub for Shell_NotifyIconGetRect.
Signed-off-by: Louis Lenders <xerox.xerox2000x@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-12-04 11:58:05 +01:00
Zebediah Figura 35d203622b shell32: Implement the Groups request for Progman DDE.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-12-04 11:42:53 +01:00
Zebediah Figura 7ddd41e326 shell32: Implement the ExitProgman() command for Progman DDE.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-12-04 11:42:41 +01:00
Zebediah Figura 57a94970f5 shell32: Implement the ReplaceItem() command for Progman DDE.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-12-04 11:42:34 +01:00
Zebediah Figura 8b2f586343 shell32/tests: Simplify existing tests and add more tests for Progman DDE.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-12-01 18:43:58 +01:00
Zebediah Figura 64c456af77 shell32: Implement the DeleteItem() command for Progman DDE.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-12-01 18:43:35 +01:00
Zebediah Figura 6e5efd001c shell32: Implement the AddItem() command for Progman DDE.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-12-01 18:43:33 +01:00
Zebediah Figura fd851064d8 shell32: Implement the ShowGroup() command for Progman DDE.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-11-30 10:24:15 +01:00
Zebediah Figura 957da4ee07 shell32: Implement the DeleteGroup() command for Progman DDE.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-11-30 10:24:13 +01:00
Zebediah Figura 83ca4e20cc shell32: Implement the CreateGroup() command for Progman DDE.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-11-30 10:24:11 +01:00
Zebediah Figura 6778023999 shell32: Add a parser for DDE commands.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-11-30 10:24:09 +01:00
Zebediah Figura 106722494a shell32/tests: Simplify and standardize test structure for progman_dde.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-11-29 21:24:50 +01:00
Lucian Poston 349064216a shell32: Stub GetRedirectionCapabilities with S_OK.
Signed-off-by: Lucian Poston <lucian.poston@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-11-24 17:33:44 +01:00
Fabian Maurer 5e88f928ed shell32/tests: Add test for IAutoComplete2 with custom source.
Signed-off-by: Fabian Maurer <dark.shadow4@web.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-11-20 12:37:15 +01:00
Marcus Meissner 5350eea78d shell32: Avoid a crash in testsuite.
This happens on wow32 builds, we try to call a 64bit program via the
generic typelib marshalling and disp is NULL. We still fail, just
do not pop up the crash dialog.

Signed-off-by: Marcus Meissner <meissner@suse.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-11-13 19:47:19 +01:00
Andrew Eikum db1a3c617e shell32: Size ShellView column widths by font width.
Signed-off-by: Andrew Eikum <aeikum@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-11-10 16:41:28 +01:00
Andrew Eikum 8d004d5151 shell32: Scale explorer browser sizes by DPI.
Signed-off-by: Andrew Eikum <aeikum@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-11-10 13:57:31 +01:00
Andrey Gusev 498578d1bb shell32: Fix misplaced parenthesis.
Signed-off-by: Andrey Gusev <andrey.goosev@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-10-13 14:21:32 +02:00
Nikolay Sivov 4c160b6f8c shell32: Improve error handling in ParseName() (Coverity).
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-10-03 13:38:29 +02:00
Nikolay Sivov e9c69fde09 shell32/tests: Fixed some leaks (Valgrind).
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-10-02 22:38:49 +02:00
Nikolay Sivov 937ef12772 shell32: PickIconDlg() is documented now.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-28 11:04:27 +02:00
Nikolay Sivov c36e7d1ec7 shell32: Added missing arguments to trace messages.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-28 11:03:49 +02:00
Nikolay Sivov 8b661a18e3 shell32: Stop using fixed size buffers for display names.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-28 11:03:45 +02:00
Nikolay Sivov 3e2559b98a shell32: Get rid of original variant used to create a Folder.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-28 11:03:42 +02:00
Nikolay Sivov 2ef383c01a shell32: Implement FolderItem::Name() property getter.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-28 11:03:38 +02:00
Nikolay Sivov 876dc3d8fd shell32: Simplify Verbs() method.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-27 10:20:16 +02:00
Nikolay Sivov c14c2ebfb7 shell32: Fix IEnumIDList::Next() called for multiple items.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-27 10:20:15 +02:00
Nikolay Sivov d484650b6d shell32: Implement ParseName() using shellfolder API.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-27 10:20:13 +02:00
Nikolay Sivov 2406d6cd84 shell32: System shellfolders don't support GetDefaultSearchGUID() in recent versions.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-27 10:20:11 +02:00
Nikolay Sivov babd22b443 shell32: System shellfolders don't implement GetDefaultColumn().
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-27 10:20:09 +02:00
Alex Henrie 67826491a6 shell32: Implement ShellExec_RunDLL.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-27 09:29:54 +02:00
Nikolay Sivov 76d46fa323 shell32: Silence fixme for tested case.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-26 21:24:08 +02:00
Nikolay Sivov d935fa69d8 shell32: Implement FolderItem attributes properties.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-26 21:24:08 +02:00
Nikolay Sivov 0d87da46a9 shell32: Store simple full path for FolderItem.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-26 21:24:08 +02:00
Nikolay Sivov 7c638b00c7 shell32: Use shellfolder API to construct FolderItems.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-26 21:24:08 +02:00
Vincent Povirk 8a46b9e5d1 shell32: Add support for find data in IShellLink:GetPath.
Signed-off-by: Vincent Povirk <vincent@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-26 08:44:19 +02:00
Vincent Povirk aa37e696cb shell32/tests: Setting a PIDL with no path resets the path.
Signed-off-by: Vincent Povirk <vincent@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-26 08:44:12 +02:00
Vincent Povirk 3615db9a00 shell32: Set shelllink path when setting pidl.
Signed-off-by: Vincent Povirk <vincent@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-26 08:44:06 +02:00
Vincent Povirk 94378704f8 shell32: IShellLink::GetPath returns S_FALSE if there's no path.
Signed-off-by: Vincent Povirk <vincent@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-26 08:43:57 +02:00
Vincent Povirk a796bcaa7f shell32: Support SFGAO_LINK in unix shell namespace.
Signed-off-by: Vincent Povirk <vincent@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-26 08:42:24 +02:00
Nikolay Sivov 709db66f8d shell32: Use regular helper to trace IID, downgrade QI failures to warnings.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-25 23:29:11 +02:00
Fabian Maurer 4ef3ffd69d shell32/tests: Fix typo.
Signed-off-by: Fabian Maurer <dark.shadow4@web.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-25 23:29:11 +02:00
Nikolay Sivov f23edde42c shell32: Partially implement MapColumnToSCID().
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-25 22:21:42 +02:00
Nikolay Sivov ec42839cd6 shell32: Implement Title property using shellfolder API.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-20 19:03:40 +02:00
Nikolay Sivov 3014fb1617 shell32: Added remaining Application() properties.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-18 09:58:43 +02:00
Nikolay Sivov 58b73fa075 shell32: Implement Parent() property for ShellDispatch objects.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-18 09:58:39 +02:00
Nikolay Sivov a1f7339137 shell32: Implement Application property for FolderItem.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-15 17:00:54 +02:00
Nikolay Sivov 03cdddc08c shell32/tests: Remove workarounds that are no longer relevant.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-15 17:00:54 +02:00
Nikolay Sivov a05d2b76b9 shell32: Implement Application() property for Folder and FolderItems.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-13 17:25:48 +02:00
Alex Henrie aac8d46c21 shell32: Implement FolderItems_get_Count.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-12 20:32:03 +02:00
Alex Henrie 93dd50666f shell32: Implement FolderItems_Item.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-12 20:32:02 +02:00
Alex Henrie 02efd35ce2 shell32/tests: Add tests for FolderItems_Item and FolderItems_get_Count.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-12 20:32:02 +02:00
Vincent Povirk fcd7d4404a shell32: Stub SHOpenWithDialog.
Signed-off-by: Vincent Povirk <vincent@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-12 10:27:43 +02:00
Fabian Maurer 755f49d7c4 shell32: Draw text on message boxes without background.
Signed-off-by: Fabian Maurer <dark.shadow4@web.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-05 10:04:06 +02:00
Alexandre Julliard feac70c1cf shell32: Avoid zeroing a buffer that will get overwritten.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-28 20:21:37 +02:00
Vincent Povirk dcb1359b5e shell32: Change default ProgramData folder and set ProfileList key.
Signed-off-by: Vincent Povirk <vincent@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-24 14:08:18 +09:00
Jactry Zeng d71bc1503b shell32/tests: Add more tests for SHGetKnownFolderIDList.
Signed-off-by: Jactry Zeng <jzeng@codeweavers.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-16 11:05:06 +09:00
Jactry Zeng 5451c7d04f shell32: Implement SHCreateItemInKnownFolder.
Signed-off-by: Jactry Zeng <jzeng@codeweavers.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-16 11:04:59 +09:00
Jactry Zeng 6048090275 shell32: Implement SHCreateItemFromRelativeName.
Signed-off-by: Jactry Zeng <jzeng@codeweavers.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-16 11:04:49 +09:00
Mark Jansen 32520439e1 shell32: Prevent a possible null pointer dereference in SHGetFileInfoW.
Signed-off-by: Mark Jansen <mark.jansen@reactos.org>
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-19 19:13:31 +02:00
Alistair Leslie-Hughes 771d3514e9 shell32/tests: Use standard wine_dbgstr_longlong.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-05 09:18:35 +02:00
Nikolay Sivov 8499ace1ff shell32: Use IS_INTRESOURCE() to test context menu verb kind.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-09 09:18:42 +02:00
Andrey Gusev 8ea9c33829 shell32: Add IApplicationDestinations stub.
Signed-off-by: Andrey Gusev <andrey.goosev@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-08 19:22:18 +02:00
Nikolay Sivov 1a5561c0cf shell32: Avoid zero length allocations when converting path in ExtractIconA() (Valgrind).
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-05 11:07:54 +02:00
Nikolay Sivov 4270c08cd7 shell32/tests: Remove null check after dereference (Coverity).
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-24 15:30:23 +02:00
Akihiro Sagawa 255fd46eeb shell32: Avoid using isspace() for WCHARs.
Found with Coccinelle.

Signed-off-by: Akihiro Sagawa <sagawa.aki@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-17 16:11:19 +02:00
Huw Davies a7d79fe445 shell32: Load icons with the correct size.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-02 17:51:29 +02:00
Huw Davies b8bf0c2628 shell32: Simplify imagelist handling.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-02 17:51:27 +02:00
Huw Davies 3a1b289d66 shell32: Fix the icon sizes of the shell imagelists.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-02 17:51:25 +02:00
Nikolay Sivov 627630c262 shell32/shellview: Respond to special interface id CDefView.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-01 10:06:26 +02:00
Nikolay Sivov a528ddd745 shell32/shellview: Handle NULL folder pointer in SHCreateShellFolderViewEx().
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-01 10:06:21 +02:00
Nikolay Sivov 7a49da5070 shell32/shellview: Set provided callback in SHCreateShellFolderView().
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-01 10:06:18 +02:00
Nikolay Sivov 8ce45458fb shell32/tests: Don't trace all messages sent to listview.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-01 10:06:13 +02:00
Nikolay Sivov 4478e61d16 shell32: Move SHCreateShellFolderView/SHCreateShellFolderViewEx and tests to corresponding files.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-01 10:05:54 +02:00
Huw Davies 826871ba95 shell32: Release the returned imagelist.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-25 11:47:20 +02:00
Huw Davies 6751e57e0b shell32: Remove an extraneous '@'.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-24 19:19:05 +02:00
Nikolay Sivov 5badc91a0f shell32/ebrowser: Respond to IOleWindow from IExplorerBrowser.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-24 15:29:20 +02:00
Nikolay Sivov f74e1b1fb1 shell32: Fix string leak.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-24 10:02:13 +02:00
Huw Davies adc439b1a9 shell32/tests: Add tests for the size of the icon returned by SHGetFileInfo().
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-21 10:53:44 +02:00
Huw Davies c4155c523d shell32: Take a reference on the imagelist returned with SHGFI_SYSICONINDEX.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-21 10:53:31 +02:00
Huw Davies 5f0d1a006b shell32: Don't copy the imagelist in SHGetImageList().
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-21 10:53:05 +02:00
Huw Davies 9072dbd2f2 shell32/tests: Add a test for the size of the icon returned by ExtractIcons().
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-21 10:52:55 +02:00
Huw Davies a33c958ee2 shell32: Use a MENUEX resource for the context menu.
This ensures the submenus can be given ids below FCIDM_SHVIEWLAST and
so don't get stripped out by SHELL_MergeMenus().

Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-19 20:02:52 +02:00
Huw Davies 734dc8f200 shell32: Use the imagelist to determine the icon size.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-19 14:20:49 +02:00
Huw Davies 524e316a14 shell32: Avoid leaking icon handles.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-19 14:20:48 +02:00
Huw Davies a2eb5999cb shell32/tests: Ignore the compressed attribute.
The Vista64 testbot VM reports its storage as compressed when run as a stand-alone job,
but not during a winetest run.

Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-17 13:19:21 +01:00
Huw Davies aef764d37c shell32/tests: Return early if the shell folder creation fails in order to avoid a compiler warning.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-17 13:19:18 +01:00
Nikolay Sivov f2499d20d4 shell32: Implement SHGetPropertyStoreFromParsingName() as a wrapper over IShellItem2.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-27 16:24:55 +01:00
Jacek Caban d9fc7d271c shell32: Added SHGetPathFromIDListEx implementation.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-23 20:12:41 +01:00
André Hentschel 995a27472e shell32: Fix some more spec file entries.
Signed-off-by: André Hentschel <nerv@dawncrow.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-23 13:15:44 +01:00
Michael Stefaniuc f20fa69c9b shell32/tests: Use the correct field for SW_SHOWNORMAL (coccinellery).
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-15 16:33:54 +01:00
Nikolay Sivov 0bfb97dcba shell32: Pass correct buffer length to RegQueryValueExW().
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-08 16:00:39 +01:00
Nikolay Sivov 258c5279df shell32: Implement IShellImageData::Draw().
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-08 10:47:52 +01:00
Nikolay Sivov 5222eca2d5 shell32: Implement IShellImageData::GetSize().
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-08 10:47:50 +01:00
Nikolay Sivov d9d99834f6 shell32: Implement IShellImageData::Decode() when created from file path.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-08 10:47:43 +01:00
Nikolay Sivov f04b66e68f shell32: Added IShellImageData stub.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-08 10:47:37 +01:00
Nikolay Sivov 3f4999cc6a shell32: Added a stub for IShellImageDataFactory.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-06 13:45:09 +01:00
André Hentschel 1c98bc14c9 shell32: Remove dead assignments (clang).
Signed-off-by: André Hentschel <nerv@dawncrow.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-31 08:52:59 +01:00
André Hentschel 1eede2926f shell32: Fix some spec file entries.
Signed-off-by: André Hentschel <nerv@dawncrow.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-27 16:31:42 +01:00
Alex Henrie e42a1d4db2 shell32: Correct dialog title in error message from "Run File" to "Run".
This makes the error message match the title in the SHELL_RUN_DLG
resource definition.

Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-26 19:28:50 +01:00
Nikolay Sivov 8f21b352c2 shell32: Fix return value of GetDetailsOf() for unixfs folder.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-26 10:37:00 +01:00
Nikolay Sivov 2cce196210 shell32/shellview: Set subitem callbacks for every column.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-26 10:36:56 +01:00
Nikolay Sivov a26d6e375e shell32/shellview: Get rid of intermediate pointer array when filling ListView.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-26 10:36:51 +01:00
Marcus Meissner c3e6ecde36 shell32/tests: Fixed CharLowerBuffA size.
Signed-off-by: Marcus Meissner <marcus@jet.franken.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-16 22:02:27 +01:00
Nikolay Sivov dba1a78a20 shell32/tests: Test valid special folder IDs with NameSpace() method.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-10 19:19:16 +01:00
Nikolay Sivov bd42aaa801 shell32/tests: Some tests for ExtractAssociatedIcon().
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-09 12:09:49 +01:00
Nikolay Sivov c1645b6dfd shell32/tests: Some tests for ExtractIcon().
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-09 12:09:47 +01:00
Nikolay Sivov f7cc41d7ae shell32: Fix potential destination buffer overrun.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-12-21 19:13:51 +01:00
Nikolay Sivov 490ffe7f40 shell32: Don't trace output string buffer contents.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-12-21 19:13:49 +01:00
Hans Leidekker a2556760ec shell32/tests: Skip SHFileOperation tests if the user doesn't have admin rights.
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-12-20 13:02:15 +01:00
Hans Leidekker 748f7e26cb shell32/tests: Accept another error from SHFileOperationA.
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-12-20 13:02:10 +01:00
Nikolay Sivov 3c6cbc2f91 shell32: Don't access uninitialized buffer (Coverity).
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-12-14 20:56:13 +01:00
VRan Liu c64cdc1fe6 shell32/tests: Simple test for KF_FLAG_DEFAULT_PATH.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-12-06 18:57:41 +01:00
Nikolay Sivov a0c259cf56 shell32: Move retrieving folder path logic to SHGetKnownFolderPath().
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-12-06 18:57:36 +01:00
Michael Müller 117c0dc5ba shell32: Add IDragSourceHelper stub.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-12-01 12:17:12 +01:00
Nikolay Sivov 8e7a041154 shell32: Simplify drag drop helper object creation.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-12-01 12:17:04 +01:00
Nikolay Sivov 794efcceee shell32: Use standard list for IEnumIDList implementation.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-12-01 12:16:56 +01:00
Nikolay Sivov 252051cb1b shell32: Respect SFGAO_NONENUMERATED attribute for registered shell extensions.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-11-30 13:26:12 +01:00
Huw Davies b670fc2c6d shell32/tests: Updated Windows 7 has a new IShellDispatch6 in its typelib.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-11-30 13:23:34 +01:00
Lauri Kenttä 1c3d6ab9cc shell32: Cosmetic changes to file type names.
Signed-off-by: Lauri Kenttä <lauri.kentta@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-11-29 21:21:31 +01:00
Huw Davies b70821a74d shell32/tests: Add some uuids present on Windows 10.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-11-29 15:11:09 +01:00
Nikolay Sivov 6d89f58ec2 shell32: Added stub implementation of ICustomDestinationList.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-11-29 12:17:30 +01:00
Nikolay Sivov 960b5996fc shell32: Limit displayed volume label length to 32.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-11-28 13:58:10 +01:00
Nikolay Sivov 1c86f97985 shell32: Get rid of some casts by using IShellFolder2 internally.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-11-28 13:56:16 +01:00
Nikolay Sivov e49878289b shell32: Remove a couple more casts of object pointers.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-11-28 13:56:09 +01:00
Nikolay Sivov 5ad123f851 shell32: Use interface pointers instead of a pointer to implementation structure.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-11-23 22:36:41 +01:00
Hans Leidekker 567b52cd93 shell32: Implement IKnownFolderManager::GetFolderByName.
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-11-22 16:32:00 +01:00
Jared Smudde 906e770121 shell32: Add caption to Run dialog.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-11-09 19:15:50 +01:00
Austin English 6c876de7d0 shell32: Add SHCreateSessionKey stub.
Signed-off-by: Austin English <austinenglish@gmail.com>
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-10-19 08:11:55 -07:00
Austin English e18654edac shell32: Add SHRemoveLocalizedName stub.
Signed-off-by: Austin English <austinenglish@gmail.com>
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-10-19 08:11:37 -07:00
Roman Pisl 6d7a32a107 shell32: Implement NIM_SETVERSION.
Signed-off-by: Roman Pisl <rpisl@seznam.cz>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-10-12 09:32:22 +02:00
André Hentschel 410a9832d1 shell32/tests: Mark win10 failure as broken.
Signed-off-by: André Hentschel <nerv@dawncrow.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-10-03 11:54:15 +02:00
Sebastian Lackner f89c3d58df shell32/tests: Fix incorrect usage of broken() function.
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-09-08 20:56:46 +09:00
Sebastian Lackner d3cb5c24a5 shell32: Remove __SHFreeAndNil macro.
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-29 23:54:42 +09:00
Sebastian Lackner af468590f7 shell32: Remove some unused static inline functions.
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-29 23:54:42 +09:00
Nikolay Sivov 91947b35ad shell32: Use interface pointer instead of implementation one.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-26 23:23:39 +09:00
Sebastian Lackner a11fb74ffb shell32: Use the correct memory allocation function in RecycleBin_GetDisplayNameOf.
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-24 12:06:53 +09:00
Nikolay Sivov 79e95afbc3 shell32/tests: Fix indentation warning on GCC 6.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-12 12:31:55 +09:00
Nikolay Sivov 27f91d71a2 shell32/tests: Fix indentation warnings on GCC 6.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-10 12:51:34 +09:00
Piotr Caban f333bf47a8 ntdll: Keep drive letter size in RtlGetFullPathName_U when full path is specified.
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-29 23:12:11 +09:00
Jactry Zeng dad2223ad6 shell32: Use remove() instead of rmdir().
rmdir() will fail when target is a symbolic link.

Signed-off-by: Jactry Zeng <jzeng@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-26 20:40:42 +09:00
Andrey Gusev 954560f847 shell32: Use debugstr_guid() and debugstr_w() in TRACE() messages.
Signed-off-by: Andrey Gusev <andrey.goosev@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-22 21:34:50 +09:00
Alex Henrie a615647435 shell32/tests: Change to temp dir to be able to remove winetest dir.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-20 23:05:52 +09:00
Alex Henrie de37f020a2 shell32/tests: Free winetest BSTR after use.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-20 23:05:49 +09:00
Alex Henrie a711285137 shell32: Set output interfaces to NULL in FolderItems functions.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-19 22:33:53 +09:00
Alex Henrie 970de7df99 shell32: Return E_INVALIDARG from FolderItems functions on null output.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-19 22:33:48 +09:00
Alex Henrie ddf76f6a66 shell32/tests: Add tests for FolderItems.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-19 22:33:37 +09:00
Alex Henrie 1ed5773843 shell32: Stub out FolderItems.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-19 22:32:41 +09:00
Alex Henrie ebf480c430 shell32: Print RIIDs as strings in shell dispatch TRACE statements.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-19 22:29:24 +09:00
Austin English ebfe169c43 shell32: Add SHGetPropertyStoreForWindow stub.
Signed-off-by: Austin English <austinenglish@gmail.com>
Signed-off-by: Andrew Eikum <aeikum@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-19 22:05:18 +09:00
Michael Stefaniuc afe0ba175c shell32/tests: Remove redundant NULL checks before CoTaskMemFree().
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-08 20:12:48 +09:00
Michael Müller b05aa34f63 shell32: Correctly compare result of SHFileOperation in UNIXFS copy/delete functions.
Signed-off-by: Michael Müller <michael@fds-team.de>
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-04 17:31:01 +09:00
Michael Stefaniuc df63e1a169 shell32/tests: Avoid casts from a COM object to an iface.
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-03 10:20:34 +09:00
Michael Stefaniuc ee3deec635 shell32: Avoid using CopyRect().
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-06-22 22:16:35 +09:00
Francois Gouget 8e548c41c1 shell32/tests: Spelling fix.
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-06-13 11:34:14 +09:00
Theodore Dubois 7c915af47e shell32: Avoid closing the caller's key.
Signed-off-by: Theodore Dubois <tblodt@icloud.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-06-08 13:18:21 +09:00
Theodore Dubois 2a7c4ea875 shell32/tests: Fix memory leaks.
Signed-off-by: Theodore Dubois <tblodt@icloud.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-06-08 13:17:45 +09:00
Theodore Dubois fbbac88519 shell32/tests: Fix out of memory errors and their underlying cause.
The out of memory errors were happening because getstring_test was using
len unitialized when GetString failed. The underlying cause was that
deleting the keys would fail because RegDeleteKey does not work if the
key has subkeys, and one of the keys has a subkey. The test fails when
the keys are still there. The subkey is now deleted before the key that
contains it.

Signed-off-by: Theodore Dubois <tblodt@icloud.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-06-08 13:17:42 +09:00
Michael Stefaniuc 33f145acc3 shell32/tests: Use wine_dbgstr_rect() to print RECTs.
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-06-07 17:08:30 +09:00
Nikolay Sivov 784a74c933 include: Added missing ASSOCF enum members.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-06-01 13:34:11 +09:00
Francois Gouget cc2a2b0970 shell32: Spelling fixes.
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-30 11:55:57 +09:00
Andrey Gusev 7f64817e5e shell32: Fix a typo in TRACE format in SHPathPrepareForWriteW.
Signed-off-by: Andrey Gusev <andrey.goosev@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-23 17:35:54 +09:00
Olivier F. R. Dierick 07156ad007 shell32/tests: Tests for broken apps that check GetLastError() after SHFileOperation().
Signed-off-by: Olivier F. R. Dierick <o.dierick@piezo-forte.be>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-02 20:11:49 +09:00
Olivier F. R. Dierick 9f202b7804 shell32: Set last error explicitly in SHFileOperation().
Signed-off-by: Olivier F. R. Dierick <o.dierick@piezo-forte.be>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-02 20:11:49 +09:00