Hugh McMaster
3fd57fd995
reg/tests: Add tests for forward and back slashes in key and value names.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-02-22 14:42:07 +01:00
Hugh McMaster
6c62ffeca7
reg/tests: Add additional tests with embedded NUL characters.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-02-22 09:22:55 +01:00
Hugh McMaster
93fbe09ed0
reg/tests: Replace RegCloseKey() with the helper function close_key().
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-02-22 09:22:53 +01:00
Hugh McMaster
5cacd496a1
reg/tests: Verify registry export after each empty key test.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-02-22 09:22:51 +01:00
Hugh McMaster
b51b969a01
reg/tests: Always overwrite export test file during 'export' sequence.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-02-22 09:22:49 +01:00
Hugh McMaster
597a12420b
reg/tests: Check for key non-existence with verify_key_nonexist().
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-02-22 09:22:47 +01:00
Hugh McMaster
e6e227f21d
reg/tests: Move /v* syntax tests to the 'add' and 'delete' test sequences.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-02-22 09:22:45 +01:00
Hugh McMaster
405853adb5
reg/tests: Ensure test key is fully removed before each sequence begins.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-02-22 09:22:43 +01:00
Hugh McMaster
add814af3e
reg/tests: Check for elevated privileges before cleaning up the Windows 3.1 test key and running unit tests.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-02-22 09:22:40 +01:00
Jacek Caban
9e97f3513e
conhost: Avoid assumption about the exact Unix cursor position after writing to the last column.
...
Spotted by Roman Pišl.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50581
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-02-16 23:01:38 +01:00
Rémi Bernon
f5ca06016d
plugplay: Broadcast WM_DEVICECHANGE message asynchronously.
...
It may otherwise trigger a nasty race condition, where:
1) For explorer.exe to register the CLSID_ShellWindows classes, it
needs RpcSS service to be started,
2) services.exe may start WinePlugPlay service group first, waiting for
its startup to complete,
3) during startup and early device enumeration, hidclass.sys may call
IoSetDeviceInterfaceState, which calls plugplay_send_event [1],
4) plugplay_send_event tries to broadcast a WM_DEVICECHANGE message with
BSF_QUERY, waiting for the individual threads to reply,
5) which times-out because window threads are waiting on explorer.exe
to create its desktop window and reply to the WM_NULL SendMessage.
This happens more likely as there is threads with message queues
being started, each waiting on the desktop window to reply. Usually
explorer.exe is able to reply to some messages with the implicit
message processing while creating its window, but not all of them.
[1] Not completely sure how, it looks like some RPC too, but before
RpcSs is started?
Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-02-16 23:01:38 +01:00
Roman Pišl
2d6b0b67d9
cmd: Fix handling of brackets in if-set expressions on a single line.
...
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50642
Signed-off-by: Roman Pišl <rpisl@seznam.cz>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-02-10 20:07:24 +01:00
Roman Pišl
6809e0599e
cmd: Fix handling of nested if-for expressions on a single line.
...
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50641
Signed-off-by: Roman Pišl <rpisl@seznam.cz>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-02-10 20:07:00 +01:00
Hugh McMaster
6cf0e7fe85
reg/tests: Add initial syntax tests for 'reg copy'.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-02-09 21:17:05 +01:00
Rémi Bernon
da3be6b0b6
ntdll: Print a warning or an error for other exceptions.
...
Depending on EH_NONCONTINUABLE.
Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-02-08 11:04:17 +01:00
Rémi Bernon
6edf3d3b09
ntdll: Print a warning for thread rename exceptions.
...
Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-02-08 11:00:20 +01:00
Roman Pišl
2ca86d3b59
conhost: Improve notification when resizing window.
...
Signed-off-by: Roman Pišl <rpisl@seznam.cz>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-02-03 20:59:55 +01:00
Roman Pišl
361b4c381e
conhost: Fix copy-paste error when setting windows size.
...
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50602
Signed-off-by: Roman Pišl <rpisl@seznam.cz>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-02-01 22:16:47 +01:00
Zebediah Figura
7eca09d7e0
explorer: Send systray messages with SendNotifyMessage().
...
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50441
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-02-01 11:02:02 +01:00
Zebediah Figura
d91a87cea2
include: Fix the definition of NOTIFYICON_VERSION[_4].
...
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-02-01 11:02:00 +01:00
Zebediah Figura
b3d00c3340
wineboot: Set the NXSupportPolicy member of the user shared data to NX_SUPPORT_POLICY_OPTIN.
...
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-01-29 10:17:41 +01:00
Alexandre Julliard
04f0729d94
wordpad: Make qsort callback function cdecl.
...
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-01-18 22:46:36 +01:00
Jacek Caban
105db4c538
conhost: Fix wrapping search in edit_line_find_in_history.
...
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50000
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-01-04 21:48:25 +01:00
Qijia Liu
0201aa3b60
winedbg: Distinguish -0 from 0.
...
According to A8.8.56, A8.8.64 and A8.8.81 of ARM DDI 0406C.d,
0 and -0 generate different instructions.
Manually add "-".
Signed-off-by: Qijia Liu <liumeo@pku.edu.cn>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-01-04 14:11:35 +01:00
Jacek Caban
d7d315ddf4
conhost: Ignore CONTROL_C_EXIT exceptions in Unix mode.
...
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50304
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-12-30 11:19:16 +01:00
Qijia Liu
c20d49026f
winedbg: Remove arm_disasm_branchreg.
...
According to A8.8.18 of ARM DDI 0406C.d, b instruction only takes
immediate argument.
Signed-off-by: Qijia Liu <liumeo@pku.edu.cn>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-12-29 21:19:31 +01:00
Jacek Caban
3d2b423328
conhost: Fix copy-paste typos in selection coordinates.
...
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50052
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-12-21 21:08:26 +01:00
Jacek Caban
ef876fc54e
conhost: Improve get_output_info debug traces.
...
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-12-16 22:32:13 +01:00
Jacek Caban
9e62d7d257
conhost: Don't create bitmap for hidden windows.
...
Fixes performance issues in ConEmu.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-12-16 22:32:10 +01:00
Jacek Caban
8a47ef28ca
conhost: Use QS_ALLINPUT to wait for input in main loop.
...
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50014
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-12-08 12:34:48 +01:00
Jacek Caban
14b50ee1b8
conhost: Fix handling selection boundaries in copy_selection.
...
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50052
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-12-08 12:34:43 +01:00
Arkadiusz Hiler
743c266e64
plugplay: Send WM_DEVICECHANGE with DBT_DEVNODES_CHANGED with each event.
...
Windows sends *a lot* of those messages whenever there's a device / drive /
etc. appearing or disappearing.
This fixes controller hotplug in Doom (2016).
Signed-off-by: Arkadiusz Hiler <ahiler@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-12-04 21:23:27 +01:00
Alexandre Julliard
2e115ab442
Revert "winecrt0: Make the main() and wmain() entry points cdecl."
...
This reverts commit f2a7405a09
.
We now have separate entry points for msvcrt builds.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-12-04 11:01:41 +01:00
Michael Stefaniuc
24ac30d2a0
regsvr32: Use a string literal for an empty string.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-12-03 10:25:26 +01:00
Jacek Caban
90cdea1b65
conhost: Allow events with left alt pressed in edit_line_insert.
...
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50197
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-12-02 19:08:04 +01:00
Gabriel Ivăncescu
7b2b4e0329
conhost: Respect the StartupInfo's wShowWindow.
...
Since 859b526c81
, console windows are always
shown even if they're supposed to start in some other state, e.g. minimized.
Signed-off-by: Gabriel Ivăncescu <gabrielopcode@gmail.com>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-12-02 19:08:04 +01:00
Francois Gouget
fe719e16a4
fsutils/tests: Fsutils requires elevated privileges on Windows <= 7.
...
So skip the tests if the first fsutils run fails and we don't have
elevated privileges.
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-12-02 19:08:04 +01:00
Alexandre Julliard
6ca76dc5e7
include: Remove some no longer used Unicode functions.
...
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-12-02 15:38:25 +01:00
Jacek Caban
2ecb871310
cmd: Don't use WCMD_is_console_handle.
...
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-12-01 19:50:20 +01:00
Michael Stefaniuc
40ce3c5b60
cmd: Use wide-char string literals.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-11-30 21:36:12 +01:00
Michael Stefaniuc
a158bf7e9c
cmd: Use wide-char string literals in builtins.c.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-11-30 21:36:12 +01:00
Michael Stefaniuc
9fcb2b097c
cmd: Inline some simple extern WCHAR strings.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-11-30 21:36:12 +01:00
Michael Stefaniuc
77fc01d39d
cmd: Avoid casting a const away.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-11-30 21:36:12 +01:00
Alexandre Julliard
981d69ada6
winemenubuilder: Silence out of bounds compiler warning.
...
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-11-26 23:25:38 +01:00
Brendan Shanks
a688cb6971
winebrowser: Prefix an invalid URL with 'http://' before opening with a browser.
...
Fixes usage like 'winebrowser winehq.org' when xdg-open or macOS 'open' is used.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50094
Signed-off-by: Brendan Shanks <bshanks@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-11-25 10:18:29 +01:00
Jacek Caban
dfe1bb7b8d
conhost: Signal console in process_console_input if needed.
...
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50037
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-11-24 20:20:38 +01:00
Jacek Caban
a66eab0dfb
kernelbase: Move Unicode conversion from ReadConsoleA to conhost.
...
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-11-19 21:44:55 +01:00
Jacek Caban
ee77a96dae
conhost/tests: Add more ReadConsoleA tests.
...
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-11-19 21:24:18 +01:00
Damjan Jovanovic
abe848f05f
cmd.exe: Increase size of WCMD_HandleTildeModifiers() buffers to MAXSTRING.
...
Some buffers in WCMD_HandleTildeModifiers() are only of size MAX_PATH,
even though they handle strings that aren't necessarily
filenames. When changed to have size MAXSTRING, a stack overflow crash
with strings of size MAX_PATH stops happening.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=42731
Signed-off-by: Damjan Jovanovic <damjan.jov@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-11-17 21:16:43 +01:00
Jacek Caban
4cc4ea449b
kernelbase: Move Unicode conversion from WriteConsoleA to conhost.
...
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-11-17 19:36:06 +01:00