Commit Graph

2520 Commits

Author SHA1 Message Date
Huw Davies e0843d234e user32: Fix a potential buffer overflow.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-21 16:10:04 +02:00
Nikolay Sivov 3c7fee39d3 user32: Partially protect WM_SETTEXT handlers from invalid input.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-20 18:58:46 +02:00
Piotr Caban f7402accc4 user32/tests: Add layered window child painting test when WS_CLIPCHILDREN flag is specified.
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-19 20:02:55 +02:00
Piotr Caban 34b108dd1d user32: Switch to normal window drawing on SetLayeredWindowAttributes call.
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-19 20:02:55 +02:00
Michael Stefaniuc 79147c8658 user32: Use SetRectEmpty() instead of memset().
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-19 09:11:46 +02:00
Huw Davies e352b29d12 user32/tests: Fix tests for minimium icon spacing when not in DPI scaling mode.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-11 16:00:39 +02:00
Huw Davies bfcf92f148 user32/tests: Fix a few failures in DPI scaling mode.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-11 16:00:37 +02:00
Huw Davies 0ce293a0d8 user32/tests: Correctly restore the caption sizes when run in DPI scaling mode.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-11 16:00:35 +02:00
Huw Davies 962d5e6469 user32: Don't bother drawing an item if it's outside the items_rect.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-31 14:03:50 +02:00
Huw Davies 21c5545a97 user32: Simplify the use of rectangles.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-31 14:03:44 +02:00
Huw Davies 66d3c80de0 user32: Pass a POPUPMENU ptr to MENU_DrawMenuItem().
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-31 14:03:32 +02:00
Huw Davies e42bcbdea3 user32: Remove the height parameter from MENU_DrawMenuItem().
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-31 14:03:23 +02:00
Huw Davies 3c0ddd5971 user32: Limit the menu height to that of the work area.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-30 22:06:33 +02:00
Huw Davies 1d4992282d user32: Disable scrolling for multi-column menus.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-30 22:06:33 +02:00
Huw Davies d4544f7fed user32: Don't finish tracking when the menu borders or scroll arrows are clicked.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-30 22:06:33 +02:00
Huw Davies 6abb7db763 user32: Scale the scroll arrows with the menu's font size.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-29 17:17:15 +02:00
Huw Davies bd785a5ac0 user32: Don't fill the background when drawing the scroll arrows.
This is done, in the correct colour, in MENU_DrawPopupMenu().

Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-29 17:17:15 +02:00
Huw Davies 79bdeceab4 user32: Clip painting to the items_rect.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-29 17:17:15 +02:00
Huw Davies 1bdd12f493 user32: Store the item rects as relative to the items_rect.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-29 17:17:14 +02:00
Zebediah Figura 0ac74d180a user32: Always send WM_CANCELMODE when disabling a window.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-29 10:20:54 +02:00
Zebediah Figura b4fea4f2f0 user32: Don't call ReleaseCapture() in EnableWindow().
Killing the capture is already handled in DefWindowProc().

Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-29 10:11:55 +02:00
Zebediah Figura 3d133becce user32/tests: Add tests for EnableWindow().
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-29 10:09:46 +02:00
Huw Davies bdcaae4b78 user32: Add an items rect to the header and use it to fix scrolling down.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-28 22:13:14 +02:00
Huw Davies d4d0247f4e user32: Simplify GetMenuItemRect().
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-28 22:12:45 +02:00
Huw Davies c72a7219fd user32: Add a helper to retrieve the height of the scroll arrows.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-28 22:12:16 +02:00
Huw Davies a8344b9616 user32: Rationalize the popup menu margin calculation.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-28 22:11:33 +02:00
Huw Davies 0a36078ee1 user32: Explicitly set last error to ERROR_SUCCESS.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-27 16:54:53 +02:00
Piotr Caban a878f0a02a user32: Don't call IsChild with NULL window in EnableWindow.
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-21 20:52:38 +01:00
Alexandre Julliard 413e27eff1 user32/tests: Re-enable a test about window positions.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-13 19:34:51 +01:00
André Hentschel b05c000c91 user32: Fix some spec file entries.
Signed-off-by: André Hentschel <nerv@dawncrow.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-27 10:16:24 +01:00
Alex Henrie 0a2f9f54eb user32: Include space for ampersands when determining MessageBox size.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-24 09:44:31 +01:00
Alex Henrie 2799be1804 user32: Translate WM_(NC)XBUTTONUP to WM_APPCOMMAND in DefWindowProc.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-23 20:14:15 +01:00
Fabian Maurer d594ba3322 user32: Only send position-change messages when needed.
Signed-off-by: Fabian Maurer <dark.shadow4@web.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-20 10:43:15 +01:00
Fabian Maurer 997d4ef44f user32: Send WM_NCPAINT and WM_ERASEBKGND when window is shown.
Signed-off-by: Fabian Maurer <dark.shadow4@web.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-20 10:42:37 +01:00
Francois Gouget a3f36a045f user32/tests: Occasional spelling fixes in comments.
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-20 10:32:09 +01:00
Rodrigo Rivas Costa fbd9ed0dee user32: Fix error handling in EndDeferWindowPos.
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-17 20:53:53 +01:00
Sebastian Lackner 6f62f9614d user32/tests: Add test for EndDeferWindowPos with destroyed window.
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-17 13:54:00 +01:00
Fabian Maurer 43b0dce203 user32/tests: Add tests for disabled buttons receiving WM_LBUTTONUP.
Signed-off-by: Fabian Maurer <dark.shadow4@web.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-16 21:39:28 +01:00
Fabian Maurer eba9294d9e user32/tests: Add WM_NCPAINT tests for windows crossing screen or maximized.
Signed-off-by: Fabian Maurer <dark.shadow4@web.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-13 21:45:27 +01:00
Fabian Maurer 372e3e223a user32/tests: Add tests for windows when first shown if they have children.
Signed-off-by: Fabian Maurer <dark.shadow4@web.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-13 21:45:27 +01:00
Fabian Maurer ea6dbfcd07 user32/tests: Add tests for windows when first shown with SetWindowPos.
Signed-off-by: Fabian Maurer <dark.shadow4@web.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-13 21:45:27 +01:00
Fabian Maurer 46b344fc2f user32/tests: Add tests for windows when first shown with WS_VISIBLE or RedrawWindow.
Signed-off-by: Fabian Maurer <dark.shadow4@web.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-13 21:45:26 +01:00
Jacek Caban af4294a9af user32: Allow creating windows using null driver for invisible winstations.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-09 16:07:41 +01:00
Dmitry Timoshkov d639d3bba0 user32: Fix groupbox rectangle calculation in the button's WM_SETTEXT handler.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-07 17:24:36 +01:00
Dmitry Timoshkov e45b80088b user32: BUTTON_CalcLabelRect should use the button font.
Otherwise WM_SETTEXT handler gets wrong rectangle to erase an old text.

Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-07 17:24:33 +01:00
Nikolay Sivov a423f14a56 user32/tests: Test to show that original font is not selected back after painting buttons.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-07 17:24:31 +01:00
Huw Davies 01112061c2 user32/tests: Restore the mouse cursor to its original position.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-07 14:45:58 +01:00
Fabian Maurer 115bbf424c user32: Don't send WM_CHAR when a menu gets VK_ESCAPE and add tests.
Signed-off-by: Fabian Maurer <dark.shadow4@web.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-03 19:05:09 +01:00
Huw Davies cdf3872f59 user32/tests: Restore the mouse cursor to its original position.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-02 19:50:34 +01:00
Huw Davies e883d0ec60 user32: Hardcode the GetWindowLong values for the desktop window to avoid a server round-trip.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-02 19:50:34 +01:00