c7ae2d5d22
explorer: Only try to destroy the IShellWindows object if it exists.
...
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52494
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
(cherry picked from commit adda27cdb8
2022-03-31 22:32:25 +02:00
3bff9ccfa4
cmd: Don't crash on 'if exist' without parameter.
...
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51598
Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
(cherry picked from commit 535da77552
2022-03-16 22:47:28 +01:00
6e7f753c15
conhost: Process Ctrl-M key input.
...
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50526
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
(cherry picked from commit 12cf3459b5
2022-03-15 23:23:53 +01:00
b00bd9b9ee
winedbg: Fix command line arguments parsing.
...
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=42030
Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
(cherry picked from commit 9808c1d8a3
2022-02-25 23:51:50 +01:00
d2392af664
attrib: Avoid crash when called without parameter.
...
If attrib is called without any parameter the variable originalname
is used uninitialized.
Signed-off-by: Bernhard Übelacker <bernhardu@mailbox.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
(cherry picked from commit 5ec1524326
2021-11-24 00:34:41 +01:00
26c739a4fe
winedbg: Fix crash when no process attached in 'info wnd' command.
...
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=49625
Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
(cherry picked from commit 5d8bad570d
2021-11-22 23:11:51 +01:00
675908b29c
services: Check correct permission for QueryServiceConfig2W.
...
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50412
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
(cherry picked from commit 4a18232e45
2021-11-22 22:15:02 +01:00
bc6346ba85
cmd: Do not change errorlevel when setting environment variables.
...
Changes CMD to set its errorlevel to 0 only when the value of an environment variable
is set in in non-interactive / batch mode, retains the previous value otherwise.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=47791
Signed-off-by: Florian Eder <others.meder@gmail.com>
Signed-off-by: Zebediah Figura <zfigura@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
(cherry picked from commit 617d14bc12
2021-10-27 21:40:02 +02:00
e2e053ea57
winecfg: Disable virtual desktop when using macdrv.
...
Signed-off-by: Gijs Vermeulen <gijsvrm@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
(cherry picked from commit e2db7ef7f4
2021-10-18 20:32:59 +02:00
4f9701317b
explorer: Store the graphics driver basename instead of the full path.
...
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
(cherry picked from commit d47be63fae
2021-10-18 20:32:59 +02:00
ea2a235727
start: Avoid duplicate backslashes in command line.
...
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
(cherry picked from commit 1b4b4a9bb5
2021-05-18 00:24:26 +02:00
7515889470
winedbg: Don't dereference possibly NULL thread pointer.
...
Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
(cherry picked from commit 6eff0342ad
2021-05-18 00:24:26 +02:00
8d2e4ee83a
wmic: Add missing aliases.
...
Signed-off-by: Chao Long <longchao@uniontech.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
(cherry picked from commit 7dba53a0f2
2021-05-18 00:24:26 +02:00
196f033dec
plugplay: Broadcast WM_DEVICECHANGE message asynchronously.
...
It may otherwise trigger a nasty race condition, where:
1) For explorer.exe to register the CLSID_ShellWindows classes, it
needs RpcSS service to be started,
2) services.exe may start WinePlugPlay service group first, waiting for
its startup to complete,
3) during startup and early device enumeration, hidclass.sys may call
IoSetDeviceInterfaceState, which calls plugplay_send_event [1],
4) plugplay_send_event tries to broadcast a WM_DEVICECHANGE message with
BSF_QUERY, waiting for the individual threads to reply,
5) which times-out because window threads are waiting on explorer.exe
to create its desktop window and reply to the WM_NULL SendMessage.
This happens more likely as there is threads with message queues
being started, each waiting on the desktop window to reply. Usually
explorer.exe is able to reply to some messages with the implicit
message processing while creating its window, but not all of them.
[1] Not completely sure how, it looks like some RPC too, but before
RpcSs is started?
Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
(cherry picked from commit f5ca06016d
2021-05-18 00:24:26 +02:00
4f24daba64
explorer: Send systray messages with SendNotifyMessage().
...
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50441
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
(cherry picked from commit 7eca09d7e0
2021-05-18 00:24:26 +02:00
9433c600f9
sc: Fix typos in CLI arguments parsing.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
(cherry picked from commit d3ddc11864
2021-05-18 00:24:26 +02:00
780b202907
cmd: Fix handling of brackets in if-set expressions on a single line.
...
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50642
Signed-off-by: Roman Pišl <rpisl@seznam.cz>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
(cherry picked from commit 2d6b0b67d9
2021-05-18 00:24:26 +02:00
907c5a2135
cmd: Fix handling of nested if-for expressions on a single line.
...
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50641
Signed-off-by: Roman Pišl <rpisl@seznam.cz>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
(cherry picked from commit 6809e0599e
2021-05-18 00:24:26 +02:00
a4ac7faab9
conhost: Avoid assumption about the exact Unix cursor position after writing to the last column.
...
Spotted by Roman Pišl.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50581
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
(cherry picked from commit 9e97f3513e
2021-05-18 00:24:26 +02:00
88a189f964
conhost: Improve notification when resizing window.
...
Signed-off-by: Roman Pišl <rpisl@seznam.cz>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
(cherry picked from commit 2ca86d3b59
2021-05-18 00:24:25 +02:00
9dff1027d5
conhost: Fix copy-paste error when setting windows size.
...
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50602
Signed-off-by: Roman Pišl <rpisl@seznam.cz>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
(cherry picked from commit 361b4c381e
2021-05-18 00:24:25 +02:00
105db4c538
conhost: Fix wrapping search in edit_line_find_in_history.
...
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50000
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-01-04 21:48:25 +01:00
0201aa3b60
winedbg: Distinguish -0 from 0.
...
According to A8.8.56, A8.8.64 and A8.8.81 of ARM DDI 0406C.d,
0 and -0 generate different instructions.
Manually add "-".
Signed-off-by: Qijia Liu <liumeo@pku.edu.cn>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-01-04 14:11:35 +01:00
d7d315ddf4
conhost: Ignore CONTROL_C_EXIT exceptions in Unix mode.
...
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50304
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-12-30 11:19:16 +01:00
c20d49026f
winedbg: Remove arm_disasm_branchreg.
...
According to A8.8.18 of ARM DDI 0406C.d, b instruction only takes
immediate argument.
Signed-off-by: Qijia Liu <liumeo@pku.edu.cn>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-12-29 21:19:31 +01:00
3d2b423328
conhost: Fix copy-paste typos in selection coordinates.
...
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50052
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-12-21 21:08:26 +01:00
ef876fc54e
conhost: Improve get_output_info debug traces.
...
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-12-16 22:32:13 +01:00
9e62d7d257
conhost: Don't create bitmap for hidden windows.
...
Fixes performance issues in ConEmu.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-12-16 22:32:10 +01:00
8a47ef28ca
conhost: Use QS_ALLINPUT to wait for input in main loop.
...
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50014
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-12-08 12:34:48 +01:00
14b50ee1b8
conhost: Fix handling selection boundaries in copy_selection.
...
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50052
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-12-08 12:34:43 +01:00
743c266e64
plugplay: Send WM_DEVICECHANGE with DBT_DEVNODES_CHANGED with each event.
...
Windows sends *a lot* of those messages whenever there's a device / drive /
etc. appearing or disappearing.
This fixes controller hotplug in Doom (2016).
Signed-off-by: Arkadiusz Hiler <ahiler@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-12-04 21:23:27 +01:00
2e115ab442
Revert "winecrt0: Make the main() and wmain() entry points cdecl."
...
This reverts commit f2a7405a09
2020-12-04 11:01:41 +01:00
24ac30d2a0
regsvr32: Use a string literal for an empty string.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-12-03 10:25:26 +01:00
90cdea1b65
conhost: Allow events with left alt pressed in edit_line_insert.
...
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50197
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-12-02 19:08:04 +01:00
7b2b4e0329
conhost: Respect the StartupInfo's wShowWindow.
...
Since 859b526c81
2020-12-02 19:08:04 +01:00
fe719e16a4
fsutils/tests: Fsutils requires elevated privileges on Windows <= 7.
...
So skip the tests if the first fsutils run fails and we don't have
elevated privileges.
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-12-02 19:08:04 +01:00
6ca76dc5e7
include: Remove some no longer used Unicode functions.
...
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-12-02 15:38:25 +01:00
2ecb871310
cmd: Don't use WCMD_is_console_handle.
...
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-12-01 19:50:20 +01:00
40ce3c5b60
cmd: Use wide-char string literals.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-11-30 21:36:12 +01:00
a158bf7e9c
cmd: Use wide-char string literals in builtins.c.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-11-30 21:36:12 +01:00
9fcb2b097c
cmd: Inline some simple extern WCHAR strings.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-11-30 21:36:12 +01:00
77fc01d39d
cmd: Avoid casting a const away.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-11-30 21:36:12 +01:00
981d69ada6
winemenubuilder: Silence out of bounds compiler warning.
...
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-11-26 23:25:38 +01:00
a688cb6971
winebrowser: Prefix an invalid URL with 'http://' before opening with a browser.
...
Fixes usage like 'winebrowser winehq.org' when xdg-open or macOS 'open' is used.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50094
Signed-off-by: Brendan Shanks <bshanks@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-11-25 10:18:29 +01:00
dfe1bb7b8d
conhost: Signal console in process_console_input if needed.
...
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50037
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-11-24 20:20:38 +01:00
a66eab0dfb
kernelbase: Move Unicode conversion from ReadConsoleA to conhost.
...
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-11-19 21:44:55 +01:00
ee77a96dae
conhost/tests: Add more ReadConsoleA tests.
...
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-11-19 21:24:18 +01:00
abe848f05f
cmd.exe: Increase size of WCMD_HandleTildeModifiers() buffers to MAXSTRING.
...
Some buffers in WCMD_HandleTildeModifiers() are only of size MAX_PATH,
even though they handle strings that aren't necessarily
filenames. When changed to have size MAXSTRING, a stack overflow crash
with strings of size MAX_PATH stops happening.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=42731
Signed-off-by: Damjan Jovanovic <damjan.jov@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-11-17 21:16:43 +01:00
4cc4ea449b
kernelbase: Move Unicode conversion from WriteConsoleA to conhost.
...
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-11-17 19:36:06 +01:00
d53577ef75
oleview: Inline WCHAR strings of length 1.
...
Merge some of those strings.
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-11-17 09:55:42 +01:00
Alex Henrie