ReceiveTempSMS
/
Sweden-Number
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

winebus.sys: Remove incorrect Report ID from the bus_sdl HID report descriptor. 

According to "USB Device Class Definition for Human Interface Devices
Firmware Specification Version 1.11" Report ID 0 is reserved and should
not be used.

On top of that if Report ID is used anywhere in the descriptor the
reports are expected to be prepended with an ID and this is not the case
for bus_sdl devices.

It worked only because our current HID parser implementation treats the
Report ID 0 as there would be none.

Signed-off-by: Arkadiusz Hiler <ahiler@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
This commit is contained in:
Arkadiusz Hiler 2021-02-23 15:54:07 +02:00 committed by Alexandre Julliard
parent 4cb6334b1b
commit ee4e33ed9a
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
dlls/winebus.sys/bus_sdl.c
View File

@ -199,7 +199,6 @@ static const BYTE CONTROLLER_TRIGGERS [] = {
static const BYTE HAPTIC_RUMBLE[] = { static const BYTE HAPTIC_RUMBLE[] = {
0x06, 0x00, 0xff, /* USAGE PAGE (vendor-defined) */ 0x06, 0x00, 0xff, /* USAGE PAGE (vendor-defined) */
0x09, 0x01, /* USAGE (1) */ 0x09, 0x01, /* USAGE (1) */
0x85, 0x00, /* REPORT_ID (0) */
/* padding */ /* padding */
0x95, 0x02, /* REPORT_COUNT (2) */ 0x95, 0x02, /* REPORT_COUNT (2) */
0x75, 0x08, /* REPORT_SIZE (8) */ 0x75, 0x08, /* REPORT_SIZE (8) */