From ee4e33ed9acf8a0dc4318d6cb0b5ba6c5cf19c0c Mon Sep 17 00:00:00 2001 From: Arkadiusz Hiler Date: Tue, 23 Feb 2021 15:54:07 +0200 Subject: [PATCH] winebus.sys: Remove incorrect Report ID from the bus_sdl HID report descriptor. According to "USB Device Class Definition for Human Interface Devices Firmware Specification Version 1.11" Report ID 0 is reserved and should not be used. On top of that if Report ID is used anywhere in the descriptor the reports are expected to be prepended with an ID and this is not the case for bus_sdl devices. It worked only because our current HID parser implementation treats the Report ID 0 as there would be none. Signed-off-by: Arkadiusz Hiler Signed-off-by: Alexandre Julliard --- dlls/winebus.sys/bus_sdl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/dlls/winebus.sys/bus_sdl.c b/dlls/winebus.sys/bus_sdl.c index 8f48b44eb95..bf62f448976 100644 --- a/dlls/winebus.sys/bus_sdl.c +++ b/dlls/winebus.sys/bus_sdl.c @@ -199,7 +199,6 @@ static const BYTE CONTROLLER_TRIGGERS [] = { static const BYTE HAPTIC_RUMBLE[] = { 0x06, 0x00, 0xff, /* USAGE PAGE (vendor-defined) */ 0x09, 0x01, /* USAGE (1) */ - 0x85, 0x00, /* REPORT_ID (0) */ /* padding */ 0x95, 0x02, /* REPORT_COUNT (2) */ 0x75, 0x08, /* REPORT_SIZE (8) */