Suggest testing patches in a gentler way.
Encourage people to submit tests with their patches as well.
This commit is contained in:
parent
a4d4652dd1
commit
a713da2fc1
|
@ -206,15 +206,21 @@ code
|
||||||
friend!
|
friend!
|
||||||
</para>
|
</para>
|
||||||
<para>
|
<para>
|
||||||
Save yourself some embarrassment and run your patched code
|
Try to test your patch against more than just your current test
|
||||||
against more than just your current test example. Experience
|
example. Experience will tell you how much effort to apply here.
|
||||||
will tell you how much effort to apply here. If there are
|
If there are any conformance tests for the code you're working on,
|
||||||
any conformance tests for the code you're working on, run them
|
run them and make sure they still pass after your patch is applied.
|
||||||
and make sure they still pass after your patch is applied. Running
|
Running tests can be done by running <command>make test</command>.
|
||||||
tests can be done by running <command>make test</command>. You may
|
You may need to run <command>make testclean</command> to undo the
|
||||||
need to run <command>make testclean</command> to undo the results
|
results of a previous test run.
|
||||||
of a previous test run. See the <quote>testing</quote> guide for
|
</para>
|
||||||
more details on Wine's conformance tests.
|
<para>
|
||||||
|
Please consider submitting a conformance test for your changes.
|
||||||
|
This will make it a lot clearer for everyone that your patch is
|
||||||
|
needed, and it will prevent future breakage. While you are not
|
||||||
|
strictly required to submit tests, it is highly encouraged to do so.
|
||||||
|
See the <quote>testing</quote> guide for more details on Wine's
|
||||||
|
conformance tests.
|
||||||
</para>
|
</para>
|
||||||
|
|
||||||
</sect1>
|
</sect1>
|
||||||
|
|
Loading…
Reference in New Issue