From a713da2fc18308fb8bd6e9bc54bf48b3694e344c Mon Sep 17 00:00:00 2001 From: "Dimitrie O. Paun" Date: Fri, 14 Jan 2005 15:14:09 +0000 Subject: [PATCH] Suggest testing patches in a gentler way. Encourage people to submit tests with their patches as well. --- documentation/patches.sgml | 24 +++++++++++++++--------- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/documentation/patches.sgml b/documentation/patches.sgml index b33fc148412..64d5e69226d 100644 --- a/documentation/patches.sgml +++ b/documentation/patches.sgml @@ -206,15 +206,21 @@ code friend! - Save yourself some embarrassment and run your patched code - against more than just your current test example. Experience - will tell you how much effort to apply here. If there are - any conformance tests for the code you're working on, run them - and make sure they still pass after your patch is applied. Running - tests can be done by running make test. You may - need to run make testclean to undo the results - of a previous test run. See the testing guide for - more details on Wine's conformance tests. + Try to test your patch against more than just your current test + example. Experience will tell you how much effort to apply here. + If there are any conformance tests for the code you're working on, + run them and make sure they still pass after your patch is applied. + Running tests can be done by running make test. + You may need to run make testclean to undo the + results of a previous test run. + + + Please consider submitting a conformance test for your changes. + This will make it a lot clearer for everyone that your patch is + needed, and it will prevent future breakage. While you are not + strictly required to submit tests, it is highly encouraged to do so. + See the testing guide for more details on Wine's + conformance tests.