d3d9: Validate the stream index in d3d9_device_SetStreamSource().

Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Henri Verbeet <hverbeet@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
This commit is contained in:
Zebediah Figura 2020-02-19 09:53:51 -06:00 committed by Alexandre Julliard
parent bd58d1327a
commit a3b36a34a6
1 changed files with 10 additions and 1 deletions

View File

@ -3669,16 +3669,25 @@ static HRESULT WINAPI d3d9_device_SetStreamSource(IDirect3DDevice9Ex *iface,
{ {
struct d3d9_device *device = impl_from_IDirect3DDevice9Ex(iface); struct d3d9_device *device = impl_from_IDirect3DDevice9Ex(iface);
struct d3d9_vertexbuffer *buffer_impl = unsafe_impl_from_IDirect3DVertexBuffer9(buffer); struct d3d9_vertexbuffer *buffer_impl = unsafe_impl_from_IDirect3DVertexBuffer9(buffer);
const struct wined3d_stateblock_state *state;
struct wined3d_buffer *wined3d_buffer; struct wined3d_buffer *wined3d_buffer;
HRESULT hr; HRESULT hr;
TRACE("iface %p, stream_idx %u, buffer %p, offset %u, stride %u.\n", TRACE("iface %p, stream_idx %u, buffer %p, offset %u, stride %u.\n",
iface, stream_idx, buffer, offset, stride); iface, stream_idx, buffer, offset, stride);
if (stream_idx >= ARRAY_SIZE(state->streams))
{
WARN("Stream index %u out of range.\n", stream_idx);
return WINED3DERR_INVALIDCALL;
}
wined3d_mutex_lock(); wined3d_mutex_lock();
if (!buffer_impl) if (!buffer_impl)
{ {
const struct wined3d_stream_state *stream = &wined3d_stateblock_get_state(device->state)->streams[stream_idx]; const struct wined3d_stream_state *stream;
state = wined3d_stateblock_get_state(device->state);
stream = &state->streams[stream_idx];
wined3d_buffer = stream->buffer; wined3d_buffer = stream->buffer;
offset = stream->offset; offset = stream->offset;
stride = stream->stride; stride = stream->stride;