reg: Fail if one or more arguments follow a help switch.

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
This commit is contained in:
Hugh McMaster 2021-05-17 23:41:06 +10:00 committed by Alexandre Julliard
parent ac32dd8abc
commit 6c466296a7
2 changed files with 12 additions and 9 deletions

View File

@ -349,14 +349,12 @@ int __cdecl wmain(int argc, WCHAR *argvW[])
return 1;
}
else if (argc == 2) /* Valid operation, no arguments supplied */
{
output_message(STRING_INVALID_SYNTAX);
output_message(STRING_FUNC_HELP, wcsupr(argvW[1]));
return 1;
}
goto invalid;
if (is_help_switch(argvW[2]))
{
if (argc > 3) goto invalid;
output_message(op_help);
output_message(STRING_REG_VIEW_USAGE);
return 0;
@ -378,4 +376,9 @@ int __cdecl wmain(int argc, WCHAR *argvW[])
return reg_import(argc, argvW);
return reg_query(argc, argvW);
invalid:
output_message(STRING_INVALID_SYNTAX);
output_message(STRING_FUNC_HELP, wcsupr(argvW[1]));
return 1;
}

View File

@ -37,16 +37,16 @@ static void test_command_syntax(void)
ok(r == REG_EXIT_SUCCESS, "got exit code %d, expected 0\n", r);
run_reg_exe("reg copy /? /f", &r);
todo_wine ok(r == REG_EXIT_FAILURE, "got exit code %d, expected 1\n", r);
ok(r == REG_EXIT_FAILURE, "got exit code %d, expected 1\n", r);
run_reg_exe("reg copy /h /f", &r);
todo_wine ok(r == REG_EXIT_FAILURE, "got exit code %d, expected 1\n", r);
ok(r == REG_EXIT_FAILURE, "got exit code %d, expected 1\n", r);
run_reg_exe("reg copy /? /s", &r);
todo_wine ok(r == REG_EXIT_FAILURE, "got exit code %d, expected 1\n", r);
ok(r == REG_EXIT_FAILURE, "got exit code %d, expected 1\n", r);
run_reg_exe("reg copy /h /s", &r);
todo_wine ok(r == REG_EXIT_FAILURE, "got exit code %d, expected 1\n", r);
ok(r == REG_EXIT_FAILURE, "got exit code %d, expected 1\n", r);
run_reg_exe("reg copy /f", &r);
ok(r == REG_EXIT_FAILURE, "got exit code %d, expected 1\n", r);