ReceiveTempSMS
/
Sweden-Number
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

user32: LB_SETITEMDATA should return 1 on success, not 0.

This commit is contained in:
Peter Verthez 2007-08-14 18:35:18 +02:00 committed by Alexandre Julliard
parent 3d58a065df
commit 13b376df73
2 changed files with 24 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
dlls/user32/listbox.c
View File

@ -2677,7 +2677,8 @@ static LRESULT WINAPI ListBoxWndProc_common( HWND hwnd, UINT msg,
return LB_ERR; return LB_ERR;
} }
descr->items[wParam].data = lParam; descr->items[wParam].data = lParam;
return LB_OKAY; /* undocumented: returns TRUE, not LB_OKAY (0) */
return TRUE;
case LB_GETCOUNT16: case LB_GETCOUNT16:
case LB_GETCOUNT: case LB_GETCOUNT:

22
dlls/user32/tests/listbox.c
View File

@ -512,6 +512,27 @@ static void test_itemfrompoint(void)
DestroyWindow( hList ); DestroyWindow( hList );
} }
static void test_listbox_item_data(void)
{
HWND hList;
int r, id;
hList = CreateWindow( "ListBox", "list test", 0,
1, 1, 600, 100, NULL, NULL, NULL, NULL );
ok( hList != NULL, "failed to create listbox\n");
id = SendMessage( hList, LB_ADDSTRING, 0, (LPARAM) "hi");
ok( id == 0, "item id wrong\n");
r = SendMessage( hList, LB_SETITEMDATA, 0, MAKELPARAM( 20, 0 ));
ok(r == TRUE, "LB_SETITEMDATA returned %d instead of TRUE\n", r);
r = SendMessage( hList, LB_GETITEMDATA, 0, 0);
ok( r == 20, "get item data failed\n");
DestroyWindow( hList );
}
START_TEST(listbox) START_TEST(listbox)
{ {
const struct listbox_test SS = const struct listbox_test SS =
@ -587,4 +608,5 @@ START_TEST(listbox)
test_selection(); test_selection();
test_listbox_height(); test_listbox_height();
test_itemfrompoint(); test_itemfrompoint();
test_listbox_item_data();
} }