2005-06-08 20:44:50 +02:00
|
|
|
/*
|
|
|
|
* Server-side window stations and desktops handling
|
|
|
|
*
|
|
|
|
* Copyright (C) 2002, 2005 Alexandre Julliard
|
|
|
|
*
|
|
|
|
* This library is free software; you can redistribute it and/or
|
|
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
|
|
* License as published by the Free Software Foundation; either
|
|
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
|
|
*
|
|
|
|
* This library is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
|
|
* Lesser General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
|
|
* License along with this library; if not, write to the Free Software
|
2006-05-18 14:49:52 +02:00
|
|
|
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
|
2005-06-08 20:44:50 +02:00
|
|
|
*/
|
|
|
|
|
|
|
|
#include "config.h"
|
|
|
|
#include "wine/port.h"
|
|
|
|
|
|
|
|
#include <stdio.h>
|
|
|
|
#include <stdarg.h>
|
|
|
|
|
2005-11-28 17:32:54 +01:00
|
|
|
#include "ntstatus.h"
|
|
|
|
#define WIN32_NO_STATUS
|
2005-06-08 20:44:50 +02:00
|
|
|
#include "windef.h"
|
|
|
|
#include "winbase.h"
|
|
|
|
#include "winuser.h"
|
2005-10-27 20:30:37 +02:00
|
|
|
#include "winternl.h"
|
2005-06-08 20:44:50 +02:00
|
|
|
|
|
|
|
#include "object.h"
|
|
|
|
#include "handle.h"
|
|
|
|
#include "request.h"
|
|
|
|
#include "process.h"
|
2005-06-09 11:43:54 +02:00
|
|
|
#include "user.h"
|
2006-03-06 21:02:24 +01:00
|
|
|
#include "file.h"
|
2008-04-15 23:32:43 +02:00
|
|
|
#include "security.h"
|
2005-06-08 20:44:50 +02:00
|
|
|
|
2021-02-05 12:08:42 +01:00
|
|
|
#define DESKTOP_ALL_ACCESS 0x01ff
|
2005-06-08 20:44:50 +02:00
|
|
|
|
|
|
|
static struct list winstation_list = LIST_INIT(winstation_list);
|
|
|
|
|
|
|
|
static void winstation_dump( struct object *obj, int verbose );
|
2005-06-09 17:39:52 +02:00
|
|
|
static int winstation_close_handle( struct object *obj, struct process *process, obj_handle_t handle );
|
2016-02-08 06:02:45 +01:00
|
|
|
static struct object *winstation_lookup_name( struct object *obj, struct unicode_str *name,
|
2020-11-25 19:42:42 +01:00
|
|
|
unsigned int attr, struct object *root );
|
2005-06-08 20:44:50 +02:00
|
|
|
static void winstation_destroy( struct object *obj );
|
|
|
|
static void desktop_dump( struct object *obj, int verbose );
|
2016-02-04 13:08:02 +01:00
|
|
|
static int desktop_link_name( struct object *obj, struct object_name *name, struct object *parent );
|
2005-06-09 17:39:52 +02:00
|
|
|
static int desktop_close_handle( struct object *obj, struct process *process, obj_handle_t handle );
|
2005-06-08 20:44:50 +02:00
|
|
|
static void desktop_destroy( struct object *obj );
|
|
|
|
|
2021-02-04 13:44:18 +01:00
|
|
|
static const WCHAR winstation_name[] = {'W','i','n','d','o','w','S','t','a','t','i','o','n'};
|
|
|
|
|
|
|
|
struct type_descr winstation_type =
|
|
|
|
{
|
|
|
|
{ winstation_name, sizeof(winstation_name) }, /* name */
|
2021-02-05 12:08:42 +01:00
|
|
|
STANDARD_RIGHTS_REQUIRED | WINSTA_ALL_ACCESS, /* valid_access */
|
|
|
|
{ /* mapping */
|
|
|
|
STANDARD_RIGHTS_READ | WINSTA_READSCREEN | WINSTA_ENUMERATE | WINSTA_READATTRIBUTES | WINSTA_ENUMDESKTOPS,
|
|
|
|
STANDARD_RIGHTS_WRITE | WINSTA_WRITEATTRIBUTES | WINSTA_CREATEDESKTOP | WINSTA_ACCESSCLIPBOARD,
|
|
|
|
STANDARD_RIGHTS_EXECUTE | WINSTA_EXITWINDOWS | WINSTA_ACCESSGLOBALATOMS,
|
|
|
|
STANDARD_RIGHTS_REQUIRED | WINSTA_ALL_ACCESS
|
|
|
|
},
|
2021-02-04 13:44:18 +01:00
|
|
|
};
|
|
|
|
|
2005-06-08 20:44:50 +02:00
|
|
|
static const struct object_ops winstation_ops =
|
|
|
|
{
|
|
|
|
sizeof(struct winstation), /* size */
|
2021-02-04 13:44:18 +01:00
|
|
|
&winstation_type, /* type */
|
2005-06-08 20:44:50 +02:00
|
|
|
winstation_dump, /* dump */
|
|
|
|
no_add_queue, /* add_queue */
|
|
|
|
NULL, /* remove_queue */
|
|
|
|
NULL, /* signaled */
|
|
|
|
NULL, /* satisfied */
|
|
|
|
no_signal, /* signal */
|
|
|
|
no_get_fd, /* get_fd */
|
2021-02-05 12:10:44 +01:00
|
|
|
default_map_access, /* map_access */
|
2007-10-03 14:10:37 +02:00
|
|
|
default_get_sd, /* get_sd */
|
|
|
|
default_set_sd, /* set_sd */
|
2020-09-22 16:52:31 +02:00
|
|
|
default_get_full_name, /* get_full_name */
|
2016-02-08 06:02:45 +01:00
|
|
|
winstation_lookup_name, /* lookup_name */
|
2016-02-04 13:08:02 +01:00
|
|
|
directory_link_name, /* link_name */
|
|
|
|
default_unlink_name, /* unlink_name */
|
2007-03-22 11:44:29 +01:00
|
|
|
no_open_file, /* open_file */
|
2019-03-25 14:37:09 +01:00
|
|
|
no_kernel_obj_list, /* get_kernel_obj_list */
|
2005-06-09 17:39:52 +02:00
|
|
|
winstation_close_handle, /* close_handle */
|
2005-06-08 20:44:50 +02:00
|
|
|
winstation_destroy /* destroy */
|
|
|
|
};
|
|
|
|
|
|
|
|
|
2021-02-04 13:44:18 +01:00
|
|
|
static const WCHAR desktop_name[] = {'D','e','s','k','t','o','p'};
|
|
|
|
|
|
|
|
struct type_descr desktop_type =
|
|
|
|
{
|
|
|
|
{ desktop_name, sizeof(desktop_name) }, /* name */
|
2021-02-05 12:08:42 +01:00
|
|
|
STANDARD_RIGHTS_REQUIRED | DESKTOP_ALL_ACCESS, /* valid_access */
|
|
|
|
{ /* mapping */
|
|
|
|
STANDARD_RIGHTS_READ | DESKTOP_ENUMERATE | DESKTOP_READOBJECTS,
|
|
|
|
STANDARD_RIGHTS_WRITE | DESKTOP_WRITEOBJECTS | DESKTOP_JOURNALPLAYBACK | DESKTOP_JOURNALRECORD
|
|
|
|
| DESKTOP_HOOKCONTROL | DESKTOP_CREATEMENU | DESKTOP_CREATEWINDOW,
|
|
|
|
STANDARD_RIGHTS_EXECUTE | DESKTOP_SWITCHDESKTOP,
|
|
|
|
STANDARD_RIGHTS_REQUIRED | DESKTOP_ALL_ACCESS
|
|
|
|
},
|
2021-02-04 13:44:18 +01:00
|
|
|
};
|
|
|
|
|
2005-06-08 20:44:50 +02:00
|
|
|
static const struct object_ops desktop_ops =
|
|
|
|
{
|
|
|
|
sizeof(struct desktop), /* size */
|
2021-02-04 13:44:18 +01:00
|
|
|
&desktop_type, /* type */
|
2005-06-08 20:44:50 +02:00
|
|
|
desktop_dump, /* dump */
|
|
|
|
no_add_queue, /* add_queue */
|
|
|
|
NULL, /* remove_queue */
|
|
|
|
NULL, /* signaled */
|
|
|
|
NULL, /* satisfied */
|
|
|
|
no_signal, /* signal */
|
|
|
|
no_get_fd, /* get_fd */
|
2021-02-05 12:10:44 +01:00
|
|
|
default_map_access, /* map_access */
|
2007-10-03 14:10:37 +02:00
|
|
|
default_get_sd, /* get_sd */
|
|
|
|
default_set_sd, /* set_sd */
|
2020-09-22 16:52:31 +02:00
|
|
|
default_get_full_name, /* get_full_name */
|
2005-11-22 15:55:42 +01:00
|
|
|
no_lookup_name, /* lookup_name */
|
2016-02-04 13:08:02 +01:00
|
|
|
desktop_link_name, /* link_name */
|
|
|
|
default_unlink_name, /* unlink_name */
|
2007-03-22 11:44:29 +01:00
|
|
|
no_open_file, /* open_file */
|
2019-03-25 14:37:09 +01:00
|
|
|
no_kernel_obj_list, /* get_kernel_obj_list */
|
2005-06-09 17:39:52 +02:00
|
|
|
desktop_close_handle, /* close_handle */
|
2005-06-08 20:44:50 +02:00
|
|
|
desktop_destroy /* destroy */
|
|
|
|
};
|
|
|
|
|
|
|
|
/* create a winstation object */
|
2016-02-12 13:00:41 +01:00
|
|
|
static struct winstation *create_winstation( struct object *root, const struct unicode_str *name,
|
2016-01-20 14:02:03 +01:00
|
|
|
unsigned int attr, unsigned int flags )
|
2005-06-08 20:44:50 +02:00
|
|
|
{
|
|
|
|
struct winstation *winstation;
|
|
|
|
|
2016-02-12 14:57:33 +01:00
|
|
|
if ((winstation = create_named_object( root, &winstation_ops, name, attr, NULL )))
|
2005-06-08 20:44:50 +02:00
|
|
|
{
|
2005-11-21 17:27:03 +01:00
|
|
|
if (get_error() != STATUS_OBJECT_NAME_EXISTS)
|
2005-06-08 20:44:50 +02:00
|
|
|
{
|
|
|
|
/* initialize it if it didn't already exist */
|
|
|
|
winstation->flags = flags;
|
2005-06-29 22:13:36 +02:00
|
|
|
winstation->clipboard = NULL;
|
2005-07-07 13:29:23 +02:00
|
|
|
winstation->atom_table = NULL;
|
2005-06-08 20:44:50 +02:00
|
|
|
list_add_tail( &winstation_list, &winstation->entry );
|
|
|
|
list_init( &winstation->desktops );
|
2016-01-20 14:27:44 +01:00
|
|
|
if (!(winstation->desktop_names = create_namespace( 7 )))
|
|
|
|
{
|
|
|
|
release_object( winstation );
|
|
|
|
return NULL;
|
|
|
|
}
|
2005-06-08 20:44:50 +02:00
|
|
|
}
|
2016-02-02 13:46:46 +01:00
|
|
|
else clear_error();
|
2005-06-08 20:44:50 +02:00
|
|
|
}
|
|
|
|
return winstation;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void winstation_dump( struct object *obj, int verbose )
|
|
|
|
{
|
|
|
|
struct winstation *winstation = (struct winstation *)obj;
|
|
|
|
|
2016-01-21 13:08:56 +01:00
|
|
|
fprintf( stderr, "Winstation flags=%x clipboard=%p atoms=%p\n",
|
2005-07-11 15:30:23 +02:00
|
|
|
winstation->flags, winstation->clipboard, winstation->atom_table );
|
2005-06-08 20:44:50 +02:00
|
|
|
}
|
|
|
|
|
2005-06-09 17:39:52 +02:00
|
|
|
static int winstation_close_handle( struct object *obj, struct process *process, obj_handle_t handle )
|
|
|
|
{
|
|
|
|
return (process->winstation != handle);
|
|
|
|
}
|
|
|
|
|
2016-02-08 06:02:45 +01:00
|
|
|
static struct object *winstation_lookup_name( struct object *obj, struct unicode_str *name,
|
2020-11-25 19:42:42 +01:00
|
|
|
unsigned int attr, struct object *root )
|
2016-02-08 06:02:45 +01:00
|
|
|
{
|
|
|
|
struct winstation *winstation = (struct winstation *)obj;
|
|
|
|
struct object *found;
|
|
|
|
|
|
|
|
assert( obj->ops == &winstation_ops );
|
|
|
|
|
2016-02-09 12:16:27 +01:00
|
|
|
if (!name) return NULL; /* open the winstation itself */
|
|
|
|
|
2020-03-24 12:47:31 +01:00
|
|
|
if (get_path_element( name->str, name->len ) < name->len) /* no backslash allowed in name */
|
2016-02-08 06:02:45 +01:00
|
|
|
{
|
|
|
|
set_error( STATUS_OBJECT_PATH_SYNTAX_BAD );
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
if ((found = find_object( winstation->desktop_names, name, attr )))
|
|
|
|
name->len = 0;
|
|
|
|
|
|
|
|
return found;
|
|
|
|
}
|
|
|
|
|
2005-06-08 20:44:50 +02:00
|
|
|
static void winstation_destroy( struct object *obj )
|
|
|
|
{
|
|
|
|
struct winstation *winstation = (struct winstation *)obj;
|
|
|
|
|
|
|
|
list_remove( &winstation->entry );
|
2005-06-29 22:13:36 +02:00
|
|
|
if (winstation->clipboard) release_object( winstation->clipboard );
|
2005-07-07 13:29:23 +02:00
|
|
|
if (winstation->atom_table) release_object( winstation->atom_table );
|
2016-01-20 14:27:44 +01:00
|
|
|
free( winstation->desktop_names );
|
2005-06-08 20:44:50 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
/* retrieve the process window station, checking the handle access rights */
|
2005-06-29 22:13:36 +02:00
|
|
|
struct winstation *get_process_winstation( struct process *process, unsigned int access )
|
2005-06-08 20:44:50 +02:00
|
|
|
{
|
|
|
|
return (struct winstation *)get_handle_obj( process, process->winstation,
|
|
|
|
access, &winstation_ops );
|
|
|
|
}
|
|
|
|
|
2005-06-28 21:37:52 +02:00
|
|
|
/* retrieve a pointer to a desktop object */
|
2008-03-18 15:17:40 +01:00
|
|
|
struct desktop *get_desktop_obj( struct process *process, obj_handle_t handle, unsigned int access )
|
2005-06-28 21:37:52 +02:00
|
|
|
{
|
|
|
|
return (struct desktop *)get_handle_obj( process, handle, access, &desktop_ops );
|
|
|
|
}
|
|
|
|
|
2005-06-08 20:44:50 +02:00
|
|
|
/* create a desktop object */
|
2005-11-21 13:05:38 +01:00
|
|
|
static struct desktop *create_desktop( const struct unicode_str *name, unsigned int attr,
|
|
|
|
unsigned int flags, struct winstation *winstation )
|
2005-06-08 20:44:50 +02:00
|
|
|
{
|
|
|
|
struct desktop *desktop;
|
|
|
|
|
2016-02-12 14:57:33 +01:00
|
|
|
if ((desktop = create_named_object( &winstation->obj, &desktop_ops, name, attr, NULL )))
|
2005-06-08 20:44:50 +02:00
|
|
|
{
|
2005-11-21 17:27:03 +01:00
|
|
|
if (get_error() != STATUS_OBJECT_NAME_EXISTS)
|
2005-06-08 20:44:50 +02:00
|
|
|
{
|
|
|
|
/* initialize it if it didn't already exist */
|
|
|
|
desktop->flags = flags;
|
|
|
|
desktop->winstation = (struct winstation *)grab_object( winstation );
|
2005-07-11 15:30:23 +02:00
|
|
|
desktop->top_window = NULL;
|
2008-06-25 14:43:39 +02:00
|
|
|
desktop->msg_window = NULL;
|
2005-07-11 20:05:50 +02:00
|
|
|
desktop->global_hooks = NULL;
|
2006-03-06 21:02:24 +01:00
|
|
|
desktop->close_timeout = NULL;
|
2011-02-24 16:45:04 +01:00
|
|
|
desktop->foreground_input = NULL;
|
2006-03-06 21:02:24 +01:00
|
|
|
desktop->users = 0;
|
2011-03-31 19:54:22 +02:00
|
|
|
memset( &desktop->cursor, 0, sizeof(desktop->cursor) );
|
2011-02-25 12:10:04 +01:00
|
|
|
memset( desktop->keystate, 0, sizeof(desktop->keystate) );
|
2005-06-08 20:44:50 +02:00
|
|
|
list_add_tail( &winstation->desktops, &desktop->entry );
|
2011-05-26 22:52:17 +02:00
|
|
|
list_init( &desktop->hotkeys );
|
2005-06-08 20:44:50 +02:00
|
|
|
}
|
2016-02-01 09:53:10 +01:00
|
|
|
else clear_error();
|
2005-06-08 20:44:50 +02:00
|
|
|
}
|
|
|
|
return desktop;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void desktop_dump( struct object *obj, int verbose )
|
|
|
|
{
|
|
|
|
struct desktop *desktop = (struct desktop *)obj;
|
|
|
|
|
2016-01-21 13:08:56 +01:00
|
|
|
fprintf( stderr, "Desktop flags=%x winstation=%p top_win=%p hooks=%p\n",
|
2005-07-11 20:05:50 +02:00
|
|
|
desktop->flags, desktop->winstation, desktop->top_window, desktop->global_hooks );
|
2005-06-08 20:44:50 +02:00
|
|
|
}
|
|
|
|
|
2016-02-04 13:08:02 +01:00
|
|
|
static int desktop_link_name( struct object *obj, struct object_name *name, struct object *parent )
|
|
|
|
{
|
|
|
|
struct winstation *winstation = (struct winstation *)parent;
|
|
|
|
|
|
|
|
if (parent->ops != &winstation_ops)
|
|
|
|
{
|
|
|
|
set_error( STATUS_OBJECT_TYPE_MISMATCH );
|
|
|
|
return 0;
|
|
|
|
}
|
2020-03-24 12:47:31 +01:00
|
|
|
if (get_path_element( name->name, name->len ) < name->len) /* no backslash allowed in name */
|
2016-02-04 13:08:02 +01:00
|
|
|
{
|
|
|
|
set_error( STATUS_OBJECT_PATH_SYNTAX_BAD );
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
namespace_add( winstation->desktop_names, name );
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
|
2005-06-09 17:39:52 +02:00
|
|
|
static int desktop_close_handle( struct object *obj, struct process *process, obj_handle_t handle )
|
2005-06-08 20:44:50 +02:00
|
|
|
{
|
2005-06-09 17:39:52 +02:00
|
|
|
struct thread *thread;
|
2005-06-08 20:44:50 +02:00
|
|
|
|
2005-06-09 17:39:52 +02:00
|
|
|
/* check if the handle is currently used by the process or one of its threads */
|
|
|
|
if (process->desktop == handle) return 0;
|
|
|
|
LIST_FOR_EACH_ENTRY( thread, &process->thread_list, struct thread, proc_entry )
|
|
|
|
if (thread->desktop == handle) return 0;
|
|
|
|
return 1;
|
2005-06-08 20:44:50 +02:00
|
|
|
}
|
|
|
|
|
2005-06-09 17:39:52 +02:00
|
|
|
static void desktop_destroy( struct object *obj )
|
2005-06-08 20:44:50 +02:00
|
|
|
{
|
2005-06-09 17:39:52 +02:00
|
|
|
struct desktop *desktop = (struct desktop *)obj;
|
2005-06-09 14:07:12 +02:00
|
|
|
|
2011-05-26 22:52:17 +02:00
|
|
|
free_hotkeys( desktop, 0 );
|
2005-07-11 15:30:23 +02:00
|
|
|
if (desktop->top_window) destroy_window( desktop->top_window );
|
2008-06-25 14:43:39 +02:00
|
|
|
if (desktop->msg_window) destroy_window( desktop->msg_window );
|
2005-07-11 20:05:50 +02:00
|
|
|
if (desktop->global_hooks) release_object( desktop->global_hooks );
|
2006-03-06 21:02:24 +01:00
|
|
|
if (desktop->close_timeout) remove_timeout_user( desktop->close_timeout );
|
2005-06-09 17:39:52 +02:00
|
|
|
list_remove( &desktop->entry );
|
|
|
|
release_object( desktop->winstation );
|
2005-06-08 20:44:50 +02:00
|
|
|
}
|
|
|
|
|
2005-07-11 12:55:53 +02:00
|
|
|
/* retrieve the thread desktop, checking the handle access rights */
|
|
|
|
struct desktop *get_thread_desktop( struct thread *thread, unsigned int access )
|
|
|
|
{
|
|
|
|
return get_desktop_obj( thread->process, thread->desktop, access );
|
|
|
|
}
|
|
|
|
|
2013-04-30 13:55:54 +02:00
|
|
|
static void close_desktop_timeout( void *private )
|
|
|
|
{
|
|
|
|
struct desktop *desktop = private;
|
|
|
|
|
|
|
|
desktop->close_timeout = NULL;
|
|
|
|
unlink_named_object( &desktop->obj ); /* make sure no other process can open it */
|
|
|
|
post_desktop_message( desktop, WM_CLOSE, 0, 0 ); /* and signal the owner to quit */
|
|
|
|
}
|
|
|
|
|
|
|
|
/* add a user of the desktop and cancel the close timeout */
|
|
|
|
static void add_desktop_user( struct desktop *desktop )
|
|
|
|
{
|
|
|
|
desktop->users++;
|
|
|
|
if (desktop->close_timeout)
|
|
|
|
{
|
|
|
|
remove_timeout_user( desktop->close_timeout );
|
|
|
|
desktop->close_timeout = NULL;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/* remove a user of the desktop and start the close timeout if necessary */
|
|
|
|
static void remove_desktop_user( struct desktop *desktop )
|
|
|
|
{
|
server: Track desktop users per thread instead of per process.
As some thread may use a different desktop from their process.
This fixes the user32 win tests, which leaks a desktop that never gets
closed. The test_shell_window test creates a new desktop, which spawns
explorer.exe process, incrementing the desktop user count to 1, then
associates the desktop to a thread, which closes it on exit.
Never the user count is incremented to 2, and closing the thread desktop
doesn't either check whether the desktop process should be terminated.
Reversely, it is possible to create a desktop, associate it with a
thread /and/ a process, and this time the desktop process would be
terminated when the process exits, although the thread may still be
using it.
Tracking the users per thread is more robust and fixes the problem as
set_thread_desktop increments the desktop user count, and thread exit
decrements it.
Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-21 10:38:15 +02:00
|
|
|
struct process *process;
|
2013-04-30 13:55:54 +02:00
|
|
|
assert( desktop->users > 0 );
|
|
|
|
desktop->users--;
|
|
|
|
|
|
|
|
/* if we have one remaining user, it has to be the manager of the desktop window */
|
server: Track desktop users per thread instead of per process.
As some thread may use a different desktop from their process.
This fixes the user32 win tests, which leaks a desktop that never gets
closed. The test_shell_window test creates a new desktop, which spawns
explorer.exe process, incrementing the desktop user count to 1, then
associates the desktop to a thread, which closes it on exit.
Never the user count is incremented to 2, and closing the thread desktop
doesn't either check whether the desktop process should be terminated.
Reversely, it is possible to create a desktop, associate it with a
thread /and/ a process, and this time the desktop process would be
terminated when the process exits, although the thread may still be
using it.
Tracking the users per thread is more robust and fixes the problem as
set_thread_desktop increments the desktop user count, and thread exit
decrements it.
Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-21 10:38:15 +02:00
|
|
|
if ((process = get_top_window_owner( desktop )) && desktop->users == process->running_threads && !desktop->close_timeout)
|
2013-04-30 13:55:54 +02:00
|
|
|
desktop->close_timeout = add_timeout_user( -TICKS_PER_SEC, close_desktop_timeout, desktop );
|
server: Track desktop users per thread instead of per process.
As some thread may use a different desktop from their process.
This fixes the user32 win tests, which leaks a desktop that never gets
closed. The test_shell_window test creates a new desktop, which spawns
explorer.exe process, incrementing the desktop user count to 1, then
associates the desktop to a thread, which closes it on exit.
Never the user count is incremented to 2, and closing the thread desktop
doesn't either check whether the desktop process should be terminated.
Reversely, it is possible to create a desktop, associate it with a
thread /and/ a process, and this time the desktop process would be
terminated when the process exits, although the thread may still be
using it.
Tracking the users per thread is more robust and fixes the problem as
set_thread_desktop increments the desktop user count, and thread exit
decrements it.
Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-21 10:38:15 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
/* set the thread default desktop handle */
|
|
|
|
void set_thread_default_desktop( struct thread *thread, struct desktop *desktop, obj_handle_t handle )
|
|
|
|
{
|
|
|
|
if (thread->desktop) return; /* nothing to do */
|
|
|
|
|
|
|
|
thread->desktop = handle;
|
|
|
|
if (!thread->process->is_system) add_desktop_user( desktop );
|
2013-04-30 13:55:54 +02:00
|
|
|
}
|
|
|
|
|
2006-03-27 12:57:17 +02:00
|
|
|
/* set the process default desktop handle */
|
|
|
|
void set_process_default_desktop( struct process *process, struct desktop *desktop,
|
|
|
|
obj_handle_t handle )
|
2005-06-08 20:44:50 +02:00
|
|
|
{
|
2006-03-27 12:57:17 +02:00
|
|
|
struct thread *thread;
|
2005-06-08 20:44:50 +02:00
|
|
|
|
2006-03-27 12:57:17 +02:00
|
|
|
if (process->desktop == handle) return; /* nothing to do */
|
2005-06-08 20:44:50 +02:00
|
|
|
|
2006-03-27 12:57:17 +02:00
|
|
|
process->desktop = handle;
|
2005-06-08 20:44:50 +02:00
|
|
|
|
2006-03-27 12:57:17 +02:00
|
|
|
/* set desktop for threads that don't have one yet */
|
|
|
|
LIST_FOR_EACH_ENTRY( thread, &process->thread_list, struct thread, proc_entry )
|
server: Track desktop users per thread instead of per process.
As some thread may use a different desktop from their process.
This fixes the user32 win tests, which leaks a desktop that never gets
closed. The test_shell_window test creates a new desktop, which spawns
explorer.exe process, incrementing the desktop user count to 1, then
associates the desktop to a thread, which closes it on exit.
Never the user count is incremented to 2, and closing the thread desktop
doesn't either check whether the desktop process should be terminated.
Reversely, it is possible to create a desktop, associate it with a
thread /and/ a process, and this time the desktop process would be
terminated when the process exits, although the thread may still be
using it.
Tracking the users per thread is more robust and fixes the problem as
set_thread_desktop increments the desktop user count, and thread exit
decrements it.
Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-21 10:38:15 +02:00
|
|
|
set_thread_default_desktop( thread, desktop, handle );
|
2005-06-08 20:44:50 +02:00
|
|
|
}
|
|
|
|
|
2006-03-27 12:57:17 +02:00
|
|
|
/* connect a process to its window station */
|
2019-12-12 12:18:31 +01:00
|
|
|
void connect_process_winstation( struct process *process, struct thread *parent_thread,
|
|
|
|
struct process *parent_process )
|
2005-06-08 20:44:50 +02:00
|
|
|
{
|
2006-03-27 12:57:17 +02:00
|
|
|
struct winstation *winstation = NULL;
|
|
|
|
struct desktop *desktop = NULL;
|
|
|
|
obj_handle_t handle;
|
2005-06-08 20:44:50 +02:00
|
|
|
|
2006-03-27 12:57:17 +02:00
|
|
|
/* check for an inherited winstation handle (don't ask...) */
|
|
|
|
if ((handle = find_inherited_handle( process, &winstation_ops )))
|
|
|
|
{
|
|
|
|
winstation = (struct winstation *)get_handle_obj( process, handle, 0, &winstation_ops );
|
|
|
|
}
|
2019-12-12 12:18:31 +01:00
|
|
|
else if (parent_process->winstation)
|
2005-06-08 20:44:50 +02:00
|
|
|
{
|
2019-12-12 12:18:31 +01:00
|
|
|
handle = duplicate_handle( parent_process, parent_process->winstation,
|
2021-02-16 11:27:18 +01:00
|
|
|
process, 0, 0, DUPLICATE_SAME_ACCESS );
|
2006-03-27 12:57:17 +02:00
|
|
|
winstation = (struct winstation *)get_handle_obj( process, handle, 0, &winstation_ops );
|
|
|
|
}
|
|
|
|
if (!winstation) goto done;
|
|
|
|
process->winstation = handle;
|
2005-06-08 20:44:50 +02:00
|
|
|
|
2006-03-27 12:57:17 +02:00
|
|
|
if ((handle = find_inherited_handle( process, &desktop_ops )))
|
|
|
|
{
|
|
|
|
desktop = get_desktop_obj( process, handle, 0 );
|
|
|
|
if (!desktop || desktop->winstation != winstation) goto done;
|
2005-06-08 20:44:50 +02:00
|
|
|
}
|
2019-12-12 12:18:31 +01:00
|
|
|
else
|
2006-03-27 12:57:17 +02:00
|
|
|
{
|
2019-12-12 12:18:31 +01:00
|
|
|
if (parent_thread && parent_thread->desktop)
|
|
|
|
handle = parent_thread->desktop;
|
|
|
|
else if (parent_process->desktop)
|
|
|
|
handle = parent_process->desktop;
|
|
|
|
else
|
|
|
|
goto done;
|
|
|
|
|
|
|
|
desktop = get_desktop_obj( parent_process, handle, 0 );
|
|
|
|
|
2006-03-27 12:57:17 +02:00
|
|
|
if (!desktop || desktop->winstation != winstation) goto done;
|
|
|
|
|
2021-02-16 11:27:18 +01:00
|
|
|
handle = duplicate_handle( parent_process, handle, process, 0, 0, DUPLICATE_SAME_ACCESS );
|
2019-12-12 12:18:31 +01:00
|
|
|
}
|
2006-03-27 12:57:17 +02:00
|
|
|
if (handle) set_process_default_desktop( process, desktop, handle );
|
|
|
|
|
|
|
|
done:
|
|
|
|
if (desktop) release_object( desktop );
|
|
|
|
if (winstation) release_object( winstation );
|
|
|
|
clear_error();
|
2005-06-08 20:44:50 +02:00
|
|
|
}
|
|
|
|
|
2006-03-06 21:02:24 +01:00
|
|
|
/* close the desktop of a given process */
|
|
|
|
void close_process_desktop( struct process *process )
|
|
|
|
{
|
server: Track desktop users per thread instead of per process.
As some thread may use a different desktop from their process.
This fixes the user32 win tests, which leaks a desktop that never gets
closed. The test_shell_window test creates a new desktop, which spawns
explorer.exe process, incrementing the desktop user count to 1, then
associates the desktop to a thread, which closes it on exit.
Never the user count is incremented to 2, and closing the thread desktop
doesn't either check whether the desktop process should be terminated.
Reversely, it is possible to create a desktop, associate it with a
thread /and/ a process, and this time the desktop process would be
terminated when the process exits, although the thread may still be
using it.
Tracking the users per thread is more robust and fixes the problem as
set_thread_desktop increments the desktop user count, and thread exit
decrements it.
Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-21 10:38:15 +02:00
|
|
|
obj_handle_t handle;
|
2006-03-06 21:02:24 +01:00
|
|
|
|
server: Track desktop users per thread instead of per process.
As some thread may use a different desktop from their process.
This fixes the user32 win tests, which leaks a desktop that never gets
closed. The test_shell_window test creates a new desktop, which spawns
explorer.exe process, incrementing the desktop user count to 1, then
associates the desktop to a thread, which closes it on exit.
Never the user count is incremented to 2, and closing the thread desktop
doesn't either check whether the desktop process should be terminated.
Reversely, it is possible to create a desktop, associate it with a
thread /and/ a process, and this time the desktop process would be
terminated when the process exits, although the thread may still be
using it.
Tracking the users per thread is more robust and fixes the problem as
set_thread_desktop increments the desktop user count, and thread exit
decrements it.
Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-21 10:38:15 +02:00
|
|
|
if (!(handle = process->desktop)) return;
|
|
|
|
|
|
|
|
process->desktop = 0;
|
|
|
|
close_handle( process, handle );
|
2006-03-06 21:02:24 +01:00
|
|
|
}
|
|
|
|
|
server: Track desktop users per thread instead of per process.
As some thread may use a different desktop from their process.
This fixes the user32 win tests, which leaks a desktop that never gets
closed. The test_shell_window test creates a new desktop, which spawns
explorer.exe process, incrementing the desktop user count to 1, then
associates the desktop to a thread, which closes it on exit.
Never the user count is incremented to 2, and closing the thread desktop
doesn't either check whether the desktop process should be terminated.
Reversely, it is possible to create a desktop, associate it with a
thread /and/ a process, and this time the desktop process would be
terminated when the process exits, although the thread may still be
using it.
Tracking the users per thread is more robust and fixes the problem as
set_thread_desktop increments the desktop user count, and thread exit
decrements it.
Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-21 10:38:15 +02:00
|
|
|
/* release (and eventually close) the desktop of a given thread */
|
|
|
|
void release_thread_desktop( struct thread *thread, int close )
|
2005-06-08 20:44:50 +02:00
|
|
|
{
|
server: Track desktop users per thread instead of per process.
As some thread may use a different desktop from their process.
This fixes the user32 win tests, which leaks a desktop that never gets
closed. The test_shell_window test creates a new desktop, which spawns
explorer.exe process, incrementing the desktop user count to 1, then
associates the desktop to a thread, which closes it on exit.
Never the user count is incremented to 2, and closing the thread desktop
doesn't either check whether the desktop process should be terminated.
Reversely, it is possible to create a desktop, associate it with a
thread /and/ a process, and this time the desktop process would be
terminated when the process exits, although the thread may still be
using it.
Tracking the users per thread is more robust and fixes the problem as
set_thread_desktop increments the desktop user count, and thread exit
decrements it.
Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-21 10:38:15 +02:00
|
|
|
struct desktop *desktop;
|
|
|
|
obj_handle_t handle;
|
|
|
|
|
|
|
|
if (!(handle = thread->desktop)) return;
|
|
|
|
|
|
|
|
if (!thread->process->is_system)
|
|
|
|
{
|
|
|
|
if (!(desktop = get_desktop_obj( thread->process, handle, 0 ))) clear_error(); /* ignore errors */
|
|
|
|
else
|
|
|
|
{
|
|
|
|
remove_desktop_user( desktop );
|
|
|
|
release_object( desktop );
|
|
|
|
}
|
|
|
|
}
|
2005-06-08 20:44:50 +02:00
|
|
|
|
server: Track desktop users per thread instead of per process.
As some thread may use a different desktop from their process.
This fixes the user32 win tests, which leaks a desktop that never gets
closed. The test_shell_window test creates a new desktop, which spawns
explorer.exe process, incrementing the desktop user count to 1, then
associates the desktop to a thread, which closes it on exit.
Never the user count is incremented to 2, and closing the thread desktop
doesn't either check whether the desktop process should be terminated.
Reversely, it is possible to create a desktop, associate it with a
thread /and/ a process, and this time the desktop process would be
terminated when the process exits, although the thread may still be
using it.
Tracking the users per thread is more robust and fixes the problem as
set_thread_desktop increments the desktop user count, and thread exit
decrements it.
Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-21 10:38:15 +02:00
|
|
|
if (close)
|
|
|
|
{
|
|
|
|
thread->desktop = 0;
|
|
|
|
close_handle( thread->process, handle );
|
|
|
|
}
|
2005-06-08 20:44:50 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
/* create a window station */
|
|
|
|
DECL_HANDLER(create_winstation)
|
|
|
|
{
|
|
|
|
struct winstation *winstation;
|
2016-01-29 08:36:45 +01:00
|
|
|
struct unicode_str name = get_req_unicode_str();
|
2016-02-12 13:00:41 +01:00
|
|
|
struct object *root = NULL;
|
2005-06-08 20:44:50 +02:00
|
|
|
|
|
|
|
reply->handle = 0;
|
2016-02-12 13:00:41 +01:00
|
|
|
if (req->rootdir && !(root = get_directory_obj( current->process, req->rootdir ))) return;
|
2016-01-20 14:02:03 +01:00
|
|
|
|
|
|
|
if ((winstation = create_winstation( root, &name, req->attributes, req->flags )))
|
2005-06-08 20:44:50 +02:00
|
|
|
{
|
2005-12-09 13:58:25 +01:00
|
|
|
reply->handle = alloc_handle( current->process, winstation, req->access, req->attributes );
|
2005-06-08 20:44:50 +02:00
|
|
|
release_object( winstation );
|
|
|
|
}
|
2016-01-20 14:02:03 +01:00
|
|
|
if (root) release_object( root );
|
2005-06-08 20:44:50 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
/* open a handle to a window station */
|
|
|
|
DECL_HANDLER(open_winstation)
|
|
|
|
{
|
2016-01-29 08:36:45 +01:00
|
|
|
struct unicode_str name = get_req_unicode_str();
|
2005-11-18 17:31:18 +01:00
|
|
|
|
2016-01-29 08:23:29 +01:00
|
|
|
reply->handle = open_object( current->process, req->rootdir, req->access,
|
|
|
|
&winstation_ops, &name, req->attributes );
|
2005-06-08 20:44:50 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
/* close a window station */
|
|
|
|
DECL_HANDLER(close_winstation)
|
|
|
|
{
|
|
|
|
struct winstation *winstation;
|
|
|
|
|
|
|
|
if ((winstation = (struct winstation *)get_handle_obj( current->process, req->handle,
|
|
|
|
0, &winstation_ops )))
|
|
|
|
{
|
2009-12-01 13:59:41 +01:00
|
|
|
if (close_handle( current->process, req->handle )) set_error( STATUS_ACCESS_DENIED );
|
2005-06-08 20:44:50 +02:00
|
|
|
release_object( winstation );
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
/* get the process current window station */
|
|
|
|
DECL_HANDLER(get_process_winstation)
|
|
|
|
{
|
|
|
|
reply->handle = current->process->winstation;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
/* set the process current window station */
|
|
|
|
DECL_HANDLER(set_process_winstation)
|
|
|
|
{
|
|
|
|
struct winstation *winstation;
|
|
|
|
|
|
|
|
if ((winstation = (struct winstation *)get_handle_obj( current->process, req->handle,
|
|
|
|
0, &winstation_ops )))
|
|
|
|
{
|
|
|
|
/* FIXME: should we close the old one? */
|
|
|
|
current->process->winstation = req->handle;
|
|
|
|
release_object( winstation );
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/* create a desktop */
|
|
|
|
DECL_HANDLER(create_desktop)
|
|
|
|
{
|
|
|
|
struct desktop *desktop;
|
|
|
|
struct winstation *winstation;
|
2016-01-29 08:36:45 +01:00
|
|
|
struct unicode_str name = get_req_unicode_str();
|
2005-06-08 20:44:50 +02:00
|
|
|
|
|
|
|
reply->handle = 0;
|
2020-06-24 12:37:22 +02:00
|
|
|
if (!name.len)
|
|
|
|
{
|
|
|
|
set_error( STATUS_INVALID_HANDLE );
|
|
|
|
return;
|
|
|
|
}
|
2005-06-08 20:44:50 +02:00
|
|
|
if ((winstation = get_process_winstation( current->process, WINSTA_CREATEDESKTOP )))
|
|
|
|
{
|
2005-11-21 13:05:38 +01:00
|
|
|
if ((desktop = create_desktop( &name, req->attributes, req->flags, winstation )))
|
2005-06-08 20:44:50 +02:00
|
|
|
{
|
2005-12-09 13:58:25 +01:00
|
|
|
reply->handle = alloc_handle( current->process, desktop, req->access, req->attributes );
|
2005-06-08 20:44:50 +02:00
|
|
|
release_object( desktop );
|
|
|
|
}
|
|
|
|
release_object( winstation );
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/* open a handle to a desktop */
|
|
|
|
DECL_HANDLER(open_desktop)
|
|
|
|
{
|
|
|
|
struct winstation *winstation;
|
2016-01-29 08:23:29 +01:00
|
|
|
struct object *obj;
|
2016-01-29 08:36:45 +01:00
|
|
|
struct unicode_str name = get_req_unicode_str();
|
2008-04-01 21:15:55 +02:00
|
|
|
|
|
|
|
/* FIXME: check access rights */
|
|
|
|
if (!req->winsta)
|
|
|
|
winstation = get_process_winstation( current->process, 0 );
|
|
|
|
else
|
|
|
|
winstation = (struct winstation *)get_handle_obj( current->process, req->winsta, 0, &winstation_ops );
|
|
|
|
|
2016-01-29 08:23:29 +01:00
|
|
|
if (!winstation) return;
|
|
|
|
|
2016-02-08 08:53:31 +01:00
|
|
|
if ((obj = open_named_object( &winstation->obj, &desktop_ops, &name, req->attributes )))
|
2005-06-08 20:44:50 +02:00
|
|
|
{
|
2016-01-29 08:23:29 +01:00
|
|
|
reply->handle = alloc_handle( current->process, obj, req->access, req->attributes );
|
|
|
|
release_object( obj );
|
2005-06-08 20:44:50 +02:00
|
|
|
}
|
2016-01-29 08:23:29 +01:00
|
|
|
|
|
|
|
release_object( winstation );
|
2005-06-08 20:44:50 +02:00
|
|
|
}
|
|
|
|
|
2013-11-08 10:10:24 +01:00
|
|
|
/* open a handle to current input desktop */
|
|
|
|
DECL_HANDLER(open_input_desktop)
|
|
|
|
{
|
|
|
|
/* FIXME: check access rights */
|
|
|
|
struct winstation *winstation = get_process_winstation( current->process, 0 );
|
|
|
|
struct desktop *desktop;
|
|
|
|
|
|
|
|
if (!winstation) return;
|
|
|
|
|
|
|
|
if (!(winstation->flags & WSF_VISIBLE))
|
|
|
|
{
|
|
|
|
set_error( STATUS_ILLEGAL_FUNCTION );
|
2013-11-09 10:17:11 +01:00
|
|
|
release_object( winstation );
|
2013-11-08 10:10:24 +01:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
if ((desktop = get_desktop_obj( current->process, current->process->desktop, 0 )))
|
|
|
|
{
|
|
|
|
reply->handle = alloc_handle( current->process, desktop, req->access, req->attributes );
|
|
|
|
release_object( desktop );
|
|
|
|
}
|
|
|
|
release_object( winstation );
|
|
|
|
}
|
2005-06-08 20:44:50 +02:00
|
|
|
|
|
|
|
/* close a desktop */
|
|
|
|
DECL_HANDLER(close_desktop)
|
|
|
|
{
|
|
|
|
struct desktop *desktop;
|
|
|
|
|
|
|
|
/* make sure it is a desktop handle */
|
|
|
|
if ((desktop = (struct desktop *)get_handle_obj( current->process, req->handle,
|
|
|
|
0, &desktop_ops )))
|
|
|
|
{
|
2009-12-01 13:59:41 +01:00
|
|
|
if (close_handle( current->process, req->handle )) set_error( STATUS_DEVICE_BUSY );
|
2005-06-08 20:44:50 +02:00
|
|
|
release_object( desktop );
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
/* get the thread current desktop */
|
|
|
|
DECL_HANDLER(get_thread_desktop)
|
|
|
|
{
|
|
|
|
struct thread *thread;
|
|
|
|
|
|
|
|
if (!(thread = get_thread_from_id( req->tid ))) return;
|
|
|
|
reply->handle = thread->desktop;
|
|
|
|
release_object( thread );
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
/* set the thread current desktop */
|
|
|
|
DECL_HANDLER(set_thread_desktop)
|
|
|
|
{
|
2005-06-28 21:37:52 +02:00
|
|
|
struct desktop *old_desktop, *new_desktop;
|
|
|
|
struct winstation *winstation;
|
2005-06-08 20:44:50 +02:00
|
|
|
|
2005-06-28 21:37:52 +02:00
|
|
|
if (!(winstation = get_process_winstation( current->process, 0 /* FIXME: access rights? */ )))
|
|
|
|
return;
|
|
|
|
|
|
|
|
if (!(new_desktop = get_desktop_obj( current->process, req->handle, 0 )))
|
2005-06-08 20:44:50 +02:00
|
|
|
{
|
2005-06-28 21:37:52 +02:00
|
|
|
release_object( winstation );
|
|
|
|
return;
|
2005-06-08 20:44:50 +02:00
|
|
|
}
|
2005-06-28 21:37:52 +02:00
|
|
|
if (new_desktop->winstation != winstation)
|
|
|
|
{
|
|
|
|
set_error( STATUS_ACCESS_DENIED );
|
|
|
|
release_object( new_desktop );
|
|
|
|
release_object( winstation );
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* check if we are changing to a new desktop */
|
|
|
|
|
|
|
|
if (!(old_desktop = get_desktop_obj( current->process, current->desktop, 0)))
|
|
|
|
clear_error(); /* ignore error */
|
|
|
|
|
|
|
|
/* when changing desktop, we can't have any users on the current one */
|
|
|
|
if (old_desktop != new_desktop && current->desktop_users > 0)
|
|
|
|
set_error( STATUS_DEVICE_BUSY );
|
|
|
|
else
|
server: Track desktop users per thread instead of per process.
As some thread may use a different desktop from their process.
This fixes the user32 win tests, which leaks a desktop that never gets
closed. The test_shell_window test creates a new desktop, which spawns
explorer.exe process, incrementing the desktop user count to 1, then
associates the desktop to a thread, which closes it on exit.
Never the user count is incremented to 2, and closing the thread desktop
doesn't either check whether the desktop process should be terminated.
Reversely, it is possible to create a desktop, associate it with a
thread /and/ a process, and this time the desktop process would be
terminated when the process exits, although the thread may still be
using it.
Tracking the users per thread is more robust and fixes the problem as
set_thread_desktop increments the desktop user count, and thread exit
decrements it.
Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-21 10:38:15 +02:00
|
|
|
{
|
2005-06-28 21:37:52 +02:00
|
|
|
current->desktop = req->handle; /* FIXME: should we close the old one? */
|
server: Track desktop users per thread instead of per process.
As some thread may use a different desktop from their process.
This fixes the user32 win tests, which leaks a desktop that never gets
closed. The test_shell_window test creates a new desktop, which spawns
explorer.exe process, incrementing the desktop user count to 1, then
associates the desktop to a thread, which closes it on exit.
Never the user count is incremented to 2, and closing the thread desktop
doesn't either check whether the desktop process should be terminated.
Reversely, it is possible to create a desktop, associate it with a
thread /and/ a process, and this time the desktop process would be
terminated when the process exits, although the thread may still be
using it.
Tracking the users per thread is more robust and fixes the problem as
set_thread_desktop increments the desktop user count, and thread exit
decrements it.
Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-21 10:38:15 +02:00
|
|
|
if (!current->process->is_system && old_desktop != new_desktop)
|
|
|
|
{
|
|
|
|
add_desktop_user( new_desktop );
|
|
|
|
if (old_desktop) remove_desktop_user( old_desktop );
|
|
|
|
}
|
|
|
|
}
|
2005-06-28 21:37:52 +02:00
|
|
|
|
2006-03-27 12:57:17 +02:00
|
|
|
if (!current->process->desktop)
|
|
|
|
set_process_default_desktop( current->process, new_desktop, req->handle );
|
|
|
|
|
2006-03-06 15:10:59 +01:00
|
|
|
if (old_desktop != new_desktop && current->queue) detach_thread_input( current );
|
2005-07-11 15:30:23 +02:00
|
|
|
|
2005-06-28 21:37:52 +02:00
|
|
|
if (old_desktop) release_object( old_desktop );
|
|
|
|
release_object( new_desktop );
|
|
|
|
release_object( winstation );
|
2005-06-08 20:44:50 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
/* get/set information about a user object (window station or desktop) */
|
|
|
|
DECL_HANDLER(set_user_object_info)
|
|
|
|
{
|
|
|
|
struct object *obj;
|
2016-01-20 14:27:44 +01:00
|
|
|
data_size_t len;
|
2005-06-08 20:44:50 +02:00
|
|
|
|
|
|
|
if (!(obj = get_handle_obj( current->process, req->handle, 0, NULL ))) return;
|
|
|
|
|
|
|
|
if (obj->ops == &desktop_ops)
|
|
|
|
{
|
|
|
|
struct desktop *desktop = (struct desktop *)obj;
|
|
|
|
reply->is_desktop = 1;
|
|
|
|
reply->old_obj_flags = desktop->flags;
|
2015-12-04 01:19:58 +01:00
|
|
|
if (req->flags & SET_USER_OBJECT_SET_FLAGS) desktop->flags = req->obj_flags;
|
2005-06-08 20:44:50 +02:00
|
|
|
}
|
|
|
|
else if (obj->ops == &winstation_ops)
|
|
|
|
{
|
|
|
|
struct winstation *winstation = (struct winstation *)obj;
|
|
|
|
reply->is_desktop = 0;
|
|
|
|
reply->old_obj_flags = winstation->flags;
|
2015-12-04 01:19:58 +01:00
|
|
|
if (req->flags & SET_USER_OBJECT_SET_FLAGS) winstation->flags = req->obj_flags;
|
2005-06-08 20:44:50 +02:00
|
|
|
}
|
|
|
|
else
|
|
|
|
{
|
|
|
|
set_error( STATUS_OBJECT_TYPE_MISMATCH );
|
|
|
|
release_object( obj );
|
|
|
|
return;
|
|
|
|
}
|
2016-01-20 14:27:44 +01:00
|
|
|
if (obj->ops == &desktop_ops && get_reply_max_size() && (req->flags & SET_USER_OBJECT_GET_FULL_NAME))
|
|
|
|
{
|
|
|
|
struct desktop *desktop = (struct desktop *)obj;
|
|
|
|
data_size_t winstation_len, desktop_len;
|
|
|
|
const WCHAR *winstation_name = get_object_name( &desktop->winstation->obj, &winstation_len );
|
|
|
|
const WCHAR *desktop_name = get_object_name( obj, &desktop_len );
|
|
|
|
WCHAR *full_name;
|
|
|
|
|
|
|
|
if (!winstation_name) winstation_len = 0;
|
|
|
|
if (!desktop_name) desktop_len = 0;
|
|
|
|
len = winstation_len + desktop_len + sizeof(WCHAR);
|
|
|
|
if ((full_name = mem_alloc( len )))
|
|
|
|
{
|
|
|
|
memcpy( full_name, winstation_name, winstation_len );
|
|
|
|
full_name[winstation_len / sizeof(WCHAR)] = '\\';
|
|
|
|
memcpy( full_name + winstation_len / sizeof(WCHAR) + 1, desktop_name, desktop_len );
|
|
|
|
set_reply_data_ptr( full_name, min( len, get_reply_max_size() ));
|
|
|
|
}
|
|
|
|
}
|
|
|
|
else
|
|
|
|
{
|
|
|
|
const WCHAR *name = get_object_name( obj, &len );
|
|
|
|
if (name) set_reply_data( name, min( len, get_reply_max_size() ));
|
|
|
|
}
|
2007-12-05 16:45:32 +01:00
|
|
|
release_object( obj );
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
/* enumerate window stations */
|
|
|
|
DECL_HANDLER(enum_winstation)
|
|
|
|
{
|
2008-04-15 23:32:43 +02:00
|
|
|
unsigned int index = 0;
|
|
|
|
struct winstation *winsta;
|
2016-01-20 14:27:44 +01:00
|
|
|
const WCHAR *name;
|
|
|
|
data_size_t len;
|
2007-12-05 16:45:32 +01:00
|
|
|
|
2008-04-15 23:32:43 +02:00
|
|
|
LIST_FOR_EACH_ENTRY( winsta, &winstation_list, struct winstation, entry )
|
2007-12-05 16:45:32 +01:00
|
|
|
{
|
2008-04-15 23:32:43 +02:00
|
|
|
unsigned int access = WINSTA_ENUMERATE;
|
|
|
|
if (req->index > index++) continue;
|
2020-09-24 06:44:56 +02:00
|
|
|
if (!check_object_access( NULL, &winsta->obj, &access )) continue;
|
2007-12-05 16:45:32 +01:00
|
|
|
clear_error();
|
|
|
|
reply->next = index;
|
2016-01-20 14:27:44 +01:00
|
|
|
if ((name = get_object_name( &winsta->obj, &len )))
|
|
|
|
set_reply_data( name, min( len, get_reply_max_size() ));
|
2007-12-05 16:45:32 +01:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
set_error( STATUS_NO_MORE_ENTRIES );
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
/* enumerate desktops */
|
|
|
|
DECL_HANDLER(enum_desktop)
|
|
|
|
{
|
|
|
|
struct winstation *winstation;
|
|
|
|
struct desktop *desktop;
|
2008-04-16 01:38:58 +02:00
|
|
|
unsigned int index = 0;
|
2016-01-20 14:27:44 +01:00
|
|
|
const WCHAR *name;
|
|
|
|
data_size_t len;
|
2007-12-05 16:45:32 +01:00
|
|
|
|
|
|
|
if (!(winstation = (struct winstation *)get_handle_obj( current->process, req->winstation,
|
|
|
|
WINSTA_ENUMDESKTOPS, &winstation_ops )))
|
|
|
|
return;
|
|
|
|
|
2008-04-16 01:38:58 +02:00
|
|
|
LIST_FOR_EACH_ENTRY( desktop, &winstation->desktops, struct desktop, entry )
|
2005-06-08 20:44:50 +02:00
|
|
|
{
|
2008-04-16 01:38:58 +02:00
|
|
|
unsigned int access = DESKTOP_ENUMERATE;
|
|
|
|
if (req->index > index++) continue;
|
|
|
|
if (!desktop->obj.name) continue;
|
2020-09-24 06:44:56 +02:00
|
|
|
if (!check_object_access( NULL, &desktop->obj, &access )) continue;
|
2016-01-20 14:27:44 +01:00
|
|
|
if ((name = get_object_name( &desktop->obj, &len )))
|
|
|
|
set_reply_data( name, min( len, get_reply_max_size() ));
|
2008-04-16 01:38:58 +02:00
|
|
|
release_object( winstation );
|
|
|
|
clear_error();
|
|
|
|
reply->next = index;
|
|
|
|
return;
|
2005-06-08 20:44:50 +02:00
|
|
|
}
|
2007-12-05 16:45:32 +01:00
|
|
|
|
|
|
|
release_object( winstation );
|
|
|
|
set_error( STATUS_NO_MORE_ENTRIES );
|
2005-06-08 20:44:50 +02:00
|
|
|
}
|