Extract target account on list method in bulk import row service spec (#29601)

This commit is contained in:
Matt Jankowski 2024-03-15 05:31:25 -04:00 committed by GitHub
parent 838b0bdf2d
commit e75b55a6d7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 19 additions and 4 deletions

View File

@ -110,7 +110,7 @@ RSpec.describe BulkImportRowService do
end end
it 'adds the target account to the list' do it 'adds the target account to the list' do
expect { subject.call(import_row) }.to change { ListAccount.joins(:list).exists?(account_id: target_account.id, list: { title: 'my list' }) }.from(false).to(true) expect { subject.call(import_row) }.to add_target_account_to_list
end end
end end
@ -124,7 +124,7 @@ RSpec.describe BulkImportRowService do
end end
it 'adds the target account to the list' do it 'adds the target account to the list' do
expect { subject.call(import_row) }.to change { ListAccount.joins(:list).exists?(account_id: target_account.id, list: { title: 'my list' }) }.from(false).to(true) expect { subject.call(import_row) }.to add_target_account_to_list
end end
end end
@ -134,7 +134,7 @@ RSpec.describe BulkImportRowService do
end end
it 'adds the target account to the list' do it 'adds the target account to the list' do
expect { subject.call(import_row) }.to change { ListAccount.joins(:list).exists?(account_id: target_account.id, list: { title: 'my list' }) }.from(false).to(true) expect { subject.call(import_row) }.to add_target_account_to_list
end end
end end
@ -146,9 +146,24 @@ RSpec.describe BulkImportRowService do
end end
it 'adds the target account to the list' do it 'adds the target account to the list' do
expect { subject.call(import_row) }.to change { ListAccount.joins(:list).exists?(account_id: target_account.id, list: { title: 'my list' }) }.from(false).to(true) expect { subject.call(import_row) }.to add_target_account_to_list
end end
end end
def add_target_account_to_list
change { target_account_on_list? }
.from(false)
.to(true)
end
def target_account_on_list?
ListAccount
.joins(:list)
.exists?(
account_id: target_account.id,
list: { title: 'my list' }
)
end
end end
context 'when the list does not exist yet' do context 'when the list does not exist yet' do