From e519f113e8154dacd7fd1b67b35bd3f40d9768a2 Mon Sep 17 00:00:00 2001 From: Matt Jankowski Date: Fri, 26 Jan 2024 11:37:05 -0500 Subject: [PATCH] Combine repeated subject in `cacheable response` shared example (#28945) --- spec/support/examples/cache.rb | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/spec/support/examples/cache.rb b/spec/support/examples/cache.rb index 43cfbade824..afbee66b2d3 100644 --- a/spec/support/examples/cache.rb +++ b/spec/support/examples/cache.rb @@ -1,22 +1,14 @@ # frozen_string_literal: true shared_examples 'cacheable response' do |expects_vary: false| - it 'does not set cookies' do + it 'sets correct cache and vary headers and does not set cookies or session' do expect(response.cookies).to be_empty expect(response.headers['Set-Cookies']).to be_nil - end - it 'does not set sessions' do expect(session).to be_empty - end - if expects_vary - it 'returns Vary header' do - expect(response.headers['Vary']).to include(expects_vary) - end - end + expect(response.headers['Vary']).to include(expects_vary) if expects_vary - it 'returns public Cache-Control header' do expect(response.headers['Cache-Control']).to include('public') end end