From d13c20fabe9507dbf71114ffe942b42b8d199925 Mon Sep 17 00:00:00 2001 From: Daniel M Brasil Date: Tue, 20 Feb 2024 16:51:29 -0300 Subject: [PATCH] add enum validation to IpBlock --- app/models/ip_block.rb | 2 +- spec/requests/api/v1/admin/ip_blocks_spec.rb | 10 ++++++++++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/app/models/ip_block.rb b/app/models/ip_block.rb index d6242efbf7d..2e1a20ff676 100644 --- a/app/models/ip_block.rb +++ b/app/models/ip_block.rb @@ -23,7 +23,7 @@ class IpBlock < ApplicationRecord sign_up_requires_approval: 5000, sign_up_block: 5500, no_access: 9999, - }, prefix: true + }, prefix: true, validate: true validates :ip, :severity, presence: true validates :ip, uniqueness: true diff --git a/spec/requests/api/v1/admin/ip_blocks_spec.rb b/spec/requests/api/v1/admin/ip_blocks_spec.rb index 98b954dd49f..79418e1f0c4 100644 --- a/spec/requests/api/v1/admin/ip_blocks_spec.rb +++ b/spec/requests/api/v1/admin/ip_blocks_spec.rb @@ -166,6 +166,16 @@ RSpec.describe 'IP Blocks' do expect(response).to have_http_status(422) end end + + context 'when the given severity is invalid' do + let(:params) { { ip: '151.0.32.55', severity: 'invalid' } } + + it 'returns http unprocessable entity' do + subject + + expect(response).to have_http_status(422) + end + end end describe 'PUT /api/v1/admin/ip_blocks/:id' do