zelo72
/
mastodon
mirror of https://github.com/mastodon/mastodon
2
2
Fork 1
Code Issues 10 Releases Wiki Activity

Guard against error extracting `body` from URL (#20428) 

If `Nokogiri::HTML(value).at_xpath('//body')` fails to find the `body` element, it will return `nil`. We can guard against that with an early return. Avoids calling `children` on `Nilclass` in those cases.
This commit is contained in:
Emily Strickland 2022-11-11 12:22:28 -08:00 committed by GitHub
parent 31005aad12
commit 96f51e593f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
app/models/account/field.rb
View File

@ -76,6 +76,7 @@ class Account::Field < ActiveModelSerializers::Model
def extract_url_from_html def extract_url_from_html
doc = Nokogiri::HTML(value).at_xpath('//body') doc = Nokogiri::HTML(value).at_xpath('//body')
return if doc.nil?
return if doc.children.size > 1 return if doc.children.size > 1
element = doc.children.first element = doc.children.first