From 59b38f9ee4397e1615cd692a1516265dc963fc99 Mon Sep 17 00:00:00 2001 From: Daniel M Brasil Date: Tue, 18 Jul 2023 08:05:19 -0300 Subject: [PATCH] Migrate to request specs in `/api/v1/mutes` (#25622) --- .../api/v1/mutes_controller_spec.rb | 65 -------------- spec/requests/api/v1/mutes_spec.rb | 90 +++++++++++++++++++ 2 files changed, 90 insertions(+), 65 deletions(-) delete mode 100644 spec/controllers/api/v1/mutes_controller_spec.rb create mode 100644 spec/requests/api/v1/mutes_spec.rb diff --git a/spec/controllers/api/v1/mutes_controller_spec.rb b/spec/controllers/api/v1/mutes_controller_spec.rb deleted file mode 100644 index 2645ed4e9d..0000000000 --- a/spec/controllers/api/v1/mutes_controller_spec.rb +++ /dev/null @@ -1,65 +0,0 @@ -# frozen_string_literal: true - -require 'rails_helper' - -RSpec.describe Api::V1::MutesController do - render_views - - let(:user) { Fabricate(:user) } - let(:scopes) { 'read:mutes' } - let(:token) { Fabricate(:accessible_access_token, resource_owner_id: user.id, scopes: scopes) } - - before { allow(controller).to receive(:doorkeeper_token) { token } } - - describe 'GET #index' do - it 'limits according to limit parameter' do - Array.new(2) { Fabricate(:mute, account: user.account) } - get :index, params: { limit: 1 } - expect(body_as_json.size).to eq 1 - end - - it 'queries mutes in range according to max_id' do - mutes = Array.new(2) { Fabricate(:mute, account: user.account) } - - get :index, params: { max_id: mutes[1] } - - expect(body_as_json.size).to eq 1 - expect(body_as_json[0][:id]).to eq mutes[0].target_account_id.to_s - end - - it 'queries mutes in range according to since_id' do - mutes = Array.new(2) { Fabricate(:mute, account: user.account) } - - get :index, params: { since_id: mutes[0] } - - expect(body_as_json.size).to eq 1 - expect(body_as_json[0][:id]).to eq mutes[1].target_account_id.to_s - end - - it 'sets pagination header for next path' do - mutes = Array.new(2) { Fabricate(:mute, account: user.account) } - get :index, params: { limit: 1, since_id: mutes[0] } - expect(response.headers['Link'].find_link(%w(rel next)).href).to eq api_v1_mutes_url(limit: 1, max_id: mutes[1]) - end - - it 'sets pagination header for previous path' do - mute = Fabricate(:mute, account: user.account) - get :index - expect(response.headers['Link'].find_link(%w(rel prev)).href).to eq api_v1_mutes_url(since_id: mute) - end - - it 'returns http success' do - get :index - expect(response).to have_http_status(200) - end - - context 'with wrong scopes' do - let(:scopes) { 'write:mutes' } - - it 'returns http forbidden' do - get :index - expect(response).to have_http_status(403) - end - end - end -end diff --git a/spec/requests/api/v1/mutes_spec.rb b/spec/requests/api/v1/mutes_spec.rb new file mode 100644 index 0000000000..9a1d16200a --- /dev/null +++ b/spec/requests/api/v1/mutes_spec.rb @@ -0,0 +1,90 @@ +# frozen_string_literal: true + +require 'rails_helper' + +RSpec.describe 'Mutes' do + let(:user) { Fabricate(:user) } + let(:scopes) { 'read:mutes' } + let(:token) { Fabricate(:accessible_access_token, resource_owner_id: user.id, scopes: scopes) } + let(:headers) { { 'Authorization' => "Bearer #{token.token}" } } + + describe 'GET /api/v1/mutes' do + subject do + get '/api/v1/mutes', headers: headers, params: params + end + + let!(:mutes) { Fabricate.times(3, :mute, account: user.account) } + let(:params) { {} } + + it_behaves_like 'forbidden for wrong scope', 'write write:mutes' + + it 'returns http success' do + subject + + expect(response).to have_http_status(200) + end + + it 'returns the muted accounts' do + subject + + muted_accounts = mutes.map(&:target_account) + + expect(body_as_json.pluck(:id)).to match_array(muted_accounts.map { |account| account.id.to_s }) + end + + context 'with limit param' do + let(:params) { { limit: 2 } } + + it 'returns only the requested number of muted accounts' do + subject + + expect(body_as_json.size).to eq(params[:limit]) + end + + it 'sets the correct pagination headers', :aggregate_failures do + subject + + headers = response.headers['Link'] + + expect(headers.find_link(%w(rel prev)).href).to eq(api_v1_mutes_url(limit: params[:limit], since_id: mutes[2].id.to_s)) + expect(headers.find_link(%w(rel next)).href).to eq(api_v1_mutes_url(limit: params[:limit], max_id: mutes[1].id.to_s)) + end + end + + context 'with max_id param' do + let(:params) { { max_id: mutes[1].id } } + + it 'queries mutes in range according to max_id', :aggregate_failures do + subject + + body = body_as_json + + expect(body.size).to eq 1 + expect(body[0][:id]).to eq mutes[0].target_account_id.to_s + end + end + + context 'with since_id param' do + let(:params) { { since_id: mutes[0].id } } + + it 'queries mutes in range according to since_id', :aggregate_failures do + subject + + body = body_as_json + + expect(body.size).to eq 2 + expect(body[0][:id]).to eq mutes[2].target_account_id.to_s + end + end + + context 'without an authentication header' do + let(:headers) { {} } + + it 'returns http unauthorized' do + subject + + expect(response).to have_http_status(401) + end + end + end +end