Convert `api/oembed` controller spec to request spec (#31605)

This commit is contained in:
Matt Jankowski 2024-08-27 03:55:25 -04:00 committed by GitHub
parent 0e7c88aa6d
commit 38a3466741
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 33 additions and 22 deletions

View File

@ -1,22 +0,0 @@
# frozen_string_literal: true
require 'rails_helper'
RSpec.describe Api::OEmbedController do
render_views
let(:alice) { Fabricate(:account, username: 'alice') }
let(:status) { Fabricate(:status, text: 'Hello world', account: alice) }
describe 'GET #show' do
before do
request.host = Rails.configuration.x.local_domain
get :show, params: { url: short_account_status_url(alice, status) }, format: :json
end
it 'returns private cache control headers', :aggregate_failures do
expect(response).to have_http_status(200)
expect(response.headers['Cache-Control']).to include('private, no-store')
end
end
end

View File

@ -0,0 +1,33 @@
# frozen_string_literal: true
require 'rails_helper'
RSpec.describe 'API OEmbed' do
describe 'GET /api/oembed' do
before { host! Rails.configuration.x.local_domain }
context 'when status is public' do
let(:status) { Fabricate(:status, visibility: :public) }
it 'returns success with private cache control headers' do
get '/api/oembed', params: { url: short_account_status_url(status.account, status) }
expect(response)
.to have_http_status(200)
expect(response.headers['Cache-Control'])
.to include('private, no-store')
end
end
context 'when status is not public' do
let(:status) { Fabricate(:status, visibility: :direct) }
it 'returns not found' do
get '/api/oembed', params: { url: short_account_status_url(status.account, status) }
expect(response)
.to have_http_status(404)
end
end
end
end