From 325b55485e093c6719ff76cabe8d69066926830b Mon Sep 17 00:00:00 2001
From: Matt Jankowski <matt@jankowski.online>
Date: Tue, 11 Mar 2025 09:32:39 -0400
Subject: [PATCH] Convert `admin/settings/branding` spec controller->request
 (#34130)

---
 .../settings/branding_controller_spec.rb      | 25 -------------------
 spec/requests/admin/settings/branding_spec.rb | 19 ++++++++++++++
 2 files changed, 19 insertions(+), 25 deletions(-)
 delete mode 100644 spec/controllers/admin/settings/branding_controller_spec.rb
 create mode 100644 spec/requests/admin/settings/branding_spec.rb

diff --git a/spec/controllers/admin/settings/branding_controller_spec.rb b/spec/controllers/admin/settings/branding_controller_spec.rb
deleted file mode 100644
index 6b3621bb8a3..00000000000
--- a/spec/controllers/admin/settings/branding_controller_spec.rb
+++ /dev/null
@@ -1,25 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-RSpec.describe Admin::Settings::BrandingController do
-  render_views
-
-  describe 'When signed in as an admin' do
-    before do
-      sign_in Fabricate(:admin_user), scope: :user
-    end
-
-    describe 'PUT #update' do
-      it 'cannot create a setting value for a non-admin key' do
-        expect(Setting.new_setting_key).to be_blank
-
-        patch :update, params: { form_admin_settings: { new_setting_key: 'New key value' } }
-
-        expect(response)
-          .to have_http_status(400)
-        expect(Setting.new_setting_key).to be_nil
-      end
-    end
-  end
-end
diff --git a/spec/requests/admin/settings/branding_spec.rb b/spec/requests/admin/settings/branding_spec.rb
new file mode 100644
index 00000000000..e5206f056fc
--- /dev/null
+++ b/spec/requests/admin/settings/branding_spec.rb
@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+RSpec.describe 'Admin Settings Branding' do
+  describe 'When signed in as an admin' do
+    before { sign_in Fabricate(:admin_user) }
+
+    describe 'PUT /admin/settings/branding' do
+      it 'cannot create a setting value for a non-admin key' do
+        expect { put admin_settings_branding_path, params: { form_admin_settings: { new_setting_key: 'New key value' } } }
+          .to_not change(Setting, :new_setting_key).from(nil)
+
+        expect(response)
+          .to have_http_status(400)
+      end
+    end
+  end
+end